)]}'
{"dragonflow/controller/apps/dnat.py":[{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"cb564f3809b191d89f57f4151cca687b0eb89c7a","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        floating_lport \u003d fip.floating_lport"},{"line_number":341,"context_line":"        subnets \u003d self.db_store.get_all("},{"line_number":342,"context_line":"            l2.Subnet(lswitch\u003dfloating_lport.lswitch.id),"},{"line_number":343,"context_line":"            index\u003dl2.Subnet.get_index(\u0027lswitch\u0027))"},{"line_number":344,"context_line":"        for subnet in subnets:"},{"line_number":345,"context_line":"            if fip.floating_ip_address in subnet.cidr:"},{"line_number":346,"context_line":"                return subnet"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_80cef057","line":343,"updated":"2017-12-18 11:48:20.000000000","message":"readability nit, shouldn\u0027t this line be indented?","commit_id":"395eeabf241bc200fbc91757a412900de650b4d0"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"842fcfbfd48bb62663ecb45b49a2683583710614","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        floating_lport \u003d fip.floating_lport"},{"line_number":341,"context_line":"        subnets \u003d self.db_store.get_all("},{"line_number":342,"context_line":"            l2.Subnet(lswitch\u003dfloating_lport.lswitch.id),"},{"line_number":343,"context_line":"            index\u003dl2.Subnet.get_index(\u0027lswitch\u0027))"},{"line_number":344,"context_line":"        for subnet in subnets:"},{"line_number":345,"context_line":"            if fip.floating_ip_address in subnet.cidr:"},{"line_number":346,"context_line":"                return subnet"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_360aad1f","line":343,"in_reply_to":"df87a7cf_7dccb269","updated":"2017-12-19 15:02:12.000000000","message":"No strong opinion about this one...","commit_id":"395eeabf241bc200fbc91757a412900de650b4d0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"20edf9e0d52b06f487017c3d21c5a93c4d825fef","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        floating_lport \u003d fip.floating_lport"},{"line_number":341,"context_line":"        subnets \u003d self.db_store.get_all("},{"line_number":342,"context_line":"            l2.Subnet(lswitch\u003dfloating_lport.lswitch.id),"},{"line_number":343,"context_line":"            index\u003dl2.Subnet.get_index(\u0027lswitch\u0027))"},{"line_number":344,"context_line":"        for subnet in subnets:"},{"line_number":345,"context_line":"            if fip.floating_ip_address in subnet.cidr:"},{"line_number":346,"context_line":"                return subnet"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_7dccb269","line":343,"in_reply_to":"df87a7cf_80cef057","updated":"2017-12-19 11:53:18.000000000","message":"Up to you. pep8 isn\u0027t complaining :)","commit_id":"395eeabf241bc200fbc91757a412900de650b4d0"}],"dragonflow/neutron/ml2/mech_driver.py":[{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"4364044c9a47bef62f621802f5b0429ed4a7b76d","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        df_subnet \u003d neutron_l2.subnet_from_neutron_subnet(subnet)"},{"line_number":343,"context_line":"        df_subnet.dhcp_ip \u003d dhcp_ip"},{"line_number":344,"context_line":"        self.nb_api.create(df_subnet)"},{"line_number":345,"context_line":"        self.nb_api.update(l2.LogicalSwitch("},{"line_number":346,"context_line":"            id\u003dnet_id, topic\u003dnetwork[\u0027tenant_id\u0027],"},{"line_number":347,"context_line":"            version\u003dnetwork[\u0027revision_number\u0027]))"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        LOG.info(\"DFMechDriver: create subnet %s\", subnet[\u0027id\u0027])"},{"line_number":350,"context_line":"        return subnet"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_6bd9c620","line":347,"range":{"start_line":345,"start_character":0,"end_line":347,"end_character":48},"updated":"2017-08-20 13:58:45.000000000","message":"Won\u0027t update_network_postcommit get fired too?","commit_id":"d3f85d43f0bcfc53c690bf4f12d934e9db678337"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"486749ad4586d9b5957d5e77a95fa96aa2c1954c","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        df_subnet \u003d neutron_l2.subnet_from_neutron_subnet(subnet)"},{"line_number":343,"context_line":"        df_subnet.dhcp_ip \u003d dhcp_ip"},{"line_number":344,"context_line":"        self.nb_api.create(df_subnet)"},{"line_number":345,"context_line":"        self.nb_api.update(l2.LogicalSwitch("},{"line_number":346,"context_line":"            id\u003dnet_id, topic\u003dnetwork[\u0027tenant_id\u0027],"},{"line_number":347,"context_line":"            version\u003dnetwork[\u0027revision_number\u0027]))"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        LOG.info(\"DFMechDriver: create subnet %s\", subnet[\u0027id\u0027])"},{"line_number":350,"context_line":"        return subnet"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_6b4786be","line":347,"range":{"start_line":345,"start_character":0,"end_line":347,"end_character":48},"in_reply_to":"9f436f4f_6bd9c620","updated":"2017-08-20 14:02:31.000000000","message":"Will verify.","commit_id":"d3f85d43f0bcfc53c690bf4f12d934e9db678337"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"804498936cad7356cc63e28cef9fbaaf79441dd1","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        df_subnet \u003d neutron_l2.subnet_from_neutron_subnet(subnet)"},{"line_number":296,"context_line":"        self.nb_api.create(df_subnet)"},{"line_number":297,"context_line":"        topic \u003d df_utils.get_obj_topic(network)"},{"line_number":298,"context_line":"        self.nb_api.update(l2.LogicalSwitch("},{"line_number":299,"context_line":"            id\u003dnet_id, topic\u003dtopic,"},{"line_number":300,"context_line":"            version\u003dnetwork[\u0027revision_number\u0027]))"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        LOG.info(\"DFMechDriver: create subnet %s\", subnet[\u0027id\u0027])"},{"line_number":303,"context_line":"        return subnet"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_0531925a","line":300,"range":{"start_line":298,"start_character":0,"end_line":300,"end_character":48},"updated":"2017-12-18 10:00:45.000000000","message":"We need this? Change does not trigger update_network_postcommit?","commit_id":"395eeabf241bc200fbc91757a412900de650b4d0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"20edf9e0d52b06f487017c3d21c5a93c4d825fef","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        df_subnet \u003d neutron_l2.subnet_from_neutron_subnet(subnet)"},{"line_number":296,"context_line":"        self.nb_api.create(df_subnet)"},{"line_number":297,"context_line":"        topic \u003d df_utils.get_obj_topic(network)"},{"line_number":298,"context_line":"        self.nb_api.update(l2.LogicalSwitch("},{"line_number":299,"context_line":"            id\u003dnet_id, topic\u003dtopic,"},{"line_number":300,"context_line":"            version\u003dnetwork[\u0027revision_number\u0027]))"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        LOG.info(\"DFMechDriver: create subnet %s\", subnet[\u0027id\u0027])"},{"line_number":303,"context_line":"        return subnet"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_167bee27","line":300,"range":{"start_line":298,"start_character":0,"end_line":300,"end_character":48},"in_reply_to":"df87a7cf_0531925a","updated":"2017-12-19 11:53:18.000000000","message":"Doesn\u0027t look like it. I checked the logs, and it seems update_network_postcommit is *not* called.","commit_id":"395eeabf241bc200fbc91757a412900de650b4d0"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"804498936cad7356cc63e28cef9fbaaf79441dd1","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        self.nb_api.update(subnet)"},{"line_number":310,"context_line":"        network \u003d context.network.current"},{"line_number":311,"context_line":"        topic \u003d df_utils.get_obj_topic(network)"},{"line_number":312,"context_line":"        self.nb_api.update(l2.LogicalSwitch("},{"line_number":313,"context_line":"            id\u003dnetwork[\u0027id\u0027], topic\u003dtopic,"},{"line_number":314,"context_line":"            version\u003dnetwork[\u0027revision_number\u0027]))"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        LOG.info(\"DFMechDriver: update subnet %s\", new_subnet[\u0027id\u0027])"},{"line_number":317,"context_line":"        return new_subnet"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_653f3e25","line":314,"range":{"start_line":312,"start_character":5,"end_line":314,"end_character":48},"updated":"2017-12-18 10:00:45.000000000","message":"Same","commit_id":"395eeabf241bc200fbc91757a412900de650b4d0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"20edf9e0d52b06f487017c3d21c5a93c4d825fef","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        self.nb_api.update(subnet)"},{"line_number":310,"context_line":"        network \u003d context.network.current"},{"line_number":311,"context_line":"        topic \u003d df_utils.get_obj_topic(network)"},{"line_number":312,"context_line":"        self.nb_api.update(l2.LogicalSwitch("},{"line_number":313,"context_line":"            id\u003dnetwork[\u0027id\u0027], topic\u003dtopic,"},{"line_number":314,"context_line":"            version\u003dnetwork[\u0027revision_number\u0027]))"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        LOG.info(\"DFMechDriver: update subnet %s\", new_subnet[\u0027id\u0027])"},{"line_number":317,"context_line":"        return new_subnet"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_d6702643","line":314,"range":{"start_line":312,"start_character":5,"end_line":314,"end_character":48},"in_reply_to":"df87a7cf_653f3e25","updated":"2017-12-19 11:53:18.000000000","message":"Same","commit_id":"395eeabf241bc200fbc91757a412900de650b4d0"}],"dragonflow/tests/unit/test_legacy_snat.py":[{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"cb564f3809b191d89f57f4151cca687b0eb89c7a","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_update_router(self):"},{"line_number":99,"context_line":"        self.test_create_router()"},{"line_number":100,"context_line":"        lswitch2 \u003d l2.LogicalSwitch(unique_key\u003d6,"},{"line_number":101,"context_line":"                                    name\u003d\u0027test_lswitch_2\u0027,"},{"line_number":102,"context_line":"                                    is_external\u003dFalse,"},{"line_number":103,"context_line":"                                    segmentation_id\u003d42,"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_2056042c","line":100,"updated":"2017-12-18 11:48:20.000000000","message":"maybe rename to test_lswitch_2 so it will be consistent?","commit_id":"395eeabf241bc200fbc91757a412900de650b4d0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"20edf9e0d52b06f487017c3d21c5a93c4d825fef","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_update_router(self):"},{"line_number":99,"context_line":"        self.test_create_router()"},{"line_number":100,"context_line":"        lswitch2 \u003d l2.LogicalSwitch(unique_key\u003d6,"},{"line_number":101,"context_line":"                                    name\u003d\u0027test_lswitch_2\u0027,"},{"line_number":102,"context_line":"                                    is_external\u003dFalse,"},{"line_number":103,"context_line":"                                    segmentation_id\u003d42,"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_5aea14d8","line":100,"in_reply_to":"df87a7cf_2056042c","updated":"2017-12-19 11:53:18.000000000","message":"The names were kept as they were before the change. The choice of names was done elsewhere. If we insist on changing them, I think it should be done in another patch.","commit_id":"395eeabf241bc200fbc91757a412900de650b4d0"}]}