)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"49a71504626f77e77c6a2d26db97f022b7ed8a09","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-10-19 16:59:57 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DHCP port per lswitch spec"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I04238c2f468ee66a4cf6b956fca2cdb6205d84e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"3f4b6375_d6603004","line":8,"updated":"2017-10-22 10:14:15.000000000","message":"please link it to the launchpad bug/bp","commit_id":"cac30f47306d89f8011e9d15eb64621ab63491b7"}],"doc/source/specs/dhcp_port_per_network.rst":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"42a063b325428eb570f8b9dbb3c0315e0a970bdc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"Problem Description"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Currently dragonflow create one dhcp-port per enable-dhcp-subnet."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"As DF don\u0027t save information about packet subnet in the ovs metadata/registers,"},{"line_number":11,"context_line":"For forwarding the packets toward the dhcp-port it\u0027s need to install flow for"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_d26cb209","line":8,"range":{"start_line":8,"start_character":21,"end_line":8,"end_character":27},"updated":"2017-09-06 12:10:36.000000000","message":"creates","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"42a063b325428eb570f8b9dbb3c0315e0a970bdc","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Currently dragonflow create one dhcp-port per enable-dhcp-subnet."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"As DF don\u0027t save information about packet subnet in the ovs metadata/registers,"},{"line_number":11,"context_line":"For forwarding the packets toward the dhcp-port it\u0027s need to install flow for"},{"line_number":12,"context_line":"each VM in the subnet."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_92762ad8","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":9},"updated":"2017-09-06 12:10:36.000000000","message":"doesn\u0027t","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"42a063b325428eb570f8b9dbb3c0315e0a970bdc","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Currently dragonflow create one dhcp-port per enable-dhcp-subnet."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"As DF don\u0027t save information about packet subnet in the ovs metadata/registers,"},{"line_number":11,"context_line":"For forwarding the packets toward the dhcp-port it\u0027s need to install flow for"},{"line_number":12,"context_line":"each VM in the subnet."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_124c7a9c","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":3},"updated":"2017-09-06 12:10:36.000000000","message":"remove","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"42a063b325428eb570f8b9dbb3c0315e0a970bdc","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Currently dragonflow create one dhcp-port per enable-dhcp-subnet."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"As DF don\u0027t save information about packet subnet in the ovs metadata/registers,"},{"line_number":11,"context_line":"For forwarding the packets toward the dhcp-port it\u0027s need to install flow for"},{"line_number":12,"context_line":"each VM in the subnet."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_925f4a40","line":10,"range":{"start_line":10,"start_character":78,"end_line":10,"end_character":79},"updated":"2017-09-06 12:10:36.000000000","message":"replace \u0027,\u0027 with \u0027.\u0027","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"42a063b325428eb570f8b9dbb3c0315e0a970bdc","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Currently dragonflow create one dhcp-port per enable-dhcp-subnet."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"As DF don\u0027t save information about packet subnet in the ovs metadata/registers,"},{"line_number":11,"context_line":"For forwarding the packets toward the dhcp-port it\u0027s need to install flow for"},{"line_number":12,"context_line":"each VM in the subnet."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This behaviour cause complexity in the code, that because every change in subnet"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_5259e257","line":11,"range":{"start_line":11,"start_character":48,"end_line":11,"end_character":57},"updated":"2017-09-06 12:10:36.000000000","message":"it needs","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"42a063b325428eb570f8b9dbb3c0315e0a970bdc","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Currently dragonflow create one dhcp-port per enable-dhcp-subnet."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"As DF don\u0027t save information about packet subnet in the ovs metadata/registers,"},{"line_number":11,"context_line":"For forwarding the packets toward the dhcp-port it\u0027s need to install flow for"},{"line_number":12,"context_line":"each VM in the subnet."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This behaviour cause complexity in the code, that because every change in subnet"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_12311a0c","line":11,"range":{"start_line":11,"start_character":15,"end_line":11,"end_character":18},"updated":"2017-09-06 12:10:36.000000000","message":"remove","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"42a063b325428eb570f8b9dbb3c0315e0a970bdc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"For forwarding the packets toward the dhcp-port it\u0027s need to install flow for"},{"line_number":12,"context_line":"each VM in the subnet."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This behaviour cause complexity in the code, that because every change in subnet"},{"line_number":15,"context_line":"(updated/add/delete/enabled-dhcp/disabled-dhcp) raise the need to do diff with"},{"line_number":16,"context_line":"the previous state, and install/remove all relevant flows."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_72085e2c","line":14,"range":{"start_line":14,"start_character":21,"end_line":14,"end_character":31},"updated":"2017-09-06 12:10:36.000000000","message":"+ it has performance penalty","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"42a063b325428eb570f8b9dbb3c0315e0a970bdc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"For forwarding the packets toward the dhcp-port it\u0027s need to install flow for"},{"line_number":12,"context_line":"each VM in the subnet."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This behaviour cause complexity in the code, that because every change in subnet"},{"line_number":15,"context_line":"(updated/add/delete/enabled-dhcp/disabled-dhcp) raise the need to do diff with"},{"line_number":16,"context_line":"the previous state, and install/remove all relevant flows."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_721f3e70","line":14,"range":{"start_line":14,"start_character":15,"end_line":14,"end_character":20},"updated":"2017-09-06 12:10:36.000000000","message":"causes","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"42a063b325428eb570f8b9dbb3c0315e0a970bdc","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Proposed Change"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Instead creating dhcp-port per subnet , DF will create one lport per"},{"line_number":22,"context_line":"enabled-dhcp switch (when enabled-dhcp-switch defined as switch that"},{"line_number":23,"context_line":"have at least one enable-dhcp-subnet)."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_ed010f06","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":16},"updated":"2017-09-06 12:10:36.000000000","message":"of creating","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"42a063b325428eb570f8b9dbb3c0315e0a970bdc","unresolved":false,"context_lines":[{"line_number":22,"context_line":"enabled-dhcp switch (when enabled-dhcp-switch defined as switch that"},{"line_number":23,"context_line":"have at least one enable-dhcp-subnet)."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"In this case we can use one flow per lswitch for foward the packet"},{"line_number":26,"context_line":"to controller, as lswitch information saved in the OXM_OF_METADATA."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In the app the subnet of the packets will be identify by the lport"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_0d4d7b71","line":25,"range":{"start_line":25,"start_character":49,"end_line":25,"end_character":55},"updated":"2017-09-06 12:10:36.000000000","message":"forwarding","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"42a063b325428eb570f8b9dbb3c0315e0a970bdc","unresolved":false,"context_lines":[{"line_number":25,"context_line":"In this case we can use one flow per lswitch for foward the packet"},{"line_number":26,"context_line":"to controller, as lswitch information saved in the OXM_OF_METADATA."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In the app the subnet of the packets will be identify by the lport"},{"line_number":29,"context_line":"that is known by reg6."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Packets that belong to subnet that not enabled dhcp will be dropped."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_2d5ef711","line":28,"range":{"start_line":28,"start_character":45,"end_line":28,"end_character":53},"updated":"2017-09-06 12:10:36.000000000","message":"identified","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"42a063b325428eb570f8b9dbb3c0315e0a970bdc","unresolved":false,"context_lines":[{"line_number":25,"context_line":"In this case we can use one flow per lswitch for foward the packet"},{"line_number":26,"context_line":"to controller, as lswitch information saved in the OXM_OF_METADATA."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In the app the subnet of the packets will be identify by the lport"},{"line_number":29,"context_line":"that is known by reg6."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Packets that belong to subnet that not enabled dhcp will be dropped."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_cd6f73c3","line":28,"range":{"start_line":28,"start_character":7,"end_line":28,"end_character":10},"updated":"2017-09-06 12:10:36.000000000","message":"what app?","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"42a063b325428eb570f8b9dbb3c0315e0a970bdc","unresolved":false,"context_lines":[{"line_number":26,"context_line":"to controller, as lswitch information saved in the OXM_OF_METADATA."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In the app the subnet of the packets will be identify by the lport"},{"line_number":29,"context_line":"that is known by reg6."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Packets that belong to subnet that not enabled dhcp will be dropped."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_cda4130b","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":16},"updated":"2017-09-06 12:10:36.000000000","message":"stored","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"42a063b325428eb570f8b9dbb3c0315e0a970bdc","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Remove the code complication that described above"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* Reduce mumber of flows in dhcp tables"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* Reduce the number of lport in the DB"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_92b18a92","line":37,"range":{"start_line":37,"start_character":9,"end_line":37,"end_character":15},"updated":"2017-09-06 12:10:36.000000000","message":"number","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"42a063b325428eb570f8b9dbb3c0315e0a970bdc","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* Reduce mumber of flows in dhcp tables"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* Reduce the number of lport in the DB"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Creating a DHCP driver"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_32a65655","line":39,"range":{"start_line":39,"start_character":23,"end_line":39,"end_character":28},"updated":"2017-09-06 12:10:36.000000000","message":"lports","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"42a063b325428eb570f8b9dbb3c0315e0a970bdc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"As part of the effort to reduce the coupling between components in"},{"line_number":46,"context_line":"the system, this spec suggest moving all the dhpc logic from the ml2-driver"},{"line_number":47,"context_line":"to a separate dhcp-driver."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This driver should be listen to subnet add/remove events, and create/delete"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_edeb4f0f","line":46,"range":{"start_line":46,"start_character":22,"end_line":46,"end_character":29},"updated":"2017-09-06 12:10:36.000000000","message":"suggests","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"42a063b325428eb570f8b9dbb3c0315e0a970bdc","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"As part of the effort to reduce the coupling between components in"},{"line_number":46,"context_line":"the system, this spec suggest moving all the dhpc logic from the ml2-driver"},{"line_number":47,"context_line":"to a separate dhcp-driver."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This driver should be listen to subnet add/remove events, and create/delete"},{"line_number":50,"context_line":"the dhcp-port according to the logic that described above."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_0d057bc2","line":47,"range":{"start_line":47,"start_character":14,"end_line":47,"end_character":25},"updated":"2017-09-06 12:10:36.000000000","message":"I am not sure about this approach. From the neutron ml2 point of view, there is mech driver that is supposed to bind the port. Implementation wise I think you can split out the DHCP related logic, but this will be called by Dragonflow mech. driver. I do not think that internal DF refactoring should have deployment impact.","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"42a063b325428eb570f8b9dbb3c0315e0a970bdc","unresolved":false,"context_lines":[{"line_number":46,"context_line":"the system, this spec suggest moving all the dhpc logic from the ml2-driver"},{"line_number":47,"context_line":"to a separate dhcp-driver."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This driver should be listen to subnet add/remove events, and create/delete"},{"line_number":50,"context_line":"the dhcp-port according to the logic that described above."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"There is 2 options listening to those events:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_edd46f49","line":49,"range":{"start_line":49,"start_character":19,"end_line":49,"end_character":28},"updated":"2017-09-06 12:10:36.000000000","message":"listen","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"ea5defade4d606564ec2b9795d76162b63eb3efa","unresolved":false,"context_lines":[{"line_number":49,"context_line":"This driver should be listen to subnet add/remove events, and create/delete"},{"line_number":50,"context_line":"the dhcp-port according to the logic that described above."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"There is 2 options listening to those events:"},{"line_number":53,"context_line":"  * listen to neutron registry events _[1]."},{"line_number":54,"context_line":"  * listen to dragonflow Northbound DB events _[2]"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_2364f5e4","line":52,"range":{"start_line":52,"start_character":6,"end_line":52,"end_character":8},"updated":"2017-09-05 02:00:43.000000000","message":"typo: is -\u003e are ?","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"a861aacb08718dca6321274aec9017d9bd9454fe","unresolved":false,"context_lines":[{"line_number":49,"context_line":"This driver should be listen to subnet add/remove events, and create/delete"},{"line_number":50,"context_line":"the dhcp-port according to the logic that described above."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"There is 2 options listening to those events:"},{"line_number":53,"context_line":"  * listen to neutron registry events _[1]."},{"line_number":54,"context_line":"  * listen to dragonflow Northbound DB events _[2]"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_17ab731d","line":52,"range":{"start_line":52,"start_character":6,"end_line":52,"end_character":8},"in_reply_to":"7f287b81_2364f5e4","updated":"2017-09-05 07:49:16.000000000","message":"will fix","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"ea5defade4d606564ec2b9795d76162b63eb3efa","unresolved":false,"context_lines":[{"line_number":56,"context_line":"In this spec we want to suggest that listening to dragonflow db could be"},{"line_number":57,"context_line":"better idea - as it reduce to coupling between dragonflow and neutron"},{"line_number":58,"context_line":"and could be a first step forward toward supporting a separate api."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"References"},{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":".. [1] https://docs.openstack.org/neutron-lib/latest/contributor/callbacks.html"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_837de96f","line":59,"updated":"2017-09-05 02:00:43.000000000","message":"I would like to vote fo the other option: Listen to Neutron events.\n\nIn a completely loosely coupled design, there will be no DHCP information on existing object. DHCP information will only exist on DHCP-owned lport, and possibly an additional model (although this should be avoided as well).\n\nIn such a design, the Dragonflow NB DB will not contain any DHCP information until this DHCP driver is invoked. \n\nThis driver\u0027s goal, by design, is to translate DHCP information from Neutron API to Dragonflow API and abstraction. This is the one and only place we allow coupling between Dragonflow code, Neutron code, and DHCP information.","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"a861aacb08718dca6321274aec9017d9bd9454fe","unresolved":false,"context_lines":[{"line_number":56,"context_line":"In this spec we want to suggest that listening to dragonflow db could be"},{"line_number":57,"context_line":"better idea - as it reduce to coupling between dragonflow and neutron"},{"line_number":58,"context_line":"and could be a first step forward toward supporting a separate api."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"References"},{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":".. [1] https://docs.openstack.org/neutron-lib/latest/contributor/callbacks.html"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_77bab76e","line":59,"in_reply_to":"7f287b81_837de96f","updated":"2017-09-05 07:49:16.000000000","message":"1. I think that this involve a some logic that specific for Dargonflow, creating DHCP port per-lswitch is not something that related to to neutron in any way - so i still think \nthats it\u0027s can be good idea to decouple them. \n2. I don\u0027t think that we can remove the attribute enable_dhcp from subnet anyway - because when subnet deleted    ,and other subnets still connected to this logical-switch , we must to know if the other subnets is dhcp_enabled - for deciding if the dhcp should removed from the lswitch.(it\u0027s can done by ref-cont but IMHO it\u0027s not strict way)\n\nproblem with the second solution , that in that case we need to decide which neutron server should handle this op , what we got automatically by neutron-api before. \n\nI still support the second option -         \nwaiting for more votes","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"591d0b5580ef5d7b28864d2f3fa82c5801655c8f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"In this spec we want to suggest that listening to dragonflow db could be"},{"line_number":57,"context_line":"better idea - as it reduce to coupling between dragonflow and neutron"},{"line_number":58,"context_line":"and could be a first step forward toward supporting a separate api."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"References"},{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":".. [1] https://docs.openstack.org/neutron-lib/latest/contributor/callbacks.html"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_e79daebb","line":59,"in_reply_to":"7f287b81_837de96f","updated":"2017-09-06 10:56:58.000000000","message":"@oanson Wouldn\u0027t we already have this information when the lswitch and subnet are created?","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"75e74c74a5b368f6257ec83bc8b01d421862a242","unresolved":false,"context_lines":[{"line_number":56,"context_line":"In this spec we want to suggest that listening to dragonflow db could be"},{"line_number":57,"context_line":"better idea - as it reduce to coupling between dragonflow and neutron"},{"line_number":58,"context_line":"and could be a first step forward toward supporting a separate api."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"References"},{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":".. [1] https://docs.openstack.org/neutron-lib/latest/contributor/callbacks.html"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_3880748b","line":59,"in_reply_to":"7f287b81_e79daebb","updated":"2017-09-06 14:45:10.000000000","message":"@lihi We need someplace to store it. My understanding was that the dhcp_* fields will be removed from the subnet model.","commit_id":"e047be826940706063d3cd233f68d6995da99ae0"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"657715e8d6bbcb17f291f9bb33d3850de7f60191","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Currently dragonflow creates one dhcp-port per enable-dhcp-subnet."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"DF dose not save information about packet subnet in the ovs metadata/registers."},{"line_number":11,"context_line":"For forwarding packets toward the dhcp-port its needs to install flow for"},{"line_number":12,"context_line":"each VM in the subnet."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f2577a7_b0d1805a","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":7},"updated":"2017-09-10 10:36:44.000000000","message":"does","commit_id":"433e2a61ce6b5965cd5d6cfc08c02b079c739cf4"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"657715e8d6bbcb17f291f9bb33d3850de7f60191","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"DF dose not save information about packet subnet in the ovs metadata/registers."},{"line_number":11,"context_line":"For forwarding packets toward the dhcp-port its needs to install flow for"},{"line_number":12,"context_line":"each VM in the subnet."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This behaviour causes complexity in the code and create a performance penalty,"},{"line_number":15,"context_line":"that because every change in subnet (updated/add/delete/enabled-dhcp/disabled-dhcp)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f2577a7_d0e2cc2f","line":12,"range":{"start_line":12,"start_character":5,"end_line":12,"end_character":7},"updated":"2017-09-10 10:36:44.000000000","message":"port","commit_id":"433e2a61ce6b5965cd5d6cfc08c02b079c739cf4"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"657715e8d6bbcb17f291f9bb33d3850de7f60191","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Proposed Change"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Instead of creating dhcp-port per subnet, DF will create one lport per"},{"line_number":22,"context_line":"enabled-dhcp switch (when enabled-dhcp-switch defined as switch that"},{"line_number":23,"context_line":"have at least one enable-dhcp-subnet)."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f2577a7_90d6844f","line":21,"range":{"start_line":21,"start_character":61,"end_line":21,"end_character":66},"updated":"2017-09-10 10:36:44.000000000","message":"port - we\u0027re creating actual ports, that later on also get translated to lports.","commit_id":"433e2a61ce6b5965cd5d6cfc08c02b079c739cf4"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"657715e8d6bbcb17f291f9bb33d3850de7f60191","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This port will contain multiple ips - one for each dhcp subnet that"},{"line_number":26,"context_line":"connected to the port. All port CUD operation will done with neutron"},{"line_number":27,"context_line":"plugin for using it\u0027s ip-adress-managemnt."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"In this case we can use one flow per lswitch for foward the packet"},{"line_number":30,"context_line":"to controller, as lswitch information saved in the OXM_OF_METADATA."}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f2577a7_70cb18a5","line":27,"range":{"start_line":27,"start_character":25,"end_line":27,"end_character":31},"updated":"2017-09-10 10:36:44.000000000","message":"address","commit_id":"433e2a61ce6b5965cd5d6cfc08c02b079c739cf4"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"657715e8d6bbcb17f291f9bb33d3850de7f60191","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"As part of the effort to reduce the coupling between components in"},{"line_number":50,"context_line":"the system, this spec suggest moving all the dhpc-logic from the"},{"line_number":51,"context_line":"mech_driver code to a separate code model."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"This model will be invoked by the ml2-driver, and will function"},{"line_number":54,"context_line":"independently. It\u0027s will used by neutron registry _[1] for subscribing"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f2577a7_30c5908f","line":51,"range":{"start_line":51,"start_character":36,"end_line":51,"end_character":41},"updated":"2017-09-10 10:36:44.000000000","message":"module","commit_id":"433e2a61ce6b5965cd5d6cfc08c02b079c739cf4"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"657715e8d6bbcb17f291f9bb33d3850de7f60191","unresolved":false,"context_lines":[{"line_number":50,"context_line":"the system, this spec suggest moving all the dhpc-logic from the"},{"line_number":51,"context_line":"mech_driver code to a separate code model."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"This model will be invoked by the ml2-driver, and will function"},{"line_number":54,"context_line":"independently. It\u0027s will used by neutron registry _[1] for subscribing"},{"line_number":55,"context_line":"to sunbet and lswitch CUD event\u0027s, and will be responsible for maintain"},{"line_number":56,"context_line":"the dhcp-port according to the logic that described above."}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f2577a7_10c29486","line":53,"range":{"start_line":53,"start_character":5,"end_line":53,"end_character":10},"updated":"2017-09-10 10:36:44.000000000","message":"module","commit_id":"433e2a61ce6b5965cd5d6cfc08c02b079c739cf4"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"6149386f3da28d91825ae73e0097107c4232162c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Instead of creating dhcp-port per subnet, DF will create one port per"},{"line_number":22,"context_line":"enabled-dhcp switch (when enabled-dhcp-switch defined as switch that"},{"line_number":23,"context_line":"have at least one enable-dhcp-subnet)."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This port will contain multiple ips - one for each dhcp subnet that"},{"line_number":26,"context_line":"connected to the port. All port CUD operation will done with neutron"},{"line_number":27,"context_line":"plugin for using it\u0027s ip-address-managemnt."}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f2577a7_5fd47bbd","line":24,"updated":"2017-09-12 18:25:10.000000000","message":"not clear in what network this port will live","commit_id":"be070e133c416f1df44469db429ab0d60036c269"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"9bdcaec628ec3fea86375b2260108a24c5a1c71a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Instead of creating dhcp-port per subnet, DF will create one port per"},{"line_number":22,"context_line":"enabled-dhcp switch (when enabled-dhcp-switch defined as switch that"},{"line_number":23,"context_line":"have at least one enable-dhcp-subnet)."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This port will contain multiple ips - one for each dhcp subnet that"},{"line_number":26,"context_line":"connected to the port. All port CUD operation will done with neutron"},{"line_number":27,"context_line":"plugin for using it\u0027s ip-address-managemnt."}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f2577a7_8f25daad","line":24,"in_reply_to":"5f2577a7_5fd47bbd","updated":"2017-09-14 07:41:08.000000000","message":"switch is DF-switch that equivalent to nuetron-network - i changed the terms in the spec","commit_id":"be070e133c416f1df44469db429ab0d60036c269"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"6149386f3da28d91825ae73e0097107c4232162c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"have at least one enable-dhcp-subnet)."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This port will contain multiple ips - one for each dhcp subnet that"},{"line_number":26,"context_line":"connected to the port. All port CUD operation will done with neutron"},{"line_number":27,"context_line":"plugin for using it\u0027s ip-address-managemnt."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"In this case we can use one flow per lswitch for foward the packet"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f2577a7_df1cebc2","line":26,"range":{"start_line":26,"start_character":23,"end_line":26,"end_character":68},"updated":"2017-09-12 18:25:10.000000000","message":"Please elaborate on impact on data model on neutron side.\nThis may also have impact on the user that expects dhcp as port in relevant subnet.","commit_id":"be070e133c416f1df44469db429ab0d60036c269"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"9bdcaec628ec3fea86375b2260108a24c5a1c71a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"have at least one enable-dhcp-subnet)."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This port will contain multiple ips - one for each dhcp subnet that"},{"line_number":26,"context_line":"connected to the port. All port CUD operation will done with neutron"},{"line_number":27,"context_line":"plugin for using it\u0027s ip-address-managemnt."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"In this case we can use one flow per lswitch for foward the packet"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f2577a7_cf50820d","line":26,"range":{"start_line":26,"start_character":23,"end_line":26,"end_character":68},"in_reply_to":"5f2577a7_df1cebc2","updated":"2017-09-14 07:41:08.000000000","message":"neutron don\u0027t define how the topology should look-like - before this change DF created port per subnet - and now it\u0027s will create port per switch. \n(I added this information in the \"Problem Description\" )","commit_id":"be070e133c416f1df44469db429ab0d60036c269"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"6149386f3da28d91825ae73e0097107c4232162c","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This port will contain multiple ips - one for each dhcp subnet that"},{"line_number":26,"context_line":"connected to the port. All port CUD operation will done with neutron"},{"line_number":27,"context_line":"plugin for using it\u0027s ip-address-managemnt."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"In this case we can use one flow per lswitch for foward the packet"},{"line_number":30,"context_line":"to controller, as lswitch information saved in the OXM_OF_METADATA."}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f2577a7_7f0e178e","line":27,"range":{"start_line":27,"start_character":32,"end_line":27,"end_character":42},"updated":"2017-09-12 18:25:10.000000000","message":"managment","commit_id":"be070e133c416f1df44469db429ab0d60036c269"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"6149386f3da28d91825ae73e0097107c4232162c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"As part of the effort to reduce the coupling between components in"},{"line_number":50,"context_line":"the system, this spec suggest moving all the dhpc-logic from the"},{"line_number":51,"context_line":"mech_driver code to a separate code module."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"This module will be invoked by the ml2-driver, and will function"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f2577a7_3f6d2f32","line":50,"range":{"start_line":50,"start_character":22,"end_line":50,"end_character":29},"updated":"2017-09-12 18:25:10.000000000","message":"suggests","commit_id":"be070e133c416f1df44469db429ab0d60036c269"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"6149386f3da28d91825ae73e0097107c4232162c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"mech_driver code to a separate code module."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"This module will be invoked by the ml2-driver, and will function"},{"line_number":54,"context_line":"independently. It\u0027s will used by neutron registry _[1] for subscribing"},{"line_number":55,"context_line":"to sunbet and lswitch CUD event\u0027s, and will be responsible for maintain"},{"line_number":56,"context_line":"the dhcp-port according to the logic that described above."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"5f2577a7_5f5fdb71","line":54,"range":{"start_line":54,"start_character":25,"end_line":54,"end_character":29},"updated":"2017-09-12 18:25:10.000000000","message":"be used","commit_id":"be070e133c416f1df44469db429ab0d60036c269"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"eb0ddfec44e8368624d17bc6a3512a543a3f3451","unresolved":false,"context_lines":[{"line_number":9,"context_line":"with \"enable_dhcp\" flag, and leave to the mechanizem-driver to build"},{"line_number":10,"context_line":"the topology that needed to support that (e.g ports, servers etc.. )."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently dragonflow when dragonflow mech-driver receive notification"},{"line_number":13,"context_line":"about subnet that enabled DHCP , it\u0027s create (via the neutron plugin)"},{"line_number":14,"context_line":"a dhcp-port for this subnet, and use it for forwarding traffic from/to"},{"line_number":15,"context_line":"the dhcp-app #_[1] in the compute-node."}],"source_content_type":"text/x-rst","patch_set":11,"id":"5f2577a7_8f5ddaea","line":12,"range":{"start_line":12,"start_character":10,"end_line":12,"end_character":20},"updated":"2017-09-14 07:56:28.000000000","message":"nit: Redundant","commit_id":"dead56192968a9d590a88b7b6b66b72f590a2f9e"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"a2cafbdc55854db9259db76f80a99802a4084ac9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"Problem Description"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"When neutron configure subnets to use dhcp - it\u0027s just mark the subnet"},{"line_number":9,"context_line":"with \"enable_dhcp\" flag, and leave to the mechanizem-driver to build"},{"line_number":10,"context_line":"the topology that needed to support that (e.g ports, servers etc.. )."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"5f2577a7_c3ef081c","line":8,"range":{"start_line":8,"start_character":5,"end_line":8,"end_character":6},"updated":"2017-09-17 07:20:58.000000000","message":"Neutron","commit_id":"e7b40d41ce1730c3b313d210937b14558da3a26b"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"a2cafbdc55854db9259db76f80a99802a4084ac9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"When neutron configure subnets to use dhcp - it\u0027s just mark the subnet"},{"line_number":9,"context_line":"with \"enable_dhcp\" flag, and leave to the mechanizem-driver to build"},{"line_number":10,"context_line":"the topology that needed to support that (e.g ports, servers etc.. )."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently dragonflow when dragonflow mech-driver receive notification"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5f2577a7_a3f07cfe","line":9,"range":{"start_line":9,"start_character":42,"end_line":9,"end_character":52},"updated":"2017-09-17 07:20:58.000000000","message":"mechanism","commit_id":"e7b40d41ce1730c3b313d210937b14558da3a26b"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"a2cafbdc55854db9259db76f80a99802a4084ac9","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This behaviour causes complexity in the code and create a performance penalty,"},{"line_number":22,"context_line":"that because every change in subnet (updated/add/delete/enabled-dhcp/disabled-dhcp)"},{"line_number":23,"context_line":"raise the need to do diff with the previous state, and install/remove all relevant flows."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Proposed Change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5f2577a7_2375ac32","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":5},"updated":"2017-09-17 07:20:58.000000000","message":"raises","commit_id":"e7b40d41ce1730c3b313d210937b14558da3a26b"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"a2cafbdc55854db9259db76f80a99802a4084ac9","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Instead of creating dhcp-port per subnet, DF will create one port per"},{"line_number":29,"context_line":"enabled-dhcp netwrok(lswitch in DF terms)- when enabled-dhcp-network"},{"line_number":30,"context_line":"defined as network that have at least one enable-dhcp-subnet."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"This port will contain multiple ips - one for each dhcp subnet that"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5f2577a7_e390c445","line":29,"range":{"start_line":29,"start_character":12,"end_line":29,"end_character":20},"updated":"2017-09-17 07:20:58.000000000","message":"typo","commit_id":"e7b40d41ce1730c3b313d210937b14558da3a26b"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"a2cafbdc55854db9259db76f80a99802a4084ac9","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* Reduce the number of lport in the DB"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Separate the DHCP logic"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"5f2577a7_03a750a9","line":52,"updated":"2017-09-17 07:20:58.000000000","message":"How this change is reflected in neutron?","commit_id":"e7b40d41ce1730c3b313d210937b14558da3a26b"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"3c904592715454bcf19cfd90e71a4f9ec7dd9473","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Dragonflow data-model impact"},{"line_number":36,"context_line":"----------------------------"},{"line_number":37,"context_line":"Instead dhcp-lport per logical-subnet, there will be dhcp-port"},{"line_number":38,"context_line":"per logical-switch. enable_dhcp trait will be removed from logical-subnet."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Dragonflow controller impact"},{"line_number":41,"context_line":"----------------------------"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5f4e5783_8bea24d5","line":38,"range":{"start_line":38,"start_character":20,"end_line":38,"end_character":73},"updated":"2017-10-17 12:21:16.000000000","message":"Is this change requires upgrade code?","commit_id":"7d8c08652b322f75f8f2d1737ba4b1d52415fe79"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"a5aec98f1377feda3be517bd71d00d938d50f0d9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Dragonflow data-model impact"},{"line_number":36,"context_line":"----------------------------"},{"line_number":37,"context_line":"Instead dhcp-lport per logical-subnet, there will be dhcp-port"},{"line_number":38,"context_line":"per logical-switch. enable_dhcp trait will be removed from logical-subnet."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Dragonflow controller impact"},{"line_number":41,"context_line":"----------------------------"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_19ebf7b0","line":38,"range":{"start_line":38,"start_character":20,"end_line":38,"end_character":73},"in_reply_to":"3f4b6375_d8d67dc4","updated":"2017-10-19 14:06:23.000000000","message":"yes the dhcp module will not save that field , and the dhcp app will not read it.","commit_id":"7d8c08652b322f75f8f2d1737ba4b1d52415fe79"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"4bc0d24176381935cb3cfb8328db757f473958dd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Dragonflow data-model impact"},{"line_number":36,"context_line":"----------------------------"},{"line_number":37,"context_line":"Instead dhcp-lport per logical-subnet, there will be dhcp-port"},{"line_number":38,"context_line":"per logical-switch. enable_dhcp trait will be removed from logical-subnet."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Dragonflow controller impact"},{"line_number":41,"context_line":"----------------------------"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5f4e5783_eae8687c","line":38,"range":{"start_line":38,"start_character":20,"end_line":38,"end_character":73},"in_reply_to":"5f4e5783_8bea24d5","updated":"2017-10-17 18:01:42.000000000","message":"I don\u0027t think that it will broke anything as it just remove operation, but it\u0027s will be more correct to add an upgrade code (I will add to the spec )","commit_id":"7d8c08652b322f75f8f2d1737ba4b1d52415fe79"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"5c76e54519bff24526212c81abc3136b40484ed0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Dragonflow data-model impact"},{"line_number":36,"context_line":"----------------------------"},{"line_number":37,"context_line":"Instead dhcp-lport per logical-subnet, there will be dhcp-port"},{"line_number":38,"context_line":"per logical-switch. enable_dhcp trait will be removed from logical-subnet."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Dragonflow controller impact"},{"line_number":41,"context_line":"----------------------------"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f4b6375_d8d67dc4","line":38,"range":{"start_line":38,"start_character":20,"end_line":38,"end_character":73},"in_reply_to":"5f4e5783_eae8687c","updated":"2017-10-18 08:50:48.000000000","message":"Will it require changes to how the data is stored in the db?","commit_id":"7d8c08652b322f75f8f2d1737ba4b1d52415fe79"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"fbc3464c7ab690160b1f849799e5855b5576101a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Instead of one dhcp logical port subnet, there will be"},{"line_number":32,"context_line":"one dhcp-port per network.That port will hold the ips"},{"line_number":33,"context_line":"from all enabled_dhcp subnets that belong that network."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Dragonflow data-model impact"},{"line_number":36,"context_line":"----------------------------"},{"line_number":37,"context_line":"Instead dhcp-lport per logical-subnet, there will be dhcp-port"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f4b6375_81dc0d19","line":34,"updated":"2017-10-18 12:39:04.000000000","message":"Would port device_owner be same as before the change? Would port in each subnet that is dhcp enabled, have port with neutron:dhcp?","commit_id":"3efdf8f19e0c4d0295d1a74cfe4aa253164dff65"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"a5aec98f1377feda3be517bd71d00d938d50f0d9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Instead of one dhcp logical port subnet, there will be"},{"line_number":32,"context_line":"one dhcp-port per network.That port will hold the ips"},{"line_number":33,"context_line":"from all enabled_dhcp subnets that belong that network."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Dragonflow data-model impact"},{"line_number":36,"context_line":"----------------------------"},{"line_number":37,"context_line":"Instead dhcp-lport per logical-subnet, there will be dhcp-port"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f4b6375_d9889872","line":34,"in_reply_to":"3f4b6375_81dc0d19","updated":"2017-10-19 14:06:23.000000000","message":"1. yes the device owner will not change \n2. this port will be connected to all subnets.\n(will add that to the spec )","commit_id":"3efdf8f19e0c4d0295d1a74cfe4aa253164dff65"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"fbc3464c7ab690160b1f849799e5855b5576101a","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* Reduce mumber of flows in dhcp tables"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* Reduce the number of lport in the DB"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Separate the DHCP logic"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f4b6375_41aa9585","line":57,"range":{"start_line":57,"start_character":23,"end_line":57,"end_character":28},"updated":"2017-10-18 12:39:04.000000000","message":"lports","commit_id":"3efdf8f19e0c4d0295d1a74cfe4aa253164dff65"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"a5aec98f1377feda3be517bd71d00d938d50f0d9","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* Reduce mumber of flows in dhcp tables"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* Reduce the number of lport in the DB"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Separate the DHCP logic"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f4b6375_b97ddc6f","line":57,"range":{"start_line":57,"start_character":23,"end_line":57,"end_character":28},"in_reply_to":"3f4b6375_41aa9585","updated":"2017-10-19 14:06:23.000000000","message":"done","commit_id":"3efdf8f19e0c4d0295d1a74cfe4aa253164dff65"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"fbc3464c7ab690160b1f849799e5855b5576101a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"As part of the effort to reduce the coupling between components in"},{"line_number":64,"context_line":"the system, this spec suggest moving all the dhpc-logic from the"},{"line_number":65,"context_line":"mech_driver code to a separate code module."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"This module will be invoked by the ml2-driver, and will function"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f4b6375_c19d6567","line":64,"range":{"start_line":64,"start_character":22,"end_line":64,"end_character":28},"updated":"2017-10-18 12:39:04.000000000","message":"suggests","commit_id":"3efdf8f19e0c4d0295d1a74cfe4aa253164dff65"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"a5aec98f1377feda3be517bd71d00d938d50f0d9","unresolved":false,"context_lines":[{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"As part of the effort to reduce the coupling between components in"},{"line_number":64,"context_line":"the system, this spec suggest moving all the dhpc-logic from the"},{"line_number":65,"context_line":"mech_driver code to a separate code module."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"This module will be invoked by the ml2-driver, and will function"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f4b6375_5994a88b","line":64,"range":{"start_line":64,"start_character":22,"end_line":64,"end_character":28},"in_reply_to":"3f4b6375_c19d6567","updated":"2017-10-19 14:06:23.000000000","message":"done","commit_id":"3efdf8f19e0c4d0295d1a74cfe4aa253164dff65"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"fbc3464c7ab690160b1f849799e5855b5576101a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"mech_driver code to a separate code module."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"This module will be invoked by the ml2-driver, and will function"},{"line_number":68,"context_line":"independently. It\u0027s will used by neutron registry _[1] for subscribing"},{"line_number":69,"context_line":"to sunbet and lswitch CUD event\u0027s, and will be responsible for maintain"},{"line_number":70,"context_line":"the dhcp-port according to the logic that described above."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f4b6375_e179812f","line":68,"range":{"start_line":68,"start_character":15,"end_line":68,"end_character":32},"updated":"2017-10-18 12:39:04.000000000","message":"It will use","commit_id":"3efdf8f19e0c4d0295d1a74cfe4aa253164dff65"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"a5aec98f1377feda3be517bd71d00d938d50f0d9","unresolved":false,"context_lines":[{"line_number":65,"context_line":"mech_driver code to a separate code module."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"This module will be invoked by the ml2-driver, and will function"},{"line_number":68,"context_line":"independently. It\u0027s will used by neutron registry _[1] for subscribing"},{"line_number":69,"context_line":"to sunbet and lswitch CUD event\u0027s, and will be responsible for maintain"},{"line_number":70,"context_line":"the dhcp-port according to the logic that described above."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f4b6375_198e3078","line":68,"range":{"start_line":68,"start_character":15,"end_line":68,"end_character":32},"in_reply_to":"3f4b6375_e179812f","updated":"2017-10-19 14:06:23.000000000","message":"done","commit_id":"3efdf8f19e0c4d0295d1a74cfe4aa253164dff65"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"fbc3464c7ab690160b1f849799e5855b5576101a","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"This module will be invoked by the ml2-driver, and will function"},{"line_number":68,"context_line":"independently. It\u0027s will used by neutron registry _[1] for subscribing"},{"line_number":69,"context_line":"to sunbet and lswitch CUD event\u0027s, and will be responsible for maintain"},{"line_number":70,"context_line":"the dhcp-port according to the logic that described above."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f4b6375_c176853f","line":69,"range":{"start_line":69,"start_character":59,"end_line":69,"end_character":63},"updated":"2017-10-18 12:39:04.000000000","message":"to","commit_id":"3efdf8f19e0c4d0295d1a74cfe4aa253164dff65"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"a5aec98f1377feda3be517bd71d00d938d50f0d9","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"This module will be invoked by the ml2-driver, and will function"},{"line_number":68,"context_line":"independently. It\u0027s will used by neutron registry _[1] for subscribing"},{"line_number":69,"context_line":"to sunbet and lswitch CUD event\u0027s, and will be responsible for maintain"},{"line_number":70,"context_line":"the dhcp-port according to the logic that described above."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f4b6375_b9f27c05","line":69,"range":{"start_line":69,"start_character":59,"end_line":69,"end_character":63},"in_reply_to":"3f4b6375_c176853f","updated":"2017-10-19 14:06:23.000000000","message":"done","commit_id":"3efdf8f19e0c4d0295d1a74cfe4aa253164dff65"}]}