)]}'
{"dragonflow/controller/df_local_controller.py":[{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"3126c1c4387bdbe86fbd025c7cf26282985c4071","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    def notify_port_status(self, ovs_port, status):"},{"line_number":264,"context_line":"        if self.neutron_notifier:"},{"line_number":265,"context_line":"            table_name \u003d l2.LogicalPort.table_name"},{"line_number":266,"context_line":"            iface_id \u003d ovs_port.iface_id"},{"line_number":267,"context_line":"            self.neutron_notifier.notify_neutron_server(table_name, iface_id,"},{"line_number":268,"context_line":"                                                        \u0027update\u0027, status)"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_23be9cfe","line":266,"range":{"start_line":266,"start_character":33,"end_line":266,"end_character":40},"updated":"2017-08-30 17:33:42.000000000","message":"was changed to lport in https://review.openstack.org/#/c/480195/","commit_id":"da39693c6ca741fbbc42c8364a09918c068949e3"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"6ef1d1e147ae5fbcb0adb642e1971beb1eb3c40f","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    def notify_port_status(self, ovs_port, status):"},{"line_number":264,"context_line":"        if self.neutron_notifier:"},{"line_number":265,"context_line":"            table_name \u003d l2.LogicalPort.table_name"},{"line_number":266,"context_line":"            iface_id \u003d ovs_port.iface_id"},{"line_number":267,"context_line":"            self.neutron_notifier.notify_neutron_server(table_name, iface_id,"},{"line_number":268,"context_line":"                                                        \u0027update\u0027, status)"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_8ec329ed","line":266,"range":{"start_line":266,"start_character":33,"end_line":266,"end_character":40},"in_reply_to":"7f287b81_23be9cfe","updated":"2017-08-31 07:05:58.000000000","message":"thx , will change","commit_id":"da39693c6ca741fbbc42c8364a09918c068949e3"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"fd23741734aaec823e894d3fea5a22dabbc8e916","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    def get_chassis_name(self):"},{"line_number":261,"context_line":"        return self.chassis_name"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def notify_port_status(self, ovs_port, status):"},{"line_number":264,"context_line":"        if self.neutron_notifier:"},{"line_number":265,"context_line":"            table_name \u003d l2.LogicalPort.table_name"},{"line_number":266,"context_line":"            iface_id \u003d ovs_port.lport"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_a930d108","line":263,"range":{"start_line":263,"start_character":8,"end_line":263,"end_character":26},"updated":"2017-09-04 14:25:22.000000000","message":"Why not update this as well to notify_neutron_server?","commit_id":"b3fc49a154ab1e804ff6f9edc8cf5f3ec5979956"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"8b9dd758f7d3c2631a4e714128fca6e7aae6fba9","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    def get_chassis_name(self):"},{"line_number":261,"context_line":"        return self.chassis_name"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def notify_port_status(self, ovs_port, status):"},{"line_number":264,"context_line":"        if self.neutron_notifier:"},{"line_number":265,"context_line":"            table_name \u003d l2.LogicalPort.table_name"},{"line_number":266,"context_line":"            iface_id \u003d ovs_port.lport"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_b7537ce2","line":263,"range":{"start_line":263,"start_character":8,"end_line":263,"end_character":26},"in_reply_to":"7f287b81_a930d108","updated":"2017-09-05 09:20:22.000000000","message":"This function is just for port status - \nand not for general notification.\n\nmaybe notify_neutron_port_status could be better?","commit_id":"b3fc49a154ab1e804ff6f9edc8cf5f3ec5979956"}],"dragonflow/db/pubsub_drivers/nb_api_neutron_notifier.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"95c82804a33f71661c85124ee33e29823daf75e4","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            core_plugin.update_port_status(n_context.get_admin_context(),"},{"line_number":114,"context_line":"                                           key, value)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def notify_neutron_server(self, table, key, action, value, topic\u003dNone):"},{"line_number":117,"context_line":"        self._send_event(table, key, \u0027update\u0027, value)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_c375319a","line":116,"updated":"2017-09-05 01:55:18.000000000","message":"topic and action parameters are not used in this function. Since there\u0027s no API compatibility issues (yet), why add unused parameters?","commit_id":"b3fc49a154ab1e804ff6f9edc8cf5f3ec5979956"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"8b9dd758f7d3c2631a4e714128fca6e7aae6fba9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            core_plugin.update_port_status(n_context.get_admin_context(),"},{"line_number":114,"context_line":"                                           key, value)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def notify_neutron_server(self, table, key, action, value, topic\u003dNone):"},{"line_number":117,"context_line":"        self._send_event(table, key, \u0027update\u0027, value)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_37278c67","line":116,"in_reply_to":"7f287b81_c375319a","updated":"2017-09-05 09:20:22.000000000","message":"for the action it\u0027s should be part of _send_event call (instead \u0027update\u0027) it\u0027s a bug and i will change it. thanks :)  \n\nthe topic will be removed ..","commit_id":"b3fc49a154ab1e804ff6f9edc8cf5f3ec5979956"}]}