)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"3b6f28541122e0c0e05dbfcd14222985ecd0eb22","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shachar Snapiri \u003cshachar.snapiri@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-09-19 10:26:24 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a flag to allow using neutron ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a flag (DF_USE_DF_OVS) - when set to false, the neutron ovs will not"},{"line_number":10,"context_line":"be uninistalled and will be used."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f5c4f37_5a839405","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":37},"updated":"2017-09-21 08:33:21.000000000","message":"what does it mean \u0027neutron ovs\u0027?","commit_id":"e314359cba6c96b0f98ee7901cde0748abf1221f"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"3ac3a87874b5cf32e8e9c2b77d9ba3937bb2d715","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shachar Snapiri \u003cshachar.snapiri@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-09-19 10:26:24 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a flag to allow using neutron ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a flag (DF_USE_DF_OVS) - when set to false, the neutron ovs will not"},{"line_number":10,"context_line":"be uninistalled and will be used."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f515b1d_b83b9736","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":37},"in_reply_to":"9f5c4f37_5a839405","updated":"2017-09-24 07:20:36.000000000","message":"The default OpenVSwitch installed by Neutron","commit_id":"e314359cba6c96b0f98ee7901cde0748abf1221f"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"3b6f28541122e0c0e05dbfcd14222985ecd0eb22","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a flag to allow using neutron ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a flag (DF_USE_DF_OVS) - when set to false, the neutron ovs will not"},{"line_number":10,"context_line":"be uninistalled and will be used."},{"line_number":11,"context_line":"This will allow us to use some preconfigurations done by neurton in some"},{"line_number":12,"context_line":"specific cases."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f5c4f37_1a7d1c1c","line":9,"range":{"start_line":9,"start_character":41,"end_line":9,"end_character":46},"updated":"2017-09-21 08:33:21.000000000","message":"please add clarification what happens when it is set to True","commit_id":"e314359cba6c96b0f98ee7901cde0748abf1221f"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"3ac3a87874b5cf32e8e9c2b77d9ba3937bb2d715","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a flag to allow using neutron ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a flag (DF_USE_DF_OVS) - when set to false, the neutron ovs will not"},{"line_number":10,"context_line":"be uninistalled and will be used."},{"line_number":11,"context_line":"This will allow us to use some preconfigurations done by neurton in some"},{"line_number":12,"context_line":"specific cases."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f515b1d_9848dbcc","line":9,"range":{"start_line":9,"start_character":41,"end_line":9,"end_character":46},"in_reply_to":"9f5c4f37_1a7d1c1c","updated":"2017-09-24 07:20:36.000000000","message":"Will do","commit_id":"e314359cba6c96b0f98ee7901cde0748abf1221f"}],"devstack/ovs_setup.sh":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"3b6f28541122e0c0e05dbfcd14222985ecd0eb22","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        # setup external bridge if necessary"},{"line_number":163,"context_line":"        check_dnat\u003d$(echo $DF_APPS_LIST | grep \"dnat\")"},{"line_number":164,"context_line":"        if [[ \"$check_dnat\" !\u003d \"\" ]]; then"},{"line_number":165,"context_line":"            # Create the bridge only if it does not already exist"},{"line_number":166,"context_line":"            if ! sudo ovs-vsctl br-exists $PUBLIC_BRIDGE; then"},{"line_number":167,"context_line":"                echo \"Setup external bridge for DNAT\""},{"line_number":168,"context_line":"                sudo ovs-vsctl add-br $PUBLIC_BRIDGE || true"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9f5c4f37_facc8862","line":165,"updated":"2017-09-21 08:33:21.000000000","message":"Is this change related to the added flag?","commit_id":"e314359cba6c96b0f98ee7901cde0748abf1221f"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"3ac3a87874b5cf32e8e9c2b77d9ba3937bb2d715","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        # setup external bridge if necessary"},{"line_number":163,"context_line":"        check_dnat\u003d$(echo $DF_APPS_LIST | grep \"dnat\")"},{"line_number":164,"context_line":"        if [[ \"$check_dnat\" !\u003d \"\" ]]; then"},{"line_number":165,"context_line":"            # Create the bridge only if it does not already exist"},{"line_number":166,"context_line":"            if ! sudo ovs-vsctl br-exists $PUBLIC_BRIDGE; then"},{"line_number":167,"context_line":"                echo \"Setup external bridge for DNAT\""},{"line_number":168,"context_line":"                sudo ovs-vsctl add-br $PUBLIC_BRIDGE || true"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7f515b1d_f8390f41","line":165,"in_reply_to":"9f5c4f37_facc8862","updated":"2017-09-24 07:20:36.000000000","message":"Indeed it is.\nWhen the DF removes the OVS, it removes the public bridge too.\nThe only way this bridge may exist is when it was created by neutron and DF did not remove it.","commit_id":"e314359cba6c96b0f98ee7901cde0748abf1221f"}],"devstack/plugin.sh":[{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"c52f44d60d7744a5d519f92de9f6336b639cd268","unresolved":false,"context_lines":[{"line_number":525,"context_line":"                install_neutron"},{"line_number":526,"context_line":"            fi"},{"line_number":527,"context_line":"            install_df"},{"line_number":528,"context_line":"            if [[ \"$DF_USE_DF_OVS\" \u003d\u003d \"True\" ]]; then"},{"line_number":529,"context_line":"                install_ovs"},{"line_number":530,"context_line":"            fi"},{"line_number":531,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff5d4b2f_3e8221ca","line":528,"range":{"start_line":528,"start_character":20,"end_line":528,"end_character":33},"updated":"2017-09-19 07:37:34.000000000","message":"maybe named as  DF_REINSTALL_OVS ?","commit_id":"e314359cba6c96b0f98ee7901cde0748abf1221f"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"3ac3a87874b5cf32e8e9c2b77d9ba3937bb2d715","unresolved":false,"context_lines":[{"line_number":525,"context_line":"                install_neutron"},{"line_number":526,"context_line":"            fi"},{"line_number":527,"context_line":"            install_df"},{"line_number":528,"context_line":"            if [[ \"$DF_USE_DF_OVS\" \u003d\u003d \"True\" ]]; then"},{"line_number":529,"context_line":"                install_ovs"},{"line_number":530,"context_line":"            fi"},{"line_number":531,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7f515b1d_3819e7d6","line":528,"range":{"start_line":528,"start_character":20,"end_line":528,"end_character":33},"in_reply_to":"ff5d4b2f_3e8221ca","updated":"2017-09-24 07:20:36.000000000","message":"Both are good. This name indicates the notation of removing the default OVS installed by neutron and reinstalling a different version used by DF.","commit_id":"e314359cba6c96b0f98ee7901cde0748abf1221f"}],"devstack/settings":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"1ff2d7f2a85a740885e516d44fe380d5b7d5ac48","unresolved":false,"context_lines":[{"line_number":51,"context_line":"Q_ENABLE_DRAGONFLOW_LOCAL_CONTROLLER\u003d${Q_ENABLE_DRAGONFLOW_LOCAL_CONTROLLER:-\"True\"}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# OVS bridges related defualts"},{"line_number":54,"context_line":"DF_REINSTALL_OVS\u003d${DF_USE_DF_OVS:-True} # Remove the OVS installed by Neutron"},{"line_number":55,"context_line":"                                        # and reinstall a newer version"},{"line_number":56,"context_line":"INTEGRATION_BRIDGE\u003d${INTEGRATION_BRIDGE:-br-int}"},{"line_number":57,"context_line":"PUBLIC_NETWORK_GATEWAY\u003d${PUBLIC_NETWORK_GATEWAY:-172.24.4.1}"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"7f515b1d_7ee3c734","line":54,"range":{"start_line":54,"start_character":19,"end_line":54,"end_character":32},"updated":"2017-09-24 12:40:10.000000000","message":"Typo: DF_USE_DF_OVS -\u003e DF_REINSTALL_OVS ?","commit_id":"8c619e1d9e438889c8f5b5d77b6745681f15cd02"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"0651757a139959d211660a17c95a5f30b6743820","unresolved":false,"context_lines":[{"line_number":51,"context_line":"Q_ENABLE_DRAGONFLOW_LOCAL_CONTROLLER\u003d${Q_ENABLE_DRAGONFLOW_LOCAL_CONTROLLER:-\"True\"}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# OVS bridges related defualts"},{"line_number":54,"context_line":"DF_REINSTALL_OVS\u003d${DF_USE_DF_OVS:-True} # Remove the OVS installed by Neutron"},{"line_number":55,"context_line":"                                        # and reinstall a newer version"},{"line_number":56,"context_line":"INTEGRATION_BRIDGE\u003d${INTEGRATION_BRIDGE:-br-int}"},{"line_number":57,"context_line":"PUBLIC_NETWORK_GATEWAY\u003d${PUBLIC_NETWORK_GATEWAY:-172.24.4.1}"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"7f515b1d_d2b18a91","line":54,"range":{"start_line":54,"start_character":19,"end_line":54,"end_character":32},"in_reply_to":"7f515b1d_7ee3c734","updated":"2017-09-25 04:33:07.000000000","message":"When you are right, you are right...","commit_id":"8c619e1d9e438889c8f5b5d77b6745681f15cd02"}]}