)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"dcb8e626134e2f24e5ed5dc54e9972e078edf345","unresolved":false,"context_lines":[{"line_number":493,"context_line":"    fi"},{"line_number":494,"context_line":"}"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"function setup_rootwrap_filters {"},{"line_number":497,"context_line":"    echo \"Adding rootwrap filters\""},{"line_number":498,"context_line":"    sudo $DRAGONFLOW_DIR/tools/deploy_rootwrap.sh $DRAGONFLOW_DIR $NEUTRON_CONF_DIR"},{"line_number":499,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":5,"id":"bf8cb3f7_734df870","line":496,"updated":"2017-12-26 08:37:05.000000000","message":"Add a guard?","commit_id":"3b7385333ce76f1dbfb58091b7bc8429b22f917d"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"81638c4363b9b7d61915f2377ffef90f868aa3fc","unresolved":false,"context_lines":[{"line_number":498,"context_line":"    if [[ \"$DF_INSTALL_DEBUG_ROOTWRAP_CONF\" \u003d\u003d \"True\" ]]; then"},{"line_number":499,"context_line":"        echo \"Adding rootwrap filters\""},{"line_number":500,"context_line":"        sudo mkdir -p -m 755 $DRAGONFLOW_DIR/rootwrap.d/* $NEUTRON_CONF_DIR/etc/rootwrap.d"},{"line_number":501,"context_line":"        sudo cp -p ${src_rootwrap_path}/* ${dst_rootwrap_path}/"},{"line_number":502,"context_line":"    fi"},{"line_number":503,"context_line":"}"},{"line_number":504,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"bf8cb3f7_39d431bd","line":501,"range":{"start_line":501,"start_character":8,"end_line":501,"end_character":63},"updated":"2017-12-26 13:29:42.000000000","message":"As commented on another file, As there are only two lines, I would prefer changing to something like:\nsudo CAT \u003c\u003cROOTWRAPEOF \u003e${dst_rootwrap_path}/dragonflow.filters\n[Filters]\novs-appctl: CommandFilter, ovs-appctl, root\nROOTWRAPEOF\nand then remove the dragonflow.filter file from the patch","commit_id":"0793215def33b9b2ede7a02660d0c446a5ae3a77"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"a764a6faf3f35f76febc77c09193f08275cd4f53","unresolved":false,"context_lines":[{"line_number":498,"context_line":"    if [[ \"$DF_INSTALL_DEBUG_ROOTWRAP_CONF\" \u003d\u003d \"True\" ]]; then"},{"line_number":499,"context_line":"        echo \"Adding rootwrap filters\""},{"line_number":500,"context_line":"        sudo mkdir -p -m 755 $DRAGONFLOW_DIR/rootwrap.d/* $NEUTRON_CONF_DIR/etc/rootwrap.d"},{"line_number":501,"context_line":"        sudo cp -p ${src_rootwrap_path}/* ${dst_rootwrap_path}/"},{"line_number":502,"context_line":"    fi"},{"line_number":503,"context_line":"}"},{"line_number":504,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"bf8cb3f7_31cbe572","line":501,"range":{"start_line":501,"start_character":8,"end_line":501,"end_character":63},"in_reply_to":"bf8cb3f7_39d431bd","updated":"2017-12-26 19:22:54.000000000","message":"src_rootwrap_path and dst_rootwrap_path are undefined.\n\nI think keeping a dedicated rootwrap file will help when we\u0027ll want to add more filters to this file.","commit_id":"0793215def33b9b2ede7a02660d0c446a5ae3a77"}],"devstack/settings":[{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"9f78a3df7efd51c0a0482e7c40c26e861f9f7cc4","unresolved":false,"context_lines":[{"line_number":6,"context_line":"DRAGONFLOW_DIR\u003d$DEST/dragonflow"},{"line_number":7,"context_line":"DRAGONFLOW_BRANCH\u003d${DRAGONFLOW_BRANCH:-master}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DF_INSTALL_DEBUG_ROOTWRAP_CONF\u003d${DF_INSTALL_DEBUG_ROOTWRAP_CONF:-\"False\"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DF_L3_BINARY\u003d$NEUTRON_BIN_DIR/df-l3-agent"},{"line_number":12,"context_line":"DF_LOCAL_CONTROLLER_BINARY\u003d$NEUTRON_BIN_DIR/df-local-controller"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"bf8cb3f7_c30e643a","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":73},"updated":"2017-12-27 19:34:01.000000000","message":"Why not default to yes when installing devstack?","commit_id":"5039cd130167bc04490f33ec6b4786e6d431054f"},{"author":{"_account_id":23766,"name":"Dima Kuznetsov","email":"dima.kuznetsov@toganetworks.com","username":"dimak"},"change_message_id":"ac5516877f5ff0e843e988c6a01a2dea7f913c71","unresolved":false,"context_lines":[{"line_number":6,"context_line":"DRAGONFLOW_DIR\u003d$DEST/dragonflow"},{"line_number":7,"context_line":"DRAGONFLOW_BRANCH\u003d${DRAGONFLOW_BRANCH:-master}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DF_INSTALL_DEBUG_ROOTWRAP_CONF\u003d${DF_INSTALL_DEBUG_ROOTWRAP_CONF:-\"False\"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DF_L3_BINARY\u003d$NEUTRON_BIN_DIR/df-l3-agent"},{"line_number":12,"context_line":"DF_LOCAL_CONTROLLER_BINARY\u003d$NEUTRON_BIN_DIR/df-local-controller"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9f91af0f_59e143fe","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":73},"in_reply_to":"9f91af0f_4e9dfb57","updated":"2017-12-28 10:32:52.000000000","message":"I don\u0027t think devstack and security can be used in the same sentence. It\u0027s not like anyone will deploy devstack in a real environment, and if they do, this will be the smallest of their security concerns :P","commit_id":"5039cd130167bc04490f33ec6b4786e6d431054f"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"ee91939dcac96f92fcb87826b5434e3dd76d9224","unresolved":false,"context_lines":[{"line_number":6,"context_line":"DRAGONFLOW_DIR\u003d$DEST/dragonflow"},{"line_number":7,"context_line":"DRAGONFLOW_BRANCH\u003d${DRAGONFLOW_BRANCH:-master}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DF_INSTALL_DEBUG_ROOTWRAP_CONF\u003d${DF_INSTALL_DEBUG_ROOTWRAP_CONF:-\"False\"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DF_L3_BINARY\u003d$NEUTRON_BIN_DIR/df-l3-agent"},{"line_number":12,"context_line":"DF_LOCAL_CONTROLLER_BINARY\u003d$NEUTRON_BIN_DIR/df-local-controller"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9f91af0f_d9ef93ae","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":73},"in_reply_to":"9f91af0f_59e143fe","updated":"2017-12-28 10:51:20.000000000","message":"I am OK with that either way :)\nChanged default behavior","commit_id":"5039cd130167bc04490f33ec6b4786e6d431054f"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"953b8b8c9722cf3f45754f0073fdb275842500e4","unresolved":false,"context_lines":[{"line_number":6,"context_line":"DRAGONFLOW_DIR\u003d$DEST/dragonflow"},{"line_number":7,"context_line":"DRAGONFLOW_BRANCH\u003d${DRAGONFLOW_BRANCH:-master}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DF_INSTALL_DEBUG_ROOTWRAP_CONF\u003d${DF_INSTALL_DEBUG_ROOTWRAP_CONF:-\"False\"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DF_L3_BINARY\u003d$NEUTRON_BIN_DIR/df-l3-agent"},{"line_number":12,"context_line":"DF_LOCAL_CONTROLLER_BINARY\u003d$NEUTRON_BIN_DIR/df-local-controller"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9f91af0f_4e9dfb57","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":73},"in_reply_to":"bf8cb3f7_c30e643a","updated":"2017-12-28 09:43:42.000000000","message":"Every rootwrap configuration is a potential security problem.\nIMHO we should avoid it as much as possible.","commit_id":"5039cd130167bc04490f33ec6b4786e6d431054f"}],"doc/source/testing_and_debugging.rst":[{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"9fa6a37c131a3519ffb5a09d9b229b62a31ae608","unresolved":false,"context_lines":[{"line_number":98,"context_line":"SimulateAndSendAction."},{"line_number":99,"context_line":"Note that in order to use this functionality, you would have to add some"},{"line_number":100,"context_line":"rootwrap configuration so that the dragonflow controller will be able to"},{"line_number":101,"context_line":"launch the ovs-appctl command."},{"line_number":102,"context_line":"To have this configured automatically, add the following line to the local"},{"line_number":103,"context_line":".conf before running the stack.sh script (for devstack only)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f91af0f_8893fb4f","line":101,"range":{"start_line":101,"start_character":15,"end_line":101,"end_character":21},"updated":"2017-12-28 06:56:23.000000000","message":"the plane to use the ofproto/trace ? \nif so -  maybe a mention that add a reference to command documentation  (maybe vswitch.org/en/latest/tutorials/ovs-advanced/)\nif it\u0027s something else please provide some details :)","commit_id":"5039cd130167bc04490f33ec6b4786e6d431054f"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"953b8b8c9722cf3f45754f0073fdb275842500e4","unresolved":false,"context_lines":[{"line_number":98,"context_line":"SimulateAndSendAction."},{"line_number":99,"context_line":"Note that in order to use this functionality, you would have to add some"},{"line_number":100,"context_line":"rootwrap configuration so that the dragonflow controller will be able to"},{"line_number":101,"context_line":"launch the ovs-appctl command."},{"line_number":102,"context_line":"To have this configured automatically, add the following line to the local"},{"line_number":103,"context_line":".conf before running the stack.sh script (for devstack only)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f91af0f_2e0d1790","line":101,"range":{"start_line":101,"start_character":15,"end_line":101,"end_character":21},"in_reply_to":"9f91af0f_8893fb4f","updated":"2017-12-28 09:43:42.000000000","message":"Indeed it is using ofproto/trace.\nThe code is already there for a long time. The problem is that you can not use it unless you add the relevant rootwrap entries, so the code can call the ovs-vsctl command (requires root permissions).\nWill add reference.","commit_id":"5039cd130167bc04490f33ec6b4786e6d431054f"}],"setup.cfg":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"dcb8e626134e2f24e5ed5dc54e9972e078edf345","unresolved":false,"context_lines":[{"line_number":23,"context_line":"packages \u003d"},{"line_number":24,"context_line":"    dragonflow"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"data_files \u003d"},{"line_number":27,"context_line":"    etc/neutron/rootwrap.d \u003d"},{"line_number":28,"context_line":"        etc/rootwrap.d/dragonflow.filters"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"bf8cb3f7_b335c0dc","line":26,"updated":"2017-12-26 08:37:05.000000000","message":"This is only for testing/debug. I don\u0027t think I want it here.","commit_id":"3b7385333ce76f1dbfb58091b7bc8429b22f917d"}],"tools/deploy_rootwrap.sh":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"dcb8e626134e2f24e5ed5dc54e9972e078edf345","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bf8cb3f7_532554aa","updated":"2017-12-26 08:37:05.000000000","message":"I don\u0027t want to add *yet another* one of these files. There\u0027s already one in Neutron, fwaas, and vpnaas.\n\nSince there are only two functional line, maybe make this inline in plugin.sh?","commit_id":"3b7385333ce76f1dbfb58091b7bc8429b22f917d"}]}