)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"8fb1a4b4d1150ec57c1b5928732548782b585cf9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Omer Anson \u003comer.anson@toganetworks.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-28 08:25:45 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Port portsec app to new framework"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5c76eabb9e15c628a6ca800123a135b7e1347c3f"},{"line_number":10,"context_line":"Related-Bug: #1738986"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":39,"id":"5f7c97a3_ad961648","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":4},"updated":"2018-06-03 05:53:23.000000000","message":"a bit confusing :-) Maybe \u0027Adjust\u0027 ...","commit_id":"b266b04caa25846706142ff26a36f67cb2ce32c0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"0dedf69179cbab264b7ff99305e0d1d11a8cd785","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Omer Anson \u003comer.anson@toganetworks.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-28 08:25:45 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Port portsec app to new framework"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5c76eabb9e15c628a6ca800123a135b7e1347c3f"},{"line_number":10,"context_line":"Related-Bug: #1738986"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":39,"id":"5f7c97a3_2d5c467b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":4},"in_reply_to":"5f7c97a3_ad961648","updated":"2018-06-03 06:32:39.000000000","message":"Will do.","commit_id":"b266b04caa25846706142ff26a36f67cb2ce32c0"}],"dragonflow/controller/apps/portsec.py":[{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"e94d492543f6c6e6d83b87a48223d20bb178bb47","unresolved":false,"context_lines":[{"line_number":400,"context_line":"            self._subtract_lists(new_valid_macs, old_valid_macs)"},{"line_number":401,"context_line":"        return added_valid_macs, removed_valid_macs"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    def initialize(self):"},{"line_number":404,"context_line":"        super(PortSecApp, self).initialize()"},{"line_number":405,"context_line":"        parser \u003d self.parser"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"5f7c97a3_0fc99d57","line":403,"range":{"start_line":403,"start_character":8,"end_line":403,"end_character":18},"updated":"2018-05-29 05:59:48.000000000","message":"I could not find any place this is called from. Could you please refer me?","commit_id":"b266b04caa25846706142ff26a36f67cb2ce32c0"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"3c989a975f5b6d45f70052494dbbeb495c06db1c","unresolved":false,"context_lines":[{"line_number":400,"context_line":"            self._subtract_lists(new_valid_macs, old_valid_macs)"},{"line_number":401,"context_line":"        return added_valid_macs, removed_valid_macs"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    def initialize(self):"},{"line_number":404,"context_line":"        super(PortSecApp, self).initialize()"},{"line_number":405,"context_line":"        parser \u003d self.parser"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"5f7c97a3_4f0f9587","line":403,"range":{"start_line":403,"start_character":8,"end_line":403,"end_character":18},"in_reply_to":"5f7c97a3_0fc99d57","updated":"2018-05-29 06:09:13.000000000","message":"It\u0027s called from the new datapath [1]\n[1] https://github.com/openstack/dragonflow/blob/2f08b2b59d5d2c50f707f2b1a08723133dbbc871/dragonflow/controller/datapath.py#L116","commit_id":"b266b04caa25846706142ff26a36f67cb2ce32c0"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"0c9611c0a825c2a9b5a1f7074630f6f80d9e7693","unresolved":false,"context_lines":[{"line_number":400,"context_line":"            self._subtract_lists(new_valid_macs, old_valid_macs)"},{"line_number":401,"context_line":"        return added_valid_macs, removed_valid_macs"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    def initialize(self):"},{"line_number":404,"context_line":"        super(PortSecApp, self).initialize()"},{"line_number":405,"context_line":"        parser \u003d self.parser"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"5f7c97a3_8b2a788e","line":403,"range":{"start_line":403,"start_character":8,"end_line":403,"end_character":18},"in_reply_to":"5f7c97a3_4f0f9587","updated":"2018-05-29 15:11:51.000000000","message":"Thanks","commit_id":"b266b04caa25846706142ff26a36f67cb2ce32c0"}],"dragonflow/controller/apps/sfc_mpls_driver.py":[{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"e94d492543f6c6e6d83b87a48223d20bb178bb47","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                            port_pair_group"},{"line_number":439,"context_line":"                        ),"},{"line_number":440,"context_line":"                    ),"},{"line_number":441,"context_line":"                    self.app.parser.NXActionResubmitTable("},{"line_number":442,"context_line":"                        table_id\u003dconstants.SFC_MPLS_DISPATCH_TABLE),"},{"line_number":443,"context_line":"                ],"},{"line_number":444,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f7c97a3_2f8019f7","line":441,"range":{"start_line":441,"start_character":36,"end_line":441,"end_character":57},"updated":"2018-05-29 05:59:48.000000000","message":"If dest table ID is higher, will it translate to goto?","commit_id":"b266b04caa25846706142ff26a36f67cb2ce32c0"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"0c9611c0a825c2a9b5a1f7074630f6f80d9e7693","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                            port_pair_group"},{"line_number":439,"context_line":"                        ),"},{"line_number":440,"context_line":"                    ),"},{"line_number":441,"context_line":"                    self.app.parser.NXActionResubmitTable("},{"line_number":442,"context_line":"                        table_id\u003dconstants.SFC_MPLS_DISPATCH_TABLE),"},{"line_number":443,"context_line":"                ],"},{"line_number":444,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f7c97a3_ab009403","line":441,"range":{"start_line":441,"start_character":36,"end_line":441,"end_character":57},"in_reply_to":"5f7c97a3_153d2b8d","updated":"2018-05-29 15:11:51.000000000","message":"Indeed, but isn\u0027t the cost of resubmit higher?\nIf so, maybe it would be wise to add some smart code that adds the optimal rule?","commit_id":"b266b04caa25846706142ff26a36f67cb2ce32c0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"95a85727b54d9bcebd1a0ecf215ec9beffcfa850","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                            port_pair_group"},{"line_number":439,"context_line":"                        ),"},{"line_number":440,"context_line":"                    ),"},{"line_number":441,"context_line":"                    self.app.parser.NXActionResubmitTable("},{"line_number":442,"context_line":"                        table_id\u003dconstants.SFC_MPLS_DISPATCH_TABLE),"},{"line_number":443,"context_line":"                ],"},{"line_number":444,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f7c97a3_153d2b8d","line":441,"range":{"start_line":441,"start_character":36,"end_line":441,"end_character":57},"in_reply_to":"5f7c97a3_2f8019f7","updated":"2018-05-29 12:44:53.000000000","message":"No, but you can resubmit forward. You just can\u0027t goto backwards.","commit_id":"b266b04caa25846706142ff26a36f67cb2ce32c0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"094b4a9c2b7620bd65875e29d32a2d6521d4c979","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                            port_pair_group"},{"line_number":439,"context_line":"                        ),"},{"line_number":440,"context_line":"                    ),"},{"line_number":441,"context_line":"                    self.app.parser.NXActionResubmitTable("},{"line_number":442,"context_line":"                        table_id\u003dconstants.SFC_MPLS_DISPATCH_TABLE),"},{"line_number":443,"context_line":"                ],"},{"line_number":444,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f7c97a3_b43c6793","line":441,"range":{"start_line":441,"start_character":36,"end_line":441,"end_character":57},"in_reply_to":"5f7c97a3_ab009403","updated":"2018-05-30 08:46:50.000000000","message":"This code will be changed again when SFC is migrated. Then we\u0027ll go through the datapath framework, which will do that for us.","commit_id":"b266b04caa25846706142ff26a36f67cb2ce32c0"}]}
