)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"23e29824882bc661e78306f1d226aeafa1a18459","unresolved":false,"context_lines":[{"line_number":7,"context_line":"SPEC - Skydive integration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Spec for the integration of the SkyDive project in Dragonflow."},{"line_number":10,"context_line":"Still a few open issues (expect more to be there) - feedback is welcome"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2045fe79423b43b98faef41dc35f28aa872a2b78"},{"line_number":13,"context_line":"Related-Bug: #1749429"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"df7087c5_dc46387d","line":10,"updated":"2018-03-12 09:32:36.000000000","message":"Lets not merge the spec with open issues, better to reduce the scope and come up with another spec for advance phase","commit_id":"107b4c668679da6783935bc29a70f965e912bb52"}],"doc/source/specs/skydive_integration.rst":[{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"be4dd73f1a551a81d72206d83dc008149112f93b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"5. Allow simulation or tracing of packets in the system on the graphical"},{"line_number":41,"context_line":"   interface."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"All of these features are supported by skydive project, but for other"},{"line_number":44,"context_line":"collectors, we should implement our own collector (or a way to send the"},{"line_number":45,"context_line":"information to the analyser) in a way that will be out-of-band with the"},{"line_number":46,"context_line":"operation of the controller (or at least not block it for long periods) and"},{"line_number":47,"context_line":"allow an administrator (rather than developer) easy access and debugging of"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa0c359_728b6e67","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":49},"updated":"2018-02-21 10:03:07.000000000","message":"I don\u0027t sure that i understood this sentence. \nIs a collector that implement 1-5 already exist? if so is it part of skydive - or an OpenStack project?","commit_id":"edcd4d3f197cf6743ac54283b95a1dab62fc0efd"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"60528e8fbd86c11c5717a905d97c1000ebcce659","unresolved":false,"context_lines":[{"line_number":40,"context_line":"5. Allow simulation or tracing of packets in the system on the graphical"},{"line_number":41,"context_line":"   interface."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"All of these features are supported by skydive project, but for other"},{"line_number":44,"context_line":"collectors, we should implement our own collector (or a way to send the"},{"line_number":45,"context_line":"information to the analyser) in a way that will be out-of-band with the"},{"line_number":46,"context_line":"operation of the controller (or at least not block it for long periods) and"},{"line_number":47,"context_line":"allow an administrator (rather than developer) easy access and debugging of"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_740f452e","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":49},"in_reply_to":"3fa0c359_728b6e67","updated":"2018-03-08 11:50:46.000000000","message":"This is the purpose of skydive integration, we would have to write our own collector that implements these things.\n4 and 5 require research, as they are UI.","commit_id":"edcd4d3f197cf6743ac54283b95a1dab62fc0efd"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"be4dd73f1a551a81d72206d83dc008149112f93b","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"All of these features are supported by skydive project, but for other"},{"line_number":44,"context_line":"collectors, we should implement our own collector (or a way to send the"},{"line_number":45,"context_line":"information to the analyser) in a way that will be out-of-band with the"},{"line_number":46,"context_line":"operation of the controller (or at least not block it for long periods) and"},{"line_number":47,"context_line":"allow an administrator (rather than developer) easy access and debugging of"},{"line_number":48,"context_line":"the system."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa0c359_b2da5675","line":45,"range":{"start_line":45,"start_character":29,"end_line":45,"end_character":47},"updated":"2018-02-21 10:03:07.000000000","message":"maybe separate what should be done - and how it\u0027s should be done into 2 different paragraphs","commit_id":"edcd4d3f197cf6743ac54283b95a1dab62fc0efd"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"60528e8fbd86c11c5717a905d97c1000ebcce659","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"All of these features are supported by skydive project, but for other"},{"line_number":44,"context_line":"collectors, we should implement our own collector (or a way to send the"},{"line_number":45,"context_line":"information to the analyser) in a way that will be out-of-band with the"},{"line_number":46,"context_line":"operation of the controller (or at least not block it for long periods) and"},{"line_number":47,"context_line":"allow an administrator (rather than developer) easy access and debugging of"},{"line_number":48,"context_line":"the system."}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_f403550c","line":45,"range":{"start_line":45,"start_character":29,"end_line":45,"end_character":47},"in_reply_to":"3fa0c359_b2da5675","updated":"2018-03-08 11:50:46.000000000","message":"I am not sure what you mean by separating to 2 paragraphs.","commit_id":"edcd4d3f197cf6743ac54283b95a1dab62fc0efd"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"b4063ec719f24e5db51234369cd79b6af7af99d9","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Implementation stages:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"1. Have a view of the topology of a specific network node"},{"line_number":36,"context_line":"2. Have real-time updates of the information (items added/removed)"},{"line_number":37,"context_line":"3. Allow aggregation of the information and have a global view of the topology"},{"line_number":38,"context_line":"4. Allow filtering and dissecting of the information to show just specific"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa0c359_66763ba7","line":35,"range":{"start_line":35,"start_character":45,"end_line":35,"end_character":57},"updated":"2018-02-22 07:11:32.000000000","message":"\u0027network node\u0027 is a bit of an overloaded term, as it has legacy meaning in Neutron. I guess you mean here \u0027node that runs a Dragonflow controller\u0027? I think we use \u0027chassis\u0027 for this in our documentation.","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"50c6def5282a97774a19aa737ef610ac4d5c99c2","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Implementation stages:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"1. Have a view of the topology of a specific network node"},{"line_number":36,"context_line":"2. Have real-time updates of the information (items added/removed)"},{"line_number":37,"context_line":"3. Allow aggregation of the information and have a global view of the topology"},{"line_number":38,"context_line":"4. Allow filtering and dissecting of the information to show just specific"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff6b8bd7_e3d64750","line":35,"range":{"start_line":35,"start_character":45,"end_line":35,"end_character":57},"in_reply_to":"3fa0c359_66763ba7","updated":"2018-03-06 13:14:05.000000000","message":"Will fix.","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"5ae97fe57fc683b3d595c147dafe1760f4d17bcb","unresolved":false,"context_lines":[{"line_number":57,"context_line":"the displaying of the information, with/without filtering requested by the"},{"line_number":58,"context_line":"end-user (be it a developer / integrator / operator)."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"The collectors will run on the Dragonflow nodes (network nodes) as a"},{"line_number":61,"context_line":"separate service (not within the controller) for several reasons:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"1. We do not want to affect the performance of the controller. Each update"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa0c359_33a728c0","line":60,"updated":"2018-02-21 13:11:49.000000000","message":"one collector per cn?","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"b4063ec719f24e5db51234369cd79b6af7af99d9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"the displaying of the information, with/without filtering requested by the"},{"line_number":58,"context_line":"end-user (be it a developer / integrator / operator)."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"The collectors will run on the Dragonflow nodes (network nodes) as a"},{"line_number":61,"context_line":"separate service (not within the controller) for several reasons:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"1. We do not want to affect the performance of the controller. Each update"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa0c359_c6df0f64","line":60,"in_reply_to":"3fa0c359_33a728c0","updated":"2018-02-22 07:11:32.000000000","message":"Maybe we should make this a deployment configuration, with support for High Availability?\n\nIf we\u0027re not running from inside the controller (and therefore don\u0027t have access to the db_store), running on all nodes might indeed be an overkill.","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"50c6def5282a97774a19aa737ef610ac4d5c99c2","unresolved":false,"context_lines":[{"line_number":57,"context_line":"the displaying of the information, with/without filtering requested by the"},{"line_number":58,"context_line":"end-user (be it a developer / integrator / operator)."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"The collectors will run on the Dragonflow nodes (network nodes) as a"},{"line_number":61,"context_line":"separate service (not within the controller) for several reasons:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"1. We do not want to affect the performance of the controller. Each update"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff6b8bd7_43dcd373","line":60,"in_reply_to":"3fa0c359_c6df0f64","updated":"2018-03-06 13:14:05.000000000","message":"So we will have a single collector running on each chassis, and we will add HA configuration in the future?\nI believe there are pitfalls there that we do not yet need to tackle, so it can be in a different spec.","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"03dcc4411abe0ebf5fa372f4f8749004476cb76d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"the displaying of the information, with/without filtering requested by the"},{"line_number":58,"context_line":"end-user (be it a developer / integrator / operator)."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"The collectors will run on the Dragonflow nodes (network nodes) as a"},{"line_number":61,"context_line":"separate service (not within the controller) for several reasons:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"1. We do not want to affect the performance of the controller. Each update"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff6b8bd7_fe2020fa","line":60,"in_reply_to":"ff6b8bd7_43dcd373","updated":"2018-03-06 14:11:39.000000000","message":"Sure. This spec can also be updated in the future.","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"5ae97fe57fc683b3d595c147dafe1760f4d17bcb","unresolved":false,"context_lines":[{"line_number":63,"context_line":"1. We do not want to affect the performance of the controller. Each update"},{"line_number":64,"context_line":"   sent to the analyzer may take up to a few seconds, in which time the"},{"line_number":65,"context_line":"   controller will not be able to service other requests."},{"line_number":66,"context_line":"2. The code running in the controller must be monkey_patched. This creates"},{"line_number":67,"context_line":"   different limitations on our code."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Integration should be done in several stages:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa0c359_734290ad","line":66,"updated":"2018-02-21 13:11:49.000000000","message":"That is the problem with monkey_patch in your env?","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"50c6def5282a97774a19aa737ef610ac4d5c99c2","unresolved":false,"context_lines":[{"line_number":63,"context_line":"1. We do not want to affect the performance of the controller. Each update"},{"line_number":64,"context_line":"   sent to the analyzer may take up to a few seconds, in which time the"},{"line_number":65,"context_line":"   controller will not be able to service other requests."},{"line_number":66,"context_line":"2. The code running in the controller must be monkey_patched. This creates"},{"line_number":67,"context_line":"   different limitations on our code."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Integration should be done in several stages:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff6b8bd7_238e7f78","line":66,"in_reply_to":"3fa0c359_066737eb","updated":"2018-03-06 13:14:05.000000000","message":"As the controller is using oslo library that requires monkey_patching, it has the same requirement.\nAlso, as Omer noted, the etcd pubsub driver requires it, so it is a bit of a problem.","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"b4063ec719f24e5db51234369cd79b6af7af99d9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"1. We do not want to affect the performance of the controller. Each update"},{"line_number":64,"context_line":"   sent to the analyzer may take up to a few seconds, in which time the"},{"line_number":65,"context_line":"   controller will not be able to service other requests."},{"line_number":66,"context_line":"2. The code running in the controller must be monkey_patched. This creates"},{"line_number":67,"context_line":"   different limitations on our code."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Integration should be done in several stages:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa0c359_066737eb","line":66,"in_reply_to":"3fa0c359_734290ad","updated":"2018-02-22 07:11:32.000000000","message":"Also noting here that our etcd driver *requires* monkey patching.","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"5ae97fe57fc683b3d595c147dafe1760f4d17bcb","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Open issues / feature discussion:"},{"line_number":85,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- How do we get the topology change notifications? As we are an external"},{"line_number":88,"context_line":"  application we disable the pubsub feature, so we should have a different"},{"line_number":89,"context_line":"  way of getting these notifications."},{"line_number":90,"context_line":"- Consider whether our code should create the views filters or leave it up"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa0c359_d331245b","line":87,"updated":"2018-02-21 13:11:49.000000000","message":"Why not using the subscriber, and subscribe to events?","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"50c6def5282a97774a19aa737ef610ac4d5c99c2","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Open issues / feature discussion:"},{"line_number":85,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- How do we get the topology change notifications? As we are an external"},{"line_number":88,"context_line":"  application we disable the pubsub feature, so we should have a different"},{"line_number":89,"context_line":"  way of getting these notifications."},{"line_number":90,"context_line":"- Consider whether our code should create the views filters or leave it up"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff6b8bd7_633d57ba","line":87,"in_reply_to":"3fa0c359_06ac17eb","updated":"2018-03-06 13:14:05.000000000","message":"Well, this will require rewriting the subscriber for the etcd, as the one we have requires monkey_patching","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"b4063ec719f24e5db51234369cd79b6af7af99d9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Open issues / feature discussion:"},{"line_number":85,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- How do we get the topology change notifications? As we are an external"},{"line_number":88,"context_line":"  application we disable the pubsub feature, so we should have a different"},{"line_number":89,"context_line":"  way of getting these notifications."},{"line_number":90,"context_line":"- Consider whether our code should create the views filters or leave it up"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa0c359_06ac17eb","line":87,"in_reply_to":"3fa0c359_d331245b","updated":"2018-02-22 07:11:32.000000000","message":"+1","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"b4063ec719f24e5db51234369cd79b6af7af99d9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  application we disable the pubsub feature, so we should have a different"},{"line_number":89,"context_line":"  way of getting these notifications."},{"line_number":90,"context_line":"- Consider whether our code should create the views filters or leave it up"},{"line_number":91,"context_line":"  to the user/operator."},{"line_number":92,"context_line":"- Do we want to support the option to emulate a passing of a packet through"},{"line_number":93,"context_line":"  the system? Is it supported by SkyDive?"},{"line_number":94,"context_line":"- Do we want to support visualization of tracing of packets in our system?"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa0c359_86890776","line":91,"updated":"2018-02-22 07:11:32.000000000","message":"Yes we should. Built-in defaults are usually good. And a newbie operator might not know what they need to see.","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"50c6def5282a97774a19aa737ef610ac4d5c99c2","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  application we disable the pubsub feature, so we should have a different"},{"line_number":89,"context_line":"  way of getting these notifications."},{"line_number":90,"context_line":"- Consider whether our code should create the views filters or leave it up"},{"line_number":91,"context_line":"  to the user/operator."},{"line_number":92,"context_line":"- Do we want to support the option to emulate a passing of a packet through"},{"line_number":93,"context_line":"  the system? Is it supported by SkyDive?"},{"line_number":94,"context_line":"- Do we want to support visualization of tracing of packets in our system?"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff6b8bd7_e37ac786","line":91,"in_reply_to":"3fa0c359_86890776","updated":"2018-03-06 13:14:05.000000000","message":"I agree, but in any case this will be a long-term thing, as it is not part of the integration per-se","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"5ae97fe57fc683b3d595c147dafe1760f4d17bcb","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  way of getting these notifications."},{"line_number":90,"context_line":"- Consider whether our code should create the views filters or leave it up"},{"line_number":91,"context_line":"  to the user/operator."},{"line_number":92,"context_line":"- Do we want to support the option to emulate a passing of a packet through"},{"line_number":93,"context_line":"  the system? Is it supported by SkyDive?"},{"line_number":94,"context_line":"- Do we want to support visualization of tracing of packets in our system?"},{"line_number":95,"context_line":"  What is required on our side to visualize it on SkyDive?"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa0c359_f336a051","line":92,"updated":"2018-02-21 13:11:49.000000000","message":"If that\u0027s possible, I think it will be a nice addition","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"50c6def5282a97774a19aa737ef610ac4d5c99c2","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  way of getting these notifications."},{"line_number":90,"context_line":"- Consider whether our code should create the views filters or leave it up"},{"line_number":91,"context_line":"  to the user/operator."},{"line_number":92,"context_line":"- Do we want to support the option to emulate a passing of a packet through"},{"line_number":93,"context_line":"  the system? Is it supported by SkyDive?"},{"line_number":94,"context_line":"- Do we want to support visualization of tracing of packets in our system?"},{"line_number":95,"context_line":"  What is required on our side to visualize it on SkyDive?"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff6b8bd7_c39a23c4","line":92,"in_reply_to":"3fa0c359_a68d237d","updated":"2018-03-06 13:14:05.000000000","message":"We would have to understand if Skydive supports it, and if so, what are the requirements","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"b4063ec719f24e5db51234369cd79b6af7af99d9","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  way of getting these notifications."},{"line_number":90,"context_line":"- Consider whether our code should create the views filters or leave it up"},{"line_number":91,"context_line":"  to the user/operator."},{"line_number":92,"context_line":"- Do we want to support the option to emulate a passing of a packet through"},{"line_number":93,"context_line":"  the system? Is it supported by SkyDive?"},{"line_number":94,"context_line":"- Do we want to support visualization of tracing of packets in our system?"},{"line_number":95,"context_line":"  What is required on our side to visualize it on SkyDive?"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa0c359_a68d237d","line":92,"in_reply_to":"3fa0c359_f336a051","updated":"2018-02-22 07:11:32.000000000","message":"Yes we do!","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"5ae97fe57fc683b3d595c147dafe1760f4d17bcb","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  to the user/operator."},{"line_number":92,"context_line":"- Do we want to support the option to emulate a passing of a packet through"},{"line_number":93,"context_line":"  the system? Is it supported by SkyDive?"},{"line_number":94,"context_line":"- Do we want to support visualization of tracing of packets in our system?"},{"line_number":95,"context_line":"  What is required on our side to visualize it on SkyDive?"},{"line_number":96,"context_line":"- As we would like to get the LogicalPort owner as well (e.g. associate"},{"line_number":97,"context_line":"  between a router and its port on the public network), we would have to add"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa0c359_534514b3","line":94,"updated":"2018-02-21 13:11:49.000000000","message":"+1 if possible","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"50c6def5282a97774a19aa737ef610ac4d5c99c2","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  to the user/operator."},{"line_number":92,"context_line":"- Do we want to support the option to emulate a passing of a packet through"},{"line_number":93,"context_line":"  the system? Is it supported by SkyDive?"},{"line_number":94,"context_line":"- Do we want to support visualization of tracing of packets in our system?"},{"line_number":95,"context_line":"  What is required on our side to visualize it on SkyDive?"},{"line_number":96,"context_line":"- As we would like to get the LogicalPort owner as well (e.g. associate"},{"line_number":97,"context_line":"  between a router and its port on the public network), we would have to add"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff6b8bd7_03b81b28","line":94,"in_reply_to":"3fa0c359_534514b3","updated":"2018-03-06 13:14:05.000000000","message":"Again, if possible and need to understand the requirements.\nAlso, we would have to define how we define the packet to be traced :-\\","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"5ae97fe57fc683b3d595c147dafe1760f4d17bcb","unresolved":false,"context_lines":[{"line_number":93,"context_line":"  the system? Is it supported by SkyDive?"},{"line_number":94,"context_line":"- Do we want to support visualization of tracing of packets in our system?"},{"line_number":95,"context_line":"  What is required on our side to visualize it on SkyDive?"},{"line_number":96,"context_line":"- As we would like to get the LogicalPort owner as well (e.g. associate"},{"line_number":97,"context_line":"  between a router and its port on the public network), we would have to add"},{"line_number":98,"context_line":"  some kind of proxy object to be able to access it on the nb_db."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa0c359_b33c982f","line":96,"updated":"2018-02-21 13:11:49.000000000","message":"It will be nice as well, but not mandatory","commit_id":"a1b08985c85871e73a254ce5863465a4b575a1ae"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"062aa0c48d821b7f2e960cba50a6ecf2261b82be","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"1. Create a basic service that runs every given period and sends an update"},{"line_number":75,"context_line":"   of the elements in the system to the analyzer."},{"line_number":76,"context_line":"2. Support removal of objects."},{"line_number":77,"context_line":"3. Handle cases of disconnect/reauthentication to the analyzer"},{"line_number":78,"context_line":"4. Handle cases of disconnect/reconnect to the nb_db"},{"line_number":79,"context_line":"5. Add a mechanism in which the skydive_service will get notification of"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_47a4ed08","line":76,"range":{"start_line":76,"start_character":2,"end_line":76,"end_character":30},"updated":"2018-03-08 09:54:49.000000000","message":"objects to monitor or objects in the topology?","commit_id":"b77c23dbac988231deb48ffec6b939480650e512"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"60528e8fbd86c11c5717a905d97c1000ebcce659","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"1. Create a basic service that runs every given period and sends an update"},{"line_number":75,"context_line":"   of the elements in the system to the analyzer."},{"line_number":76,"context_line":"2. Support removal of objects."},{"line_number":77,"context_line":"3. Handle cases of disconnect/reauthentication to the analyzer"},{"line_number":78,"context_line":"4. Handle cases of disconnect/reconnect to the nb_db"},{"line_number":79,"context_line":"5. Add a mechanism in which the skydive_service will get notification of"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_e105d57b","line":76,"range":{"start_line":76,"start_character":2,"end_line":76,"end_character":30},"in_reply_to":"df7087c5_47a4ed08","updated":"2018-03-08 11:50:46.000000000","message":"From the topology view - will update","commit_id":"b77c23dbac988231deb48ffec6b939480650e512"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"062aa0c48d821b7f2e960cba50a6ecf2261b82be","unresolved":false,"context_lines":[{"line_number":82,"context_line":"6. Specify an API for DragonFlow applications to add custom information to"},{"line_number":83,"context_line":"   the topology view (e.g. port-behind-port) and relevant metadata to be"},{"line_number":84,"context_line":"   used in the view filtering."},{"line_number":85,"context_line":"7. Better the visualization (custom icons, etc.)"},{"line_number":86,"context_line":"8. Add some SkyDive views / filters."},{"line_number":87,"context_line":"9. As we would like to get the LogicalPort owner as well (e.g. associate"},{"line_number":88,"context_line":"   between a router and its port on the public network), we would have to add"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_e750a1d7","line":85,"range":{"start_line":85,"start_character":2,"end_line":85,"end_character":9},"updated":"2018-03-08 09:54:49.000000000","message":"Improve?","commit_id":"b77c23dbac988231deb48ffec6b939480650e512"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"60528e8fbd86c11c5717a905d97c1000ebcce659","unresolved":false,"context_lines":[{"line_number":82,"context_line":"6. Specify an API for DragonFlow applications to add custom information to"},{"line_number":83,"context_line":"   the topology view (e.g. port-behind-port) and relevant metadata to be"},{"line_number":84,"context_line":"   used in the view filtering."},{"line_number":85,"context_line":"7. Better the visualization (custom icons, etc.)"},{"line_number":86,"context_line":"8. Add some SkyDive views / filters."},{"line_number":87,"context_line":"9. As we would like to get the LogicalPort owner as well (e.g. associate"},{"line_number":88,"context_line":"   between a router and its port on the public network), we would have to add"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_010b298e","line":85,"range":{"start_line":85,"start_character":2,"end_line":85,"end_character":9},"in_reply_to":"df7087c5_e750a1d7","updated":"2018-03-08 11:50:46.000000000","message":"ok","commit_id":"b77c23dbac988231deb48ffec6b939480650e512"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"03dcc4411abe0ebf5fa372f4f8749004476cb76d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  application we disable the pubsub feature, so we should have a different"},{"line_number":96,"context_line":"  way of getting these notifications."},{"line_number":97,"context_line":"  One solution may be using the pubsub mechanism, but it will require"},{"line_number":98,"context_line":"  rewriting (at least) the etcd subscriber driver."},{"line_number":99,"context_line":"- What views / filters do we want to supply - need to investigate how to"},{"line_number":100,"context_line":"  define them."},{"line_number":101,"context_line":"- If possible, we would like to support the option to emulate a passing"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff6b8bd7_decbdc1b","line":98,"range":{"start_line":98,"start_character":2,"end_line":98,"end_character":49},"updated":"2018-03-06 14:11:39.000000000","message":"nit: The wording is a bit confusing. I assume you mean rewriting the etcd pub/sub driver to support both monkey_patched and non-monkey_patched executions? Otherwise we will have two versions of the driver, and I oppose that.","commit_id":"b77c23dbac988231deb48ffec6b939480650e512"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"6143e4c7f5e8effa73a651d88d2c33bc475b3479","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  application we disable the pubsub feature, so we should have a different"},{"line_number":96,"context_line":"  way of getting these notifications."},{"line_number":97,"context_line":"  One solution may be using the pubsub mechanism, but it will require"},{"line_number":98,"context_line":"  rewriting (at least) the etcd subscriber driver."},{"line_number":99,"context_line":"- What views / filters do we want to supply - need to investigate how to"},{"line_number":100,"context_line":"  define them."},{"line_number":101,"context_line":"- If possible, we would like to support the option to emulate a passing"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_44593458","line":98,"range":{"start_line":98,"start_character":2,"end_line":98,"end_character":49},"in_reply_to":"df7087c5_89da05e7","updated":"2018-03-08 09:07:25.000000000","message":"Still, having two versions of the same driver (one for eventlet and one for native) is a Bad Idea (TM).","commit_id":"b77c23dbac988231deb48ffec6b939480650e512"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"676f426d0a4ea4630d0563e404e478e9986e438d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  application we disable the pubsub feature, so we should have a different"},{"line_number":96,"context_line":"  way of getting these notifications."},{"line_number":97,"context_line":"  One solution may be using the pubsub mechanism, but it will require"},{"line_number":98,"context_line":"  rewriting (at least) the etcd subscriber driver."},{"line_number":99,"context_line":"- What views / filters do we want to supply - need to investigate how to"},{"line_number":100,"context_line":"  define them."},{"line_number":101,"context_line":"- If possible, we would like to support the option to emulate a passing"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_89da05e7","line":98,"range":{"start_line":98,"start_character":2,"end_line":98,"end_character":49},"in_reply_to":"ff6b8bd7_decbdc1b","updated":"2018-03-08 08:00:30.000000000","message":"It is the only the subscriber part of the pub/sub, but I will change","commit_id":"b77c23dbac988231deb48ffec6b939480650e512"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"03dcc4411abe0ebf5fa372f4f8749004476cb76d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  One solution may be using the pubsub mechanism, but it will require"},{"line_number":98,"context_line":"  rewriting (at least) the etcd subscriber driver."},{"line_number":99,"context_line":"- What views / filters do we want to supply - need to investigate how to"},{"line_number":100,"context_line":"  define them."},{"line_number":101,"context_line":"- If possible, we would like to support the option to emulate a passing"},{"line_number":102,"context_line":"  of a packet through the system. Is it supported by SkyDive? if so, how?"},{"line_number":103,"context_line":"- If possible, we would like to support visualization of tracing of packets"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff6b8bd7_fee340a3","line":100,"updated":"2018-03-06 14:11:39.000000000","message":"Sounds like a future design, as long as the correct placeholders are in place.","commit_id":"b77c23dbac988231deb48ffec6b939480650e512"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"6143e4c7f5e8effa73a651d88d2c33bc475b3479","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  One solution may be using the pubsub mechanism, but it will require"},{"line_number":98,"context_line":"  rewriting (at least) the etcd subscriber driver."},{"line_number":99,"context_line":"- What views / filters do we want to supply - need to investigate how to"},{"line_number":100,"context_line":"  define them."},{"line_number":101,"context_line":"- If possible, we would like to support the option to emulate a passing"},{"line_number":102,"context_line":"  of a packet through the system. Is it supported by SkyDive? if so, how?"},{"line_number":103,"context_line":"- If possible, we would like to support visualization of tracing of packets"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_c43a24e6","line":100,"in_reply_to":"df7087c5_69e1b19a","updated":"2018-03-08 09:07:25.000000000","message":"Sounds good.","commit_id":"b77c23dbac988231deb48ffec6b939480650e512"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"676f426d0a4ea4630d0563e404e478e9986e438d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  One solution may be using the pubsub mechanism, but it will require"},{"line_number":98,"context_line":"  rewriting (at least) the etcd subscriber driver."},{"line_number":99,"context_line":"- What views / filters do we want to supply - need to investigate how to"},{"line_number":100,"context_line":"  define them."},{"line_number":101,"context_line":"- If possible, we would like to support the option to emulate a passing"},{"line_number":102,"context_line":"  of a packet through the system. Is it supported by SkyDive? if so, how?"},{"line_number":103,"context_line":"- If possible, we would like to support visualization of tracing of packets"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_69e1b19a","line":100,"in_reply_to":"ff6b8bd7_fee340a3","updated":"2018-03-08 08:00:30.000000000","message":"This can be the placeholder","commit_id":"b77c23dbac988231deb48ffec6b939480650e512"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"4ad2b699d87b0e4350fb7bcb4f7950fb2300ab4e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"https://bugs.launchpad.net/dragonflow/+bug/1749429"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Currently we do not have an easy way to visualize the way Dragonflow sees the"},{"line_number":16,"context_line":"topology and the relations between objects. This view is important both for"},{"line_number":17,"context_line":"operators using the project, and for developers trying to debug the system."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"To solve this, we would like to leverage one of the SkyDive [1]_ project"}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_0a282384","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":42},"updated":"2018-03-08 13:27:04.000000000","message":"topology elements","commit_id":"c460a805a78bda8c964a2a7475d26f2582157530"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"1118b873dbb1ddab5a57f050678a9575bbe4ade0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"https://bugs.launchpad.net/dragonflow/+bug/1749429"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Currently we do not have an easy way to visualize the way Dragonflow sees the"},{"line_number":16,"context_line":"topology and the relations between objects. This view is important both for"},{"line_number":17,"context_line":"operators using the project, and for developers trying to debug the system."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"To solve this, we would like to leverage one of the SkyDive [1]_ project"}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_7d6054a6","line":16,"range":{"start_line":16,"start_character":35,"end_line":16,"end_character":42},"in_reply_to":"df7087c5_0a282384","updated":"2018-03-11 08:42:28.000000000","message":"Done","commit_id":"c460a805a78bda8c964a2a7475d26f2582157530"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"4ad2b699d87b0e4350fb7bcb4f7950fb2300ab4e","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Currently we do not have an easy way to visualize the way Dragonflow sees the"},{"line_number":16,"context_line":"topology and the relations between objects. This view is important both for"},{"line_number":17,"context_line":"operators using the project, and for developers trying to debug the system."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"To solve this, we would like to leverage one of the SkyDive [1]_ project"},{"line_number":20,"context_line":"capabilities - being a good topologies visualization tool. This will allow"}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_ca21cba1","line":17,"range":{"start_line":17,"start_character":16,"end_line":17,"end_character":27},"updated":"2018-03-08 13:27:04.000000000","message":"Dragonflow","commit_id":"c460a805a78bda8c964a2a7475d26f2582157530"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"1118b873dbb1ddab5a57f050678a9575bbe4ade0","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Currently we do not have an easy way to visualize the way Dragonflow sees the"},{"line_number":16,"context_line":"topology and the relations between objects. This view is important both for"},{"line_number":17,"context_line":"operators using the project, and for developers trying to debug the system."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"To solve this, we would like to leverage one of the SkyDive [1]_ project"},{"line_number":20,"context_line":"capabilities - being a good topologies visualization tool. This will allow"}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_9d63e8b1","line":17,"range":{"start_line":17,"start_character":16,"end_line":17,"end_character":27},"in_reply_to":"df7087c5_ca21cba1","updated":"2018-03-11 08:42:28.000000000","message":"Done","commit_id":"c460a805a78bda8c964a2a7475d26f2582157530"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"4ad2b699d87b0e4350fb7bcb4f7950fb2300ab4e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"operators using the project, and for developers trying to debug the system."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"To solve this, we would like to leverage one of the SkyDive [1]_ project"},{"line_number":20,"context_line":"capabilities - being a good topologies visualization tool. This will allow"},{"line_number":21,"context_line":"us to concentrate on the building of the overall topology view (skydive"},{"line_number":22,"context_line":"model) and use the skydive for all the different ways to visualize and dissect"},{"line_number":23,"context_line":"the information (skydive view)."}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_8af8b3c4","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":38},"updated":"2018-03-08 13:27:04.000000000","message":"network topology","commit_id":"c460a805a78bda8c964a2a7475d26f2582157530"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"1118b873dbb1ddab5a57f050678a9575bbe4ade0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"operators using the project, and for developers trying to debug the system."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"To solve this, we would like to leverage one of the SkyDive [1]_ project"},{"line_number":20,"context_line":"capabilities - being a good topologies visualization tool. This will allow"},{"line_number":21,"context_line":"us to concentrate on the building of the overall topology view (skydive"},{"line_number":22,"context_line":"model) and use the skydive for all the different ways to visualize and dissect"},{"line_number":23,"context_line":"the information (skydive view)."}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_3d5adcf2","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":38},"in_reply_to":"df7087c5_8af8b3c4","updated":"2018-03-11 08:42:28.000000000","message":"Done","commit_id":"c460a805a78bda8c964a2a7475d26f2582157530"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"4ad2b699d87b0e4350fb7bcb4f7950fb2300ab4e","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"To solve this, we would like to leverage one of the SkyDive [1]_ project"},{"line_number":20,"context_line":"capabilities - being a good topologies visualization tool. This will allow"},{"line_number":21,"context_line":"us to concentrate on the building of the overall topology view (skydive"},{"line_number":22,"context_line":"model) and use the skydive for all the different ways to visualize and dissect"},{"line_number":23,"context_line":"the information (skydive view)."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_ca278b64","line":21,"range":{"start_line":21,"start_character":3,"end_line":21,"end_character":40},"updated":"2018-03-08 13:27:04.000000000","message":"to provide","commit_id":"c460a805a78bda8c964a2a7475d26f2582157530"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"1118b873dbb1ddab5a57f050678a9575bbe4ade0","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"To solve this, we would like to leverage one of the SkyDive [1]_ project"},{"line_number":20,"context_line":"capabilities - being a good topologies visualization tool. This will allow"},{"line_number":21,"context_line":"us to concentrate on the building of the overall topology view (skydive"},{"line_number":22,"context_line":"model) and use the skydive for all the different ways to visualize and dissect"},{"line_number":23,"context_line":"the information (skydive view)."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_5d5d50e7","line":21,"range":{"start_line":21,"start_character":3,"end_line":21,"end_character":40},"in_reply_to":"df7087c5_ca278b64","updated":"2018-03-11 08:42:28.000000000","message":"Done","commit_id":"c460a805a78bda8c964a2a7475d26f2582157530"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"4ad2b699d87b0e4350fb7bcb4f7950fb2300ab4e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Add the ability to view the topology as known by DragonFlow in a graphical way."},{"line_number":30,"context_line":"This feature is needed to allow easier debugging of issues in flows and"},{"line_number":31,"context_line":"understanding the behaviour of DragonFlow."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Implementation stages:"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_d7ef3385","line":31,"range":{"start_line":30,"start_character":69,"end_line":31,"end_character":41},"updated":"2018-03-08 13:27:04.000000000","message":"not sure it can lid a light on the Dragonflow behavior, it can provide a view that Dragonflow controller has on the network topology","commit_id":"c460a805a78bda8c964a2a7475d26f2582157530"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"1118b873dbb1ddab5a57f050678a9575bbe4ade0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Add the ability to view the topology as known by DragonFlow in a graphical way."},{"line_number":30,"context_line":"This feature is needed to allow easier debugging of issues in flows and"},{"line_number":31,"context_line":"understanding the behaviour of DragonFlow."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Implementation stages:"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_6d21b44d","line":31,"range":{"start_line":30,"start_character":69,"end_line":31,"end_character":41},"in_reply_to":"df7087c5_d7ef3385","updated":"2018-03-11 08:42:28.000000000","message":"If we can show what happens to a packet when it traverses through the system, it can show the behaviour of Dragonflow","commit_id":"c460a805a78bda8c964a2a7475d26f2582157530"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"4ad2b699d87b0e4350fb7bcb4f7950fb2300ab4e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"This feature is needed to allow easier debugging of issues in flows and"},{"line_number":31,"context_line":"understanding the behaviour of DragonFlow."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Implementation stages:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"1. Have a view of the topology of a specific chassis (Node running"},{"line_number":36,"context_line":"   Dragonflow controller)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_57032343","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":22},"updated":"2018-03-08 13:27:04.000000000","message":"These are different use cases, better to rename","commit_id":"c460a805a78bda8c964a2a7475d26f2582157530"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"1118b873dbb1ddab5a57f050678a9575bbe4ade0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"This feature is needed to allow easier debugging of issues in flows and"},{"line_number":31,"context_line":"understanding the behaviour of DragonFlow."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Implementation stages:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"1. Have a view of the topology of a specific chassis (Node running"},{"line_number":36,"context_line":"   Dragonflow controller)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_8d91a855","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":22},"in_reply_to":"df7087c5_57032343","updated":"2018-03-11 08:42:28.000000000","message":"Not sure I understand","commit_id":"c460a805a78bda8c964a2a7475d26f2582157530"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"4ad2b699d87b0e4350fb7bcb4f7950fb2300ab4e","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"1. Have a view of the topology of a specific chassis (Node running"},{"line_number":36,"context_line":"   Dragonflow controller)"},{"line_number":37,"context_line":"2. Have real-time updates of the information (items added/removed)"},{"line_number":38,"context_line":"3. Allow aggregation of the information and have a global view of the topology"},{"line_number":39,"context_line":"4. Allow filtering and dissecting of the information to show just specific"},{"line_number":40,"context_line":"   parts."}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_37fa2f42","line":37,"range":{"start_line":37,"start_character":46,"end_line":37,"end_character":51},"updated":"2018-03-08 13:27:04.000000000","message":"topology element","commit_id":"c460a805a78bda8c964a2a7475d26f2582157530"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"1118b873dbb1ddab5a57f050678a9575bbe4ade0","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"1. Have a view of the topology of a specific chassis (Node running"},{"line_number":36,"context_line":"   Dragonflow controller)"},{"line_number":37,"context_line":"2. Have real-time updates of the information (items added/removed)"},{"line_number":38,"context_line":"3. Allow aggregation of the information and have a global view of the topology"},{"line_number":39,"context_line":"4. Allow filtering and dissecting of the information to show just specific"},{"line_number":40,"context_line":"   parts."}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_fd73047f","line":37,"range":{"start_line":37,"start_character":46,"end_line":37,"end_character":51},"in_reply_to":"df7087c5_37fa2f42","updated":"2018-03-11 08:42:28.000000000","message":"Done","commit_id":"c460a805a78bda8c964a2a7475d26f2582157530"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"4ad2b699d87b0e4350fb7bcb4f7950fb2300ab4e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"1. Have a view of the topology of a specific chassis (Node running"},{"line_number":36,"context_line":"   Dragonflow controller)"},{"line_number":37,"context_line":"2. Have real-time updates of the information (items added/removed)"},{"line_number":38,"context_line":"3. Allow aggregation of the information and have a global view of the topology"},{"line_number":39,"context_line":"4. Allow filtering and dissecting of the information to show just specific"},{"line_number":40,"context_line":"   parts."},{"line_number":41,"context_line":"5. Allow simulation or tracing of packets in the system on the graphical"}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_17928bf7","line":38,"range":{"start_line":38,"start_character":51,"end_line":38,"end_character":78},"updated":"2018-03-08 13:27:04.000000000","message":"worth to explain what you mean by global topology","commit_id":"c460a805a78bda8c964a2a7475d26f2582157530"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"1118b873dbb1ddab5a57f050678a9575bbe4ade0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"1. Have a view of the topology of a specific chassis (Node running"},{"line_number":36,"context_line":"   Dragonflow controller)"},{"line_number":37,"context_line":"2. Have real-time updates of the information (items added/removed)"},{"line_number":38,"context_line":"3. Allow aggregation of the information and have a global view of the topology"},{"line_number":39,"context_line":"4. Allow filtering and dissecting of the information to show just specific"},{"line_number":40,"context_line":"   parts."},{"line_number":41,"context_line":"5. Allow simulation or tracing of packets in the system on the graphical"}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_1d6fd892","line":38,"range":{"start_line":38,"start_character":51,"end_line":38,"end_character":78},"in_reply_to":"df7087c5_17928bf7","updated":"2018-03-11 08:42:28.000000000","message":"Done","commit_id":"c460a805a78bda8c964a2a7475d26f2582157530"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"4ad2b699d87b0e4350fb7bcb4f7950fb2300ab4e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"5. Allow simulation or tracing of packets in the system on the graphical"},{"line_number":42,"context_line":"   interface."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"All of these features are supported by skydive project, but for other"},{"line_number":45,"context_line":"collectors, we should implement our own collector (or a way to send the"},{"line_number":46,"context_line":"information to the analyser) in a way that will be out-of-band with the"},{"line_number":47,"context_line":"operation of the controller (or at least not block it for long periods) and"},{"line_number":48,"context_line":"allow an administrator (rather than developer) easy access and debugging of"},{"line_number":49,"context_line":"the system."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Proposed Change"},{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_976c5b09","line":49,"range":{"start_line":44,"start_character":0,"end_line":49,"end_character":11},"updated":"2018-03-08 13:27:04.000000000","message":"Please split into several sentences","commit_id":"c460a805a78bda8c964a2a7475d26f2582157530"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"1118b873dbb1ddab5a57f050678a9575bbe4ade0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"5. Allow simulation or tracing of packets in the system on the graphical"},{"line_number":42,"context_line":"   interface."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"All of these features are supported by skydive project, but for other"},{"line_number":45,"context_line":"collectors, we should implement our own collector (or a way to send the"},{"line_number":46,"context_line":"information to the analyser) in a way that will be out-of-band with the"},{"line_number":47,"context_line":"operation of the controller (or at least not block it for long periods) and"},{"line_number":48,"context_line":"allow an administrator (rather than developer) easy access and debugging of"},{"line_number":49,"context_line":"the system."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Proposed Change"},{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"df7087c5_bd6d8c99","line":49,"range":{"start_line":44,"start_character":0,"end_line":49,"end_character":11},"in_reply_to":"df7087c5_976c5b09","updated":"2018-03-11 08:42:28.000000000","message":"Done","commit_id":"c460a805a78bda8c964a2a7475d26f2582157530"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"f3438ef94bf199da799f448898ad94b92377cad1","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Add one Skydive analyzer with one (or more) collectors."},{"line_number":55,"context_line":"The collectors are responsible to collect the topology information,"},{"line_number":56,"context_line":"translate it to the skydive model structure and send it to the analyzer."},{"line_number":57,"context_line":"The Analyzer, in turn, is responsible to aggregate the information and for"},{"line_number":58,"context_line":"the displaying of the information, with/without filtering requested by the"},{"line_number":59,"context_line":"end-user (be it a developer / integrator / operator)."}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_67d443be","line":56,"range":{"start_line":56,"start_character":20,"end_line":56,"end_character":27},"updated":"2018-03-11 06:21:01.000000000","message":"Skydive","commit_id":"17a41b2fd7292c2498a72787c102581a4ac51889"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"1118b873dbb1ddab5a57f050678a9575bbe4ade0","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Add one Skydive analyzer with one (or more) collectors."},{"line_number":55,"context_line":"The collectors are responsible to collect the topology information,"},{"line_number":56,"context_line":"translate it to the skydive model structure and send it to the analyzer."},{"line_number":57,"context_line":"The Analyzer, in turn, is responsible to aggregate the information and for"},{"line_number":58,"context_line":"the displaying of the information, with/without filtering requested by the"},{"line_number":59,"context_line":"end-user (be it a developer / integrator / operator)."}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_7d37f4b1","line":56,"range":{"start_line":56,"start_character":20,"end_line":56,"end_character":27},"in_reply_to":"df7087c5_67d443be","updated":"2018-03-11 08:42:28.000000000","message":"Done","commit_id":"17a41b2fd7292c2498a72787c102581a4ac51889"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"f3438ef94bf199da799f448898ad94b92377cad1","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"1. Create a basic service that runs every given period and sends an update"},{"line_number":75,"context_line":"   of the elements in the system to the analyzer."},{"line_number":76,"context_line":"2. Support handling removal of objects from the DB and remove them from the"},{"line_number":77,"context_line":"   topology view in SkyDive."},{"line_number":78,"context_line":"3. Handle cases of disconnect/re-authentication to the analyzer"},{"line_number":79,"context_line":"4. Handle cases of disconnect/reconnect to the nb_db"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_67ed238a","line":76,"range":{"start_line":76,"start_character":3,"end_line":76,"end_character":50},"updated":"2018-03-11 06:21:01.000000000","message":"\u0027Support topology update\u0027 sounds more clear to me","commit_id":"17a41b2fd7292c2498a72787c102581a4ac51889"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"1118b873dbb1ddab5a57f050678a9575bbe4ade0","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"1. Create a basic service that runs every given period and sends an update"},{"line_number":75,"context_line":"   of the elements in the system to the analyzer."},{"line_number":76,"context_line":"2. Support handling removal of objects from the DB and remove them from the"},{"line_number":77,"context_line":"   topology view in SkyDive."},{"line_number":78,"context_line":"3. Handle cases of disconnect/re-authentication to the analyzer"},{"line_number":79,"context_line":"4. Handle cases of disconnect/reconnect to the nb_db"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_9d3a0896","line":76,"range":{"start_line":76,"start_character":3,"end_line":76,"end_character":50},"in_reply_to":"df7087c5_67ed238a","updated":"2018-03-11 08:42:28.000000000","message":"Done","commit_id":"17a41b2fd7292c2498a72787c102581a4ac51889"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"f3438ef94bf199da799f448898ad94b92377cad1","unresolved":false,"context_lines":[{"line_number":75,"context_line":"   of the elements in the system to the analyzer."},{"line_number":76,"context_line":"2. Support handling removal of objects from the DB and remove them from the"},{"line_number":77,"context_line":"   topology view in SkyDive."},{"line_number":78,"context_line":"3. Handle cases of disconnect/re-authentication to the analyzer"},{"line_number":79,"context_line":"4. Handle cases of disconnect/reconnect to the nb_db"},{"line_number":80,"context_line":"5. Add a mechanism in which the skydive_service will get notification of"},{"line_number":81,"context_line":"   objects that were added-to/removed-from the topology to have an"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_27ff2b35","line":78,"range":{"start_line":78,"start_character":47,"end_line":78,"end_character":63},"updated":"2018-03-11 06:21:01.000000000","message":"between Controller to Analyzer","commit_id":"17a41b2fd7292c2498a72787c102581a4ac51889"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"1118b873dbb1ddab5a57f050678a9575bbe4ade0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"   of the elements in the system to the analyzer."},{"line_number":76,"context_line":"2. Support handling removal of objects from the DB and remove them from the"},{"line_number":77,"context_line":"   topology view in SkyDive."},{"line_number":78,"context_line":"3. Handle cases of disconnect/re-authentication to the analyzer"},{"line_number":79,"context_line":"4. Handle cases of disconnect/reconnect to the nb_db"},{"line_number":80,"context_line":"5. Add a mechanism in which the skydive_service will get notification of"},{"line_number":81,"context_line":"   objects that were added-to/removed-from the topology to have an"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_3d417c0c","line":78,"range":{"start_line":78,"start_character":47,"end_line":78,"end_character":63},"in_reply_to":"df7087c5_27ff2b35","updated":"2018-03-11 08:42:28.000000000","message":"Done","commit_id":"17a41b2fd7292c2498a72787c102581a4ac51889"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"f3438ef94bf199da799f448898ad94b92377cad1","unresolved":false,"context_lines":[{"line_number":76,"context_line":"2. Support handling removal of objects from the DB and remove them from the"},{"line_number":77,"context_line":"   topology view in SkyDive."},{"line_number":78,"context_line":"3. Handle cases of disconnect/re-authentication to the analyzer"},{"line_number":79,"context_line":"4. Handle cases of disconnect/reconnect to the nb_db"},{"line_number":80,"context_line":"5. Add a mechanism in which the skydive_service will get notification of"},{"line_number":81,"context_line":"   objects that were added-to/removed-from the topology to have an"},{"line_number":82,"context_line":"   experience that is closer to real-time as opposed to periodic updates."}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_c7fd0f3b","line":79,"range":{"start_line":79,"start_character":39,"end_line":79,"end_character":52},"updated":"2018-03-11 06:21:01.000000000","message":"Controller to nb_db","commit_id":"17a41b2fd7292c2498a72787c102581a4ac51889"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"1118b873dbb1ddab5a57f050678a9575bbe4ade0","unresolved":false,"context_lines":[{"line_number":76,"context_line":"2. Support handling removal of objects from the DB and remove them from the"},{"line_number":77,"context_line":"   topology view in SkyDive."},{"line_number":78,"context_line":"3. Handle cases of disconnect/re-authentication to the analyzer"},{"line_number":79,"context_line":"4. Handle cases of disconnect/reconnect to the nb_db"},{"line_number":80,"context_line":"5. Add a mechanism in which the skydive_service will get notification of"},{"line_number":81,"context_line":"   objects that were added-to/removed-from the topology to have an"},{"line_number":82,"context_line":"   experience that is closer to real-time as opposed to periodic updates."}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_5d44701b","line":79,"range":{"start_line":79,"start_character":39,"end_line":79,"end_character":52},"in_reply_to":"df7087c5_c7fd0f3b","updated":"2018-03-11 08:42:28.000000000","message":"Done","commit_id":"17a41b2fd7292c2498a72787c102581a4ac51889"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"f3438ef94bf199da799f448898ad94b92377cad1","unresolved":false,"context_lines":[{"line_number":85,"context_line":"   used in the view filtering."},{"line_number":86,"context_line":"7. Improve the visualization (custom icons, etc.)"},{"line_number":87,"context_line":"8. Add some SkyDive views / filters."},{"line_number":88,"context_line":"9. As we would like to get the LogicalPort owner as well (e.g. associate"},{"line_number":89,"context_line":"   between a router and its port on the public network), we would have to add"},{"line_number":90,"context_line":"   some kind of proxy object to be able to access it on the nb_db."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Open issues / feature discussion:"},{"line_number":93,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_67bbe371","line":90,"range":{"start_line":88,"start_character":3,"end_line":90,"end_character":66},"updated":"2018-03-11 06:21:01.000000000","message":"The intent here is not clear","commit_id":"17a41b2fd7292c2498a72787c102581a4ac51889"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"1118b873dbb1ddab5a57f050678a9575bbe4ade0","unresolved":false,"context_lines":[{"line_number":85,"context_line":"   used in the view filtering."},{"line_number":86,"context_line":"7. Improve the visualization (custom icons, etc.)"},{"line_number":87,"context_line":"8. Add some SkyDive views / filters."},{"line_number":88,"context_line":"9. As we would like to get the LogicalPort owner as well (e.g. associate"},{"line_number":89,"context_line":"   between a router and its port on the public network), we would have to add"},{"line_number":90,"context_line":"   some kind of proxy object to be able to access it on the nb_db."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Open issues / feature discussion:"},{"line_number":93,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_1d46f822","line":90,"range":{"start_line":88,"start_character":3,"end_line":90,"end_character":66},"in_reply_to":"df7087c5_67bbe371","updated":"2018-03-11 08:42:28.000000000","message":"Done","commit_id":"17a41b2fd7292c2498a72787c102581a4ac51889"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"f3438ef94bf199da799f448898ad94b92377cad1","unresolved":false,"context_lines":[{"line_number":93,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"- How do we get the topology change notifications? As we are an external"},{"line_number":96,"context_line":"  application we disable the pubsub feature, so we should have a different"},{"line_number":97,"context_line":"  way of getting these notifications."},{"line_number":98,"context_line":"  One solution may be using the pubsub mechanism, but it will require"},{"line_number":99,"context_line":"  rewriting (at least) the etcd pub/sub subscriber driver to use (e.g.)"},{"line_number":100,"context_line":"  etcd3gw or etcd3 library (for patched code or not) so we can support"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_e7a61354","line":97,"range":{"start_line":96,"start_character":65,"end_line":97,"end_character":36},"updated":"2018-03-11 06:21:01.000000000","message":"Why pubsub cannot be extended to handle this case?","commit_id":"17a41b2fd7292c2498a72787c102581a4ac51889"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"1118b873dbb1ddab5a57f050678a9575bbe4ade0","unresolved":false,"context_lines":[{"line_number":93,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"- How do we get the topology change notifications? As we are an external"},{"line_number":96,"context_line":"  application we disable the pubsub feature, so we should have a different"},{"line_number":97,"context_line":"  way of getting these notifications."},{"line_number":98,"context_line":"  One solution may be using the pubsub mechanism, but it will require"},{"line_number":99,"context_line":"  rewriting (at least) the etcd pub/sub subscriber driver to use (e.g.)"},{"line_number":100,"context_line":"  etcd3gw or etcd3 library (for patched code or not) so we can support"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_fdc5448f","line":97,"range":{"start_line":96,"start_character":65,"end_line":97,"end_character":36},"in_reply_to":"df7087c5_e7a61354","updated":"2018-03-11 08:42:28.000000000","message":"pubsub is a possible solution as described below","commit_id":"17a41b2fd7292c2498a72787c102581a4ac51889"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"f3438ef94bf199da799f448898ad94b92377cad1","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  of a packet through the system. Is it supported by SkyDive? if so, how?"},{"line_number":108,"context_line":"- If possible, we would like to support visualization of tracing of packets"},{"line_number":109,"context_line":"  in our system. Is it supported by SkyDive? if so, how?"},{"line_number":110,"context_line":"  What is required on our side to visualize it on SkyDive?"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"References"},{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_2772cbe4","line":110,"range":{"start_line":110,"start_character":2,"end_line":110,"end_character":58},"updated":"2018-03-11 06:21:01.000000000","message":"I think for the first phase, we should start from what is already supported with Neutron. More can be defined later","commit_id":"17a41b2fd7292c2498a72787c102581a4ac51889"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"1118b873dbb1ddab5a57f050678a9575bbe4ade0","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  of a packet through the system. Is it supported by SkyDive? if so, how?"},{"line_number":108,"context_line":"- If possible, we would like to support visualization of tracing of packets"},{"line_number":109,"context_line":"  in our system. Is it supported by SkyDive? if so, how?"},{"line_number":110,"context_line":"  What is required on our side to visualize it on SkyDive?"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"References"},{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"df7087c5_bdbfccf9","line":110,"range":{"start_line":110,"start_character":2,"end_line":110,"end_character":58},"in_reply_to":"df7087c5_2772cbe4","updated":"2018-03-11 08:42:28.000000000","message":"I am not aware of anything that is currently supported by Neutron...","commit_id":"17a41b2fd7292c2498a72787c102581a4ac51889"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"23e29824882bc661e78306f1d226aeafa1a18459","unresolved":false,"context_lines":[{"line_number":106,"context_line":"  etcd3gw or etcd3 library (for patched code or not) so we can support"},{"line_number":107,"context_line":"  both cases for different use-cases."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"I believe that a separate spec would have to cover these:"},{"line_number":110,"context_line":"- What views / filters do we want to supply - need to investigate how to"},{"line_number":111,"context_line":"  define them."},{"line_number":112,"context_line":"- If possible, we would like to support the option to emulate a passing"}],"source_content_type":"text/x-rst","patch_set":8,"id":"df7087c5_dc14f850","line":109,"range":{"start_line":109,"start_character":17,"end_line":109,"end_character":31},"updated":"2018-03-12 09:32:36.000000000","message":"+1. This seems to be suitable for more advanced phase","commit_id":"107b4c668679da6783935bc29a70f965e912bb52"}]}