)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"b23ca64d99b28b52a32158632bc6977b78845b22","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Omer Anson \u003comer.anson@toganetworks.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-02-27 23:39:34 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"L2: Drop broadcast packets the port sends to itself"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add flows to detect broadcast packets sent by a virtual port that will"},{"line_number":10,"context_line":"retransmit to itself."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df7087c5_73ef8087","line":7,"updated":"2018-03-07 07:09:39.000000000","message":"and multicast?","commit_id":"bada3a167f4194df0d531436cb88ea1c8e4fe967"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"661c34d7642a28b275d8a723e017028d655616ad","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Omer Anson \u003comer.anson@toganetworks.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-02-27 23:39:34 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"L2: Drop broadcast packets the port sends to itself"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add flows to detect broadcast packets sent by a virtual port that will"},{"line_number":10,"context_line":"retransmit to itself."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df7087c5_0f6035a5","line":7,"in_reply_to":"df7087c5_73ef8087","updated":"2018-03-08 09:26:26.000000000","message":"Yes","commit_id":"bada3a167f4194df0d531436cb88ea1c8e4fe967"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"d7ae3dee38cc8230c4794dd5d340dc0fe47746df","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add flows to detect broadcast (and multicast) packets sent by a virtual"},{"line_number":10,"context_line":"port that will retransmit to itself."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic3afab9378cf84953bca2e7e576ed6f39dd321bb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df7087c5_07f8357a","line":11,"updated":"2018-03-18 14:13:30.000000000","message":"missing link to bug/bp","commit_id":"646e1916e4789bdc4c3a501b5e0b16a9543f7ecf"}],"dragonflow/controller/apps/l2.py":[{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"b23ca64d99b28b52a32158632bc6977b78845b22","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from ryu.lib.mac import haddr_to_bin"},{"line_number":21,"context_line":"from ryu.lib.packet import in_proto"},{"line_number":22,"context_line":"from ryu.ofproto import ether"},{"line_number":23,"context_line":"from ryu.ofproto import ofproto_v1_0"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from dragonflow import conf as cfg"},{"line_number":26,"context_line":"from dragonflow.controller.common import arp_responder"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_d3720c12","line":23,"updated":"2018-03-07 07:09:39.000000000","message":"not in use","commit_id":"bada3a167f4194df0d531436cb88ea1c8e4fe967"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"661c34d7642a28b275d8a723e017028d655616ad","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from ryu.lib.mac import haddr_to_bin"},{"line_number":21,"context_line":"from ryu.lib.packet import in_proto"},{"line_number":22,"context_line":"from ryu.ofproto import ether"},{"line_number":23,"context_line":"from ryu.ofproto import ofproto_v1_0"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from dragonflow import conf as cfg"},{"line_number":26,"context_line":"from dragonflow.controller.common import arp_responder"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_2f65f9b5","line":23,"in_reply_to":"df7087c5_d3720c12","updated":"2018-03-08 09:26:26.000000000","message":"Will remove","commit_id":"bada3a167f4194df0d531436cb88ea1c8e4fe967"},{"author":{"_account_id":26131,"name":"Eyal Leshem","email":"eyal.leshem@toganetworks.com","username":"leyal"},"change_message_id":"b23ca64d99b28b52a32158632bc6977b78845b22","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        # Detect and drop self-destined broadcast packets"},{"line_number":342,"context_line":"        match \u003d self._get_multicast_broadcast_match(reg6\u003dport_key, reg7\u003dport_key)"},{"line_number":343,"context_line":"        self.mod_flow("},{"line_number":344,"context_line":"            table_id\u003dconst.EGRESS_TABLE,"},{"line_number":345,"context_line":"            priority\u003dconst.PRIORITY_HIGH,"},{"line_number":346,"context_line":"            match\u003dmatch)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_53603c33","line":343,"updated":"2018-03-07 07:09:39.000000000","message":"Is drop action needed here ?","commit_id":"bada3a167f4194df0d531436cb88ea1c8e4fe967"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"661c34d7642a28b275d8a723e017028d655616ad","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        # Detect and drop self-destined broadcast packets"},{"line_number":342,"context_line":"        match \u003d self._get_multicast_broadcast_match(reg6\u003dport_key, reg7\u003dport_key)"},{"line_number":343,"context_line":"        self.mod_flow("},{"line_number":344,"context_line":"            table_id\u003dconst.EGRESS_TABLE,"},{"line_number":345,"context_line":"            priority\u003dconst.PRIORITY_HIGH,"},{"line_number":346,"context_line":"            match\u003dmatch)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_8f73e580","line":343,"in_reply_to":"df7087c5_53603c33","updated":"2018-03-08 09:26:26.000000000","message":"default action is drop. So if no actions or instructions are passed, that\u0027s the action of the flow.","commit_id":"bada3a167f4194df0d531436cb88ea1c8e4fe967"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"123803145fbb728bb761af8191ec99de6a58e28f","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        # Detect and drop self-destined broadcast packets"},{"line_number":342,"context_line":"        match \u003d self._get_multicast_broadcast_match(reg6\u003dport_key, reg7\u003dport_key)"},{"line_number":343,"context_line":"        self.mod_flow("},{"line_number":344,"context_line":"            table_id\u003dconst.EGRESS_TABLE,"},{"line_number":345,"context_line":"            priority\u003dconst.PRIORITY_HIGH,"},{"line_number":346,"context_line":"            match\u003dmatch)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_fda2249a","line":343,"in_reply_to":"df7087c5_8f73e580","updated":"2018-03-11 09:14:27.000000000","message":"As this was confusing also for me, maybe add explicit drop?","commit_id":"bada3a167f4194df0d531436cb88ea1c8e4fe967"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"c969abcbcd489b43f81d8ff483769dc74f0d4a98","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        # Detect and drop self-destined broadcast packets"},{"line_number":342,"context_line":"        match \u003d self._get_multicast_broadcast_match(reg6\u003dport_key, reg7\u003dport_key)"},{"line_number":343,"context_line":"        self.mod_flow("},{"line_number":344,"context_line":"            table_id\u003dconst.EGRESS_TABLE,"},{"line_number":345,"context_line":"            priority\u003dconst.PRIORITY_HIGH,"},{"line_number":346,"context_line":"            match\u003dmatch)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_ddee40b3","line":343,"in_reply_to":"df7087c5_fda2249a","updated":"2018-03-11 09:46:42.000000000","message":"Will make the comment above more explicit.","commit_id":"bada3a167f4194df0d531436cb88ea1c8e4fe967"}]}