)]}'
{"dragonflow/tests/fullstack/test_pub_sub.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"80ac7691abe2407ebd0f2e00a336da26d19f1730","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    pass"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class PubSubTestBase(test_base.DFTestBase):"},{"line_number":38,"context_line":"    def _get_server_publisher(self, bind_address\u003d\"127.0.0.1\", port\u003d12345):"},{"line_number":39,"context_line":"        cfg.CONF.set_override(\u0027publisher_port\u0027, port, group\u003d\u0027df\u0027)"},{"line_number":40,"context_line":"        cfg.CONF.set_override(\u0027publisher_bind_address\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_e6ddab42","line":37,"updated":"2018-03-12 06:51:56.000000000","message":"Why do we need to change all the functions to private?","commit_id":"7d2ce7a5428e4743c70709555d2a573cfd2c1655"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"9ca83f15a15f96b83a8d77835f719f47996d9c62","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    pass"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class PubSubTestBase(test_base.DFTestBase):"},{"line_number":38,"context_line":"    def _get_server_publisher(self, bind_address\u003d\"127.0.0.1\", port\u003d12345):"},{"line_number":39,"context_line":"        cfg.CONF.set_override(\u0027publisher_port\u0027, port, group\u003d\u0027df\u0027)"},{"line_number":40,"context_line":"        cfg.CONF.set_override(\u0027publisher_bind_address\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_a941c43b","line":37,"in_reply_to":"df7087c5_665afb4f","updated":"2018-03-12 07:54:04.000000000","message":"Good enough.","commit_id":"7d2ce7a5428e4743c70709555d2a573cfd2c1655"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"249ed6653d2c560fd71c3dbe336fab7ddebe8739","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    pass"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class PubSubTestBase(test_base.DFTestBase):"},{"line_number":38,"context_line":"    def _get_server_publisher(self, bind_address\u003d\"127.0.0.1\", port\u003d12345):"},{"line_number":39,"context_line":"        cfg.CONF.set_override(\u0027publisher_port\u0027, port, group\u003d\u0027df\u0027)"},{"line_number":40,"context_line":"        cfg.CONF.set_override(\u0027publisher_bind_address\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_665afb4f","line":37,"in_reply_to":"df7087c5_e6ddab42","updated":"2018-03-12 07:42:10.000000000","message":"Why not? they are only being used here.\nBTW, AFAIU it is protected and not private","commit_id":"7d2ce7a5428e4743c70709555d2a573cfd2c1655"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"80ac7691abe2407ebd0f2e00a336da26d19f1730","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        publishers \u003d self.nb_api.get_all(core.Publisher)"},{"line_number":65,"context_line":"        for publisher in publishers:"},{"line_number":66,"context_line":"            subscriber.register_listen_address(publisher.uri)"},{"line_number":67,"context_line":"        subscriber.daemonize()"},{"line_number":68,"context_line":"        return subscriber"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_a6e7b312","line":67,"updated":"2018-03-12 06:51:56.000000000","message":"Since every caller does it, and this is by definition a test class, maybe just call self.addCleanup(subscriber.close) here?","commit_id":"7d2ce7a5428e4743c70709555d2a573cfd2c1655"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"9ca83f15a15f96b83a8d77835f719f47996d9c62","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        publishers \u003d self.nb_api.get_all(core.Publisher)"},{"line_number":65,"context_line":"        for publisher in publishers:"},{"line_number":66,"context_line":"            subscriber.register_listen_address(publisher.uri)"},{"line_number":67,"context_line":"        subscriber.daemonize()"},{"line_number":68,"context_line":"        return subscriber"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_c93c38c1","line":67,"in_reply_to":"df7087c5_463577f6","updated":"2018-03-12 07:54:04.000000000","message":"Good enough.","commit_id":"7d2ce7a5428e4743c70709555d2a573cfd2c1655"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"249ed6653d2c560fd71c3dbe336fab7ddebe8739","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        publishers \u003d self.nb_api.get_all(core.Publisher)"},{"line_number":65,"context_line":"        for publisher in publishers:"},{"line_number":66,"context_line":"            subscriber.register_listen_address(publisher.uri)"},{"line_number":67,"context_line":"        subscriber.daemonize()"},{"line_number":68,"context_line":"        return subscriber"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_463577f6","line":67,"in_reply_to":"df7087c5_a6e7b312","updated":"2018-03-12 07:42:10.000000000","message":"I do not like it as this is not consistent with the contract of the method","commit_id":"7d2ce7a5428e4743c70709555d2a573cfd2c1655"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"80ac7691abe2407ebd0f2e00a336da26d19f1730","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        subscriber \u003d self._get_subscriber(_db_change_callback)"},{"line_number":91,"context_line":"        self.addCleanup(subscriber.close)"},{"line_number":92,"context_line":"        network \u003d self.store(objects.NetworkTestObj(self.neutron, self.nb_api))"},{"line_number":93,"context_line":"        self.addCleanup(network.close)"},{"line_number":94,"context_line":"        network_id \u003d network.create()"},{"line_number":95,"context_line":"        if cfg.CONF.df.enable_selective_topology_distribution:"},{"line_number":96,"context_line":"            topic \u003d network.get_topic()"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_46c01751","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":38},"updated":"2018-03-12 06:51:56.000000000","message":"This is what self.store does. If you add a call to addCleanup here, the call to self.store should be removed (In fact, the whole self.store business should be removed in favour of addCleanup)","commit_id":"7d2ce7a5428e4743c70709555d2a573cfd2c1655"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"249ed6653d2c560fd71c3dbe336fab7ddebe8739","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        subscriber \u003d self._get_subscriber(_db_change_callback)"},{"line_number":91,"context_line":"        self.addCleanup(subscriber.close)"},{"line_number":92,"context_line":"        network \u003d self.store(objects.NetworkTestObj(self.neutron, self.nb_api))"},{"line_number":93,"context_line":"        self.addCleanup(network.close)"},{"line_number":94,"context_line":"        network_id \u003d network.create()"},{"line_number":95,"context_line":"        if cfg.CONF.df.enable_selective_topology_distribution:"},{"line_number":96,"context_line":"            topic \u003d network.get_topic()"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_a62573c4","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":38},"in_reply_to":"df7087c5_46c01751","updated":"2018-03-12 07:42:10.000000000","message":"Will remove","commit_id":"7d2ce7a5428e4743c70709555d2a573cfd2c1655"}]}