)]}'
{"tools/run_dragonflow.sh":[{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"9f43b7f6d8567c79e413d51d93b193ff14895afe","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      shift"},{"line_number":12,"context_line":"      DB_ADDRESS\u003d$1"},{"line_number":13,"context_line":"      ;;"},{"line_number":14,"context_line":"    --management_ip)"},{"line_number":15,"context_line":"      shift"},{"line_number":16,"context_line":"      MANAGEMENT_IP\u003d$1"},{"line_number":17,"context_line":"      ;;"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5f7c97a3_b1516710","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":19},"updated":"2018-07-12 11:28:35.000000000","message":"This breaks the convention of the file.\nWe should either use address *or* ip in the arguments we get from the user.\nPersonally I would prefer to go for updating the configuration.","commit_id":"dd76c0fc1c58124b55f5f802ac14a07b5129d007"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"78a47646c7002382bfb7bdfee741ea35d8ada450","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      shift"},{"line_number":12,"context_line":"      DB_ADDRESS\u003d$1"},{"line_number":13,"context_line":"      ;;"},{"line_number":14,"context_line":"    --management_ip)"},{"line_number":15,"context_line":"      shift"},{"line_number":16,"context_line":"      MANAGEMENT_IP\u003d$1"},{"line_number":17,"context_line":"      ;;"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5f7c97a3_270e748c","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":19},"in_reply_to":"5f7c97a3_47485061","updated":"2018-07-12 13:47:13.000000000","message":"go for it :)","commit_id":"dd76c0fc1c58124b55f5f802ac14a07b5129d007"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"ad1c72740777a1d48e83691635e89b18110aa16f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      shift"},{"line_number":12,"context_line":"      DB_ADDRESS\u003d$1"},{"line_number":13,"context_line":"      ;;"},{"line_number":14,"context_line":"    --management_ip)"},{"line_number":15,"context_line":"      shift"},{"line_number":16,"context_line":"      MANAGEMENT_IP\u003d$1"},{"line_number":17,"context_line":"      ;;"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5f7c97a3_47485061","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":19},"in_reply_to":"5f7c97a3_b1516710","updated":"2018-07-12 13:20:34.000000000","message":"Why not to update this file convention? The configuration stored in dragonflow.ini also use `local_ip`, and `management_ip` params, and so is the internal conf.","commit_id":"dd76c0fc1c58124b55f5f802ac14a07b5129d007"}]}