)]}'
{"tools/run_dragonflow.sh":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"1a078c8b7666a5b04a21f60c231fd51935fbd571","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        exit 1"},{"line_number":40,"context_line":"      fi"},{"line_number":41,"context_line":"      VERB\u003d$1"},{"line_number":42,"context_line":"      shift"},{"line_number":43,"context_line":"      ;;"},{"line_number":44,"context_line":"  esac"},{"line_number":45,"context_line":"  shift"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fce034c_49559b1c","side":"PARENT","line":42,"updated":"2019-04-17 10:41:18.000000000","message":"Why remove this?","commit_id":"bc821f0250c31bbfb3cfb9e2739e765554df7232"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"e38fd448c8bb7621fa24abe3cb75c1b8b0c51388","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        exit 1"},{"line_number":40,"context_line":"      fi"},{"line_number":41,"context_line":"      VERB\u003d$1"},{"line_number":42,"context_line":"      shift"},{"line_number":43,"context_line":"      ;;"},{"line_number":44,"context_line":"  esac"},{"line_number":45,"context_line":"  shift"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fce034c_b4a57206","side":"PARENT","line":42,"in_reply_to":"3fce034c_49559b1c","updated":"2019-04-17 10:53:05.000000000","message":"Because we have double shift in this case (also line 45)","commit_id":"bc821f0250c31bbfb3cfb9e2739e765554df7232"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"1a078c8b7666a5b04a21f60c231fd51935fbd571","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    /usr/local/bin/df-local-controller --config-file /etc/dragonflow/dragonflow.ini"},{"line_number":81,"context_line":"    ;;"},{"line_number":82,"context_line":"  \"bash\")"},{"line_number":83,"context_line":"    /bin/bash $@"},{"line_number":84,"context_line":"    ;;"},{"line_number":85,"context_line":"  \"rest\")"},{"line_number":86,"context_line":"    df-model -j -o /var/dragonflow_model.json"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fce034c_093553f7","line":83,"updated":"2019-04-17 10:41:18.000000000","message":"Maybe place in quotes: s/$@/\"$@\"/ ? This way, if something is quoted on the command line, it remains quoted when being sent to bash.","commit_id":"c3d43ddc6eb5554d08ebd86e04bfb047f4e444c9"},{"author":{"_account_id":17880,"name":"Shachar Snapiri","email":"shachar.snapiri@toganetworks.com","username":"snapiri"},"change_message_id":"e38fd448c8bb7621fa24abe3cb75c1b8b0c51388","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    /usr/local/bin/df-local-controller --config-file /etc/dragonflow/dragonflow.ini"},{"line_number":81,"context_line":"    ;;"},{"line_number":82,"context_line":"  \"bash\")"},{"line_number":83,"context_line":"    /bin/bash $@"},{"line_number":84,"context_line":"    ;;"},{"line_number":85,"context_line":"  \"rest\")"},{"line_number":86,"context_line":"    df-model -j -o /var/dragonflow_model.json"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fce034c_94aab6cf","line":83,"in_reply_to":"3fce034c_093553f7","updated":"2019-04-17 10:53:05.000000000","message":"Done","commit_id":"c3d43ddc6eb5554d08ebd86e04bfb047f4e444c9"}]}
