)]}'
{"openstack_election/utils.py":[{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"69d70e56c927b175d4a4a7b8a169df510b079edc","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    # Print the profile if verbosity is 1 or higher"},{"line_number":135,"context_line":"    if verbose \u003e\u003d 1 and result[\u0027data\u0027]:"},{"line_number":136,"context_line":"        print(\"Found: \""},{"line_number":137,"context_line":"              \"https://openstack.org/community/members/profile/%s\""},{"line_number":138,"context_line":"              % result[\u0027data\u0027][0][\u0027id\u0027])"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_65dbc07c","line":136,"updated":"2019-08-30 02:51:19.000000000","message":"I personally prefer to change from \"Found: \" to \"PASS - Found: \" for the consistency with Foundation member validation but it looks still good.","commit_id":"8a361a5f05438453bffdb7f61cb52201660172eb"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"3858401024f46038c17297f7996021ae120d26df","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    # Print the profile if verbosity is 1 or higher"},{"line_number":135,"context_line":"    if verbose \u003e\u003d 1 and result[\u0027data\u0027]:"},{"line_number":136,"context_line":"        print(\"Found: \""},{"line_number":137,"context_line":"              \"https://openstack.org/community/members/profile/%s\""},{"line_number":138,"context_line":"              % result[\u0027data\u0027][0][\u0027id\u0027])"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_4a3565f6","line":136,"updated":"2019-08-30 18:30:41.000000000","message":"done (by adding an additional line after it, for consistency with the member check)","commit_id":"8a361a5f05438453bffdb7f61cb52201660172eb"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"69d70e56c927b175d4a4a7b8a169df510b079edc","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        print(\"Found: \""},{"line_number":137,"context_line":"              \"https://openstack.org/community/members/profile/%s\""},{"line_number":138,"context_line":"              % result[\u0027data\u0027][0][\u0027id\u0027])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    return result"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_e5e7b045","line":139,"updated":"2019-08-30 02:51:19.000000000","message":"Just a minor comment: can we add like the followings?\n\nelse:\n    print(\"FAIL: Not found\")","commit_id":"8a361a5f05438453bffdb7f61cb52201660172eb"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"3858401024f46038c17297f7996021ae120d26df","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        print(\"Found: \""},{"line_number":137,"context_line":"              \"https://openstack.org/community/members/profile/%s\""},{"line_number":138,"context_line":"              % result[\u0027data\u0027][0][\u0027id\u0027])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    return result"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_ea3531f7","line":139,"updated":"2019-08-30 18:30:41.000000000","message":"done (in the calling function, added consistent with the membership check)","commit_id":"8a361a5f05438453bffdb7f61cb52201660172eb"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"cc3a5e93b53a1fb329e990e3ec21d41bbfefd242","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    GERRIT_API_URL \u003d \u0027https://review.openstack.org/\u0027"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    raw \u003d requester(GERRIT_API_URL + method, params\u003dparams,"},{"line_number":84,"context_line":"                    headers\u003d{\u0027Accept\u0027: \u0027application/json\u0027})"},{"line_number":85,"context_line":"    return decode_json(raw)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_52318f59","side":"PARENT","line":84,"updated":"2019-10-10 18:52:58.000000000","message":"Good catch, yes it should just be replaced with GERRIT_BASE. Thanks!","commit_id":"a3b4725f1b7156852eae3e1acbd61b7c54634fec"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"a05fbd8b1d8d40932d435ae1d7216b8c92dc4d0a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    \"\"\"Query the Gerrit REST API\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # The base URL to Gerrit REST API"},{"line_number":80,"context_line":"    GERRIT_API_URL \u003d \u0027https://review.openstack.org/\u0027"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    raw \u003d requester(GERRIT_API_URL + method, params\u003dparams,"},{"line_number":83,"context_line":"                    headers\u003d{\u0027Accept\u0027: \u0027application/json\u0027})"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_69b5d331","line":80,"updated":"2019-10-10 06:24:26.000000000","message":"Can this just be GERRIT_BASE?  If not it needs opendev love.","commit_id":"5b4dde175d487145719ea5d0c8a756e445ab26e4"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"a05fbd8b1d8d40932d435ae1d7216b8c92dc4d0a","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    raw \u003d requester(GERRIT_API_URL + method, params\u003dparams,"},{"line_number":83,"context_line":"                    headers\u003d{\u0027Accept\u0027: \u0027application/json\u0027})"},{"line_number":84,"context_line":"    if verbose \u003e\u003d 2:"},{"line_number":85,"context_line":"        print(\"Queried: %s\" % raw.url)"},{"line_number":86,"context_line":"    return decode_json(raw)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_898b6f66","line":85,"range":{"start_line":84,"start_character":0,"end_line":85,"end_character":38},"updated":"2019-10-10 06:24:26.000000000","message":"Does it make sense to do this in requester() ?","commit_id":"5b4dde175d487145719ea5d0c8a756e445ab26e4"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"cc3a5e93b53a1fb329e990e3ec21d41bbfefd242","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    raw \u003d requester(GERRIT_API_URL + method, params\u003dparams,"},{"line_number":83,"context_line":"                    headers\u003d{\u0027Accept\u0027: \u0027application/json\u0027})"},{"line_number":84,"context_line":"    if verbose \u003e\u003d 2:"},{"line_number":85,"context_line":"        print(\"Queried: %s\" % raw.url)"},{"line_number":86,"context_line":"    return decode_json(raw)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_f2319b5a","line":85,"updated":"2019-10-10 18:52:58.000000000","message":"It might, I\u0027ll look at what other places we call requester() from and see if that\u0027ll be a problem.","commit_id":"5b4dde175d487145719ea5d0c8a756e445ab26e4"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"cc3a5e93b53a1fb329e990e3ec21d41bbfefd242","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    return yaml.safe_load(yaml_stream)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"def get_from_git(project, obj, params\u003d{}):"},{"line_number":96,"context_line":"    \"\"\"Retrieve a file from the cgit interface\"\"\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    url \u003d \u0027https://opendev.org/\u0027 + project + \u0027/raw/\u0027 + obj"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_1237974f","line":95,"updated":"2019-10-10 18:52:58.000000000","message":"The trick is going to be making it so that branches and tags can still be used interchangeably here. Gitea uses different paths for them rather than treating them as generic reference names.","commit_id":"5b4dde175d487145719ea5d0c8a756e445ab26e4"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"a05fbd8b1d8d40932d435ae1d7216b8c92dc4d0a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    return yaml.safe_load(yaml_stream)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"def get_from_git(project, obj, params\u003d{}):"},{"line_number":96,"context_line":"    \"\"\"Retrieve a file from the cgit interface\"\"\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    url \u003d \u0027https://opendev.org/\u0027 + project + \u0027/raw/\u0027 + obj"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_e9ef831a","line":95,"updated":"2019-10-10 06:24:26.000000000","message":"nit: I think it might be nice to have branch\u003d\u0027master\u0027 and construct the full URL with it?","commit_id":"5b4dde175d487145719ea5d0c8a756e445ab26e4"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"a05fbd8b1d8d40932d435ae1d7216b8c92dc4d0a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"def get_from_git(project, obj, params\u003d{}):"},{"line_number":96,"context_line":"    \"\"\"Retrieve a file from the cgit interface\"\"\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    url \u003d \u0027https://opendev.org/\u0027 + project + \u0027/raw/\u0027 + obj"},{"line_number":99,"context_line":"    raw \u003d requester(url, params\u003dparams,"},{"line_number":100,"context_line":"                    headers\u003d{\u0027Accept\u0027: \u0027application/json\u0027})"},{"line_number":101,"context_line":"    return load_yaml(raw.text)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_29859b5a","line":98,"range":{"start_line":98,"start_character":10,"end_line":98,"end_character":32},"updated":"2019-10-10 06:24:26.000000000","message":"Can this use GIT_URL ?","commit_id":"5b4dde175d487145719ea5d0c8a756e445ab26e4"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"cc3a5e93b53a1fb329e990e3ec21d41bbfefd242","unresolved":false,"context_lines":[{"line_number":95,"context_line":"def get_from_git(project, obj, params\u003d{}):"},{"line_number":96,"context_line":"    \"\"\"Retrieve a file from the cgit interface\"\"\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    url \u003d \u0027https://opendev.org/\u0027 + project + \u0027/raw/\u0027 + obj"},{"line_number":99,"context_line":"    raw \u003d requester(url, params\u003dparams,"},{"line_number":100,"context_line":"                    headers\u003d{\u0027Accept\u0027: \u0027application/json\u0027})"},{"line_number":101,"context_line":"    return load_yaml(raw.text)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_b23fa323","line":98,"updated":"2019-10-10 18:52:58.000000000","message":"Yep, I\u0027ll update it.","commit_id":"5b4dde175d487145719ea5d0c8a756e445ab26e4"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"49cef7c2bd0e0262d9a9749e3f2b3d50bb206f82","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                        ]},"},{"line_number":125,"context_line":"                    headers\u003d{\u0027Accept\u0027: \u0027application/json\u0027},"},{"line_number":126,"context_line":"                    verbose\u003dverbose,"},{"line_number":127,"context_line":"                    ))"},{"line_number":128,"context_line":"    result \u003d decode_json(raw)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    # Print the profile if verbosity is 1 or higher"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_2e1ee45e","line":127,"updated":"2019-10-11 13:42:12.000000000","message":"Whoops, somehow I added an extra ) here and then cleaned it up in the next patch in the series.","commit_id":"21ecde9d66b6eee622eb601113de0876bc70439e"}]}
