)]}'
{"id":"openstack%2Felection~753934","triplet_id":"openstack%2Felection~master~I4d5d9b1d55379adfd1c7d7765324306abf40cdb7","project":"openstack/election","branch":"master","topic":"wallaby","hashtags":[],"change_id":"I4d5d9b1d55379adfd1c7d7765324306abf40cdb7","subject":"Don\u0027t test candidate files if they\u0027re removed","status":"MERGED","created":"2020-09-24 03:56:06.000000000","updated":"2021-01-15 20:52:18.000000000","submitted":"2021-01-15 20:46:34.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"753934-wallaby","meta_rev_id":"3e6f624c4ed6903a7822d6950eed7942817c2892","_number":753934,"virtual_id_number":753934,"owner":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},{"value":0,"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-01-15 20:46:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-09-28 13:43:37.000000000","_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"all":[{"value":2,"date":"2020-10-13 03:48:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},{"value":2,"date":"2021-01-15 20:29:31.000000000","_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"all":[{"value":0,"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},{"value":1,"date":"2021-01-15 20:36:43.000000000","_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-28 14:00:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-10-13 03:48:27.000000000","updated_by":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"reviewer":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"state":"REVIEWER"},{"updated":"2021-01-15 20:29:31.000000000","updated_by":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"reviewer":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"state":"REVIEWER"}],"messages":[{"id":"59d94f11c59b569ef96596692f34bc7641c7a761","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2020-09-24 03:56:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b8a6f39f444a161783147b969d1f1b5c1cfae3c4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-24 04:04:59.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/25ade4b853d144ad8d0005ebfb09f4cd : FAILURE in 3m 15s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/64d37d2fdadf448ab543e63358a250b7 : FAILURE in 3m 21s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/b70a94ddf8554c0c8bb9594828ed7428 : SUCCESS in 3m 06s\n- election-tox-ci-checks-review https://zuul.opendev.org/t/openstack/build/61026792fc7845ff975d73fb4c5462f2 : SUCCESS in 3m 12s\n- election-tox-ci-checks-election https://zuul.opendev.org/t/openstack/build/2136f8753b37463aa8e4d23404540b82 : FAILURE in 3m 04s","accounts_in_message":[],"_revision_number":1},{"id":"00c95f81b44455a5b77a78c644e84b772e617109","author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"date":"2020-09-24 07:42:35.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"158d48394a97065c2e9b487bc7492d8a59570f5c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-24 07:55:03.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ab857aa5180940e9a10515044060ab03 : SUCCESS in 3m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4c03e94da6504b8a944af2c674e85bda : FAILURE in 3m 52s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/8499e441df624421bd98ba8cc2d0f650 : SUCCESS in 3m 50s\n- election-tox-ci-checks-review https://zuul.opendev.org/t/openstack/build/8d11a38ad3ee4510be4ec2650c9830e2 : SUCCESS in 4m 33s\n- election-tox-ci-checks-election https://zuul.opendev.org/t/openstack/build/2fe7c72430db4db8bd23128694edb1b0 : SUCCESS in 4m 24s","accounts_in_message":[],"_revision_number":1},{"id":"fb3069a4d096eaea82233db1238717e56e1c7cac","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2020-09-24 12:40:04.000000000","message":"Patch Set 1: Workflow-1\n\nI\u0027ll take a look at the unit test failure in a bit.","accounts_in_message":[],"_revision_number":1},{"id":"cf5c3cadd31a20d685c97c71fc3698a7e3f9b5b8","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2020-09-24 16:11:59.000000000","message":"Patch Set 1:\n\ntest_find_modified_candidate_files_all_good is going to need adjusting to accommodate this behavior change.","accounts_in_message":[],"_revision_number":1},{"id":"3bb39a08c280e3d027aba80675659ff44444668a","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2020-09-24 17:03:53.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"91f4233060cd43fcb8658ddd19d0c0d6e404447a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-24 18:04:32.000000000","message":"Patch Set 2: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b8e1023319cd4456afbe0b84530b1e5c : SUCCESS in 5m 05s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e3840ebced5040acaeed2712374234bb : SUCCESS in 5m 13s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/8b80881c1c284261b94b7ba58d8242d2 : FAILURE in 4m 33s\n- election-tox-ci-checks-review https://zuul.opendev.org/t/openstack/build/bca9d4c30489408bbb312fb03c2dee1f : SUCCESS in 4m 29s\n- election-tox-ci-checks-election https://zuul.opendev.org/t/openstack/build/a2fa81a9b6db4b9fb5e9104691d9bcb3 : SUCCESS in 4m 15s","accounts_in_message":[],"_revision_number":2},{"id":"034c6ed606387e9995598180513814f5de8d8a9c","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2020-09-24 19:34:05.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"4281afebccdd77772c0b39cc9572dd22896eece9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-24 19:46:09.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e0c89dd175dd4fa599bd99d4a7c5c403 : SUCCESS in 5m 08s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e665f36e44ab4071b9c6d516015c5ac7 : SUCCESS in 3m 38s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/95b19833fccd47659d6e93a0aad1507a : SUCCESS in 3m 24s\n- election-tox-ci-checks-review https://zuul.opendev.org/t/openstack/build/29a6ab99f0e44be89290c2c3d7f275ef : SUCCESS in 3m 26s\n- election-tox-ci-checks-election https://zuul.opendev.org/t/openstack/build/81f934dd9acc4a0f88aed4946ad7ec92 : SUCCESS in 4m 44s","accounts_in_message":[],"_revision_number":3},{"id":"0b9f88102ea6e9889a6bd3d53898cc09ee8948ce","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2020-09-28 13:21:13.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"8594ecc5b5591ac1f19090f3f5b0debe2753b465","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2020-09-28 13:22:01.000000000","message":"Patch Set 4:\n\nGratuitously rebased as I need to stack a revert for a later change onto this one.","accounts_in_message":[],"_revision_number":4},{"id":"e9bfbba9aa3fc0aa51920d59111729dd9ede880e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-28 13:32:07.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b84682597f094c63a2b14ef147a10d8e : FAILURE in 4m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/028f5a93608e4651bd020047f8d0ab7a : SUCCESS in 3m 50s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/8b84a1deca28429fa133e3b184e9cfc7 : SUCCESS in 4m 12s\n- election-tox-ci-checks-review https://zuul.opendev.org/t/openstack/build/46bc2354981342509d679bf23270c460 : SUCCESS in 3m 51s\n- election-tox-ci-checks-election https://zuul.opendev.org/t/openstack/build/ed14e0a724db4ab8a9b493d6d1f16d80 : FAILURE in 4m 19s","accounts_in_message":[],"_revision_number":4},{"id":"dbeed2506ad451d405cf8e752afc2bb85b8d811e","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2020-09-28 13:43:01.000000000","message":"Patch Set 4:\n\nThe failure indicates that if we wait to merge this fix until it\u0027s actually needed, it\u0027ll need to be squashed with the revert we\u0027re trying to use it to merge. Tests passed for 754268 which is stacked on this (now abandoned) where they failed for this change itself, proving it works at least.","accounts_in_message":[],"_revision_number":4},{"id":"fca2a41c39bbf340b2232852267d98beb74957ff","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2020-09-28 13:43:37.000000000","message":"Patch Set 4:\n\nrecheck for passing job results now that the condition which we were testing this change with has been resolved","accounts_in_message":[],"_revision_number":4},{"id":"119b157f35763c10f7a244643fa4745cd7591025","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-28 14:00:41.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/15ba93e0a57f4ff99f57ae2f19d85e13 : SUCCESS in 4m 44s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3e2ec1be866e494fad77e49e107cb2e8 : SUCCESS in 4m 14s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/3a7390753c974f06a46cab2de668f15c : SUCCESS in 4m 23s\n- election-tox-ci-checks-review https://zuul.opendev.org/t/openstack/build/5bea8ae6c939423881949559c9cb5f06 : SUCCESS in 3m 08s\n- election-tox-ci-checks-election https://zuul.opendev.org/t/openstack/build/56b2f84cee0747e3917b637ae07f82c9 : SUCCESS in 4m 21s","accounts_in_message":[],"_revision_number":4},{"id":"df7028f34d89be77eb2cb4986b57b5dfc24d5bf5","author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"date":"2020-10-05 14:29:26.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"ea7ebff34e6d6ef3d7de79af01742df2c3c3ff28","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-05 14:41:20.000000000","message":"Patch Set 4:\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/92194a2459214cccb7a0a265270cc39f : SUCCESS in 4m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e336a1318afc4cd1b72773344b348f75 : SUCCESS in 3m 45s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/14cda57186514a88866f8d83837ba7f9 : SUCCESS in 3m 34s\n- election-tox-ci-checks-review https://zuul.opendev.org/t/openstack/build/3319601fe1474309a1d487a5710f3e5c : SUCCESS in 3m 04s\n- election-tox-ci-checks-election https://zuul.opendev.org/t/openstack/build/21e029a676764b7083a7d05650e4697f : SUCCESS in 4m 30s","accounts_in_message":[],"_revision_number":4},{"id":"7d471ccd73d83fe5a28a4c1889b289301d7fae0c","author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"date":"2020-10-13 03:48:27.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"aea48a594790e7347afcf6b0e324d88e1574cd5f","author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"date":"2021-01-15 20:29:31.000000000","message":"Patch Set 4: Code-Review+2\n\nLooks good to me. Thanks Fungi!","accounts_in_message":[],"_revision_number":4},{"id":"2a05bd3f2fd008e5cb0dc06e405abd4ff9e27cfd","author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"date":"2021-01-15 20:36:43.000000000","message":"Patch Set 4: Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"c6eb4a6915030e27c27b7cf577e1bd36da7b486b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-15 20:37:02.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"63ed847d09731d3faa01a95f3c1b9fe3f0133691","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-15 20:46:32.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/09bd60dc037d49ac89a7df3d5aad4f8f : SUCCESS in 4m 22s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/71ee7c840dfe4fc495227ff55dc39a8f : SUCCESS in 4m 00s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/544bbaad7f4742e3b7472fff2da7eb16 : SUCCESS in 4m 01s\n- election-tox-ci-checks-election https://zuul.opendev.org/t/openstack/build/34298425e78a44a4b864e97db26aa2c7 : SUCCESS in 3m 46s","accounts_in_message":[],"_revision_number":4},{"id":"bbca4e3976806846ba5a70d146144eb3140d6103","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-15 20:46:34.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"3e6f624c4ed6903a7822d6950eed7942817c2892","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-15 20:52:18.000000000","message":"Patch Set 4:\n\nBuild succeeded (promote pipeline).\n\n- promote-governance-election https://zuul.opendev.org/t/openstack/build/73266de75191477997deec48d49e0edd : SUCCESS in 1m 07s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"4570981c1bc0ecffe541151b4f2be4bcb52c6686","revisions":{"86d143609a73d6b899e63ce20a3bca95279a174e":{"kind":"REWORK","_number":1,"created":"2020-09-24 03:56:06.000000000","uploader":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"ref":"refs/changes/34/753934/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/election","ref":"refs/changes/34/753934/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/election refs/changes/34/753934/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/election refs/changes/34/753934/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/election refs/changes/34/753934/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/election refs/changes/34/753934/1"}}},"commit":{"parents":[{"commit":"b5750d843e052c7a3cb459843fec992679967ec2","subject":"Merge \"Adding Balazs Gibizer candidacy for Nova PTL\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/election/commit/b5750d843e052c7a3cb459843fec992679967ec2"}]}],"author":{"name":"Jeremy Stanley","email":"fungi@yuggoth.org","date":"2020-09-24 03:52:21.000000000","tz":0},"committer":{"name":"Jeremy Stanley","email":"fungi@yuggoth.org","date":"2020-09-24 03:55:47.000000000","tz":0},"subject":"Don\u0027t test candidate files if they\u0027re removed","message":"Don\u0027t test candidate files if they\u0027re removed\n\nThe routine to determine which files to check for candidacies, when\nused to analyze files being changed with --HEAD, should only test\nthose files if they are being kept by the change. If they\u0027re being\ndeleted, then there is no reason to test them. Further, testing\nfiles which are slated for removal makes it basically impossible to\nrevert a previously merged candidacy which has since been\ninvalidated (for example, by resigning OSF Individual Membership).\n\nChange-Id: I4d5d9b1d55379adfd1c7d7765324306abf40cdb7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/election/commit/86d143609a73d6b899e63ce20a3bca95279a174e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/election/commit/86d143609a73d6b899e63ce20a3bca95279a174e"}]},"branch":"refs/heads/master"},"fae12a0600ab5a5bfe0fc8384d5002713cc8fbcc":{"kind":"REWORK","_number":2,"created":"2020-09-24 17:03:53.000000000","uploader":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"ref":"refs/changes/34/753934/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/election","ref":"refs/changes/34/753934/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/election refs/changes/34/753934/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/election refs/changes/34/753934/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/election refs/changes/34/753934/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/election refs/changes/34/753934/2"}}},"commit":{"parents":[{"commit":"b5750d843e052c7a3cb459843fec992679967ec2","subject":"Merge \"Adding Balazs Gibizer candidacy for Nova PTL\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/election/commit/b5750d843e052c7a3cb459843fec992679967ec2"}]}],"author":{"name":"Jeremy Stanley","email":"fungi@yuggoth.org","date":"2020-09-24 03:52:21.000000000","tz":0},"committer":{"name":"Jeremy Stanley","email":"fungi@yuggoth.org","date":"2020-09-24 17:02:27.000000000","tz":0},"subject":"Don\u0027t test candidate files if they\u0027re removed","message":"Don\u0027t test candidate files if they\u0027re removed\n\nThe routine to determine which files to check for candidacies, when\nused to analyze files being changed with --HEAD, should only test\nthose files if they are being kept by the change. If they\u0027re being\ndeleted, then there is no reason to test them. Further, testing\nfiles which are slated for removal makes it basically impossible to\nrevert a previously merged candidacy which has since been\ninvalidated (for example, by resigning OSF Individual Membership).\n\nMock os.path.exists in test_find_modified_candidate_files_all_good\nto just return True, since we aren\u0027t actually creating the file in\nthat test.\n\nChange-Id: I4d5d9b1d55379adfd1c7d7765324306abf40cdb7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/election/commit/fae12a0600ab5a5bfe0fc8384d5002713cc8fbcc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/election/commit/fae12a0600ab5a5bfe0fc8384d5002713cc8fbcc"}]},"branch":"refs/heads/master"},"c77c7478cabd1d8f9b1577996a927d39fb6d58da":{"kind":"REWORK","_number":3,"created":"2020-09-24 19:34:05.000000000","uploader":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"ref":"refs/changes/34/753934/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/election","ref":"refs/changes/34/753934/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/election refs/changes/34/753934/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/election refs/changes/34/753934/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/election refs/changes/34/753934/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/election refs/changes/34/753934/3"}}},"commit":{"parents":[{"commit":"b5750d843e052c7a3cb459843fec992679967ec2","subject":"Merge \"Adding Balazs Gibizer candidacy for Nova PTL\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/election/commit/b5750d843e052c7a3cb459843fec992679967ec2"}]}],"author":{"name":"Jeremy Stanley","email":"fungi@yuggoth.org","date":"2020-09-24 03:52:21.000000000","tz":0},"committer":{"name":"Jeremy Stanley","email":"fungi@yuggoth.org","date":"2020-09-24 19:33:29.000000000","tz":0},"subject":"Don\u0027t test candidate files if they\u0027re removed","message":"Don\u0027t test candidate files if they\u0027re removed\n\nThe routine to determine which files to check for candidacies, when\nused to analyze files being changed with --HEAD, should only test\nthose files if they are being kept by the change. If they\u0027re being\ndeleted, then there is no reason to test them. Further, testing\nfiles which are slated for removal makes it basically impossible to\nrevert a previously merged candidacy which has since been\ninvalidated (for example, by resigning OSF Individual Membership).\n\nMock os.path.exists in test_find_modified_candidate_files_all_good\nto just return True, since we aren\u0027t actually creating the file in\nthat test.\n\nChange-Id: I4d5d9b1d55379adfd1c7d7765324306abf40cdb7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/election/commit/c77c7478cabd1d8f9b1577996a927d39fb6d58da"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/election/commit/c77c7478cabd1d8f9b1577996a927d39fb6d58da"}]},"branch":"refs/heads/master"},"4570981c1bc0ecffe541151b4f2be4bcb52c6686":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2020-09-28 13:21:13.000000000","uploader":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"ref":"refs/changes/34/753934/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/election","ref":"refs/changes/34/753934/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/election refs/changes/34/753934/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/election refs/changes/34/753934/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/election refs/changes/34/753934/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/election refs/changes/34/753934/4"}}},"commit":{"parents":[{"commit":"0c2b4aae5302b309f845331369ff50012c3605eb","subject":"Merge \"Add Gage Hugo candidacy for OpenStack-Helm PTL\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/election/commit/0c2b4aae5302b309f845331369ff50012c3605eb"}]}],"author":{"name":"Jeremy Stanley","email":"fungi@yuggoth.org","date":"2020-09-24 03:52:21.000000000","tz":0},"committer":{"name":"Jeremy Stanley","email":"fungi@yuggoth.org","date":"2020-09-28 13:21:06.000000000","tz":0},"subject":"Don\u0027t test candidate files if they\u0027re removed","message":"Don\u0027t test candidate files if they\u0027re removed\n\nThe routine to determine which files to check for candidacies, when\nused to analyze files being changed with --HEAD, should only test\nthose files if they are being kept by the change. If they\u0027re being\ndeleted, then there is no reason to test them. Further, testing\nfiles which are slated for removal makes it basically impossible to\nrevert a previously merged candidacy which has since been\ninvalidated (for example, by resigning OSF Individual Membership).\n\nMock os.path.exists in test_find_modified_candidate_files_all_good\nto just return True, since we aren\u0027t actually creating the file in\nthat test.\n\nChange-Id: I4d5d9b1d55379adfd1c7d7765324306abf40cdb7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/election/commit/4570981c1bc0ecffe541151b4f2be4bcb52c6686"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/election/commit/4570981c1bc0ecffe541151b4f2be4bcb52c6686"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}