)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5b29e62eda05312cddd91cd5f53704d8afe7db12","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Most of the election tooling work on seperate events"},{"line_number":10,"context_line":"of PTL and TC election. If election is combined then"},{"line_number":11,"context_line":"setup_election_config generate the combined event("},{"line_number":12,"context_line":"for example \u0027TC \u0026 PTL Election\u0027) and it does not work"},{"line_number":13,"context_line":"with those tools/scripts."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This fixes it and even for combined election it generates"},{"line_number":16,"context_line":"the separate events. If we look at the election site, the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d49efa4c_c3975273","line":13,"range":{"start_line":12,"start_character":32,"end_line":13,"end_character":25},"updated":"2023-03-04 07:18:05.000000000","message":"What doesn\u0027t work with a single event \u0027TC \u0026 PTL $x\u0027?","commit_id":"2144e175411db1ca166eeb9198b7dff98496f906"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"112facc33c643d9a8221f81f2ec98784fe4df8c4","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Most of the election tooling work on seperate events"},{"line_number":10,"context_line":"of PTL and TC election. If election is combined then"},{"line_number":11,"context_line":"setup_election_config generate the combined event("},{"line_number":12,"context_line":"for example \u0027TC \u0026 PTL Election\u0027) and it does not work"},{"line_number":13,"context_line":"with those tools/scripts."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This fixes it and even for combined election it generates"},{"line_number":16,"context_line":"the separate events. If we look at the election site, the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"89716ba0_08a6b160","line":13,"range":{"start_line":12,"start_character":32,"end_line":13,"end_character":25},"in_reply_to":"d49efa4c_c3975273","updated":"2023-03-06 19:51:32.000000000","message":"for single event it is fine as it generate the per event data but for combined it is combining both into single","commit_id":"2144e175411db1ca166eeb9198b7dff98496f906"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5b29e62eda05312cddd91cd5f53704d8afe7db12","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This fixes it and even for combined election it generates"},{"line_number":16,"context_line":"the separate events. If we look at the election site, the"},{"line_number":17,"context_line":"separate events are more clear for users."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Generated config looks like below:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0c0bfd91_f726bbf0","line":17,"range":{"start_line":17,"start_character":25,"end_line":17,"end_character":41},"updated":"2023-03-04 07:18:05.000000000","message":"Has the existing output caused a problem or confusion?","commit_id":"2144e175411db1ca166eeb9198b7dff98496f906"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"112facc33c643d9a8221f81f2ec98784fe4df8c4","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This fixes it and even for combined election it generates"},{"line_number":16,"context_line":"the separate events. If we look at the election site, the"},{"line_number":17,"context_line":"separate events are more clear for users."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Generated config looks like below:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"85d58d04_ac1f35be","line":17,"range":{"start_line":17,"start_character":25,"end_line":17,"end_character":41},"in_reply_to":"0c0bfd91_f726bbf0","updated":"2023-03-06 19:51:32.000000000","message":"it does not work for combined election where it generate the combined event for example\n\n- name: TC \u0026 PTL Election\n  start: 2023-02-22T23:45\n  end: 2023-03-08T23:45\n\nand many of the scripts in election repo query event with single event like \u0027PTL Election\u0027. To make it work we need to manually separate the event in configuration file - example: https://review.opendev.org/c/openstack/election/+/872227\n\nThis change fix it for combined election also so that generated data can be added in configuration file without any manual updates.","commit_id":"2144e175411db1ca166eeb9198b7dff98496f906"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"bd1cb95b6211f415d456e90e75eb76f9650a6df0","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This fixes it and even for combined election it generates"},{"line_number":16,"context_line":"the separate events. If we look at the election site, the"},{"line_number":17,"context_line":"separate events are more clear for users."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Generated config looks like below:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e32484d4_1189ca01","line":17,"range":{"start_line":17,"start_character":25,"end_line":17,"end_character":41},"in_reply_to":"85d58d04_ac1f35be","updated":"2023-03-07 00:32:36.000000000","message":"Like I said I Understand *what* this does.  I don\u0027t understand *why* you\u0027re doing it.  You say ...\"many of the scripts\"... Can you give me an example of one?\n\nWe have used the combined event string as long as we\u0027ve been doing combined elections, excluding the last two.","commit_id":"2144e175411db1ca166eeb9198b7dff98496f906"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"bbeab86fd7479449998d4f4a7d8b2f697cce2205","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This fixes it and even for combined election it generates"},{"line_number":16,"context_line":"the separate events. If we look at the election site, the"},{"line_number":17,"context_line":"separate events are more clear for users."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Generated config looks like below:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1c2e95b3_423fb645","line":17,"range":{"start_line":17,"start_character":25,"end_line":17,"end_character":41},"in_reply_to":"93cc64be_acafae90","updated":"2023-03-08 01:16:59.000000000","message":"I wasn\u0027t aware of neededing to make those changes.  The git history seems to confirm your statements.\n\n(venv) [tony@thor election]$ git log -p -- configuration.yaml gerrit/master | grep -E \u0027^[+-].*(\\\u0026|Election)\u0027\n\nThanks for helping me understand your motivation,","commit_id":"2144e175411db1ca166eeb9198b7dff98496f906"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4b17cebfad58416b360ac9462618a254663c7541","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This fixes it and even for combined election it generates"},{"line_number":16,"context_line":"the separate events. If we look at the election site, the"},{"line_number":17,"context_line":"separate events are more clear for users."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Generated config looks like below:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"93cc64be_acafae90","line":17,"range":{"start_line":17,"start_character":25,"end_line":17,"end_character":41},"in_reply_to":"e32484d4_1189ca01","updated":"2023-03-07 02:34:18.000000000","message":"in configuration file, we had to separate those combined string to make it work right? we never kept combined string in configuration file. Below are the some script failed with these combined string because they query the separate event string\n\n- https://github.com/openstack/election/blob/349b659a038993b241b17b0514516d49f3d2c592/openstack_election/cmds/render_statistics.py#L71\n- https://github.com/openstack/election/blob/349b659a038993b241b17b0514516d49f3d2c592/openstack_election/cmds/template_emails.py#L60\n- https://github.com/openstack/election/blob/349b659a038993b241b17b0514516d49f3d2c592/openstack_election/cmds/template_emails.py#L65","commit_id":"2144e175411db1ca166eeb9198b7dff98496f906"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"bbeab86fd7479449998d4f4a7d8b2f697cce2205","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Generated config looks like below:"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Id8357dc93df1f11ffe38abd252edbc137e7f5080"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"release: 2023.2"},{"line_number":24,"context_line":"election_type: combined"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0502371f_31673063","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":52},"updated":"2023-03-08 01:16:59.000000000","message":"Please remove this line.","commit_id":"2144e175411db1ca166eeb9198b7dff98496f906"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"a0fa91cbcebc86dc8081206fc6c0af9791a416c9","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Generated config looks like below:"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Id8357dc93df1f11ffe38abd252edbc137e7f5080"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"release: 2023.2"},{"line_number":24,"context_line":"election_type: combined"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b1255280_e2e0ff5a","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":52},"in_reply_to":"0502371f_31673063","updated":"2023-03-25 01:23:47.000000000","message":"Something put it back :(","commit_id":"2144e175411db1ca166eeb9198b7dff98496f906"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5b29e62eda05312cddd91cd5f53704d8afe7db12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e29320c7_9876bcec","updated":"2023-03-04 07:18:05.000000000","message":"I\u0027m okay with the implementation of this but I really don\u0027t see the point/value.\n\nLooking for help understanding the motivation","commit_id":"2144e175411db1ca166eeb9198b7dff98496f906"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"bd1cb95b6211f415d456e90e75eb76f9650a6df0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f4c09999_23b31dfb","updated":"2023-03-07 00:32:36.000000000","message":"My comments stand.  I\u0027m okay with the implementation.  I want to understand the objective motivation. ","commit_id":"2144e175411db1ca166eeb9198b7dff98496f906"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"bbeab86fd7479449998d4f4a7d8b2f697cce2205","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f274ba4c_96ff0e42","updated":"2023-03-08 01:16:59.000000000","message":"switching to -1 because of the additional Change-Id in the commit message.\n\nApart from that I\u0027m, now, +2","commit_id":"2144e175411db1ca166eeb9198b7dff98496f906"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"112facc33c643d9a8221f81f2ec98784fe4df8c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4088411a_930336c1","in_reply_to":"e29320c7_9876bcec","updated":"2023-03-06 19:51:32.000000000","message":"This script does not work for combined election, either we need to fix it or fix many other script query the single event even in case of combined election.","commit_id":"2144e175411db1ca166eeb9198b7dff98496f906"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fa8c108327a7ecc51b3f30d8a7327606a38ccb00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3d9d50b7_92e1061a","in_reply_to":"f274ba4c_96ff0e42","updated":"2023-03-08 16:09:57.000000000","message":"oh, sorry about it. done","commit_id":"2144e175411db1ca166eeb9198b7dff98496f906"}]}