)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"20230361ce7ac24aaa90b0c88bbf04c744c36736","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Update job config."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Switch to 2023.2 testing runtime py version (7f56f206e6) we added"},{"line_number":10,"context_line":"the openstack-python3-jobs template to the zuul config.  This doesn\u0027t"},{"line_number":11,"context_line":"work for the elections repo as we don\u0027t have a pep8 target, and we also"},{"line_number":12,"context_line":"do not want to add publish-openstack-python-branch-tarball to the"},{"line_number":13,"context_line":"promote pipeline."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e5350d58_00f2d9f5","line":11,"range":{"start_line":10,"start_character":57,"end_line":11,"end_character":59},"updated":"2023-08-17 16:06:33.000000000","message":"I am not sure about it, we used to run pep8 on election and it was passing and as we have python file in this tooling we should run pep8. I am not seeing any reason why we should skip that for this tool. pep8 provide consistency to the other OpenStack tool/projects coding practice.","commit_id":"1491095ce36dbe52ab2d2debefdb3a292a1a21c2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e29bf3c0c6265c8de7f4c90d642babf3c636a11c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update job config."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Switch to 2023.2 testing runtime py version (7f56f206e6) we added"},{"line_number":10,"context_line":"the openstack-python3-jobs template to the zuul config.  This doesn\u0027t"},{"line_number":11,"context_line":"work for the elections repo as we don\u0027t have a pep8 target, and we also"},{"line_number":12,"context_line":"do not want to add publish-openstack-python-branch-tarball to the"},{"line_number":13,"context_line":"promote pipeline."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bffe6aba_0f5039ea","line":11,"range":{"start_line":10,"start_character":57,"end_line":11,"end_character":59},"in_reply_to":"8b1b8242_97ccbeb6","updated":"2023-08-17 16:20:50.000000000","message":"ok this commit message line is confusing which say it does not work for election. it work there but instead we can say linter job already run the flake8 checks so we do not need this extra job.","commit_id":"1491095ce36dbe52ab2d2debefdb3a292a1a21c2"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"6241de46a7bf45dfa0e5b8068893f8a4a152237b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update job config."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Switch to 2023.2 testing runtime py version (7f56f206e6) we added"},{"line_number":10,"context_line":"the openstack-python3-jobs template to the zuul config.  This doesn\u0027t"},{"line_number":11,"context_line":"work for the elections repo as we don\u0027t have a pep8 target, and we also"},{"line_number":12,"context_line":"do not want to add publish-openstack-python-branch-tarball to the"},{"line_number":13,"context_line":"promote pipeline."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8b1b8242_97ccbeb6","line":11,"range":{"start_line":10,"start_character":57,"end_line":11,"end_character":59},"in_reply_to":"e5350d58_00f2d9f5","updated":"2023-08-17 16:08:01.000000000","message":"It\u0027s part of the linters target","commit_id":"1491095ce36dbe52ab2d2debefdb3a292a1a21c2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"20230361ce7ac24aaa90b0c88bbf04c744c36736","unresolved":true,"context_lines":[{"line_number":9,"context_line":"In Switch to 2023.2 testing runtime py version (7f56f206e6) we added"},{"line_number":10,"context_line":"the openstack-python3-jobs template to the zuul config.  This doesn\u0027t"},{"line_number":11,"context_line":"work for the elections repo as we don\u0027t have a pep8 target, and we also"},{"line_number":12,"context_line":"do not want to add publish-openstack-python-branch-tarball to the"},{"line_number":13,"context_line":"promote pipeline."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Instead just opencode the python jobs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ea225def_c4582fd6","line":12,"range":{"start_line":12,"start_character":19,"end_line":12,"end_character":58},"updated":"2023-08-17 16:06:33.000000000","message":"I agree with this that we do not need this as such","commit_id":"1491095ce36dbe52ab2d2debefdb3a292a1a21c2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"cb151f98f3d1cecbd42cda76fe87e356cba2acad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b279f8a5_29c78eee","updated":"2023-08-17 17:12:22.000000000","message":"I am approving this as it has  Ians\u0027 +2.  Ghanshyam and I discussed it on IRC[1] where it was said \"up to you\".  Ghanshyam objects but in this case I feel like the commit message is fine.  Anyone modifying the job configuration can trivially see what each target covers.\n\nIf the election repo was configured with copyCondition\u003dNO_CODE_CHANGE[3]  we\ncould update the commit message to say:\n\n   This doesn\u0027t work for the elections repo as we don\u0027t have a pep8 target\n   (instead we use the linters target).\n\nbut this feels like minimal gain to me.\n\n[1] https://meetings.opendev.org/irclogs/%23openstack-election/%23openstack-election.2023-08-17.log.html#t2023-08-17T16:09:13\n[2] https://meetings.opendev.org/irclogs/%23openstack-election/%23openstack-election.2023-08-17.log.html#t2023-08-17T16:29:37 \n[3] https://review.opendev.org/Documentation/config-labels.html#no_code_change","commit_id":"1491095ce36dbe52ab2d2debefdb3a292a1a21c2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"20230361ce7ac24aaa90b0c88bbf04c744c36736","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5625ea45_940a66e3","updated":"2023-08-17 16:06:33.000000000","message":"I think we should run pep8 here.","commit_id":"1491095ce36dbe52ab2d2debefdb3a292a1a21c2"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"4c67446636f26498b6340b1afce8b9e12e8f3e8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"299f7ac2_b105283f","updated":"2023-08-17 15:47:10.000000000","message":"Looks good with 1) current pass status on Zuul queue 2) There is no pep8 section in tox.ini on the repo and 3) agree that this repo does not require tarball.","commit_id":"1491095ce36dbe52ab2d2debefdb3a292a1a21c2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2a91208f8e3b09ef76e2af35625dc359d6185135","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"81c46e4d_3adc7e8e","in_reply_to":"b279f8a5_29c78eee","updated":"2023-08-17 17:21:14.000000000","message":"sure, I am fine if you do not want to change the commit msg and I will not block it as election time going on. But commit msg here is clearly confusing and it seems like election repo does not need and run pep8/flake8 checks to run but that is not the case as it run as part of linters job. I am seeing commit msg as important as code as it provide hostory of change and in future if anyone read this cmt msg can et confused until they read the IRC logs.","commit_id":"1491095ce36dbe52ab2d2debefdb3a292a1a21c2"}]}