)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"d7a2c1bf46854958414f1c7b28d18b9ef21365b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dcd39652_ca8867bc","updated":"2025-01-09 15:08:55.000000000","message":"thanks for clearing it up","commit_id":"cd9628a7609f8e11e82c2a195e3488b3c9e15ae7"}],"tox.ini":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f0b2b1dc6d3fae93dca21440cc23c2465036889f","unresolved":true,"context_lines":[{"line_number":36,"context_line":"commands \u003d sphinx-build -W -b html doc/source doc/build/html"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[testenv:pypy-etcd]"},{"line_number":39,"context_line":"commands \u003d {toxinidir}/setup-etcd-env.sh pifpaf -g TOOZ_TEST run etcd -- py.test -vv \u0027{posargs}\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[testenv:py39-etcd]"},{"line_number":42,"context_line":"commands \u003d {toxinidir}/setup-etcd-env.sh pifpaf -g TOOZ_TEST run etcd -- py.test -vv \u0027{posargs}\u0027"}],"source_content_type":"text/x-properties","patch_set":6,"id":"12d988a1_7df60b4b","side":"PARENT","line":39,"updated":"2024-12-09 10:11:21.000000000","message":"should we really remove TOOZ_TEST it\u0027s what used to pass info through env vars to testing?","commit_id":"713d4f5d5f3c8a33c7da5be9553ec356c043f9b3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0c5e4af42f358f4e5525a8885b6e0a54ce27310d","unresolved":true,"context_lines":[{"line_number":36,"context_line":"commands \u003d sphinx-build -W -b html doc/source doc/build/html"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[testenv:pypy-etcd]"},{"line_number":39,"context_line":"commands \u003d {toxinidir}/setup-etcd-env.sh pifpaf -g TOOZ_TEST run etcd -- py.test -vv \u0027{posargs}\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[testenv:py39-etcd]"},{"line_number":42,"context_line":"commands \u003d {toxinidir}/setup-etcd-env.sh pifpaf -g TOOZ_TEST run etcd -- py.test -vv \u0027{posargs}\u0027"}],"source_content_type":"text/x-properties","patch_set":6,"id":"86a6bcfd_7d6efa99","side":"PARENT","line":39,"in_reply_to":"12d988a1_7df60b4b","updated":"2024-12-09 12:49:00.000000000","message":"TOOZ_TEST is not actually used in the current test code. We should probably update the unit test code to detect etcd3 url from environment variables but I\u0027ll leave it for follow up and remove the unused items for now.","commit_id":"713d4f5d5f3c8a33c7da5be9553ec356c043f9b3"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f0b2b1dc6d3fae93dca21440cc23c2465036889f","unresolved":true,"context_lines":[{"line_number":8,"context_line":"       -r{toxinidir}/requirements.txt"},{"line_number":9,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":10,"context_line":"commands \u003d"},{"line_number":11,"context_line":"  find . -type f -name \"*.pyc\" -delete"},{"line_number":12,"context_line":"  stestr run {posargs}"},{"line_number":13,"context_line":"allowlist_externals \u003d"},{"line_number":14,"context_line":"  find"}],"source_content_type":"text/x-properties","patch_set":6,"id":"563a633c_8248b0d9","line":11,"updated":"2024-12-09 10:11:21.000000000","message":"perhaps use {toxinidir} instead of current dir `.` since one can stand in a subdirectory and tox will traverse upwards to find tox.ini?","commit_id":"cd9628a7609f8e11e82c2a195e3488b3c9e15ae7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0c5e4af42f358f4e5525a8885b6e0a54ce27310d","unresolved":true,"context_lines":[{"line_number":8,"context_line":"       -r{toxinidir}/requirements.txt"},{"line_number":9,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":10,"context_line":"commands \u003d"},{"line_number":11,"context_line":"  find . -type f -name \"*.pyc\" -delete"},{"line_number":12,"context_line":"  stestr run {posargs}"},{"line_number":13,"context_line":"allowlist_externals \u003d"},{"line_number":14,"context_line":"  find"}],"source_content_type":"text/x-properties","patch_set":6,"id":"6c32e45b_1a68505c","line":11,"in_reply_to":"563a633c_8248b0d9","updated":"2024-12-09 12:49:00.000000000","message":"We can use {toxinidir} but I tend to keep the current logic because it\u0027s widely used in the other repos.","commit_id":"cd9628a7609f8e11e82c2a195e3488b3c9e15ae7"}]}