)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"51a9d45d9b6b991f7a46bc9561d6cb98f660ab0e","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Allow session parameter to configure pool size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add an optional session parameter to etc3client that accept custom"},{"line_number":10,"context_line":"session boject allowing us to provide pre-configure session object with"},{"line_number":11,"context_line":"custom session allow users to configure pool size etc."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"closes-bug: #2125229"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9abe00aa_7241793a","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":14},"updated":"2025-12-03 12:54:57.000000000","message":"typo.","commit_id":"690a2bb4408866050da8965ad0b6b941e0c500f0"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"9d34eff8de53e4a02735e0d92eb56e8c31240ba6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow session parameter to configure pool size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add an optional session parameter to etc3client that accept custom"},{"line_number":10,"context_line":"session boject allowing us to provide pre-configure session object with"},{"line_number":11,"context_line":"custom session allow users to configure pool size etc."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"closes-bug: #2125229"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a6bb82d4_f439ccdb","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":14},"in_reply_to":"9abe00aa_7241793a","updated":"2025-12-03 13:20:36.000000000","message":"Done","commit_id":"690a2bb4408866050da8965ad0b6b941e0c500f0"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"78a7fee54503c7b70468059c625a874505496e3b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow session parameter to configure pool size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add an optional session parameter to etc3client that accept custom"},{"line_number":10,"context_line":"session object allowing us to provide pre-configure session object with"},{"line_number":11,"context_line":"custom session allow users to configure pool size etc."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa59f303_3569489e","line":9,"range":{"start_line":9,"start_character":37,"end_line":9,"end_character":47},"updated":"2025-12-03 15:18:17.000000000","message":"nit: s/etc3client/etcd3client/","commit_id":"5ae4eda55b10bad1c68f338ce74306a7c35bebfe"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"223ee93ff6ee25b68e918449f649b4cfaf15c306","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow session parameter to configure pool size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add an optional session parameter to etc3client that accept custom"},{"line_number":10,"context_line":"session object allowing us to provide pre-configure session object with"},{"line_number":11,"context_line":"custom session allow users to configure pool size etc."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"0199002c_71bd3c4d","line":9,"range":{"start_line":9,"start_character":37,"end_line":9,"end_character":47},"in_reply_to":"fa59f303_3569489e","updated":"2025-12-03 15:34:11.000000000","message":"Done","commit_id":"5ae4eda55b10bad1c68f338ce74306a7c35bebfe"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0dfa144770e5cf3867daa682ca019166eb568521","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Abhishek Bongale \u003cabhishekbongale@outlook.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-12-03 15:30:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow session parameter to configure pool size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add an optional session parameter to s/etc3client/etcd3client/ that"},{"line_number":10,"context_line":"accept custom session object allowing us to provide pre-configure"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ca321831_e79d05e3","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":46},"updated":"2025-12-03 17:19:48.000000000","message":"If pool size is the only use case we expect, then I\u0027d rather suggest providing a more specific interfaces to customize auto-created session object. It may help people from configuring their session object \"properly\" according to the internal logic (for example you have to make sure that scheme is consistent with the key used when mounting an adopter.","commit_id":"35b919c7ee12206420ef3688f1d9b46c94c26b23"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fc1eed452d356325bf4979685ced98192f5a954b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Abhishek Bongale \u003cabhishekbongale@outlook.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-12-03 15:30:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow session parameter to configure pool size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add an optional session parameter to s/etc3client/etcd3client/ that"},{"line_number":10,"context_line":"accept custom session object allowing us to provide pre-configure"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ea72a4e3_a0d73abd","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":46},"in_reply_to":"2f997987_7ca02b39","updated":"2025-12-04 13:26:23.000000000","message":"Maybe we can start with this and consider having narrowed down interface if we learn more about the real use case. For now updating the commit title is enough.","commit_id":"35b919c7ee12206420ef3688f1d9b46c94c26b23"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"b400654f64278cf8a0ca4b87add1d235bf6a8f7e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Abhishek Bongale \u003cabhishekbongale@outlook.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-12-03 15:30:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow session parameter to configure pool size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add an optional session parameter to s/etc3client/etcd3client/ that"},{"line_number":10,"context_line":"accept custom session object allowing us to provide pre-configure"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"2f997987_7ca02b39","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":46},"in_reply_to":"ca321831_e79d05e3","updated":"2025-12-03 21:25:37.000000000","message":"I thought about it, and yes primary driver to this change is connection pool in production for networking-generic-switch. My thought process going for passing session object over manipulating the default session is\n1.  Adding adaptor in the __init__(), we have to pass all the HTTP adaptor parameters creating overhead and \n2. do etcd3gw client needs to know all the intricacies of HTTP connection? If user wants it, he can configure it and pass the session object.","commit_id":"35b919c7ee12206420ef3688f1d9b46c94c26b23"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0dfa144770e5cf3867daa682ca019166eb568521","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow session parameter to configure pool size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add an optional session parameter to s/etc3client/etcd3client/ that"},{"line_number":10,"context_line":"accept custom session object allowing us to provide pre-configure"},{"line_number":11,"context_line":"session object with custom session allow users to configure pool size"},{"line_number":12,"context_line":"etc."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"62f92d2c_156a710b","line":9,"range":{"start_line":9,"start_character":37,"end_line":9,"end_character":62},"updated":"2025-12-03 17:19:48.000000000","message":"I think the comment in patch set 5 does not expect that you add the whole content by \"replace etc3client by etcd3client\" (assuming that it is a sed command representation)\n\nAlso, the actual class name is Etcd3Client.","commit_id":"35b919c7ee12206420ef3688f1d9b46c94c26b23"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"b400654f64278cf8a0ca4b87add1d235bf6a8f7e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow session parameter to configure pool size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add an optional session parameter to s/etc3client/etcd3client/ that"},{"line_number":10,"context_line":"accept custom session object allowing us to provide pre-configure"},{"line_number":11,"context_line":"session object with custom session allow users to configure pool size"},{"line_number":12,"context_line":"etc."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"090533d0_dbbaaf52","line":9,"range":{"start_line":9,"start_character":37,"end_line":9,"end_character":62},"in_reply_to":"62f92d2c_156a710b","updated":"2025-12-03 21:25:37.000000000","message":"Acknowledged","commit_id":"35b919c7ee12206420ef3688f1d9b46c94c26b23"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0dfa144770e5cf3867daa682ca019166eb568521","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Allow session parameter to configure pool size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add an optional session parameter to s/etc3client/etcd3client/ that"},{"line_number":10,"context_line":"accept custom session object allowing us to provide pre-configure"},{"line_number":11,"context_line":"session object with custom session allow users to configure pool size"},{"line_number":12,"context_line":"etc."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"8003c098_36a32ab3","line":10,"range":{"start_line":10,"start_character":52,"end_line":10,"end_character":65},"updated":"2025-12-03 17:19:48.000000000","message":"a pre-configured","commit_id":"35b919c7ee12206420ef3688f1d9b46c94c26b23"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fc1eed452d356325bf4979685ced98192f5a954b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow session parameter to configure pool size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add an optional session parameter to s/etc3client/etcd3client/ that"},{"line_number":10,"context_line":"accept custom session object allowing us to provide pre-configure"},{"line_number":11,"context_line":"session object with custom session allow users to configure pool size"},{"line_number":12,"context_line":"etc."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"c0fff73c_6224d218","line":10,"range":{"start_line":10,"start_character":52,"end_line":10,"end_character":65},"in_reply_to":"8003c098_36a32ab3","updated":"2025-12-04 13:26:23.000000000","message":"Done","commit_id":"35b919c7ee12206420ef3688f1d9b46c94c26b23"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0dfa144770e5cf3867daa682ca019166eb568521","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add an optional session parameter to s/etc3client/etcd3client/ that"},{"line_number":10,"context_line":"accept custom session object allowing us to provide pre-configure"},{"line_number":11,"context_line":"session object with custom session allow users to configure pool size"},{"line_number":12,"context_line":"etc."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"closes-bug: #2125229"},{"line_number":15,"context_line":"Change-Id: I0997837edd179d64cd5a86491e291b71eabfebe1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"47e60502_203d9f9b","line":12,"range":{"start_line":11,"start_character":35,"end_line":12,"end_character":4},"updated":"2025-12-03 17:19:48.000000000","message":". This allows users to customize request behavior such as connection pool size.","commit_id":"35b919c7ee12206420ef3688f1d9b46c94c26b23"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fc1eed452d356325bf4979685ced98192f5a954b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add an optional session parameter to s/etc3client/etcd3client/ that"},{"line_number":10,"context_line":"accept custom session object allowing us to provide pre-configure"},{"line_number":11,"context_line":"session object with custom session allow users to configure pool size"},{"line_number":12,"context_line":"etc."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"closes-bug: #2125229"},{"line_number":15,"context_line":"Change-Id: I0997837edd179d64cd5a86491e291b71eabfebe1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"431f18fc_8eea79bb","line":12,"range":{"start_line":11,"start_character":35,"end_line":12,"end_character":4},"in_reply_to":"47e557d8_b4aab389","updated":"2025-12-04 13:26:23.000000000","message":"Done","commit_id":"35b919c7ee12206420ef3688f1d9b46c94c26b23"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"b400654f64278cf8a0ca4b87add1d235bf6a8f7e","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add an optional session parameter to s/etc3client/etcd3client/ that"},{"line_number":10,"context_line":"accept custom session object allowing us to provide pre-configure"},{"line_number":11,"context_line":"session object with custom session allow users to configure pool size"},{"line_number":12,"context_line":"etc."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"closes-bug: #2125229"},{"line_number":15,"context_line":"Change-Id: I0997837edd179d64cd5a86491e291b71eabfebe1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"47e557d8_b4aab389","line":12,"range":{"start_line":11,"start_character":35,"end_line":12,"end_character":4},"in_reply_to":"47e60502_203d9f9b","updated":"2025-12-03 21:25:37.000000000","message":"Acknowledged","commit_id":"35b919c7ee12206420ef3688f1d9b46c94c26b23"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"51a9d45d9b6b991f7a46bc9561d6cb98f660ab0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aa850b1f_9bbf8ba7","updated":"2025-12-03 12:54:57.000000000","message":"Thanks, would be worth to also add a tiny release note","commit_id":"690a2bb4408866050da8965ad0b6b941e0c500f0"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"2ff31c88fbfee42698b36d4355606adb7794f7db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7345a659_7c2f89df","in_reply_to":"aa850b1f_9bbf8ba7","updated":"2025-12-03 12:59:08.000000000","message":"++","commit_id":"690a2bb4408866050da8965ad0b6b941e0c500f0"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"78a7fee54503c7b70468059c625a874505496e3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b428797b_a74f803b","updated":"2025-12-03 15:18:17.000000000","message":"Overall looks good, some suggestions in line.","commit_id":"5ae4eda55b10bad1c68f338ce74306a7c35bebfe"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"b400654f64278cf8a0ca4b87add1d235bf6a8f7e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"025385f3_a44dec52","updated":"2025-12-03 21:25:37.000000000","message":"forgot to run pre-commit","commit_id":"35b919c7ee12206420ef3688f1d9b46c94c26b23"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"17a8bf8f34613e79ce5e153188d70cc33259d9ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b45623cb_00561dba","in_reply_to":"025385f3_a44dec52","updated":"2025-12-04 14:02:28.000000000","message":"Done","commit_id":"35b919c7ee12206420ef3688f1d9b46c94c26b23"}],"etcd3gw/client.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"51a9d45d9b6b991f7a46bc9561d6cb98f660ab0e","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        :param host: etcd host"},{"line_number":51,"context_line":"        :param port: etcd port"},{"line_number":52,"context_line":"        :param protocol: protocol (http or https)"},{"line_number":53,"context_line":"        :param ca_cert: CA certificate for SSL/TLS verification"},{"line_number":54,"context_line":"        :param cert_key: client certificate key"},{"line_number":55,"context_line":"        :param cert_cert: client certificate"},{"line_number":56,"context_line":"        :param timeout: request timeout"},{"line_number":57,"context_line":"        :param api_path: API path (default to auto-discovery)"},{"line_number":58,"context_line":"        :param session: optional preconfigured request.session object."},{"line_number":59,"context_line":"                        If not provided new session will be created"},{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":"        self.host \u003d host"},{"line_number":62,"context_line":"        self.port \u003d port"}],"source_content_type":"text/x-python","patch_set":3,"id":"0f6243fe_801c6c5b","line":59,"range":{"start_line":53,"start_character":0,"end_line":59,"end_character":67},"updated":"2025-12-03 12:54:57.000000000","message":"Thanks","commit_id":"690a2bb4408866050da8965ad0b6b941e0c500f0"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"9d34eff8de53e4a02735e0d92eb56e8c31240ba6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        :param host: etcd host"},{"line_number":51,"context_line":"        :param port: etcd port"},{"line_number":52,"context_line":"        :param protocol: protocol (http or https)"},{"line_number":53,"context_line":"        :param ca_cert: CA certificate for SSL/TLS verification"},{"line_number":54,"context_line":"        :param cert_key: client certificate key"},{"line_number":55,"context_line":"        :param cert_cert: client certificate"},{"line_number":56,"context_line":"        :param timeout: request timeout"},{"line_number":57,"context_line":"        :param api_path: API path (default to auto-discovery)"},{"line_number":58,"context_line":"        :param session: optional preconfigured request.session object."},{"line_number":59,"context_line":"                        If not provided new session will be created"},{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":"        self.host \u003d host"},{"line_number":62,"context_line":"        self.port \u003d port"}],"source_content_type":"text/x-python","patch_set":3,"id":"6fdc0c30_9f433663","line":59,"range":{"start_line":53,"start_character":0,"end_line":59,"end_character":67},"in_reply_to":"0f6243fe_801c6c5b","updated":"2025-12-03 13:20:36.000000000","message":"Done","commit_id":"690a2bb4408866050da8965ad0b6b941e0c500f0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0dfa144770e5cf3867daa682ca019166eb568521","unresolved":true,"context_lines":[{"line_number":67,"context_line":"        else:"},{"line_number":68,"context_line":"            self.session \u003d requests.Session()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.timeout \u003d timeout"},{"line_number":71,"context_line":"        if ca_cert is not None:"},{"line_number":72,"context_line":"            self.session.verify \u003d ca_cert"},{"line_number":73,"context_line":"        if cert_cert is not None and cert_key is not None:"},{"line_number":74,"context_line":"            self.session.cert \u003d (cert_cert, cert_key)"},{"line_number":75,"context_line":"        self._api_path \u003d api_path"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":8,"id":"98ba630a_bfecc93b","line":74,"range":{"start_line":70,"start_character":30,"end_line":74,"end_character":53},"updated":"2025-12-03 17:19:48.000000000","message":"I wonder if we should avoid these if session is explicitly given so that the pre-configured object is not messed up unexpectedly ?","commit_id":"35b919c7ee12206420ef3688f1d9b46c94c26b23"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3024180438d73e47f94e45ff08bd9143bcf71e13","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        else:"},{"line_number":68,"context_line":"            self.session \u003d requests.Session()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.timeout \u003d timeout"},{"line_number":71,"context_line":"        if ca_cert is not None:"},{"line_number":72,"context_line":"            self.session.verify \u003d ca_cert"},{"line_number":73,"context_line":"        if cert_cert is not None and cert_key is not None:"},{"line_number":74,"context_line":"            self.session.cert \u003d (cert_cert, cert_key)"},{"line_number":75,"context_line":"        self._api_path \u003d api_path"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":8,"id":"ee001f4b_822d267d","line":74,"range":{"start_line":70,"start_character":30,"end_line":74,"end_character":53},"in_reply_to":"8cdf3a77_be3383a8","updated":"2025-12-06 08:24:09.000000000","message":"Done","commit_id":"35b919c7ee12206420ef3688f1d9b46c94c26b23"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"b400654f64278cf8a0ca4b87add1d235bf6a8f7e","unresolved":true,"context_lines":[{"line_number":67,"context_line":"        else:"},{"line_number":68,"context_line":"            self.session \u003d requests.Session()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.timeout \u003d timeout"},{"line_number":71,"context_line":"        if ca_cert is not None:"},{"line_number":72,"context_line":"            self.session.verify \u003d ca_cert"},{"line_number":73,"context_line":"        if cert_cert is not None and cert_key is not None:"},{"line_number":74,"context_line":"            self.session.cert \u003d (cert_cert, cert_key)"},{"line_number":75,"context_line":"        self._api_path \u003d api_path"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":8,"id":"9cfbe80e_79ca40b1","line":74,"range":{"start_line":70,"start_character":30,"end_line":74,"end_character":53},"in_reply_to":"98ba630a_bfecc93b","updated":"2025-12-03 21:25:37.000000000","message":"hmm, I thought about it,\n\nLet\u0027s say:\nUser passes custom session (with ca_cert, cert_cert etc) and passes ca_cert, cert_cert and cert_key\n-\u003e it will override the session.\n\nbit confusing but flexible can pass session and still can overrides cert.","commit_id":"35b919c7ee12206420ef3688f1d9b46c94c26b23"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fc1eed452d356325bf4979685ced98192f5a954b","unresolved":true,"context_lines":[{"line_number":67,"context_line":"        else:"},{"line_number":68,"context_line":"            self.session \u003d requests.Session()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.timeout \u003d timeout"},{"line_number":71,"context_line":"        if ca_cert is not None:"},{"line_number":72,"context_line":"            self.session.verify \u003d ca_cert"},{"line_number":73,"context_line":"        if cert_cert is not None and cert_key is not None:"},{"line_number":74,"context_line":"            self.session.cert \u003d (cert_cert, cert_key)"},{"line_number":75,"context_line":"        self._api_path \u003d api_path"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":8,"id":"bced4938_2f69f5af","line":74,"range":{"start_line":70,"start_character":30,"end_line":74,"end_character":53},"in_reply_to":"9cfbe80e_79ca40b1","updated":"2025-12-04 13:26:23.000000000","message":"I\u0027ve checked a few existing implementations (eg the one in novaclient) and these do not manipulate session object and expect these are set properly in the session object.\nI\u0027d suggest we follow the same approach and skip these logics. This is more consistent with the point 2 you described in the commit message.\n\nIn my personal opinion, I don\u0027t see much \"flexible\" benefit with this thin logic.","commit_id":"35b919c7ee12206420ef3688f1d9b46c94c26b23"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"17a8bf8f34613e79ce5e153188d70cc33259d9ac","unresolved":true,"context_lines":[{"line_number":67,"context_line":"        else:"},{"line_number":68,"context_line":"            self.session \u003d requests.Session()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.timeout \u003d timeout"},{"line_number":71,"context_line":"        if ca_cert is not None:"},{"line_number":72,"context_line":"            self.session.verify \u003d ca_cert"},{"line_number":73,"context_line":"        if cert_cert is not None and cert_key is not None:"},{"line_number":74,"context_line":"            self.session.cert \u003d (cert_cert, cert_key)"},{"line_number":75,"context_line":"        self._api_path \u003d api_path"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":8,"id":"8cdf3a77_be3383a8","line":74,"range":{"start_line":70,"start_character":30,"end_line":74,"end_character":53},"in_reply_to":"bced4938_2f69f5af","updated":"2025-12-04 14:02:28.000000000","message":"++\n\nI will update the code with:\n\n```suggestion\n     else:\n        self.session \u003d requests.Session()\n        if ca_cert is not None:\n            self.session.verify \u003d ca_cert\n        if cert_cert is not None and cert_key is not None:\n            self.session.cert \u003d (cert_cert, cert_key)\n    self.timeout \u003d timeout\n    self._api_path \u003d api_path\n```","commit_id":"35b919c7ee12206420ef3688f1d9b46c94c26b23"}],"releasenotes/notes/client-configurable-session-ae1b68a0e4bd894f.yaml":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"bc26837e85c14e8d8ff6878f08660cf151c731a9","unresolved":true,"context_lines":[{"line_number":3,"context_line":"    - |"},{"line_number":4,"context_line":"      Now, we are able to pass optional ``session`` parameter to Etcd3Client"},{"line_number":5,"context_line":"      allowing users to provide a pre-configured requests.Session object with"},{"line_number":6,"context_line":"      custom pool settings etc. checkout the #2125229 for more details."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b9b479d8_3713415d","line":6,"range":{"start_line":6,"start_character":46,"end_line":6,"end_character":53},"updated":"2025-12-03 13:29:52.000000000","message":"Not sure it will render properly at doc build... I wonder if we shouldn\u0027t prefer the link instead of the launchpad number.","commit_id":"ad9a986ec438ff1f02bbcf1699f8e5d6f0f2158c"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"532dc3bcd9346c1906694a4ce2f9ed689a74b1a0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    - |"},{"line_number":4,"context_line":"      Now, we are able to pass optional ``session`` parameter to Etcd3Client"},{"line_number":5,"context_line":"      allowing users to provide a pre-configured requests.Session object with"},{"line_number":6,"context_line":"      custom pool settings etc. checkout the #2125229 for more details."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d61760bc_8149daf0","line":6,"range":{"start_line":6,"start_character":46,"end_line":6,"end_character":53},"in_reply_to":"b9b479d8_3713415d","updated":"2025-12-03 14:13:40.000000000","message":"Done","commit_id":"ad9a986ec438ff1f02bbcf1699f8e5d6f0f2158c"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"78a7fee54503c7b70468059c625a874505496e3b","unresolved":true,"context_lines":[{"line_number":2,"context_line":"  features:"},{"line_number":3,"context_line":"    - |"},{"line_number":4,"context_line":"      Now, we are able to pass optional ``session`` parameter to Etcd3Client"},{"line_number":5,"context_line":"      allowing users to provide a pre-configured requests.Session object with"},{"line_number":6,"context_line":"      custom pool settings etc."},{"line_number":7,"context_line":"      checkout https://bugs.launchpad.net/python-etcd3gw/+bug/2125229 for"},{"line_number":8,"context_line":"      more details."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba193795_d003966a","line":5,"range":{"start_line":5,"start_character":57,"end_line":5,"end_character":58},"updated":"2025-12-03 15:18:17.000000000","message":"nit/suggestion: ``requests.Session`` ?","commit_id":"5ae4eda55b10bad1c68f338ce74306a7c35bebfe"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"b3793b93b7a493ba47b4ef20ea209139542a873d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  features:"},{"line_number":3,"context_line":"    - |"},{"line_number":4,"context_line":"      Now, we are able to pass optional ``session`` parameter to Etcd3Client"},{"line_number":5,"context_line":"      allowing users to provide a pre-configured requests.Session object with"},{"line_number":6,"context_line":"      custom pool settings etc."},{"line_number":7,"context_line":"      checkout https://bugs.launchpad.net/python-etcd3gw/+bug/2125229 for"},{"line_number":8,"context_line":"      more details."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"21edc476_c2c6041d","line":5,"range":{"start_line":5,"start_character":57,"end_line":5,"end_character":58},"in_reply_to":"99a920ca_7cbfc98c","updated":"2025-12-03 15:26:20.000000000","message":"Done","commit_id":"5ae4eda55b10bad1c68f338ce74306a7c35bebfe"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"f291545f48c75d9edd834e94484d89ae22a62982","unresolved":true,"context_lines":[{"line_number":2,"context_line":"  features:"},{"line_number":3,"context_line":"    - |"},{"line_number":4,"context_line":"      Now, we are able to pass optional ``session`` parameter to Etcd3Client"},{"line_number":5,"context_line":"      allowing users to provide a pre-configured requests.Session object with"},{"line_number":6,"context_line":"      custom pool settings etc."},{"line_number":7,"context_line":"      checkout https://bugs.launchpad.net/python-etcd3gw/+bug/2125229 for"},{"line_number":8,"context_line":"      more details."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"99a920ca_7cbfc98c","line":5,"range":{"start_line":5,"start_character":57,"end_line":5,"end_character":58},"in_reply_to":"ba193795_d003966a","updated":"2025-12-03 15:19:56.000000000","message":"Oops, gerrit UI :)\n\nI mean add double backticks to make request.Session render as ``reguest.Session`` in the built docs.","commit_id":"5ae4eda55b10bad1c68f338ce74306a7c35bebfe"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"78a7fee54503c7b70468059c625a874505496e3b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"      Now, we are able to pass optional ``session`` parameter to Etcd3Client"},{"line_number":5,"context_line":"      allowing users to provide a pre-configured requests.Session object with"},{"line_number":6,"context_line":"      custom pool settings etc."},{"line_number":7,"context_line":"      checkout https://bugs.launchpad.net/python-etcd3gw/+bug/2125229 for"},{"line_number":8,"context_line":"      more details."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d81146ae_c764d958","line":8,"range":{"start_line":7,"start_character":5,"end_line":8,"end_character":19},"updated":"2025-12-03 15:18:17.000000000","message":"It is common to use:\n\n```\nSee bug `2125229 \u003chttps://bugs.launchpad.net/python-etcd3gw/+bug/2125229\u003e`_ for details.\n```\n\nThat will render a link in html docs.","commit_id":"5ae4eda55b10bad1c68f338ce74306a7c35bebfe"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"223ee93ff6ee25b68e918449f649b4cfaf15c306","unresolved":false,"context_lines":[{"line_number":4,"context_line":"      Now, we are able to pass optional ``session`` parameter to Etcd3Client"},{"line_number":5,"context_line":"      allowing users to provide a pre-configured requests.Session object with"},{"line_number":6,"context_line":"      custom pool settings etc."},{"line_number":7,"context_line":"      checkout https://bugs.launchpad.net/python-etcd3gw/+bug/2125229 for"},{"line_number":8,"context_line":"      more details."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ae18bca3_06b65868","line":8,"range":{"start_line":7,"start_character":5,"end_line":8,"end_character":19},"in_reply_to":"d81146ae_c764d958","updated":"2025-12-03 15:34:11.000000000","message":"Done","commit_id":"5ae4eda55b10bad1c68f338ce74306a7c35bebfe"}]}