)]}'
{"freezer_api/api/common/middleware.py":[{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"79cb3445d66ebb39e47ab0fba75e7f152922842d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        if isinstance(resp.body, dict):"},{"line_number":28,"context_line":"            try:"},{"line_number":29,"context_line":"                resp.body \u003d json.dumps(resp.body)"},{"line_number":30,"context_line":"            except Exception:"},{"line_number":31,"context_line":"                raise freezer_api_exc.FreezerAPIException("},{"line_number":32,"context_line":"                    \u0027Internal server error: malformed json reply\u0027)"},{"line_number":33,"context_line":"    return resp"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_109b6073","line":30,"updated":"2016-02-29 12:24:26.000000000","message":"Any reason for this change? Do we need to deal with some exceptions, e.g. KeyboardInterrupt. or is there a plan to handle Exception as e later on?","commit_id":"8d220b56a7a6ba06a396e7bfc569fe773700cbe8"},{"author":{"_account_id":11151,"name":"Fausto Marzi","email":"fausto.marzi@ericsson.com","username":"fausto.marzi"},"change_message_id":"3de560d03d1744a2d5b0d5d09f4804d18f283c5a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        if isinstance(resp.body, dict):"},{"line_number":28,"context_line":"            try:"},{"line_number":29,"context_line":"                resp.body \u003d json.dumps(resp.body)"},{"line_number":30,"context_line":"            except Exception:"},{"line_number":31,"context_line":"                raise freezer_api_exc.FreezerAPIException("},{"line_number":32,"context_line":"                    \u0027Internal server error: malformed json reply\u0027)"},{"line_number":33,"context_line":"    return resp"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_5b898974","line":30,"in_reply_to":"9aed3d3a_109b6073","updated":"2016-02-29 12:29:17.000000000","message":"just only with except new flake8 version fail, so the pep8 job would fail.","commit_id":"8d220b56a7a6ba06a396e7bfc569fe773700cbe8"}],"freezer_api/api/v1/jobs.py":[{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"79cb3445d66ebb39e47ab0fba75e7f152922842d","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        try:"},{"line_number":159,"context_line":"            event, params \u003d next(iteritems(doc))"},{"line_number":160,"context_line":"        except Exception:"},{"line_number":161,"context_line":"            raise freezer_api_exc.BadDataFormat(\"Bad event request format\")"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        job_doc \u003d self.db.get_job(user_id\u003duser_id,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_90ead0aa","line":160,"updated":"2016-02-29 12:24:26.000000000","message":"ditto","commit_id":"8d220b56a7a6ba06a396e7bfc569fe773700cbe8"},{"author":{"_account_id":11151,"name":"Fausto Marzi","email":"fausto.marzi@ericsson.com","username":"fausto.marzi"},"change_message_id":"3de560d03d1744a2d5b0d5d09f4804d18f283c5a","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        try:"},{"line_number":159,"context_line":"            event, params \u003d next(iteritems(doc))"},{"line_number":160,"context_line":"        except Exception:"},{"line_number":161,"context_line":"            raise freezer_api_exc.BadDataFormat(\"Bad event request format\")"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        job_doc \u003d self.db.get_job(user_id\u003duser_id,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_fbdfbd66","line":160,"in_reply_to":"9aed3d3a_90ead0aa","updated":"2016-02-29 12:29:17.000000000","message":"Yes same here, the pep8 gate job would fail.","commit_id":"8d220b56a7a6ba06a396e7bfc569fe773700cbe8"}],"freezer_api/api/v1/sessions.py":[{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"79cb3445d66ebb39e47ab0fba75e7f152922842d","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        try:"},{"line_number":119,"context_line":"            action, params \u003d next(iteritems(doc))"},{"line_number":120,"context_line":"        except Exception:"},{"line_number":121,"context_line":"            raise freezer_api_exc.BadDataFormat(\"Bad action request format\")"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        session_doc \u003d self.db.get_session(user_id\u003duser_id,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_30dae417","line":120,"updated":"2016-02-29 12:24:26.000000000","message":"ditto","commit_id":"8d220b56a7a6ba06a396e7bfc569fe773700cbe8"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"79cb3445d66ebb39e47ab0fba75e7f152922842d","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    def set_job_end(self, job_id, result, timestamp):"},{"line_number":244,"context_line":"        try:"},{"line_number":245,"context_line":"            job \u003d self.doc[\u0027jobs\u0027][job_id]"},{"line_number":246,"context_line":"        except Exception:"},{"line_number":247,"context_line":"            raise freezer_api_exc.BadDataFormat(\u0027job_id not found in session\u0027)"},{"line_number":248,"context_line":"        job[\u0027status\u0027] \u003d \u0027completed\u0027"},{"line_number":249,"context_line":"        job[\u0027result\u0027] \u003d result"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_b0fc3473","line":246,"updated":"2016-02-29 12:24:26.000000000","message":"ditto, and in general ;)","commit_id":"8d220b56a7a6ba06a396e7bfc569fe773700cbe8"}],"freezer_api/common/json_schemas.py":[{"author":{"_account_id":14509,"name":"Pierre Mathieu","email":"pierre-arthur.mathieu@hpe.com","username":"slashme"},"change_message_id":"548b697d69a778dc31c460dc75d4c9d91682bb01","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\""},{"line_number":17,"context_line":"import copy "},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"freezer_action_properties \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_5b06a91d","line":17,"range":{"start_line":17,"start_character":11,"end_line":17,"end_character":12},"updated":"2016-02-29 12:24:16.000000000","message":"Please remove whitespace","commit_id":"8d220b56a7a6ba06a396e7bfc569fe773700cbe8"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"79cb3445d66ebb39e47ab0fba75e7f152922842d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\""},{"line_number":17,"context_line":"import copy "},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"freezer_action_properties \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_5067a84c","line":17,"updated":"2016-02-29 12:24:26.000000000","message":"please remove the extra space","commit_id":"8d220b56a7a6ba06a396e7bfc569fe773700cbe8"},{"author":{"_account_id":11151,"name":"Fausto Marzi","email":"fausto.marzi@ericsson.com","username":"fausto.marzi"},"change_message_id":"3de560d03d1744a2d5b0d5d09f4804d18f283c5a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\""},{"line_number":17,"context_line":"import copy "},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"freezer_action_properties \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_7b39eda3","line":17,"in_reply_to":"9aed3d3a_5067a84c","updated":"2016-02-29 12:29:17.000000000","message":"Done","commit_id":"8d220b56a7a6ba06a396e7bfc569fe773700cbe8"}],"tox.ini":[{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"79cb3445d66ebb39e47ab0fba75e7f152922842d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"setenv \u003d OS_PATH_TEST \u003d ./freezer_api/tests/unit"},{"line_number":39,"context_line":"commands \u003d"},{"line_number":40,"context_line":"    find . -type f -name \"*.pyc\" -delete"},{"line_number":41,"context_line":"    rm -rf .testrepository"},{"line_number":42,"context_line":"    python setup.py test --coverage --coverage-package-name freezer_api --testr-args\u003d\"{posargs}\""},{"line_number":43,"context_line":"    coverage report -m"},{"line_number":44,"context_line":"    rm -f .coverage"}],"source_content_type":"text/x-properties","patch_set":14,"id":"9aed3d3a_bb1ed55c","line":41,"updated":"2016-02-29 12:24:26.000000000","message":"isn\u0027t this duplicated? If the testenv clears it after running I see no need for this code to be around again. Am I missing something?","commit_id":"8d220b56a7a6ba06a396e7bfc569fe773700cbe8"},{"author":{"_account_id":11151,"name":"Fausto Marzi","email":"fausto.marzi@ericsson.com","username":"fausto.marzi"},"change_message_id":"3de560d03d1744a2d5b0d5d09f4804d18f283c5a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"setenv \u003d OS_PATH_TEST \u003d ./freezer_api/tests/unit"},{"line_number":39,"context_line":"commands \u003d"},{"line_number":40,"context_line":"    find . -type f -name \"*.pyc\" -delete"},{"line_number":41,"context_line":"    rm -rf .testrepository"},{"line_number":42,"context_line":"    python setup.py test --coverage --coverage-package-name freezer_api --testr-args\u003d\"{posargs}\""},{"line_number":43,"context_line":"    coverage report -m"},{"line_number":44,"context_line":"    rm -f .coverage"}],"source_content_type":"text/x-properties","patch_set":14,"id":"9aed3d3a_fbfb3dbf","line":41,"in_reply_to":"9aed3d3a_bb1ed55c","updated":"2016-02-29 12:29:17.000000000","message":"I agree, no one uses it, but locally in the dev environment, if the tests fail the .testsrepository is not removed, so I need to remove it by hand. But you are right, it\u0027s not necessary.","commit_id":"8d220b56a7a6ba06a396e7bfc569fe773700cbe8"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"acaec4cc500e69ad1cad43741de1c74cd2e25b54","unresolved":false,"context_lines":[{"line_number":38,"context_line":"setenv \u003d OS_PATH_TEST \u003d ./freezer_api/tests/unit"},{"line_number":39,"context_line":"commands \u003d"},{"line_number":40,"context_line":"    find . -type f -name \"*.pyc\" -delete"},{"line_number":41,"context_line":"    rm -rf .testrepository"},{"line_number":42,"context_line":"    python setup.py test --coverage --coverage-package-name freezer_api --testr-args\u003d\"{posargs}\""},{"line_number":43,"context_line":"    coverage report -m"},{"line_number":44,"context_line":"    rm -f .coverage"}],"source_content_type":"text/x-properties","patch_set":14,"id":"9aed3d3a_5ba8698d","line":41,"in_reply_to":"9aed3d3a_fbfb3dbf","updated":"2016-02-29 12:32:27.000000000","message":"Let\u0027s address this on a different patch, I\u0027ll +1 for now, thanks!","commit_id":"8d220b56a7a6ba06a396e7bfc569fe773700cbe8"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"79cb3445d66ebb39e47ab0fba75e7f152922842d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"setenv \u003d OS_PATH_TEST \u003d ./freezer_api/tests/unit"},{"line_number":51,"context_line":"commands \u003d"},{"line_number":52,"context_line":"    find . -type f -name \"*.pyc\" -delete"},{"line_number":53,"context_line":"    rm -rf .testrepository"},{"line_number":54,"context_line":"    python setup.py test --coverage --coverage-package-name freezer_api --testr-args\u003d\"{posargs}\""},{"line_number":55,"context_line":"    coverage report -m"},{"line_number":56,"context_line":"    rm -f .coverage"}],"source_content_type":"text/x-properties","patch_set":14,"id":"9aed3d3a_3b33e5f7","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":26},"updated":"2016-02-29 12:24:26.000000000","message":"ditto","commit_id":"8d220b56a7a6ba06a396e7bfc569fe773700cbe8"}]}