)]}'
{"freezer_api/cmd/manage.py":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"5cb272bc068083972f39a019d2a420d823862a86","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            return self.elk.indices.delete_mapping(self.index,"},{"line_number":249,"context_line":"                                                   doc_type\u003ddoc_type)"},{"line_number":250,"context_line":"        except Exception:"},{"line_number":251,"context_line":"            raise"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def remove_mappings(self):"},{"line_number":254,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_7ad0fc53","line":251,"updated":"2016-07-11 12:12:24.000000000","message":"I think this change has no sense. The only reason it was done before is hide stack trace. But this construction is absolutely useless and if you remove this lines of code it will be the same :)","commit_id":"1005276a280be6d4f804b80c8dc88720ef952019"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"acfa5bc3f9af96eb98a94ef0c2c84767ba34515f","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            return self.elk.indices.delete_mapping(self.index,"},{"line_number":249,"context_line":"                                                   doc_type\u003ddoc_type)"},{"line_number":250,"context_line":"        except Exception:"},{"line_number":251,"context_line":"            raise"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def remove_mappings(self):"},{"line_number":254,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_230176af","line":251,"in_reply_to":"1aa78d24_7ad0fc53","updated":"2016-07-16 02:10:36.000000000","message":"Done","commit_id":"1005276a280be6d4f804b80c8dc88720ef952019"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"5847bee7d3b18513400612d8264afbd056b65fe7","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        \"\"\""},{"line_number":245,"context_line":"        LOG.info(\u0027Removing mapping {0} from index {1}\u0027.format(doc_type,"},{"line_number":246,"context_line":"                                                              self.index))"},{"line_number":247,"context_line":"        try:"},{"line_number":248,"context_line":"            return self.elk.indices.delete_mapping(self.index,"},{"line_number":249,"context_line":"                                                   doc_type\u003ddoc_type)"},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_ee3745e1","line":247,"updated":"2016-07-16 02:18:46.000000000","message":"There is no reason to have this try here if there is no except block.","commit_id":"7f3618f2c57cf3636da14ff92c456456d232ee14"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"1cb76206d6145636a4b42679a6c1d2d1352e01bf","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        \"\"\""},{"line_number":245,"context_line":"        LOG.info(\u0027Removing mapping {0} from index {1}\u0027.format(doc_type,"},{"line_number":246,"context_line":"                                                              self.index))"},{"line_number":247,"context_line":"        try:"},{"line_number":248,"context_line":"            return self.elk.indices.delete_mapping(self.index,"},{"line_number":249,"context_line":"                                                   doc_type\u003ddoc_type)"},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_8ed32938","line":247,"in_reply_to":"fad55976_ee3745e1","updated":"2016-07-16 02:22:40.000000000","message":"In fact, this won\u0027t even run. It gives \u0027syntax error\u0027.","commit_id":"7f3618f2c57cf3636da14ff92c456456d232ee14"},{"author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"change_message_id":"76d9756385e43f9bc27baafbad7aacdbf5b04bb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dada55a8_33025370","updated":"2016-07-19 08:40:53.000000000","message":"Will the exception from elk.indices.delete_mapping be processed by caller?","commit_id":"46adcc7a7980046326f7aae144d40ea4c425d05b"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"e3becfe736fbd1ed4072da3412d3191e0843e06f","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        LOG.info(\u0027check if index: {0} exists or not\u0027.format(index))"},{"line_number":137,"context_line":"        try:"},{"line_number":138,"context_line":"            return self.elk.indices.exists(index\u003dindex)"},{"line_number":139,"context_line":"        except elasticsearch.TransportError:"},{"line_number":140,"context_line":"            raise"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def _check_mapping_exists(self, mappings):"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_f457f8ff","line":139,"updated":"2016-07-19 12:06:11.000000000","message":"Catching and then raising the same exception is the same as not catching any exception. Should probably log something and then raise the exception.","commit_id":"46adcc7a7980046326f7aae144d40ea4c425d05b"}]}