)]}'
{"freezer_api/cmd/manage.py":[{"author":{"_account_id":15041,"name":"Domhnall Walsh","email":"domhnall.eam.walsh@hpe.com","username":"domhnall"},"change_message_id":"196efcc9d92e0d28e854a72513dfde09345179bf","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":"from oslo_log import log"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import elasticsearch"},{"line_number":25,"context_line":"from elasticsearch.exceptions import NotFoundError, TransportError"},{"line_number":26,"context_line":"import requests"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from freezer_api import __version__ as FREEZER_API_VERSION"},{"line_number":29,"context_line":"from freezer_api.common.config import setup_logging"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_ca4f5b90","line":26,"range":{"start_line":24,"start_character":1,"end_line":26,"end_character":15},"updated":"2016-07-26 16:15:37.000000000","message":"In the wrong place, see Hacking guidelines :)","commit_id":"32332a7ff79f4fb34b1b1f49ee35dfd8957192bb"},{"author":{"_account_id":15041,"name":"Domhnall Walsh","email":"domhnall.eam.walsh@hpe.com","username":"domhnall"},"change_message_id":"1e8c00c5abde07ba5f8a108f8f463ee98e4e7eaa","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":"from oslo_log import log"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import elasticsearch"},{"line_number":25,"context_line":"from elasticsearch.exceptions import NotFoundError, TransportError"},{"line_number":26,"context_line":"import requests"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from freezer_api import __version__ as FREEZER_API_VERSION"},{"line_number":29,"context_line":"from freezer_api.common.config import setup_logging"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_bcb0ebf5","line":26,"range":{"start_line":24,"start_character":1,"end_line":26,"end_character":15},"in_reply_to":"dada55a8_ca4f5b90","updated":"2016-07-28 10:44:35.000000000","message":"Sorry, my mistake, I think. :(","commit_id":"32332a7ff79f4fb34b1b1f49ee35dfd8957192bb"},{"author":{"_account_id":14340,"name":"Memo Garcia","email":"guillermo.ramirez-garcia@hp.com","username":"memogarcia"},"change_message_id":"0a37b5c7fce60a9a17915a260e895d47bcfa4f5d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":"from oslo_log import log"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import elasticsearch"},{"line_number":25,"context_line":"from elasticsearch.exceptions import NotFoundError, TransportError"},{"line_number":26,"context_line":"import requests"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from freezer_api import __version__ as FREEZER_API_VERSION"},{"line_number":29,"context_line":"from freezer_api.common.config import setup_logging"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_fc5b8352","line":26,"range":{"start_line":24,"start_character":1,"end_line":26,"end_character":15},"in_reply_to":"dada55a8_ca4f5b90","updated":"2016-07-28 10:42:39.000000000","message":"requests is not part of the standard library","commit_id":"32332a7ff79f4fb34b1b1f49ee35dfd8957192bb"},{"author":{"_account_id":15041,"name":"Domhnall Walsh","email":"domhnall.eam.walsh@hpe.com","username":"domhnall"},"change_message_id":"196efcc9d92e0d28e854a72513dfde09345179bf","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        if current_version.endswith(self.index):"},{"line_number":190,"context_line":"            return \u0027{0}_v{1}\u0027.format(self.index, self.mapping_version)"},{"line_number":191,"context_line":"        else:"},{"line_number":192,"context_line":"            version \u003d current_version[9:]  # this may fail"},{"line_number":193,"context_line":"            version \u003d int(version) + 1"},{"line_number":194,"context_line":"            return \u0027{0}_v{1}\u0027.format(self.index, str(version))"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_5eeb30dc","line":192,"range":{"start_line":192,"start_character":38,"end_line":192,"end_character":40},"updated":"2016-07-26 16:15:37.000000000","message":"is this the length of \u0027freezer_v\u0027? It looks a bit \"magic\" the way it\u0027s written here, maybe a string.split() or a regex would look less magical :)","commit_id":"32332a7ff79f4fb34b1b1f49ee35dfd8957192bb"},{"author":{"_account_id":14340,"name":"Memo Garcia","email":"guillermo.ramirez-garcia@hp.com","username":"memogarcia"},"change_message_id":"0a37b5c7fce60a9a17915a260e895d47bcfa4f5d","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        if current_version.endswith(self.index):"},{"line_number":190,"context_line":"            return \u0027{0}_v{1}\u0027.format(self.index, self.mapping_version)"},{"line_number":191,"context_line":"        else:"},{"line_number":192,"context_line":"            version \u003d current_version[9:]  # this may fail"},{"line_number":193,"context_line":"            version \u003d int(version) + 1"},{"line_number":194,"context_line":"            return \u0027{0}_v{1}\u0027.format(self.index, str(version))"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_bcbbcb71","line":192,"range":{"start_line":192,"start_character":38,"end_line":192,"end_character":40},"in_reply_to":"dada55a8_5eeb30dc","updated":"2016-07-28 10:42:39.000000000","message":"done, thanks","commit_id":"32332a7ff79f4fb34b1b1f49ee35dfd8957192bb"},{"author":{"_account_id":15041,"name":"Domhnall Walsh","email":"domhnall.eam.walsh@hpe.com","username":"domhnall"},"change_message_id":"196efcc9d92e0d28e854a72513dfde09345179bf","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                \u0027version_type\u0027: \u0027external\u0027"},{"line_number":204,"context_line":"            }"},{"line_number":205,"context_line":"        }"},{"line_number":206,"context_line":"        reindex_url \u003d \u0027{0}{1}\u0027.format(self.endpoint, \u0027/_reindex\u0027)"},{"line_number":207,"context_line":"        r \u003d requests.post(reindex_url, data\u003djson.dumps(payload))"},{"line_number":208,"context_line":"        return r.text"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_fe082482","line":206,"range":{"start_line":206,"start_character":8,"end_line":206,"end_character":65},"updated":"2016-07-26 16:15:37.000000000","message":"I\u0027m worried by this phrase in the ES 2.3 docs: \"Warning: The reindex API is new and should still be considered experimental. The API may change in ways that are not backwards compatible.\"\n\nNot sure what else you could do though :(","commit_id":"32332a7ff79f4fb34b1b1f49ee35dfd8957192bb"},{"author":{"_account_id":14340,"name":"Memo Garcia","email":"guillermo.ramirez-garcia@hp.com","username":"memogarcia"},"change_message_id":"0a37b5c7fce60a9a17915a260e895d47bcfa4f5d","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                \u0027version_type\u0027: \u0027external\u0027"},{"line_number":204,"context_line":"            }"},{"line_number":205,"context_line":"        }"},{"line_number":206,"context_line":"        reindex_url \u003d \u0027{0}{1}\u0027.format(self.endpoint, \u0027/_reindex\u0027)"},{"line_number":207,"context_line":"        r \u003d requests.post(reindex_url, data\u003djson.dumps(payload))"},{"line_number":208,"context_line":"        return r.text"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_5c944fe1","line":206,"range":{"start_line":206,"start_character":8,"end_line":206,"end_character":65},"in_reply_to":"dada55a8_fe082482","updated":"2016-07-28 10:42:39.000000000","message":"we can implement this feature manually, but I don\u0027t want to read all the data from the index and then send it back to es. it may take a while, but not so sure what should we do here.","commit_id":"32332a7ff79f4fb34b1b1f49ee35dfd8957192bb"},{"author":{"_account_id":15041,"name":"Domhnall Walsh","email":"domhnall.eam.walsh@hpe.com","username":"domhnall"},"change_message_id":"37ec78eaf701a21b09bb28f1a229dac987b830cc","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        if current_version.endswith(self.index):"},{"line_number":190,"context_line":"            return \u0027{0}_v{1}\u0027.format(self.index, self.mapping_version)"},{"line_number":191,"context_line":"        else:"},{"line_number":192,"context_line":"            version \u003d current_version.split(\u0027_\u0027)[1]"},{"line_number":193,"context_line":"            version \u003d version.split(\u0027v\u0027)[1]"},{"line_number":194,"context_line":"            version \u003d int(version) + 1"},{"line_number":195,"context_line":"            return \u0027{0}_v{1}\u0027.format(self.index, str(version))"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_7fcca535","line":193,"range":{"start_line":192,"start_character":0,"end_line":193,"end_character":43},"updated":"2016-07-28 10:57:03.000000000","message":"Would \"version\u003dcurrent_version.split(\u0027_v\u0027)[1]\" be easier to understand here?","commit_id":"0b09c814b81deb4dd6bbbcc912924dd505220dc6"}]}
