)]}'
{"id":"openstack%2Ffreezer-api~614409","triplet_id":"openstack%2Ffreezer-api~master~I7b63bcb4e5c13b524a5c2e6edb6e061fb17c0f06","project":"openstack/freezer-api","branch":"master","topic":"register-backend-in-elasticv2","hashtags":[],"change_id":"I7b63bcb4e5c13b524a5c2e6edb6e061fb17c0f06","subject":"register elasticv2 backend options","status":"ABANDONED","created":"2018-10-31 06:29:17.000000000","updated":"2024-12-03 18:11:37.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6cffbdc7f21a36ed4d674f18bacd36514c6a5d23","_number":614409,"virtual_id_number":614409,"owner":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},{"date":"2018-11-01 01:41:42.000000000","_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},{"value":1,"date":"2018-10-31 07:13:38.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"disliked":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"all":[{"value":-2,"date":"2019-01-08 08:12:23.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},{"value":-1,"date":"2018-10-31 08:00:31.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-10-31 07:13:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-10-31 08:00:31.000000000","updated_by":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"reviewer":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"state":"REVIEWER"},{"updated":"2019-01-08 08:12:23.000000000","updated_by":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"reviewer":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"state":"REVIEWER"}],"messages":[{"id":"6ab8b42a84d8f6785fc587c41e03438071785f3d","author":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"date":"2018-10-31 06:29:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bc3173d01f34122f72a8453ff46d77c7b60a1a50","author":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"date":"2018-10-31 06:32:11.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"414959e657665eceebfa0f1dda27bc5a7294f29c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-31 07:13:38.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/09/614409/2/check/openstack-tox-pep8/b930d2a/ : SUCCESS in 3m 07s\n- openstack-tox-py27 http://logs.openstack.org/09/614409/2/check/openstack-tox-py27/56ac9b1/ : SUCCESS in 3m 51s\n- openstack-tox-py35 http://logs.openstack.org/09/614409/2/check/openstack-tox-py35/b09b096/ : SUCCESS in 4m 29s\n- openstack-tox-py36 http://logs.openstack.org/09/614409/2/check/openstack-tox-py36/780b156/ : SUCCESS in 4m 02s\n- freezer-api-ubuntu-xenial http://logs.openstack.org/09/614409/2/check/freezer-api-ubuntu-xenial/ae092aa/ : SUCCESS in 30m 51s\n- freezer-api-centos-7 http://logs.openstack.org/09/614409/2/check/freezer-api-centos-7/fa06dc8/ : SUCCESS in 38m 49s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/09/614409/2/check/openstack-tox-lower-constraints/3fdd2bf/ : SUCCESS in 4m 29s\n- openstack-tox-pylint http://logs.openstack.org/09/614409/2/check/openstack-tox-pylint/3145e87/ : SUCCESS in 4m 29s\n- freezer-tempest-basic http://logs.openstack.org/09/614409/2/check/freezer-tempest-basic/b608302/ : SUCCESS in 34m 58s","accounts_in_message":[],"_revision_number":2},{"id":"821727126bbf0a58d4df37375b217c21c8be2f4d","author":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"date":"2018-10-31 08:00:31.000000000","message":"Patch Set 2: Code-Review-1\n\ncurently, freezer-api only support elasticv2, in CONF ,\n[storage]\ndriver \u003d elasticsearch\nbackend \u003d elasticsearch","accounts_in_message":[],"_revision_number":2},{"id":"175f55a4d48862703113d5a0f3e70be1d20c75fa","author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"date":"2018-10-31 14:33:48.000000000","message":"Patch Set 2:\n\ngecong, I\u0027m not sure what you are saying?","accounts_in_message":[],"_revision_number":2},{"id":"99d5b4ea344794a9ccfc59eaee609633cb8aed01","author":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"date":"2018-11-01 00:46:07.000000000","message":"Patch Set 2:\n\n\u003e gecong, I\u0027m not sure what you are saying?\n\nHi,Trinh Nguyen! There are many problems about freezer-api v1 and v2.\nAt present, Elastic engine is written dead, V1 no longer supports：\ndb/elastic/driver.py:\nDef get_engine (self):\n    If not self._engine:\n        Self._engine \u003d db_session.ElasticSearchEngineV2 (self.backend)\n    Return self._engine\nActually, there is enable_v1_api and enable_v2_api ,but it is not used reasonably, I would like to revise it, such as creating a BP or a common patch.","accounts_in_message":[],"_revision_number":2},{"id":"267cf4d190a2a30303b2bf978fed5fa9c37f8470","author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"date":"2018-11-01 00:50:48.000000000","message":"Patch Set 2:\n\nOk. Let\u0027s do it in another patchset. Thanks.","accounts_in_message":[],"_revision_number":2},{"id":"048e124135cc909d3390f480bfd0d5504c1a5f17","author":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"date":"2018-11-01 01:41:42.000000000","message":"Patch Set 2:\n\n\u003e curently, freezer-api only support elasticv2, in CONF ,\n \u003e [storage]\n \u003e driver \u003d elasticsearch\n \u003e backend \u003d elasticsearch\n\nSo is this configuration correct or not https://docs.openstack.org/freezer/queens/install/install-rdo.html#install-and-configure-components ?\n[storage]\n...\nbackend \u003d elasticv2\ndriver \u003d freezer_api.storage.elasticv2.ElasticSearchEngineV2","accounts_in_message":[],"_revision_number":2},{"id":"acd4bc80a87a55debda71184e59c0e16d5d94178","author":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"date":"2018-11-01 07:56:03.000000000","message":"Patch Set 2:\n\n\u003e \u003e curently, freezer-api only support elasticv2, in CONF ,\n \u003e \u003e [storage]\n \u003e \u003e driver \u003d elasticsearch\n \u003e \u003e backend \u003d elasticsearch\n \u003e \n \u003e So is this configuration correct or not https://docs.openstack.org/freezer/queens/install/install-rdo.html#install-and-configure-components\n \u003e ?\n \u003e [storage]\n \u003e ...\n \u003e backend \u003d elasticv2\n \u003e driver \u003d freezer_api.storage.elasticv2.ElasticSearchEngineV2\n\nthe doc is not correct. in the patch https://review.openstack.org/#/c/614689/ , we are implementing freezer-api v1 and v2 support. after that , you may correct the doc, thanks","accounts_in_message":[],"_revision_number":2},{"id":"15046678bf403727e0171703d7606f89c09e083d","author":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"date":"2019-01-08 08:12:23.000000000","message":"Patch Set 2: Code-Review-2\n\nThe configuration item about _OPTS is defined in db/elasticsearch/drvier.py, such as ElasticSearchDB._ES_OPTS.\nDistinguish elasticV1 and elasticv2 with enable_v1_api. Such as enable_v1_api\u003dTrue, it is elasticv1, otherwise it is elasticv2.\nI suggest that the patch is abandoned.","accounts_in_message":[],"_revision_number":2},{"id":"6cffbdc7f21a36ed4d674f18bacd36514c6a5d23","tag":"autogenerated:gerrit:abandon","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2024-12-03 18:11:37.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"be2ea46de7278bbf96e9d169db59d5ed6f9f2361","revisions":{"21ac0db074e34b8d8b902c196048e7428201406b":{"kind":"REWORK","_number":1,"created":"2018-10-31 06:29:17.000000000","uploader":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"ref":"refs/changes/09/614409/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/freezer-api","ref":"refs/changes/09/614409/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/freezer-api refs/changes/09/614409/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/freezer-api refs/changes/09/614409/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/freezer-api refs/changes/09/614409/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/freezer-api refs/changes/09/614409/1"}}},"commit":{"parents":[{"commit":"d5ceed835c573fdfe9bcade04eb38fcabca8fe18","subject":"Merge \"Add devstack sqlalchemy support for freezer\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/freezer-api/commit/d5ceed835c573fdfe9bcade04eb38fcabca8fe18"}]}],"author":{"name":"Mike Chen","email":"dstbtgagt@foxmail.com","date":"2018-10-31 06:24:33.000000000","tz":480},"committer":{"name":"Mike Chen","email":"dstbtgagt@foxmail.com","date":"2018-10-31 06:24:33.000000000","tz":480},"subject":"register elasticv2 backend options","message":"register elasticv2 backend options\n\nWe need to register the group and options to CONF in elasticv2 just\nlike in the elastic backend. Otherwise elasticv2 will not work and\nfreezer API will fail.\n\nChange-Id: I7b63bcb4e5c13b524a5c2e6edb6e061fb17c0f06\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/freezer-api/commit/21ac0db074e34b8d8b902c196048e7428201406b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/freezer-api/commit/21ac0db074e34b8d8b902c196048e7428201406b"}]},"branch":"refs/heads/master"},"be2ea46de7278bbf96e9d169db59d5ed6f9f2361":{"kind":"REWORK","_number":2,"created":"2018-10-31 06:32:11.000000000","uploader":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"ref":"refs/changes/09/614409/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/freezer-api","ref":"refs/changes/09/614409/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/freezer-api refs/changes/09/614409/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/freezer-api refs/changes/09/614409/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/freezer-api refs/changes/09/614409/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/freezer-api refs/changes/09/614409/2"}}},"commit":{"parents":[{"commit":"d5ceed835c573fdfe9bcade04eb38fcabca8fe18","subject":"Merge \"Add devstack sqlalchemy support for freezer\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/freezer-api/commit/d5ceed835c573fdfe9bcade04eb38fcabca8fe18"}]}],"author":{"name":"Mike Chen","email":"dstbtgagt@foxmail.com","date":"2018-10-31 06:24:33.000000000","tz":480},"committer":{"name":"Mike Chen","email":"dstbtgagt@foxmail.com","date":"2018-10-31 06:31:47.000000000","tz":480},"subject":"register elasticv2 backend options","message":"register elasticv2 backend options\n\nWe need to register the group and options to CONF in elasticv2 just\nlike in the elastic backend. Otherwise elasticv2 will not work and\nfreezer API will fail.\n\nChange-Id: I7b63bcb4e5c13b524a5c2e6edb6e061fb17c0f06\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/freezer-api/commit/be2ea46de7278bbf96e9d169db59d5ed6f9f2361"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/freezer-api/commit/be2ea46de7278bbf96e9d169db59d5ed6f9f2361"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":["label:Code-Review\u003dMIN"],"failing_atoms":["label:Code-Review\u003dMAX"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}