)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"change_message_id":"b2599e025e763012e4fc75511480477505355fce","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Domhnall Walsh \u003cdomhnall.eam.walsh@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-23 15:59:16 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding a dummy monitoring driver and making NotifierBaseDriver class a bit more abstract."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6310ca346afa907a590969f673faef17bbdd918e"},{"line_number":10,"context_line":"Closes-Bug: #1700048"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f201791_f56d6604","line":7,"updated":"2017-06-23 15:26:34.000000000","message":"The commit message exceeds the limit of characters per line.","commit_id":"2cb9bb74cf49acbac7b03ee4b858a7dafb229bf1"},{"author":{"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},"change_message_id":"53a481d7376cd33774ddd2dd2d35a31c7cb894f8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Domhnall Walsh \u003cdomhnall.eam.walsh@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-23 15:59:16 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding a dummy monitoring driver and making NotifierBaseDriver class a bit more abstract."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6310ca346afa907a590969f673faef17bbdd918e"},{"line_number":10,"context_line":"Closes-Bug: #1700048"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f1d235d_1b699cbd","line":7,"in_reply_to":"5f201791_f56d6604","updated":"2017-06-29 09:16:56.000000000","message":"More than 79 characters","commit_id":"2cb9bb74cf49acbac7b03ee4b858a7dafb229bf1"}],"freezer_dr/notifiers/drivers/default/default_email.py":[{"author":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"change_message_id":"b2599e025e763012e4fc75511480477505355fce","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, url, username, password, templates_dir, notify_from,"},{"line_number":32,"context_line":"                 admin_list\u003dNone, **kwargs):"},{"line_number":33,"context_line":"        \"\"\" Initialize the notification backend."},{"line_number":34,"context_line":"        :param url: Notification system backend"},{"line_number":35,"context_line":"        :param username: Username"},{"line_number":36,"context_line":"        :param password: Password"},{"line_number":37,"context_line":"        :param templates_dir: Path to templates directory to load message"},{"line_number":38,"context_line":"        templates"},{"line_number":39,"context_line":"        :param kwargs: Key:Value arguments"},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        self.url \u003d url"},{"line_number":42,"context_line":"        self.username \u003d username"},{"line_number":43,"context_line":"        self.password \u003d password"},{"line_number":44,"context_line":"        self.templates_dir \u003d templates_dir"},{"line_number":45,"context_line":"        self.admin_list \u003d admin_list"},{"line_number":46,"context_line":"        self.notify_from \u003d notify_from"},{"line_number":47,"context_line":"        self.options \u003d kwargs"},{"line_number":48,"context_line":"        super(StandardEmail, self).__init__()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        LOG.info(\u0027Initializing StandardEmail notifier driver @ {0}\u0027.format(url))"},{"line_number":51,"context_line":"        server \u003d smtplib.SMTP(url, kwargs.get(\u0027port\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_38eab30e","line":48,"range":{"start_line":33,"start_character":8,"end_line":48,"end_character":45},"updated":"2017-06-23 15:26:34.000000000","message":"I\u0027m not sure why do we need to change the design of the abstract driver and move the initialization here ?\n\nfor the dummy driver you can pass localhost for example...","commit_id":"2cb9bb74cf49acbac7b03ee4b858a7dafb229bf1"},{"author":{"_account_id":15041,"name":"Domhnall Walsh","email":"domhnall.eam.walsh@hpe.com","username":"domhnall"},"change_message_id":"a8d5a688cfb85d3f4efe330ea7cc8017c45655bf","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, url, username, password, templates_dir, notify_from,"},{"line_number":32,"context_line":"                 admin_list\u003dNone, **kwargs):"},{"line_number":33,"context_line":"        \"\"\" Initialize the notification backend."},{"line_number":34,"context_line":"        :param url: Notification system backend"},{"line_number":35,"context_line":"        :param username: Username"},{"line_number":36,"context_line":"        :param password: Password"},{"line_number":37,"context_line":"        :param templates_dir: Path to templates directory to load message"},{"line_number":38,"context_line":"        templates"},{"line_number":39,"context_line":"        :param kwargs: Key:Value arguments"},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        self.url \u003d url"},{"line_number":42,"context_line":"        self.username \u003d username"},{"line_number":43,"context_line":"        self.password \u003d password"},{"line_number":44,"context_line":"        self.templates_dir \u003d templates_dir"},{"line_number":45,"context_line":"        self.admin_list \u003d admin_list"},{"line_number":46,"context_line":"        self.notify_from \u003d notify_from"},{"line_number":47,"context_line":"        self.options \u003d kwargs"},{"line_number":48,"context_line":"        super(StandardEmail, self).__init__()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        LOG.info(\u0027Initializing StandardEmail notifier driver @ {0}\u0027.format(url))"},{"line_number":51,"context_line":"        server \u003d smtplib.SMTP(url, kwargs.get(\u0027port\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_f80f9bde","line":48,"range":{"start_line":33,"start_character":8,"end_line":48,"end_character":45},"in_reply_to":"5f201791_38eab30e","updated":"2017-06-23 15:40:15.000000000","message":"I think it\u0027s more generic that way; some notifiers may not involve a network connection, for example, or may use a different authentication scheme (e.g. JWT or something). The existing list looks like it belongs better applied to the Email driver rather than being proposed as a standard set of properties that every notification driver will use?","commit_id":"2cb9bb74cf49acbac7b03ee4b858a7dafb229bf1"}]}