)]}'
{"freezer_dr/main.py":[{"author":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"change_message_id":"d62c058fe4261ea77bebba639e0c150434bebc7d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        evacuated_nodes, failed_nodes \u003d evac.evacuate(nodes)"},{"line_number":47,"context_line":"        LOG.debug(\"Successfully evacuated nodes {0}\".format(evacuated_nodes))"},{"line_number":48,"context_line":"        LOG.debug(\"Failed to evacuate nodes {0}\".format(failed_nodes))"},{"line_number":49,"context_line":"        evacuated_nodes \u003d evac.get_nodes_details(evacuated_nodes)"},{"line_number":50,"context_line":"        notifier.notify(evacuated_nodes, \u0027success\u0027)"},{"line_number":51,"context_line":"        failed_nodes \u003d evac.get_nodes_details(failed_nodes)"},{"line_number":52,"context_line":"        notifier.notify(failed_nodes, \u0027error\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d6c9d958","line":49,"updated":"2018-08-14 14:28:09.000000000","message":"moving this function call here will make freezer lose the previous node details as the vms has moved to a new node ... so It needs to be before the evacuate call...","commit_id":"55244fd4e05cee8cce3d62c10e3e9845acc788d1"},{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"2b9f0601b05ff5e896f16c8db4843f41230b5880","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        evacuated_nodes, failed_nodes \u003d evac.evacuate(nodes)"},{"line_number":47,"context_line":"        LOG.debug(\"Successfully evacuated nodes {0}\".format(evacuated_nodes))"},{"line_number":48,"context_line":"        LOG.debug(\"Failed to evacuate nodes {0}\".format(failed_nodes))"},{"line_number":49,"context_line":"        evacuated_nodes \u003d evac.get_nodes_details(evacuated_nodes)"},{"line_number":50,"context_line":"        notifier.notify(evacuated_nodes, \u0027success\u0027)"},{"line_number":51,"context_line":"        failed_nodes \u003d evac.get_nodes_details(failed_nodes)"},{"line_number":52,"context_line":"        notifier.notify(failed_nodes, \u0027error\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1692c657","line":49,"in_reply_to":"3f79a3b5_d6c9d958","updated":"2018-08-16 05:46:34.000000000","message":"Done. How do you think about my new patch? Thanks. :)","commit_id":"55244fd4e05cee8cce3d62c10e3e9845acc788d1"},{"author":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"change_message_id":"ee0c15b88fa4b563b0c75ffba228f2bf28647990","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        # Shutdown the node"},{"line_number":45,"context_line":"        evac \u003d EvacuationManager()"},{"line_number":46,"context_line":"        notify_nodes \u003d evac.get_nodes_details(nodes)"},{"line_number":47,"context_line":"        notifier.notify(notify_nodes, \u0027original\u0027)"},{"line_number":48,"context_line":"        evacuated_nodes, failed_nodes \u003d evac.evacuate(nodes)"},{"line_number":49,"context_line":"        LOG.debug(\"Successfully evacuated nodes {0}\".format(evacuated_nodes))"},{"line_number":50,"context_line":"        LOG.debug(\"Failed to evacuate nodes {0}\".format(failed_nodes))"},{"line_number":51,"context_line":"        evacuated_nodes \u003d evac.get_nodes_details(evacuated_nodes)"},{"line_number":52,"context_line":"        notifier.notify(evacuated_nodes, \u0027success\u0027)"},{"line_number":53,"context_line":"        failed_nodes \u003d evac.get_nodes_details(failed_nodes)"},{"line_number":54,"context_line":"        notifier.notify(failed_nodes, \u0027error\u0027)"},{"line_number":55,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_f0e3a432","line":52,"range":{"start_line":47,"start_character":7,"end_line":52,"end_character":51},"updated":"2018-08-27 10:20:05.000000000","message":"This is better than the previous one. I just have one concern send the original nodes (affected nodes) and succeeded ones might be a bit confusing so I would say let\u0027s do the following if possible\n\noriginal \u003d evac.get_nodes_details(nodes)\nevacuated_nodes, failed_nodes \u003d evac.evacuate(nodes)\nevacuated_nodes \u003d evac.get_nodes_details(evacuated_nodes)\nnotifier.notify(evacuated_nodes, \u0027success\u0027)\nfailed \u003d []\nfor node in original:\n    if node not in evacuated_nodes:\n        failed.append(node)\n\nnotifier.notify(failed, \u0027error\u0027)\n\nso we notify what failed and what succeeded as well, what do you think ?","commit_id":"e13dec53f95101e6a5bd18324bedb676f44ee6d8"},{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"50f9eae49cc573488832634846beaeb584917a44","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        # Shutdown the node"},{"line_number":45,"context_line":"        evac \u003d EvacuationManager()"},{"line_number":46,"context_line":"        notify_nodes \u003d evac.get_nodes_details(nodes)"},{"line_number":47,"context_line":"        notifier.notify(notify_nodes, \u0027original\u0027)"},{"line_number":48,"context_line":"        evacuated_nodes, failed_nodes \u003d evac.evacuate(nodes)"},{"line_number":49,"context_line":"        LOG.debug(\"Successfully evacuated nodes {0}\".format(evacuated_nodes))"},{"line_number":50,"context_line":"        LOG.debug(\"Failed to evacuate nodes {0}\".format(failed_nodes))"},{"line_number":51,"context_line":"        evacuated_nodes \u003d evac.get_nodes_details(evacuated_nodes)"},{"line_number":52,"context_line":"        notifier.notify(evacuated_nodes, \u0027success\u0027)"},{"line_number":53,"context_line":"        failed_nodes \u003d evac.get_nodes_details(failed_nodes)"},{"line_number":54,"context_line":"        notifier.notify(failed_nodes, \u0027error\u0027)"},{"line_number":55,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_2bf51fcb","line":52,"range":{"start_line":47,"start_character":7,"end_line":52,"end_character":51},"in_reply_to":"3f79a3b5_f0e3a432","updated":"2018-08-28 00:01:47.000000000","message":"failed nodes are already been notified below (line 53, 54)","commit_id":"e13dec53f95101e6a5bd18324bedb676f44ee6d8"}]}
