)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5054dc11536d02625207c106418675fc3a023f01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"67195907_52599a4c","updated":"2026-08-28 15:35:58.000000000","message":"I am really still not sure if it should be that, or a schema change...\nAs in schema 7 we can use conditions, and reduce amount of required fields. So still need to think about pros/cons here.","commit_id":"267a7607cfe53f8934cf3c3fb6efa93895837844"}],"freezer/scheduler/scheduler_job.py":[{"author":{"_account_id":39044,"name":"Alicja Filipek","display_name":"alaf01","email":"alicja.filipek@cleura.com","username":"alaf01"},"change_message_id":"2809d77f40e6a471e59f4868cfb68fc5b89a1a48","unresolved":true,"context_lines":[{"line_number":376,"context_line":"        if action_name \u003d\u003d \u0027backup\u0027 \\"},{"line_number":377,"context_line":"                and action_mode \u003d\u003d \u0027cindernative\u0027:"},{"line_number":378,"context_line":"            if not freezer_action.get(\u0027hostname\u0027):"},{"line_number":379,"context_line":"                freezer_action[\u0027hostname\u0027] \u003d ("},{"line_number":380,"context_line":"                    self.job_doc.get(\u0027client_id\u0027)"},{"line_number":381,"context_line":"                )"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c4a46be0_cfdf1571","line":379,"updated":"2026-08-28 14:27:03.000000000","message":"some comment why we allow not to have hostname would be nice. Could \u0027client_id\u0027 be None?","commit_id":"267a7607cfe53f8934cf3c3fb6efa93895837844"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2ba82325c3b34fbf54ee07cb49d4869db42d6af0","unresolved":true,"context_lines":[{"line_number":376,"context_line":"        if action_name \u003d\u003d \u0027backup\u0027 \\"},{"line_number":377,"context_line":"                and action_mode \u003d\u003d \u0027cindernative\u0027:"},{"line_number":378,"context_line":"            if not freezer_action.get(\u0027hostname\u0027):"},{"line_number":379,"context_line":"                freezer_action[\u0027hostname\u0027] \u003d ("},{"line_number":380,"context_line":"                    self.job_doc.get(\u0027client_id\u0027)"},{"line_number":381,"context_line":"                )"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf790ae5_846ef236","line":379,"in_reply_to":"c4a46be0_cfdf1571","updated":"2026-08-28 14:31:04.000000000","message":"No, it can\u0027t. Client_id is required when we attach an action to a job:\nhttps://opendev.org/openstack/freezer-api/src/branch/master/freezer_api/common/json_schemas.py#L341\n\nAnd we do not want to expose the actual hostname here, as for the cindernative it does not matter to begin with... But I feel it might need some more polishing...","commit_id":"267a7607cfe53f8934cf3c3fb6efa93895837844"}]}
