)]}'
{"freezer/arguments.py":[{"author":{"_account_id":14159,"name":"Fabrizio Vanni","email":"fabrizio.vanni@hpe.com","username":"fabrizio.vanni"},"change_message_id":"ecd94a9f9d27f3e06abf53e3a86e2efa74fc3152","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        \u0027--compression\u0027, action\u003d\u0027store\u0027,"},{"line_number":414,"context_line":"        choices\u003d[\u0027gzip\u0027, \u0027bzip2\u0027],"},{"line_number":415,"context_line":"        help\u003d\u0027compression algorithme to use. gzip is default algorithme\u0027"},{"line_number":416,"context_line":"             \u0027for now.\u0027,"},{"line_number":417,"context_line":"        dest\u003d\u0027compression\u0027, default\u003d\u0027gzip\u0027)"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    arg_parser.set_defaults(**defaults)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_4b18521e","line":416,"updated":"2015-07-15 13:30:56.000000000","message":"Default algorithm is gzip (or whatever is agreed). No need to add \"for now\". Also, algorithme is french :)","commit_id":"fb8f021d572d3bfe0459edef1d14b321d0b87937"}],"freezer/backup.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"af8c23c648b318d025cb000d1201331b708c4708","unresolved":false,"context_lines":[{"line_number":24,"context_line":"import os"},{"line_number":25,"context_line":"from os.path import expanduser"},{"line_number":26,"context_line":"import time"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from freezer import utils"},{"line_number":29,"context_line":"from freezer.lvm import lvm_snap, lvm_snap_remove, get_lvm_info"},{"line_number":30,"context_line":"from freezer.tar import TarCommandBuilder"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a4dcd0f_0ae575a2","side":"PARENT","line":27,"updated":"2015-08-12 11:21:04.000000000","message":"Why removing the empty line separating these two import blocks?\nhttp://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"f6c1c1db25b1f3686011b7ccf3d181048e944650"},{"author":{"_account_id":14159,"name":"Fabrizio Vanni","email":"fabrizio.vanni@hpe.com","username":"fabrizio.vanni"},"change_message_id":"ebbaef46743cbde77c23390050e0c0881c867d09","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            builder \u003d TarCommandBuilder(backup_opt_dict.tar_path,"},{"line_number":289,"context_line":"                                        filepath\u003dfilepath)"},{"line_number":290,"context_line":"            builder.set_dereference(backup_opt_dict.dereference_symlink)"},{"line_number":291,"context_line":"            if backup_opt_dict.compression:"},{"line_number":292,"context_line":"                builder.set_compression_algo("},{"line_number":293,"context_line":"                    utils.get_tar_flag_from_algo(backup_opt_dict.compression))"},{"line_number":294,"context_line":"            if backup_opt_dict.exclude:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a4dcd0f_e7ade4e9","line":291,"updated":"2015-08-12 10:36:11.000000000","message":"backup_opt_dict.compression is actually always defined, according to the code in arguments.py, lines 68 and 413-417","commit_id":"b44057b4a8f2a7cdff0dcb6de5e35067761b9ff6"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"af8c23c648b318d025cb000d1201331b708c4708","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            builder \u003d TarCommandBuilder(backup_opt_dict.tar_path,"},{"line_number":289,"context_line":"                                        filepath\u003dfilepath)"},{"line_number":290,"context_line":"            builder.set_dereference(backup_opt_dict.dereference_symlink)"},{"line_number":291,"context_line":"            if backup_opt_dict.compression:"},{"line_number":292,"context_line":"                builder.set_compression_algo("},{"line_number":293,"context_line":"                    utils.get_tar_flag_from_algo(backup_opt_dict.compression))"},{"line_number":294,"context_line":"            if backup_opt_dict.exclude:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a4dcd0f_55531e17","line":291,"in_reply_to":"1a4dcd0f_e7ade4e9","updated":"2015-08-12 11:21:04.000000000","message":"True, as there is choices specified on the add_argument and default value for it as well there is no way to get this valued to something that would not validate the if.","commit_id":"b44057b4a8f2a7cdff0dcb6de5e35067761b9ff6"}],"freezer/job.py":[{"author":{"_account_id":14159,"name":"Fabrizio Vanni","email":"fabrizio.vanni@hpe.com","username":"fabrizio.vanni"},"change_message_id":"ebbaef46743cbde77c23390050e0c0881c867d09","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            if conf.encrypt_pass_file:"},{"line_number":138,"context_line":"                builder.set_encryption(conf.openssl_path,"},{"line_number":139,"context_line":"                                       conf.encrypt_pass_file)"},{"line_number":140,"context_line":"            if conf.compression:"},{"line_number":141,"context_line":"                builder.set_compression_algo("},{"line_number":142,"context_line":"                    utils.get_tar_flag_from_algo(conf.compression))"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a4dcd0f_475ff8e4","line":140,"updated":"2015-08-12 10:36:11.000000000","message":"backup_opt_dict.compression is actually always defined, according to the code in arguments.py, lines 68 and 413-417\n\n(same as freezer/backup.py line 291)","commit_id":"b44057b4a8f2a7cdff0dcb6de5e35067761b9ff6"}],"freezer/tar.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"af8c23c648b318d025cb000d1201331b708c4708","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from freezer import winutils"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"import os"},{"line_number":27,"context_line":"import logging"},{"line_number":28,"context_line":"import subprocess"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a4dcd0f_d5664eec","side":"PARENT","line":25,"updated":"2015-08-12 11:21:04.000000000","message":"ditto  http://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"f6c1c1db25b1f3686011b7ccf3d181048e944650"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"af8c23c648b318d025cb000d1201331b708c4708","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            self.ssh_ip,"},{"line_number":125,"context_line":"            \"cat \u003e {0}\".format(self.output_file))"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def set_compression_algo(self, compression_algo):"},{"line_number":128,"context_line":"        self.compression_algo \u003d compression_algo"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def build(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a4dcd0f_95a766a6","line":127,"updated":"2015-08-12 11:21:04.000000000","message":"Why not just set it right in the first place at the init?","commit_id":"b44057b4a8f2a7cdff0dcb6de5e35067761b9ff6"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"af8c23c648b318d025cb000d1201331b708c4708","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        self.ssh_ip \u003d remote_ip"},{"line_number":202,"context_line":"        self.ssh_user \u003d remote_user"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def set_compression_algo(self, compression_algo):"},{"line_number":205,"context_line":"        self.compression_algo \u003d compression_algo"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def build(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a4dcd0f_55bc7eba","line":204,"updated":"2015-08-12 11:21:04.000000000","message":"ditto","commit_id":"b44057b4a8f2a7cdff0dcb6de5e35067761b9ff6"}],"freezer/utils.py":[{"author":{"_account_id":14159,"name":"Fabrizio Vanni","email":"fabrizio.vanni@hpe.com","username":"fabrizio.vanni"},"change_message_id":"ecd94a9f9d27f3e06abf53e3a86e2efa74fc3152","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    return u\u0027{0}_segments\u0027.format(container)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"def compression_algorithm(compression):"},{"line_number":376,"context_line":"    algo \u003d {"},{"line_number":377,"context_line":"        \u0027gzip\u0027: \u0027-z\u0027,"},{"line_number":378,"context_line":"        \u0027bzip2\u0027: \u0027-j\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_d00f2f37","line":375,"updated":"2015-07-15 13:30:56.000000000","message":"if you want, you can choose a more expressive name, indicating the purpose, which is to translate the chosen algorithm into a specific tar flag","commit_id":"fb8f021d572d3bfe0459edef1d14b321d0b87937"},{"author":{"_account_id":14159,"name":"Fabrizio Vanni","email":"fabrizio.vanni@hpe.com","username":"fabrizio.vanni"},"change_message_id":"ebbaef46743cbde77c23390050e0c0881c867d09","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        \u0027bzip2\u0027: \u0027-j\u0027,"},{"line_number":254,"context_line":"        \u0027xz\u0027: \u0027-J\u0027,"},{"line_number":255,"context_line":"    }"},{"line_number":256,"context_line":"    return algo.get(compression, \u0027-z\u0027)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"class Bunch:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a4dcd0f_e7cc048b","line":256,"updated":"2015-08-12 10:36:11.000000000","message":"default algorithm (gzip) is already selected in arguments.py","commit_id":"b44057b4a8f2a7cdff0dcb6de5e35067761b9ff6"}]}