)]}'
{"freezer/arguments.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a920c02097dd52ab4f3357b8b74af0713d218b1d","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        backup_args.__dict__[\u0027work_dir\u0027] \u003d work_dir"},{"line_number":459,"context_line":"        os.makedirs(work_dir)"},{"line_number":460,"context_line":"    except (OSError, IOError):"},{"line_number":461,"context_line":"        if not os.path.isdir(work_dir):"},{"line_number":462,"context_line":"            raise OSError("},{"line_number":463,"context_line":"                \u0027File {} already exists and is not a directory\u0027.format("},{"line_number":464,"context_line":"                    work_dir))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_411b16cb","line":461,"updated":"2015-08-13 16:46:35.000000000","message":"You might not want to do this. There are circumstances where your client will just fail because you don\u0027t have for example permissions to create the folder. \n\nJust for reference what Thomas did for us (glanceclient) for similar: https://review.openstack.org/#/c/175300","commit_id":"0d6e0d0004d43b13a64070c57f6406636d132222"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"fc38d8268754c6f484459f11f2aa41b2cbe5c4da","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from __future__ import print_function"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from freezer.winutils import is_windows"},{"line_number":27,"context_line":"from oslo_utils import encodeutils"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"import argparse"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_a19d1168","line":26,"updated":"2015-08-14 11:09:41.000000000","message":"you should not import individual functions,\nfrom freezer import winutils\n\nwinutils.is_windows() would be better approach:\nhttp://docs.openstack.org/developer/hacking/#imports","commit_id":"add6e2a0148c9935800348136ca3d73793afc2be"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"fc38d8268754c6f484459f11f2aa41b2cbe5c4da","unresolved":false,"context_lines":[{"line_number":38,"context_line":"import sys"},{"line_number":39,"context_line":"import socket"},{"line_number":40,"context_line":"import utils"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"home \u003d expanduser(\"~\")"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_218021f7","line":41,"updated":"2015-08-14 11:09:41.000000000","message":"also the import orders could follow the OS hacking guidelines.","commit_id":"add6e2a0148c9935800348136ca3d73793afc2be"}]}
