)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"3c51f2a9867821b65eb882c24abec005d5085792","unresolved":false,"context_lines":[{"line_number":11,"context_line":"(upload-limit, download-limit) to trickle and remove it from"},{"line_number":12,"context_line":"freezer agent."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes: #1466858"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I0c3ac2e4085389dc71c8e242c84fefe7aea3c8a5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba15a1d1_33d8061e","line":14,"updated":"2015-09-23 17:40:47.000000000","message":"Closes-Bug: #1466858\n\nThat way you will get the link to the actual bug and launchpad will treat this as fix for that bug.","commit_id":"aa4d6f4da69559cabd51944896b5d28fa88e3a91"}],"freezer/arguments.py":[{"author":{"_account_id":11151,"name":"Fausto Marzi","email":"fausto.marzi@ericsson.com","username":"fausto.marzi"},"change_message_id":"ef2f16ee7e679835fab78d33c6c3b6b590e26251","unresolved":false,"context_lines":[{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    backup_args.__dict__[\u0027time_stamp\u0027] \u003d None"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    if backup_args.upload_limit !\u003d -1 or backup_args.download_limit !\u003d -1\\"},{"line_number":571,"context_line":"            and not winutils.is_windows():"},{"line_number":572,"context_line":"        if backup_args.config:"},{"line_number":573,"context_line":"            conf_file \u003d NamedTemporaryFile(prefix\u003d\u0027freezer_job_\u0027, delete\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_0e69188c","line":570,"updated":"2015-09-23 19:34:21.000000000","message":"Can we change the default value of -1 to upload_limit and download_limit? It would be good to have it consistent with the other options (i.e. None).","commit_id":"aa4d6f4da69559cabd51944896b5d28fa88e3a91"},{"author":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"change_message_id":"51477b420d41a76e9313816795c9775f4e54ead1","unresolved":false,"context_lines":[{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    backup_args.__dict__[\u0027time_stamp\u0027] \u003d None"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    if backup_args.upload_limit !\u003d -1 or backup_args.download_limit !\u003d -1\\"},{"line_number":571,"context_line":"            and not winutils.is_windows():"},{"line_number":572,"context_line":"        if backup_args.config:"},{"line_number":573,"context_line":"            conf_file \u003d NamedTemporaryFile(prefix\u003d\u0027freezer_job_\u0027, delete\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_b3ee3a20","line":570,"in_reply_to":"ba15a1d1_0e69188c","updated":"2015-09-24 14:43:23.000000000","message":"Done","commit_id":"aa4d6f4da69559cabd51944896b5d28fa88e3a91"},{"author":{"_account_id":11151,"name":"Fausto Marzi","email":"fausto.marzi@ericsson.com","username":"fausto.marzi"},"change_message_id":"ef2f16ee7e679835fab78d33c6c3b6b590e26251","unresolved":false,"context_lines":[{"line_number":576,"context_line":"            conf_index \u003d sys.argv.index(\u0027--config\u0027) + 1"},{"line_number":577,"context_line":"            sys.argv[conf_index] \u003d conf_file.name"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"        if \u0027--upload-limit\u0027 in sys.argv:"},{"line_number":580,"context_line":"            index \u003d sys.argv.index(\u0027--upload-limit\u0027)"},{"line_number":581,"context_line":"            sys.argv.pop(index)"},{"line_number":582,"context_line":"            sys.argv.pop(index)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_ebf37671","line":579,"updated":"2015-09-23 19:34:21.000000000","message":"why this? wouldn\u0027t  be more consistent something like:\n\nif \u0027--upload-limit\u0027 in backup_args.__dict__: ?\n\nor using hasattr?\n\nIn that way we check the existence of \u0027--upload-limit\u0027 after the input is validated by the argparse/configparse module.","commit_id":"aa4d6f4da69559cabd51944896b5d28fa88e3a91"},{"author":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"change_message_id":"51477b420d41a76e9313816795c9775f4e54ead1","unresolved":false,"context_lines":[{"line_number":576,"context_line":"            conf_index \u003d sys.argv.index(\u0027--config\u0027) + 1"},{"line_number":577,"context_line":"            sys.argv[conf_index] \u003d conf_file.name"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"        if \u0027--upload-limit\u0027 in sys.argv:"},{"line_number":580,"context_line":"            index \u003d sys.argv.index(\u0027--upload-limit\u0027)"},{"line_number":581,"context_line":"            sys.argv.pop(index)"},{"line_number":582,"context_line":"            sys.argv.pop(index)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_737d026c","line":579,"in_reply_to":"ba15a1d1_ebf37671","updated":"2015-09-24 14:43:23.000000000","message":"the idea is we need to pass the same parameters to the command line again through subprocess, but without --upload-limit nor --download-limit so I am looking into sys.argv to remove those attrs, and it\u0027s list so I can\u0027t use hasattr with list\n\nbackup_args.__dict__ has the values processed by the parser but I don\u0027t need \u0027em, I need to remove it from the args to be passed to the subprocess in main.py\n\nexample: \n\nfreezerc --action backup --mode fs -F /path ... --upload-limit 10k --download-limit 10k\nthis will create a subprocess as follow\n\n/usr/local/bin/trickle -d 10k -u 10k /usr/bin/freezerc --action backup --mode fs -F /path ...\n\nwithout upload, download limits","commit_id":"aa4d6f4da69559cabd51944896b5d28fa88e3a91"},{"author":{"_account_id":11151,"name":"Fausto Marzi","email":"fausto.marzi@ericsson.com","username":"fausto.marzi"},"change_message_id":"ef2f16ee7e679835fab78d33c6c3b6b590e26251","unresolved":false,"context_lines":[{"line_number":601,"context_line":"                trickle_lib \u003d distspawn.find_executable("},{"line_number":602,"context_line":"                    \u0027trickle-overload.so\u0027, path\u003d\":\".join("},{"line_number":603,"context_line":"                        os.environ.get(\u0027PATH\u0027)))"},{"line_number":604,"context_line":"        if trickle_executable is not None and trickle_lib is not None:"},{"line_number":605,"context_line":"            logging.info(\"[*] Info: Starting trickle ...\")"},{"line_number":606,"context_line":"            os.environ[\u0027LD_PRELOAD\u0027] \u003d trickle_lib"},{"line_number":607,"context_line":"            trickle_command \u003d \u0027{0} -d {1} -u {2} \u0027.\\"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_8b9bda16","line":604,"updated":"2015-09-23 19:34:21.000000000","message":"if trickle_executable and trickle_lib: ?","commit_id":"aa4d6f4da69559cabd51944896b5d28fa88e3a91"},{"author":{"_account_id":11151,"name":"Fausto Marzi","email":"fausto.marzi@ericsson.com","username":"fausto.marzi"},"change_message_id":"8c0c2bcf9a487ad4689a1b2e27d5c1cdf41846e3","unresolved":false,"context_lines":[{"line_number":601,"context_line":"                trickle_lib \u003d distspawn.find_executable("},{"line_number":602,"context_line":"                    \u0027trickle-overload.so\u0027, path\u003d\":\".join("},{"line_number":603,"context_line":"                        os.environ.get(\u0027PATH\u0027)))"},{"line_number":604,"context_line":"        if trickle_executable is not None and trickle_lib is not None:"},{"line_number":605,"context_line":"            logging.info(\"[*] Info: Starting trickle ...\")"},{"line_number":606,"context_line":"            os.environ[\u0027LD_PRELOAD\u0027] \u003d trickle_lib"},{"line_number":607,"context_line":"            trickle_command \u003d \u0027{0} -d {1} -u {2} \u0027.\\"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_cba3b54e","line":604,"in_reply_to":"ba15a1d1_134286ae","updated":"2015-09-24 14:59:10.000000000","message":"I agree, my comment was related to simplify the if statement as:\n \ns/if trickle_executable is not None and trickle_lib is not None:/if trickle_executable and trickle_lib:/","commit_id":"aa4d6f4da69559cabd51944896b5d28fa88e3a91"},{"author":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"change_message_id":"51477b420d41a76e9313816795c9775f4e54ead1","unresolved":false,"context_lines":[{"line_number":601,"context_line":"                trickle_lib \u003d distspawn.find_executable("},{"line_number":602,"context_line":"                    \u0027trickle-overload.so\u0027, path\u003d\":\".join("},{"line_number":603,"context_line":"                        os.environ.get(\u0027PATH\u0027)))"},{"line_number":604,"context_line":"        if trickle_executable is not None and trickle_lib is not None:"},{"line_number":605,"context_line":"            logging.info(\"[*] Info: Starting trickle ...\")"},{"line_number":606,"context_line":"            os.environ[\u0027LD_PRELOAD\u0027] \u003d trickle_lib"},{"line_number":607,"context_line":"            trickle_command \u003d \u0027{0} -d {1} -u {2} \u0027.\\"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_134286ae","line":604,"in_reply_to":"ba15a1d1_8b9bda16","updated":"2015-09-24 14:43:23.000000000","message":"trickle depends on a library called trickle-overload.so and this lib needs to be in a certain path /usr/lib/trickle/trickle-overload.so otherwise trickle won\u0027t work.\n\nFresco built freezer again with a hack allows us to pass the lib through LD_PRELOAD.\n\nIf the library is not present trickle won\u0027t work !, so I need to check if it\u0027s present and we can locate it or not","commit_id":"aa4d6f4da69559cabd51944896b5d28fa88e3a91"}],"freezer/main.py":[{"author":{"_account_id":11151,"name":"Fausto Marzi","email":"fausto.marzi@ericsson.com","username":"fausto.marzi"},"change_message_id":"ef2f16ee7e679835fab78d33c6c3b6b590e26251","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        process \u003d subprocess.Popen(freezer_command.split(),"},{"line_number":169,"context_line":"                                   stdout\u003dsubprocess.PIPE,"},{"line_number":170,"context_line":"                                   stderr\u003dsubprocess.PIPE,"},{"line_number":171,"context_line":"                                   env\u003dos.environ.copy(), shell\u003dTrue)"},{"line_number":172,"context_line":"        while process.poll() is None:"},{"line_number":173,"context_line":"            print process.stdout.readline().rstrip()"},{"line_number":174,"context_line":"        output, error \u003d process.communicate()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_8b375afd","line":171,"updated":"2015-09-23 19:34:21.000000000","message":"why shell\u003dTrue/ Can we remove it?","commit_id":"aa4d6f4da69559cabd51944896b5d28fa88e3a91"},{"author":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"change_message_id":"51477b420d41a76e9313816795c9775f4e54ead1","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        process \u003d subprocess.Popen(freezer_command.split(),"},{"line_number":169,"context_line":"                                   stdout\u003dsubprocess.PIPE,"},{"line_number":170,"context_line":"                                   stderr\u003dsubprocess.PIPE,"},{"line_number":171,"context_line":"                                   env\u003dos.environ.copy(), shell\u003dTrue)"},{"line_number":172,"context_line":"        while process.poll() is None:"},{"line_number":173,"context_line":"            print process.stdout.readline().rstrip()"},{"line_number":174,"context_line":"        output, error \u003d process.communicate()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_5381dec1","line":171,"in_reply_to":"ba15a1d1_8b375afd","updated":"2015-09-24 14:43:23.000000000","message":"Done","commit_id":"aa4d6f4da69559cabd51944896b5d28fa88e3a91"}],"freezer/utils.py":[{"author":{"_account_id":11151,"name":"Fausto Marzi","email":"fausto.marzi@ericsson.com","username":"fausto.marzi"},"change_message_id":"ef2f16ee7e679835fab78d33c6c3b6b590e26251","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    for option, option_value in config.items():"},{"line_number":133,"context_line":"        parser.set(section, option, option_value)"},{"line_number":134,"context_line":"    parser.write(f)"},{"line_number":135,"context_line":"    f.seek(0)"},{"line_number":136,"context_line":"    f.close()"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_4e42b03f","line":135,"updated":"2015-09-23 19:34:21.000000000","message":"Isn\u0027t f.seek(0) redundant is f.close() is used?","commit_id":"aa4d6f4da69559cabd51944896b5d28fa88e3a91"},{"author":{"_account_id":11151,"name":"Fausto Marzi","email":"fausto.marzi@ericsson.com","username":"fausto.marzi"},"change_message_id":"8c0c2bcf9a487ad4689a1b2e27d5c1cdf41846e3","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    for option, option_value in config.items():"},{"line_number":133,"context_line":"        parser.set(section, option, option_value)"},{"line_number":134,"context_line":"    parser.write(f)"},{"line_number":135,"context_line":"    f.seek(0)"},{"line_number":136,"context_line":"    f.close()"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_8b5b7d54","line":135,"in_reply_to":"ba15a1d1_33522a68","updated":"2015-09-24 14:59:10.000000000","message":"Yep, that was my point, if you close the file, there\u0027s no need of fd.seek(0)","commit_id":"aa4d6f4da69559cabd51944896b5d28fa88e3a91"},{"author":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"change_message_id":"51477b420d41a76e9313816795c9775f4e54ead1","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    for option, option_value in config.items():"},{"line_number":133,"context_line":"        parser.set(section, option, option_value)"},{"line_number":134,"context_line":"    parser.write(f)"},{"line_number":135,"context_line":"    f.seek(0)"},{"line_number":136,"context_line":"    f.close()"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_33522a68","line":135,"in_reply_to":"ba15a1d1_4e42b03f","updated":"2015-09-24 14:43:23.000000000","message":"f.seek(0) it has nothing to do here, and won\u0027t close the file and I received an error from the subprocess it can\u0027t access the file because it\u0027s open by the parent so I have to use f.close(), but it\u0027s Okay I will remove seek","commit_id":"aa4d6f4da69559cabd51944896b5d28fa88e3a91"}]}
