)]}'
{"freezer/engine/tar/tar_builders.py":[{"author":{"_account_id":14159,"name":"Fabrizio Vanni","email":"fabrizio.vanni@hpe.com","username":"fabrizio.vanni"},"change_message_id":"e38be1666b569494086217cd060b4968ab94cd49","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    }"},{"line_number":166,"context_line":"    compression_exec \u003d spawn.find_executable(compression)"},{"line_number":167,"context_line":"    if not compression_exec:"},{"line_number":168,"context_line":"        logging.error(\"[*] Critical Error: {0} executable not found \""},{"line_number":169,"context_line":"                      .format(compression))"},{"line_number":170,"context_line":"        raise Exception(\"[*] Critical Error: [*] {0} executable not found \"."},{"line_number":171,"context_line":"                        format(compression))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_f7d8b3f1","line":168,"updated":"2015-10-06 11:30:21.000000000","message":"error is logged by caller.\nlogging here results in duplicate logging entry","commit_id":"8e640bda918d715513459fda9176a1d044c15700"},{"author":{"_account_id":11151,"name":"Fausto Marzi","email":"fausto.marzi@ericsson.com","username":"fausto.marzi"},"change_message_id":"cd01f40d8efcfa3b4159e0a053beb7bfd2086c67","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        \u0027xz\u0027: \u0027-J\u0027,"},{"line_number":165,"context_line":"    }"},{"line_number":166,"context_line":"    compression_exec \u003d get_executable_path(compression)"},{"line_number":167,"context_line":"    if not compression_exec:"},{"line_number":168,"context_line":"        logging.error(\"[*] Critical Error: {0} executable not found \""},{"line_number":169,"context_line":"                      .format(compression))"},{"line_number":170,"context_line":"        raise Exception(\"[*] Critical Error: [*] {0} executable not found \"."}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_904f0592","line":167,"updated":"2015-10-06 12:31:59.000000000","message":"Same error is printed twice. logging.error can be removed.","commit_id":"8c5b36fe0e044cfdb7f2723891b2203df8586949"}],"freezer/streaming.py":[{"author":{"_account_id":11151,"name":"Fausto Marzi","email":"fausto.marzi@ericsson.com","username":"fausto.marzi"},"change_message_id":"cd01f40d8efcfa3b4159e0a053beb7bfd2086c67","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        try:"},{"line_number":150,"context_line":"            super(QueuedThread, self).run()"},{"line_number":151,"context_line":"        except Exception as e:"},{"line_number":152,"context_line":"            logging.exception(e)"},{"line_number":153,"context_line":"            self.rich_queue.force_stop()"},{"line_number":154,"context_line":"            raise e"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_901dc575","line":152,"updated":"2015-10-06 12:31:59.000000000","message":"this is logged twice by logging.exception and raise e. Please remove.","commit_id":"8c5b36fe0e044cfdb7f2723891b2203df8586949"}],"freezer/utils.py":[{"author":{"_account_id":14340,"name":"Memo Garcia","email":"guillermo.ramirez-garcia@hp.com","username":"memogarcia"},"change_message_id":"e51f6e17e94fcceb0575da2c0120ddb13bcecbcc","unresolved":false,"context_lines":[{"line_number":375,"context_line":"    return tar"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"def get_executable_path(binary):"},{"line_number":379,"context_line":"    from winutils import is_windows"},{"line_number":380,"context_line":"    if is_windows():"},{"line_number":381,"context_line":"        path_to_binaries \u003d os.path.dirname(os.path.abspath(__file__))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_58533a6b","line":378,"updated":"2015-10-09 08:48:16.000000000","message":"we need to start documenting what a function does, so if we want to reuse the code we only need to read the docs and not all the code\n\ndef get_executable_path(binary):\n    \"\"\"This function returns the path of a given binary\"\"\"\"","commit_id":"a80445f9e53d2df47de0fd859283e11e9010de6f"}]}
