)]}'
{"freezer/backup.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"16501daac66537cc091fa2e96ad5185bbc7e52c8","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        logging.info(\"[*] Deleting temporary volume\")"},{"line_number":251,"context_line":"        cinder.volumes.delete(copied_volume)"},{"line_number":252,"context_line":"        logging.info(\"[*] Deleting temporary image\")"},{"line_number":253,"context_line":"        client_manager.get_glance().images.delete(image.id)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def backup_cinder(self, volume_id, name\u003dNone, description\u003dNone):"},{"line_number":256,"context_line":"        client_manager \u003d self.client_manager"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_4788fb22","line":253,"updated":"2015-11-03 18:02:48.000000000","message":"All the logging calls in this function should be DEBUG level.\nSee: https://wiki.openstack.org/wiki/LoggingStandards","commit_id":"85775c2793f9270f6d7d33aebc7dd56d28be74d7"}],"freezer/osclients.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"b70e1dbb8e7852b282d88149275d5d7d406e5479","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            display_name\u003dsnapshot_name,"},{"line_number":173,"context_line":"            force\u003dTrue)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        logging.info(\"Snapshot for volume with id {0}\".format(volume.id))"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        while snapshot.status !\u003d \"available\":"},{"line_number":178,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_07b433f0","line":175,"updated":"2015-11-03 18:00:47.000000000","message":"Perhaps debug, see below.","commit_id":"85775c2793f9270f6d7d33aebc7dd56d28be74d7"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"b70e1dbb8e7852b282d88149275d5d7d406e5479","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                time.sleep(5)"},{"line_number":227,"context_line":"                logging.info(\"Image status: \" + image.status)"},{"line_number":228,"context_line":"                image \u003d self.get_glance().images.get(image.id)"},{"line_number":229,"context_line":"                if image.status \u003d\u003d \"error\":"},{"line_number":230,"context_line":"                    raise Exception(\"Image have error state\")"},{"line_number":231,"context_line":"            except Exception as e:"},{"line_number":232,"context_line":"                logging.info(e)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_c7206b4c","line":229,"updated":"2015-11-03 18:00:47.000000000","message":"There is no image status \"error\", it\u0027s either [\u0027queued\u0027, \u0027saving\u0027, \u0027active\u0027, \u0027killed\u0027] in these situations (There is slight possibility of it being [\u0027pending_delete\u0027, \u0027deleted\u0027])\n\nThis will cause eternal loop if the upload fails and the image transitions to \u0027killed\u0027 (or if Image API v2 is used back to \u0027queued\u0027).","commit_id":"85775c2793f9270f6d7d33aebc7dd56d28be74d7"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"b70e1dbb8e7852b282d88149275d5d7d406e5479","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        :return: stream of image data"},{"line_number":249,"context_line":"        \"\"\""},{"line_number":250,"context_line":"        logging.info(\"Download image\")"},{"line_number":251,"context_line":"        logging.info(image)"},{"line_number":252,"context_line":"        stream \u003d self.get_glance().images.data(image.id)"},{"line_number":253,"context_line":"        logging.info(\"Stream with size {0}\".format(image.size))"},{"line_number":254,"context_line":"        return ReSizeStream(stream, image.size, 1000000)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_87f103d0","line":251,"updated":"2015-11-03 18:00:47.000000000","message":"Please NO!\nhttps://wiki.openstack.org/wiki/LoggingStandards","commit_id":"85775c2793f9270f6d7d33aebc7dd56d28be74d7"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"b70e1dbb8e7852b282d88149275d5d7d406e5479","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        logging.info(\"Download image\")"},{"line_number":251,"context_line":"        logging.info(image)"},{"line_number":252,"context_line":"        stream \u003d self.get_glance().images.data(image.id)"},{"line_number":253,"context_line":"        logging.info(\"Stream with size {0}\".format(image.size))"},{"line_number":254,"context_line":"        return ReSizeStream(stream, image.size, 1000000)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_47ba3be3","line":253,"updated":"2015-11-03 18:00:47.000000000","message":"Ditto, maybe debug?","commit_id":"85775c2793f9270f6d7d33aebc7dd56d28be74d7"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"62b21fcd28a1d99b49cedef146f25a09049425bb","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                if image.status in (\"killed\", \"deleted\"):"},{"line_number":233,"context_line":"                    raise e"},{"line_number":234,"context_line":"                logging.exception(e)"},{"line_number":235,"context_line":"                logging.info(\"Exception getting image status\")"},{"line_number":236,"context_line":"        return image"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def clean_snapshot(self, snapshot):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_706efeca","line":235,"updated":"2015-11-04 11:00:41.000000000","message":"Sorry missed this, no INFO level error logging, please. This looks like fatal enough situation that we should log WARN or even ERROR here.","commit_id":"061ce826a95d87a88a091e44624142e1fb4a1418"}]}
