)]}'
{"freezer/common/config.py":[{"author":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"change_message_id":"3bd83f563fb8436179e9cd382891eb69daff8396","unresolved":false,"context_lines":[{"line_number":488,"context_line":"            utils.save_config_to_file(defaults, conf_file)"},{"line_number":489,"context_line":"            conf_index \u003d sys.argv.index(\u0027--config\u0027) + 1"},{"line_number":490,"context_line":"            sys.argv[conf_index] \u003d conf_file.name"},{"line_number":491,"context_line":"            #delete the tempfile \"freezer_job_$temp\""},{"line_number":492,"context_line":"            utils.delete_file(conf_file_name)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        if \u0027--upload-limit\u0027 in sys.argv:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a1b2928_c7c41e42","line":491,"range":{"start_line":491,"start_character":13,"end_line":491,"end_character":19},"updated":"2016-04-11 09:43:25.000000000","message":"As Einst said file shouldn\u0027t be deleted here and tmp files will be removed automatically why would we care about deleting it ?!!","commit_id":"dc58f4bbbe157ff56ab11b5de4427d4ea0078140"},{"author":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"change_message_id":"ba80cfc2245ce3fbe670acd86ba954ad1706e03a","unresolved":false,"context_lines":[{"line_number":488,"context_line":"            utils.save_config_to_file(defaults, conf_file)"},{"line_number":489,"context_line":"            conf_index \u003d sys.argv.index(\u0027--config\u0027) + 1"},{"line_number":490,"context_line":"            sys.argv[conf_index] \u003d conf_file.name"},{"line_number":491,"context_line":"            #delete the tempfile \"freezer_job_$temp\""},{"line_number":492,"context_line":"            utils.delete_file(conf_file_name)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        if \u0027--upload-limit\u0027 in sys.argv:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a1b2928_273a3237","line":491,"range":{"start_line":491,"start_character":13,"end_line":491,"end_character":19},"in_reply_to":"7a1b2928_c7c41e42","updated":"2016-04-11 09:45:15.000000000","message":"Also this isn\u0027t addressing this bug https://bugs.launchpad.net/freezer/+bug/1568657 \nThis is the wrong code. you should modify the scheduler code not the agent !!","commit_id":"dc58f4bbbe157ff56ab11b5de4427d4ea0078140"},{"author":{"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},"change_message_id":"291c7e6b55f1544af510fabf92af32d26627272c","unresolved":false,"context_lines":[{"line_number":488,"context_line":"            utils.save_config_to_file(defaults, conf_file)"},{"line_number":489,"context_line":"            conf_index \u003d sys.argv.index(\u0027--config\u0027) + 1"},{"line_number":490,"context_line":"            sys.argv[conf_index] \u003d conf_file.name"},{"line_number":491,"context_line":"            #delete the tempfile \"freezer_job_$temp\""},{"line_number":492,"context_line":"            utils.delete_file(conf_file_name)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        if \u0027--upload-limit\u0027 in sys.argv:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a1b2928_8de7e711","line":491,"range":{"start_line":491,"start_character":13,"end_line":491,"end_character":19},"in_reply_to":"7a1b2928_c7c41e42","updated":"2016-04-11 12:34:14.000000000","message":"the tmp file will be removed automatically, but when  freezer-schedule is runing, it create the tmp,if scheduler is frequent，  more and more the file in tmp. so, I think it is no beautiful","commit_id":"dc58f4bbbe157ff56ab11b5de4427d4ea0078140"},{"author":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"change_message_id":"c1324f5d62da1789b7fcd97a7e8851ff12ab46dc","unresolved":false,"context_lines":[{"line_number":489,"context_line":"            conf_index \u003d sys.argv.index(\u0027--config\u0027) + 1"},{"line_number":490,"context_line":"            sys.argv[conf_index] \u003d conf_file.name"},{"line_number":491,"context_line":"            #delete the tempfile \"freezer_job_$temp\""},{"line_number":492,"context_line":"            utils.delete_file(conf_file_name)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        if \u0027--upload-limit\u0027 in sys.argv:"},{"line_number":495,"context_line":"            index \u003d sys.argv.index(\u0027--upload-limit\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a1b2928_ac762c3c","line":492,"updated":"2016-04-11 08:26:42.000000000","message":"the file should not be deleted here, I think should be deleted at the point  that sys.argv is released","commit_id":"dc58f4bbbe157ff56ab11b5de4427d4ea0078140"}]}
