)]}'
{"freezer/common/config.py":[{"author":{"_account_id":14509,"name":"Pierre Mathieu","email":"pierre-arthur.mathieu@hpe.com","username":"slashme"},"change_message_id":"c4130d4d421bc1b7cec4e248de0d776aadde290f","unresolved":false,"context_lines":[{"line_number":351,"context_line":"                     \u0027restore.\u0027),"},{"line_number":352,"context_line":"    cfg.StrOpt(\u0027restore_nova_nic\u0027,"},{"line_number":353,"context_line":"               dest\u003d\u0027restore_nova_nic\u0027,"},{"line_number":354,"context_line":"               help\u003d\"ID of networks. Config restore the nova used by the network. If there is \""},{"line_number":355,"context_line":"                    \"only one network on the tenants, it don\u0027t need to configure the parameters. \""},{"line_number":356,"context_line":"                    \"If not, config the parameters to restore nova.\")"},{"line_number":357,"context_line":"]"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_5554cec8","line":356,"range":{"start_line":354,"start_character":20,"end_line":356,"end_character":68},"updated":"2016-05-10 10:20:33.000000000","message":"This help message needs to be reworked.\n\nHow about:\n\nId of the network to attach to the restored VM. In the case of a project containing multiple network, it is necessary to provide the Id of the network to attach to the restored VM.","commit_id":"be44cd0d22524b38fb02494828d8f50a7e5bd15a"},{"author":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"change_message_id":"e350be50772530c14a0e4444250b45069c01abe9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    \u0027windows_volume\u0027: \u0027\u0027, \u0027command\u0027: None, \u0027metadata_out\u0027: False,"},{"line_number":64,"context_line":"    \u0027storage\u0027: \u0027swift\u0027, \u0027ssh_key\u0027: \u0027\u0027, \u0027ssh_username\u0027: \u0027\u0027, \u0027ssh_host\u0027: \u0027\u0027,"},{"line_number":65,"context_line":"    \u0027ssh_port\u0027: DEFAULT_SSH_PORT, \u0027compression\u0027: \u0027gzip\u0027,"},{"line_number":66,"context_line":"    \u0027overwrite\u0027: False, \u0027restore_nova_nic\u0027: \u0027\u0027,"},{"line_number":67,"context_line":"}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_375c934a","line":66,"range":{"start_line":66,"start_character":44,"end_line":66,"end_character":47},"updated":"2016-05-26 14:39:58.000000000","message":"It\u0027s better to use None","commit_id":"6c1ac248f74287af0726d0161578e63d9a640eb3"},{"author":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"change_message_id":"e350be50772530c14a0e4444250b45069c01abe9","unresolved":false,"context_lines":[{"line_number":351,"context_line":"                     \u0027restore.\u0027),"},{"line_number":352,"context_line":"    cfg.StrOpt(\u0027restore-nova-nic\u0027,"},{"line_number":353,"context_line":"               dest\u003d\u0027restore_nova_nic\u0027,"},{"line_number":354,"context_line":"               help\u003d\"Id of the network to attach to the restored VM. \""},{"line_number":355,"context_line":"                    \"In the case of a project containing multiple network, \""},{"line_number":356,"context_line":"                    \"it is necessary to provide the Id of the network to \""},{"line_number":357,"context_line":"                    \"attach to the restored VM.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_d2ff15ff","line":354,"range":{"start_line":354,"start_character":21,"end_line":354,"end_character":23},"updated":"2016-05-26 14:39:58.000000000","message":"I would say \"ID\" not \"Id\"","commit_id":"6c1ac248f74287af0726d0161578e63d9a640eb3"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"ce476df05d1623cb7f0daa1f3ab616a742a3b3a2","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    cfg.StrOpt(\u0027restore-nova-nic\u0027,"},{"line_number":372,"context_line":"               dest\u003d\u0027restore_nova_nic\u0027,"},{"line_number":373,"context_line":"               help\u003d\"ID of the network to attach to the restored VM. \""},{"line_number":374,"context_line":"                    \"In the case of a project containing multiple network, \""},{"line_number":375,"context_line":"                    \"it is necessary to provide the Id of the network to \""},{"line_number":376,"context_line":"                    \"attach to the restored VM.\")"},{"line_number":377,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_223d57c4","line":374,"updated":"2016-05-27 02:06:57.000000000","message":"\"In the case of a project containing multiple networks, \"\n\nNeed to add an \u0027s\u0027 to \u0027network\u0027.","commit_id":"feefb7cf7da3cf26ede8e0dc59b1643bd4298c67"},{"author":{"_account_id":15041,"name":"Domhnall Walsh","email":"domhnall.eam.walsh@hpe.com","username":"domhnall"},"change_message_id":"d3de7645488a48283e6a57161a95d90931e261e7","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    \u0027ssh_port\u0027: DEFAULT_SSH_PORT, \u0027compression\u0027: \u0027gzip\u0027,"},{"line_number":79,"context_line":"    \u0027overwrite\u0027: False,"},{"line_number":80,"context_line":"    \u0027consistency_check\u0027: False, \u0027consistency_checksum\u0027: None,"},{"line_number":81,"context_line":"    \u0027restore_nova_nic\u0027: None,"},{"line_number":82,"context_line":"}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_9c81cc92","line":81,"range":{"start_line":81,"start_character":5,"end_line":81,"end_character":21},"updated":"2016-07-18 07:44:01.000000000","message":"Should be \"nova-restore-network\"?","commit_id":"ab1f6e050efff2826e8bfed0f567745238b34c6a"}],"freezer/job.py":[{"author":{"_account_id":15041,"name":"Domhnall Walsh","email":"domhnall.eam.walsh@hpe.com","username":"domhnall"},"change_message_id":"d3de7645488a48283e6a57161a95d90931e261e7","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        res \u003d restore.RestoreOs(conf.client_manager, conf.container)"},{"line_number":231,"context_line":"        if conf.backup_media \u003d\u003d \u0027nova\u0027:"},{"line_number":232,"context_line":"            nova_network \u003d None"},{"line_number":233,"context_line":"            if conf.restore_nova_nic:"},{"line_number":234,"context_line":"                nova_network \u003d conf.nova_restore_network"},{"line_number":235,"context_line":"            res.restore_nova(conf.nova_inst_id, restore_timestamp,"},{"line_number":236,"context_line":"                             nova_network)"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_dc622416","line":233,"range":{"start_line":233,"start_character":20,"end_line":233,"end_character":36},"updated":"2016-07-18 07:44:01.000000000","message":"Should be \"nova-restore-network\" I think?","commit_id":"ab1f6e050efff2826e8bfed0f567745238b34c6a"}],"freezer/openstack/restore.py":[{"author":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"change_message_id":"828a5267457cb10fd8d8cc740bc4433e4483b9eb","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        \"\"\""},{"line_number":122,"context_line":"        nova \u003d self.client_manager.get_nova()"},{"line_number":123,"context_line":"        nic_num \u003d len(nova.networks.findall())"},{"line_number":124,"context_line":"        if nic_num \u003e 1 and (restore_nic is None):"},{"line_number":125,"context_line":"            raise Exception(\"The parameter --restore-nova-nic required\")"},{"line_number":126,"context_line":"        (info, image) \u003d self._create_image(instance_id, restore_from_timestamp)"},{"line_number":127,"context_line":"        flavor \u003d nova.flavors.get(info[\u0027x-object-meta-flavor-id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_defcd240","line":124,"updated":"2016-05-27 15:38:28.000000000","message":"I think here should verify the restore_nic is available","commit_id":"feefb7cf7da3cf26ede8e0dc59b1643bd4298c67"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"ce476df05d1623cb7f0daa1f3ab616a742a3b3a2","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        nova \u003d self.client_manager.get_nova()"},{"line_number":123,"context_line":"        nic_num \u003d len(nova.networks.findall())"},{"line_number":124,"context_line":"        if nic_num \u003e 1 and (restore_nic is None):"},{"line_number":125,"context_line":"            raise Exception(\"The parameter --restore-nova-nic required\")"},{"line_number":126,"context_line":"        (info, image) \u003d self._create_image(instance_id, restore_from_timestamp)"},{"line_number":127,"context_line":"        flavor \u003d nova.flavors.get(info[\u0027x-object-meta-flavor-id\u0027])"},{"line_number":128,"context_line":"        logging.info(\"[*] Creation an instance\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_4245fb40","line":125,"range":{"start_line":125,"start_character":62,"end_line":125,"end_character":70},"updated":"2016-05-27 02:06:57.000000000","message":"\"The parameter --restore-nova-nic is required\"","commit_id":"feefb7cf7da3cf26ede8e0dc59b1643bd4298c67"},{"author":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"change_message_id":"ced89d7da4f48d883bf66d22fa8cd6f1dea73459","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        :param restore_from_timestamp:"},{"line_number":118,"context_line":"        :type restore_from_timestamp: int"},{"line_number":119,"context_line":"        :param instance_id: id of attached nova instance"},{"line_number":120,"context_line":"        :param restor_nic: id of network"},{"line_number":121,"context_line":"        :return:"},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        nova \u003d self.client_manager.get_nova()"}],"source_content_type":"text/x-python","patch_set":8,"id":"9abb7d3a_40bc6e05","line":120,"range":{"start_line":120,"start_character":15,"end_line":120,"end_character":25},"updated":"2016-05-28 06:16:49.000000000","message":"typo error","commit_id":"f8c0448bc8c9d2218ba128bbca1e47b43aaafafc"},{"author":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"change_message_id":"ced89d7da4f48d883bf66d22fa8cd6f1dea73459","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        nic_list \u003d nova.networks.findall()"},{"line_number":125,"context_line":"        if len(nic_list) \u003e 1 and (restore_nic is None):"},{"line_number":126,"context_line":"            raise Exception(\"The parameter --restore-nova-nic is required\")"},{"line_number":127,"context_line":"        if restore_nic and (restore_nic not in nova_list):"},{"line_number":128,"context_line":"            raise Exception(\"The network %s is invalid\" %restore_nic)"},{"line_number":129,"context_line":"        (info, image) \u003d self._create_image(instance_id, restore_from_timestamp)"},{"line_number":130,"context_line":"        flavor \u003d nova.flavors.get(info[\u0027x-object-meta-flavor-id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"9abb7d3a_e041220d","line":127,"range":{"start_line":127,"start_character":47,"end_line":127,"end_character":56},"updated":"2016-05-28 06:16:49.000000000","message":"nic_list","commit_id":"f8c0448bc8c9d2218ba128bbca1e47b43aaafafc"},{"author":{"_account_id":15041,"name":"Domhnall Walsh","email":"domhnall.eam.walsh@hpe.com","username":"domhnall"},"change_message_id":"d3de7645488a48283e6a57161a95d90931e261e7","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        size \u003d length / gb"},{"line_number":106,"context_line":"        if length % gb \u003e 0:"},{"line_number":107,"context_line":"            size +\u003d 1"},{"line_number":108,"context_line":"        LOG.info(\"Creation volume from image\")"},{"line_number":109,"context_line":"        self.client_manager.get_cinder().volumes.create(size,"},{"line_number":110,"context_line":"                                                        imageRef\u003dimage.id)"},{"line_number":111,"context_line":"        LOG.info(\"Deleting temporary image\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_fcd568b9","line":108,"range":{"start_line":108,"start_character":18,"end_line":108,"end_character":26},"updated":"2016-07-18 07:44:01.000000000","message":"Should be \"Creating\"","commit_id":"ab1f6e050efff2826e8bfed0f567745238b34c6a"},{"author":{"_account_id":15041,"name":"Domhnall Walsh","email":"domhnall.eam.walsh@hpe.com","username":"domhnall"},"change_message_id":"d3de7645488a48283e6a57161a95d90931e261e7","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        :param restore_from_timestamp:"},{"line_number":118,"context_line":"        :type restore_from_timestamp: int"},{"line_number":119,"context_line":"        :param instance_id: id of attached nova instance"},{"line_number":120,"context_line":"        :param restore_nic: id of network"},{"line_number":121,"context_line":"        :return:"},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        nova \u003d self.client_manager.get_nova()"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_9c770c02","line":120,"range":{"start_line":120,"start_character":15,"end_line":120,"end_character":26},"updated":"2016-07-18 07:44:01.000000000","message":"Should be nova_network to be consistent with the method signature?","commit_id":"ab1f6e050efff2826e8bfed0f567745238b34c6a"},{"author":{"_account_id":15041,"name":"Domhnall Walsh","email":"domhnall.eam.walsh@hpe.com","username":"domhnall"},"change_message_id":"d3de7645488a48283e6a57161a95d90931e261e7","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        nova \u003d self.client_manager.get_nova()"},{"line_number":124,"context_line":"        nic_list \u003d nova.networks.findall()"},{"line_number":125,"context_line":"        if len(nic_list) \u003e 1 and (nova_network is None):"},{"line_number":126,"context_line":"            raise Exception(\"The parameter --restore-nova-nic is required\")"},{"line_number":127,"context_line":"        if nova_network and (nova_network not in nic_list):"},{"line_number":128,"context_line":"            raise Exception(\"The network %s is invalid\" % nova_network)"},{"line_number":129,"context_line":"        (info, image) \u003d self._create_image(instance_id, restore_from_timestamp)"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_bc7db0e9","line":126,"range":{"start_line":126,"start_character":45,"end_line":126,"end_character":61},"updated":"2016-07-18 07:44:01.000000000","message":"Should be \"nova-restore-network\" I think?","commit_id":"ab1f6e050efff2826e8bfed0f567745238b34c6a"},{"author":{"_account_id":15041,"name":"Domhnall Walsh","email":"domhnall.eam.walsh@hpe.com","username":"domhnall"},"change_message_id":"d3de7645488a48283e6a57161a95d90931e261e7","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        :return:"},{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        nova \u003d self.client_manager.get_nova()"},{"line_number":124,"context_line":"        nic_list \u003d nova.networks.findall()"},{"line_number":125,"context_line":"        if len(nic_list) \u003e 1 and (nova_network is None):"},{"line_number":126,"context_line":"            raise Exception(\"The parameter --restore-nova-nic is required\")"},{"line_number":127,"context_line":"        if nova_network and (nova_network not in nic_list):"},{"line_number":128,"context_line":"            raise Exception(\"The network %s is invalid\" % nova_network)"},{"line_number":129,"context_line":"        (info, image) \u003d self._create_image(instance_id, restore_from_timestamp)"},{"line_number":130,"context_line":"        flavor \u003d nova.flavors.get(info[\u0027x-object-meta-flavor-id\u0027])"},{"line_number":131,"context_line":"        LOG.info(\"Creation an instance\")"},{"line_number":132,"context_line":"        if nova_network is None:"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_7c9058ed","line":129,"range":{"start_line":124,"start_character":0,"end_line":129,"end_character":79},"updated":"2016-07-18 07:44:01.000000000","message":"\"nic_list\" should probably be something like \"network_list\" or similar for clarity.","commit_id":"ab1f6e050efff2826e8bfed0f567745238b34c6a"},{"author":{"_account_id":15041,"name":"Domhnall Walsh","email":"domhnall.eam.walsh@hpe.com","username":"domhnall"},"change_message_id":"d3de7645488a48283e6a57161a95d90931e261e7","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            raise Exception(\"The network %s is invalid\" % nova_network)"},{"line_number":129,"context_line":"        (info, image) \u003d self._create_image(instance_id, restore_from_timestamp)"},{"line_number":130,"context_line":"        flavor \u003d nova.flavors.get(info[\u0027x-object-meta-flavor-id\u0027])"},{"line_number":131,"context_line":"        LOG.info(\"Creation an instance\")"},{"line_number":132,"context_line":"        if nova_network is None:"},{"line_number":133,"context_line":"            nova.servers.create(info[\u0027x-object-meta-name\u0027], image, flavor)"},{"line_number":134,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"dada55a8_dc5fc473","line":131,"range":{"start_line":131,"start_character":18,"end_line":131,"end_character":26},"updated":"2016-07-18 07:44:01.000000000","message":"Should be \"Creating\"","commit_id":"ab1f6e050efff2826e8bfed0f567745238b34c6a"}]}