)]}'
{"devstack/gate_hook.sh":[{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"e0d349920f2a81629eef717a357d9cb18239c4e6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"echo \"Start Gate Hook\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin freezer https://git.openstack.org/openstack/freezer\""},{"line_number":21,"context_line":"export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"enable_plugin freezer-api https://git.openstack.org/openstack/freezer-api\""},{"line_number":22,"context_line":"# Swift is needed for some of the integration tests"},{"line_number":23,"context_line":"export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"enable_service s-proxy s-object s-container s-account\""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-sh","patch_set":18,"id":"7aa08908_e6acad8e","line":21,"updated":"2016-06-09 16:36:28.000000000","message":"Would a space be better than a newline? newline is a bit confusing if you just need white space. Not sure why you chose a newline. Is that what other projects do?","commit_id":"a0ed47c03573b0fb5b77c2bfa790edac1d8e8651"},{"author":{"_account_id":14028,"name":"Jonas Pfannschmidt","email":"jonas.pfannschmidt@hp.com","username":"jonaspf"},"change_message_id":"4816c4ae2b2e0f8028966196446448551a283710","unresolved":false,"context_lines":[{"line_number":18,"context_line":"echo \"Start Gate Hook\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin freezer https://git.openstack.org/openstack/freezer\""},{"line_number":21,"context_line":"export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"enable_plugin freezer-api https://git.openstack.org/openstack/freezer-api\""},{"line_number":22,"context_line":"# Swift is needed for some of the integration tests"},{"line_number":23,"context_line":"export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"enable_service s-proxy s-object s-container s-account\""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-sh","patch_set":18,"id":"7aa08908_dc2ea4a4","line":21,"in_reply_to":"7aa08908_e6acad8e","updated":"2016-06-09 17:05:02.000000000","message":"I just copied this from other projects. I assume the newline is necessary because everyone else does it that way but I\u0027m not sure.","commit_id":"a0ed47c03573b0fb5b77c2bfa790edac1d8e8651"}],"freezer/tests/freezer_tempest_plugin/tests/scenario/test_backups.py":[{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"2514f401fa040ef26071ad77c137b14eeddb6c7f","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    credentials \u003d [\u0027primary\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"},{"line_number":38,"context_line":"    def setup_clients(cls):"},{"line_number":39,"context_line":"        super(BaseFreezerCliTest, cls).setup_clients()"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_301b3282","line":37,"range":{"start_line":37,"start_character":5,"end_line":37,"end_character":16},"updated":"2016-05-25 16:09:50.000000000","message":"Does this need to be a class method? Could this method just access the class variables withouth being class method?","commit_id":"630edb6b078a368b170dc0367f46c967254422b9"},{"author":{"_account_id":14028,"name":"Jonas Pfannschmidt","email":"jonas.pfannschmidt@hp.com","username":"jonaspf"},"change_message_id":"13c83f159180b8f9217afbba26a5ebcc66b8cd5c","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    credentials \u003d [\u0027primary\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"},{"line_number":38,"context_line":"    def setup_clients(cls):"},{"line_number":39,"context_line":"        super(BaseFreezerCliTest, cls).setup_clients()"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_3d0b7b2d","line":37,"range":{"start_line":37,"start_character":5,"end_line":37,"end_character":16},"in_reply_to":"bab6814e_301b3282","updated":"2016-06-09 11:33:52.000000000","message":"I believe this has to be a class method. Reason: the superclass calls this function from the setupClass function which itself is a class method.\nThe benefit is that all this initialisation stuff is only done once when the class is set up and not for every single test.","commit_id":"630edb6b078a368b170dc0367f46c967254422b9"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"2514f401fa040ef26071ad77c137b14eeddb6c7f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def setup_clients(cls):"},{"line_number":39,"context_line":"        super(BaseFreezerCliTest, cls).setup_clients()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        uri \u003d cls.os_primary.auth_provider.auth_client.auth_url[:-len(\u0027/tokens\u0027)]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        cls.cli \u003d CLIClientWithFreezer("},{"line_number":44,"context_line":"            username \u003d cls.os_primary.credentials.credentials.username,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_b907151c","line":41,"range":{"start_line":41,"start_character":78,"end_line":41,"end_character":81},"updated":"2016-05-25 16:09:50.000000000","message":"Could we refactor these kinds of manipulations into a method that has a meaningful name?","commit_id":"630edb6b078a368b170dc0367f46c967254422b9"},{"author":{"_account_id":14028,"name":"Jonas Pfannschmidt","email":"jonas.pfannschmidt@hp.com","username":"jonaspf"},"change_message_id":"13c83f159180b8f9217afbba26a5ebcc66b8cd5c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def setup_clients(cls):"},{"line_number":39,"context_line":"        super(BaseFreezerCliTest, cls).setup_clients()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        uri \u003d cls.os_primary.auth_provider.auth_client.auth_url[:-len(\u0027/tokens\u0027)]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        cls.cli \u003d CLIClientWithFreezer("},{"line_number":44,"context_line":"            username \u003d cls.os_primary.credentials.credentials.username,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_4812035a","line":41,"range":{"start_line":41,"start_character":78,"end_line":41,"end_character":81},"in_reply_to":"bab6814e_b907151c","updated":"2016-06-09 11:33:52.000000000","message":"Absolutely. I\u0027m fixing this in the next patchset","commit_id":"630edb6b078a368b170dc0367f46c967254422b9"}]}