)]}'
{"freezer/scheduler/daemon.py":[{"author":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"change_message_id":"0a30cca33f18025cd2d3ec65587a3d004a8fec58","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    @staticmethod"},{"line_number":97,"context_line":"    def handle_program_exit(signum, frame):"},{"line_number":98,"context_line":"        logging.info(\u0027Got signal {0}. Exiting ...\u0027.format(signum))"},{"line_number":99,"context_line":"        NoDaemon.exit_flag \u003d True"},{"line_number":100,"context_line":"        NoDaemon.instance.daemonizable.stop()"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3aaa91ec_25593d5b","line":98,"range":{"start_line":98,"start_character":9,"end_line":98,"end_character":20},"updated":"2016-06-29 03:21:56.000000000","message":"I think these lines should be modified, either","commit_id":"f1597c5f35a723e75dfa4eb71cf4f38a35128a0e"},{"author":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"change_message_id":"437bf28da5bb798db686baa5db50e24852323e09","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    @staticmethod"},{"line_number":97,"context_line":"    def handle_program_exit(signum, frame):"},{"line_number":98,"context_line":"        logging.info(\u0027Got signal {0}. Exiting ...\u0027.format(signum))"},{"line_number":99,"context_line":"        NoDaemon.exit_flag \u003d True"},{"line_number":100,"context_line":"        NoDaemon.instance.daemonizable.stop()"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3aaa91ec_31504232","line":98,"range":{"start_line":98,"start_character":9,"end_line":98,"end_character":20},"in_reply_to":"3aaa91ec_11d9c622","updated":"2016-06-29 14:09:00.000000000","message":"but you have modify the other scheduler files, too.","commit_id":"f1597c5f35a723e75dfa4eb71cf4f38a35128a0e"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"a99d24aa04f08ddd0d3e0718f7e9838785b21b0a","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    @staticmethod"},{"line_number":97,"context_line":"    def handle_program_exit(signum, frame):"},{"line_number":98,"context_line":"        logging.info(\u0027Got signal {0}. Exiting ...\u0027.format(signum))"},{"line_number":99,"context_line":"        NoDaemon.exit_flag \u003d True"},{"line_number":100,"context_line":"        NoDaemon.instance.daemonizable.stop()"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3aaa91ec_11d9c622","line":98,"range":{"start_line":98,"start_character":9,"end_line":98,"end_character":20},"in_reply_to":"3aaa91ec_25593d5b","updated":"2016-06-29 14:04:07.000000000","message":"The scheduler is doing some log configuration with the python logging. Since the scheduler will be split apart from the agent, and because the scheduler does the logging configuration it would be better at this time to not make any changes to the scheduler module logging.","commit_id":"f1597c5f35a723e75dfa4eb71cf4f38a35128a0e"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"52f738b9af3d805576b23b6e49a4ad48c8f0af66","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    @staticmethod"},{"line_number":97,"context_line":"    def handle_program_exit(signum, frame):"},{"line_number":98,"context_line":"        logging.info(\u0027Got signal {0}. Exiting ...\u0027.format(signum))"},{"line_number":99,"context_line":"        NoDaemon.exit_flag \u003d True"},{"line_number":100,"context_line":"        NoDaemon.instance.daemonizable.stop()"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3aaa91ec_837e0d68","line":98,"range":{"start_line":98,"start_character":9,"end_line":98,"end_character":20},"in_reply_to":"3aaa91ec_31504232","updated":"2016-06-29 14:11:39.000000000","message":"I reverted the files in the scheduler module except for the following:\n\n1) removed the \u0027[*]\u0027\n2) renamed logging to LOG\n\nThat is the only change. If you see anymore changes, please let me know. Thanks.","commit_id":"f1597c5f35a723e75dfa4eb71cf4f38a35128a0e"}],"freezer/snapshot/lvm.py":[{"author":{"_account_id":17001,"name":"Tim Buckley","email":"timothy.jas.buckley@hpe.com","username":"timothy.jas.buckley"},"change_message_id":"a0298deaabf9fff9b80694d7665f4e802fd8e5b4","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    if lvm_process.returncode:"},{"line_number":147,"context_line":"        raise Exception(\u0027lvm snapshot creation error: {0}\u0027.format(lvm_err))"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    LOG.debug(\u0027{0}\u0027.format(lvm_out))"},{"line_number":150,"context_line":"    LOG.warning(\u0027Logical volume \"{0}\" created\u0027."},{"line_number":151,"context_line":"                format(backup_opt_dict.lvm_snapname))"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_544a1256","line":149,"range":{"start_line":149,"start_character":4,"end_line":149,"end_character":36},"updated":"2016-06-23 19:24:23.000000000","message":"nit: I think this could just be LOG.debug(lvm_out)","commit_id":"2df161702254a352d839a086bf93c4acf8696138"}],"freezer/utils/config.py":[{"author":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"change_message_id":"0a30cca33f18025cd2d3ec65587a3d004a8fec58","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from six.moves import configparser"},{"line_number":20,"context_line":"from six.moves import cStringIO"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from oslo_log import log"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from freezer.utils import utils"}],"source_content_type":"text/x-python","patch_set":14,"id":"3aaa91ec_48858057","line":22,"updated":"2016-06-29 03:21:56.000000000","message":"why import config here, I didn\u0027t see any use in this file?","commit_id":"f1597c5f35a723e75dfa4eb71cf4f38a35128a0e"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"a99d24aa04f08ddd0d3e0718f7e9838785b21b0a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from six.moves import configparser"},{"line_number":20,"context_line":"from six.moves import cStringIO"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from oslo_log import log"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from freezer.utils import utils"}],"source_content_type":"text/x-python","patch_set":14,"id":"3aaa91ec_1118a61d","line":22,"in_reply_to":"3aaa91ec_48858057","updated":"2016-06-29 14:04:07.000000000","message":"Done","commit_id":"f1597c5f35a723e75dfa4eb71cf4f38a35128a0e"}]}