)]}'
{"freezer/engine/tar/tar_engine.py":[{"author":{"_account_id":17001,"name":"Tim Buckley","email":"timothy.jas.buckley@hpe.com","username":"timothy.jas.buckley"},"change_message_id":"0991bcc5ce6c815628797c3b6fbb9187ef66f85f","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        tar_err \u003d process.communicate()[1]"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        if tar_err:"},{"line_number":147,"context_line":"            logging.exception(\u0027[*] {0} error: {1}\u0027.format(function, tar_err))"},{"line_number":148,"context_line":"            raise Exception(tar_err)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        if process.returncode:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_29053310","line":147,"range":{"start_line":147,"start_character":31,"end_line":147,"end_character":34},"updated":"2016-06-24 21:17:44.000000000","message":"Probably best not to include these since the logging patch removes them?","commit_id":"25911e13652963932fa39fc042fb9bf5d484dfb5"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"c070db06231534ce4ea12e2ba14974fc28f38407","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        tar_err \u003d process.communicate()[1]"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        if tar_err:"},{"line_number":147,"context_line":"            logging.exception(\u0027[*] {0} error: {1}\u0027.format(function, tar_err))"},{"line_number":148,"context_line":"            raise Exception(tar_err)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        if process.returncode:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_e9d5ebe4","line":147,"range":{"start_line":147,"start_character":31,"end_line":147,"end_character":34},"in_reply_to":"3aaa91ec_29053310","updated":"2016-06-24 21:36:12.000000000","message":"Done","commit_id":"25911e13652963932fa39fc042fb9bf5d484dfb5"},{"author":{"_account_id":14509,"name":"Pierre Mathieu","email":"pierre-arthur.mathieu@hpe.com","username":"slashme"},"change_message_id":"61035af3abc81d12a6a3ebcaa5ec3c00a891297f","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        \"\"\""},{"line_number":144,"context_line":"        tar_err \u003d process.communicate()[1]"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        if tar_err:"},{"line_number":147,"context_line":"            logging.error(\u0027{0} error: {1}\u0027.format(function, tar_err))"},{"line_number":148,"context_line":"            raise Exception(tar_err)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        if process.returncode:"},{"line_number":151,"context_line":"            logging.error(\u0027{0} return code is not 0\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_80e4cdab","line":148,"range":{"start_line":146,"start_character":0,"end_line":148,"end_character":36},"updated":"2016-06-27 11:25:27.000000000","message":"Do we really want to raise when anything is written to stderr? \nAre we sure that tar only write in STDERR in case of an unrecoverable error ?\n\nHow about logging if tar_err contains something and only raising if returncode !\u003d 0 ?\n\n\n\n\nAlso, I just noticed we need to use pipestatus in tar_builder when using encryption. Right now the return code we get is only the one from openssl and we lose the one from tar.","commit_id":"7e648b5d5395322ab01e2aac81787f74ae3b6860"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"26e7485d977ac813d36deee2ae05583cec53e993","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        \"\"\""},{"line_number":144,"context_line":"        tar_err \u003d process.communicate()[1]"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        if tar_err:"},{"line_number":147,"context_line":"            logging.error(\u0027{0} error: {1}\u0027.format(function, tar_err))"},{"line_number":148,"context_line":"            raise Exception(tar_err)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        if process.returncode:"},{"line_number":151,"context_line":"            logging.error(\u0027{0} return code is not 0\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_e1a82cde","line":148,"range":{"start_line":146,"start_character":0,"end_line":148,"end_character":36},"in_reply_to":"3aaa91ec_80e4cdab","updated":"2016-06-27 13:46:36.000000000","message":"Done","commit_id":"7e648b5d5395322ab01e2aac81787f74ae3b6860"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"7f8c08a736db5e8058a09316533b34964a25089f","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        \"\"\""},{"line_number":144,"context_line":"        tar_err \u003d process.communicate()[1]"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        if tar_err:"},{"line_number":147,"context_line":"            logging.error(\u0027{0} error: {1}\u0027.format(function, tar_err))"},{"line_number":148,"context_line":"            raise Exception(tar_err)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        if process.returncode:"},{"line_number":151,"context_line":"            logging.error(\u0027{0} return code is not 0\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_2c4a3328","line":148,"range":{"start_line":146,"start_character":0,"end_line":148,"end_character":36},"in_reply_to":"3aaa91ec_80e4cdab","updated":"2016-06-27 11:59:52.000000000","message":"I think we do want to raise when anything is written to stderr for the following reasons.\n\n1. Several manual tests show that stderr is non-empty when only errors occur.\n2. The spec for stderr/linux/unix states that error messages should go to stderr and possibly diagnostics.\n3. It is probably better to be conservative and then relax if necessary.\n\nThat being said, I\u0027m fine with only raising an exception if return code is non-zero since return code should always be non-zero if stderr is non-empty.\n\nCan we open another bug for the pipestatus issue?","commit_id":"7e648b5d5395322ab01e2aac81787f74ae3b6860"}]}