)]}'
{"freezer/openstack/osclients.py":[{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"f48ff0e5b76ddf31788710d4877d127847d9baad","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            os_options[\u0027region_name\u0027] \u003d self.swift_args.get(\u0027region_name\u0027)"},{"line_number":116,"context_line":"        if \u0027endpoint_type\u0027 in self.swift_args.keys():"},{"line_number":117,"context_line":"            os_options[\u0027endpoint_type\u0027] \u003d self.swift_args.pop(\u0027endpoint_type\u0027)"},{"line_number":118,"context_line":"        if \u0027tenant_id\u0027 in self.swift_args.keys():"},{"line_number":119,"context_line":"            os_options[\u0027tenant_id\u0027] \u003d self.swift_args.pop(\u0027tenant_id\u0027)"},{"line_number":120,"context_line":"        if \u0027identity_api_version\u0027 in self.swift_args.keys():"},{"line_number":121,"context_line":"            os_options[\u0027identity_api_version\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_6b0261b6","line":118,"range":{"start_line":118,"start_character":11,"end_line":118,"end_character":22},"updated":"2016-07-07 20:55:23.000000000","message":"what about project_id? \u0027tenant\u0027 is deprecated in favour of \u0027project\u0027.","commit_id":"1b88853e76d230a3d50133f8f10e09c1d13b3f49"},{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"b1eebf5d5b6a3f655fb8a6026ab1aaaa249992a6","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            os_options[\u0027region_name\u0027] \u003d self.swift_args.get(\u0027region_name\u0027)"},{"line_number":116,"context_line":"        if \u0027endpoint_type\u0027 in self.swift_args.keys():"},{"line_number":117,"context_line":"            os_options[\u0027endpoint_type\u0027] \u003d self.swift_args.pop(\u0027endpoint_type\u0027)"},{"line_number":118,"context_line":"        if \u0027tenant_id\u0027 in self.swift_args.keys():"},{"line_number":119,"context_line":"            os_options[\u0027tenant_id\u0027] \u003d self.swift_args.pop(\u0027tenant_id\u0027)"},{"line_number":120,"context_line":"        if \u0027identity_api_version\u0027 in self.swift_args.keys():"},{"line_number":121,"context_line":"            os_options[\u0027identity_api_version\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_379f1352","line":118,"range":{"start_line":118,"start_character":11,"end_line":118,"end_character":22},"in_reply_to":"1aa78d24_14081528","updated":"2016-07-08 01:39:19.000000000","message":"i didn\u0027t say to remove it, just to add project_id since it is the current parameter. btw, this os_options docstring in swiftclient is out of date :)","commit_id":"1b88853e76d230a3d50133f8f10e09c1d13b3f49"},{"author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"change_message_id":"7fee4f250699cbafe573e1ce6da8db29d6fa0b84","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            os_options[\u0027region_name\u0027] \u003d self.swift_args.get(\u0027region_name\u0027)"},{"line_number":116,"context_line":"        if \u0027endpoint_type\u0027 in self.swift_args.keys():"},{"line_number":117,"context_line":"            os_options[\u0027endpoint_type\u0027] \u003d self.swift_args.pop(\u0027endpoint_type\u0027)"},{"line_number":118,"context_line":"        if \u0027tenant_id\u0027 in self.swift_args.keys():"},{"line_number":119,"context_line":"            os_options[\u0027tenant_id\u0027] \u003d self.swift_args.pop(\u0027tenant_id\u0027)"},{"line_number":120,"context_line":"        if \u0027identity_api_version\u0027 in self.swift_args.keys():"},{"line_number":121,"context_line":"            os_options[\u0027identity_api_version\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_0a08ee27","line":118,"range":{"start_line":118,"start_character":11,"end_line":118,"end_character":22},"in_reply_to":"1aa78d24_379f1352","updated":"2016-07-08 01:52:28.000000000","message":"Yes. The \u0027project_id\u0027 will be added.","commit_id":"1b88853e76d230a3d50133f8f10e09c1d13b3f49"},{"author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"change_message_id":"9efe4193b1ee9b434bd8fa752da30e7d45b3c3f1","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            os_options[\u0027region_name\u0027] \u003d self.swift_args.get(\u0027region_name\u0027)"},{"line_number":116,"context_line":"        if \u0027endpoint_type\u0027 in self.swift_args.keys():"},{"line_number":117,"context_line":"            os_options[\u0027endpoint_type\u0027] \u003d self.swift_args.pop(\u0027endpoint_type\u0027)"},{"line_number":118,"context_line":"        if \u0027tenant_id\u0027 in self.swift_args.keys():"},{"line_number":119,"context_line":"            os_options[\u0027tenant_id\u0027] \u003d self.swift_args.pop(\u0027tenant_id\u0027)"},{"line_number":120,"context_line":"        if \u0027identity_api_version\u0027 in self.swift_args.keys():"},{"line_number":121,"context_line":"            os_options[\u0027identity_api_version\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_14081528","line":118,"range":{"start_line":118,"start_character":11,"end_line":118,"end_character":22},"in_reply_to":"1aa78d24_6b0261b6","updated":"2016-07-08 01:22:34.000000000","message":"The \"tenant_id\" maybe will be used in Class Connection of swift client. https://github.com/openstack/python-swiftclient/blob/master/swiftclient/client.py#L1444","commit_id":"1b88853e76d230a3d50133f8f10e09c1d13b3f49"},{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"f48ff0e5b76ddf31788710d4877d127847d9baad","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            os_options[\u0027auth_token\u0027] \u003d self.swift_args.pop(\u0027token\u0027)"},{"line_number":127,"context_line":"        if \u0027auth_version\u0027 in self.swift_args.keys():"},{"line_number":128,"context_line":"            auth_version \u003d self.swift_args.get(\u0027auth_version\u0027)"},{"line_number":129,"context_line":"        if \u0027project_domain_name\u0027 in self.swift_args.keys():"},{"line_number":130,"context_line":"            os_options[\u0027project_domain_name\u0027] \u003d \\"},{"line_number":131,"context_line":"                self.swift_args.get(\u0027project_domain_name\u0027)"},{"line_number":132,"context_line":"        if \u0027user_domain_name\u0027 in self.swift_args.keys():"},{"line_number":133,"context_line":"            os_options[\u0027user_domain_name\u0027] \u003d \\"},{"line_number":134,"context_line":"                self.swift_args.get(\u0027user_domain_name\u0027)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        tenant_name \u003d self.swift_args.get(\u0027project_name\u0027) or self.swift_args.\\"},{"line_number":137,"context_line":"            get(\u0027tenant_name\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_abd1e931","line":134,"range":{"start_line":129,"start_character":8,"end_line":134,"end_character":55},"updated":"2016-07-07 20:55:23.000000000","message":"please add project_domain and user_domain IDs too, as long as swiftclient supports them.","commit_id":"1b88853e76d230a3d50133f8f10e09c1d13b3f49"},{"author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"change_message_id":"9efe4193b1ee9b434bd8fa752da30e7d45b3c3f1","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            os_options[\u0027auth_token\u0027] \u003d self.swift_args.pop(\u0027token\u0027)"},{"line_number":127,"context_line":"        if \u0027auth_version\u0027 in self.swift_args.keys():"},{"line_number":128,"context_line":"            auth_version \u003d self.swift_args.get(\u0027auth_version\u0027)"},{"line_number":129,"context_line":"        if \u0027project_domain_name\u0027 in self.swift_args.keys():"},{"line_number":130,"context_line":"            os_options[\u0027project_domain_name\u0027] \u003d \\"},{"line_number":131,"context_line":"                self.swift_args.get(\u0027project_domain_name\u0027)"},{"line_number":132,"context_line":"        if \u0027user_domain_name\u0027 in self.swift_args.keys():"},{"line_number":133,"context_line":"            os_options[\u0027user_domain_name\u0027] \u003d \\"},{"line_number":134,"context_line":"                self.swift_args.get(\u0027user_domain_name\u0027)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        tenant_name \u003d self.swift_args.get(\u0027project_name\u0027) or self.swift_args.\\"},{"line_number":137,"context_line":"            get(\u0027tenant_name\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_b44dc19b","line":134,"range":{"start_line":129,"start_character":8,"end_line":134,"end_character":55},"in_reply_to":"1aa78d24_abd1e931","updated":"2016-07-08 01:22:34.000000000","message":"Yes. Except project_domain and user_domain IDs, the project_id should be added also. http://docs.openstack.org/developer/python-swiftclient/client-api.html#keystone-v3","commit_id":"1b88853e76d230a3d50133f8f10e09c1d13b3f49"},{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"7ac482aaa7db656ed463fc95c9fd1e68dc5f675b","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            os_options[\u0027auth_token\u0027] \u003d self.swift_args.pop(\u0027token\u0027)"},{"line_number":127,"context_line":"        if \u0027auth_version\u0027 in self.swift_args.keys():"},{"line_number":128,"context_line":"            auth_version \u003d self.swift_args.get(\u0027auth_version\u0027)"},{"line_number":129,"context_line":"        if \u0027project_domain_name\u0027 in self.swift_args.keys():"},{"line_number":130,"context_line":"            os_options[\u0027project_domain_name\u0027] \u003d \\"},{"line_number":131,"context_line":"                self.swift_args.get(\u0027project_domain_name\u0027)"},{"line_number":132,"context_line":"        if \u0027user_domain_name\u0027 in self.swift_args.keys():"},{"line_number":133,"context_line":"            os_options[\u0027user_domain_name\u0027] \u003d \\"},{"line_number":134,"context_line":"                self.swift_args.get(\u0027user_domain_name\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_aa343afb","line":131,"range":{"start_line":129,"start_character":8,"end_line":131,"end_character":58},"updated":"2016-07-08 02:28:11.000000000","message":"you don\u0027t need to check if these keys are present in self.swift_args because you\u0027re using .get(), so None will be returned if they\u0027re not. for parameters that take None as default value, it\u0027ll be okay and keystoneclient will know how do handle them. swiftclient does that anyway [1], so i think it\u0027d be better to remove these if statements - or at least those related to your change.\n\n[1] https://github.com/openstack/python-swiftclient/blob/master/swiftclient/client.py#L550-L567","commit_id":"16ab9857b3e37110613b4e3daf9c03d9558a8e6c"},{"author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"change_message_id":"1d099a761d15ba530e5ae9098941a87b4b201d66","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            os_options[\u0027auth_token\u0027] \u003d self.swift_args.pop(\u0027token\u0027)"},{"line_number":127,"context_line":"        if \u0027auth_version\u0027 in self.swift_args.keys():"},{"line_number":128,"context_line":"            auth_version \u003d self.swift_args.get(\u0027auth_version\u0027)"},{"line_number":129,"context_line":"        if \u0027project_domain_name\u0027 in self.swift_args.keys():"},{"line_number":130,"context_line":"            os_options[\u0027project_domain_name\u0027] \u003d \\"},{"line_number":131,"context_line":"                self.swift_args.get(\u0027project_domain_name\u0027)"},{"line_number":132,"context_line":"        if \u0027user_domain_name\u0027 in self.swift_args.keys():"},{"line_number":133,"context_line":"            os_options[\u0027user_domain_name\u0027] \u003d \\"},{"line_number":134,"context_line":"                self.swift_args.get(\u0027user_domain_name\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_ad929449","line":131,"range":{"start_line":129,"start_character":8,"end_line":131,"end_character":58},"in_reply_to":"1aa78d24_aa343afb","updated":"2016-07-08 02:48:58.000000000","message":"Good idea! I read the Python API document about dict.get(), the default will be returned when the key is not in the dictionary. If the default is not given, it defaults to None. And this method never raises a KeyError. Therefore, these if statements are redundant.","commit_id":"16ab9857b3e37110613b4e3daf9c03d9558a8e6c"}]}