)]}'
{"freezer/common/config.py":[{"author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"change_message_id":"54b1ed5f0cd2f845c3b4c4f9e800b7a3511f5541","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1ac06dbe_4702570c","updated":"2016-08-23 06:18:13.000000000","message":"In the original code, the \"sys.argv[1:]\" is not available. But it seems to be a unrelated change. When keeping the \"args\u003dsys.argv[1:]\", in the function get_client_manager(backup_args), the --inseurce option can be found in \"backup_args\".","commit_id":"03af2aaecd4487696172409fe3441762c7fb26ef"},{"author":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"change_message_id":"f1acf3f6ad70e8dc553008549b82cbc7c5b3e49e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1ac06dbe_8d02003d","in_reply_to":"1ac06dbe_4702570c","updated":"2016-08-25 10:30:01.000000000","message":"sys.argv[1:] required only once, when registering the cli opts. It\u0027s better to pass it from main so and modify the function to accept args list so we can at least test it","commit_id":"03af2aaecd4487696172409fe3441762c7fb26ef"}],"freezer/openstack/osclients.py":[{"author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"change_message_id":"54b1ed5f0cd2f845c3b4c4f9e800b7a3511f5541","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1ac06dbe_82c1dd56","updated":"2016-08-23 06:18:13.000000000","message":"It\u0027s better to change the default to \"None\" for OS_INSECURE, and in the function get_client_manager(), check if the OS_INSECURE is \"None\", if yes, the --insecure cli will be used in here.\n\nBecause the function create_from_dict() was called by create_from_env() using \"os.environ\" as parameter. So all environment variables will be got from here. We should be not add the cli option in the function.","commit_id":"03af2aaecd4487696172409fe3441762c7fb26ef"},{"author":{"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},"change_message_id":"ea1c204ddb5c1b3b5d01f44d4b174316462a01bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1ac06dbe_5a954a3e","in_reply_to":"1ac06dbe_2d9cac5c","updated":"2016-08-25 14:13:59.000000000","message":"Done","commit_id":"03af2aaecd4487696172409fe3441762c7fb26ef"},{"author":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"change_message_id":"f1acf3f6ad70e8dc553008549b82cbc7c5b3e49e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1ac06dbe_2d9cac5c","in_reply_to":"1ac06dbe_78d72e4b","updated":"2016-08-25 10:30:01.000000000","message":"I think the place of --insecure option is correct. there is not opts for os credentials so we only get it from one place and it\u0027s better to have it all group. So If I didn\u0027t find the OS_INSECURE I have to look for --insecure opt as it\u0027s the only one from os auth registered in freezer-agent. \n\nWhy do I need to do many checks and I can do it only once and in one place ?\n\nI think here is the best place for insecure options to be loaded otherwise I have to handle it in many places instead of one place. The insecure opt can be False or None there is no differences and False should be more relative as it\u0027s a bool flag.","commit_id":"03af2aaecd4487696172409fe3441762c7fb26ef"},{"author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"change_message_id":"c98bbcfd75be753b37ae97aa74e96ff43ed609b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1ac06dbe_78d72e4b","in_reply_to":"1ac06dbe_82c1dd56","updated":"2016-08-23 07:03:56.000000000","message":"Maybe we can check if OS_INSECURE is \"None\" in create_swift()(in the file osclients.py). If yes, the --insecure cli will be used.","commit_id":"03af2aaecd4487696172409fe3441762c7fb26ef"}]}