)]}'
{"freezer/job.py":[{"author":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"change_message_id":"7e6983922b1f8df68924da32b9507a4fa0a18433","unresolved":false,"context_lines":[{"line_number":92,"context_line":"class BackupJob(Job):"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _validate(self):"},{"line_number":95,"context_line":"        if self.conf.backup_media \u003d\u003d \u0027fs\u0027:"},{"line_number":96,"context_line":"            if not self.conf.path_to_backup:"},{"line_number":97,"context_line":"                raise ValueError(\u0027path-to-backup argument must be provided\u0027)"},{"line_number":98,"context_line":"            if self.conf.no_incremental and (self.conf.max_level or"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_3a94fce0","line":95,"range":{"start_line":95,"start_character":21,"end_line":95,"end_character":33},"updated":"2016-09-14 14:41:53.000000000","message":"I think self.conf.mode is more convenient ? What do you think ?","commit_id":"e0106df618a5dc4d617efc00180182d7d9487dc2"},{"author":{"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},"change_message_id":"073e3f0dc082f5aa76454ec85a01eebe837041f5","unresolved":false,"context_lines":[{"line_number":92,"context_line":"class BackupJob(Job):"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _validate(self):"},{"line_number":95,"context_line":"        if self.conf.backup_media \u003d\u003d \u0027fs\u0027:"},{"line_number":96,"context_line":"            if not self.conf.path_to_backup:"},{"line_number":97,"context_line":"                raise ValueError(\u0027path-to-backup argument must be provided\u0027)"},{"line_number":98,"context_line":"            if self.conf.no_incremental and (self.conf.max_level or"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_5cfa9dbe","line":95,"range":{"start_line":95,"start_character":21,"end_line":95,"end_character":33},"in_reply_to":"7a8ec9b2_3a94fce0","updated":"2016-09-14 16:17:06.000000000","message":"Hi saher, self.conf.backup_media is better, because the mode include fs,  mysql mongo,sqlserver. if we backup nova or cinder, the mode is fs, but we  should not to do a validate.\nbut we have a self.conf.backup_media it is ok, when we backup nova, cinder, self.conf.backup_media is nova and cinder, it have a better distinguish between","commit_id":"e0106df618a5dc4d617efc00180182d7d9487dc2"}]}