)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12712,"name":"Gleb Stepanov","email":"gstepanov@mirantis.com","username":"stgleb"},"change_message_id":"c70a088d5f2166a2390130fa1b2ed8895b435a66","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shangzhong Zhu \u003czhu.shangzhong@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-28 11:16:56 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Raise IndexError if backup isn\u0027t exist"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The freezer-agent doesn\u0027t print any error even if backup is not exists"},{"line_number":10,"context_line":"when removing the specified date backup with --remove-from-date or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a74a57a_4985b1ab","line":7,"updated":"2016-11-29 17:05:23.000000000","message":"doesn\u0027t","commit_id":"27e4a6507e0b45bb5b686d2219442f274549d043"}],"freezer/storage/base.py":[{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"2e6a0e56fd1f4cc37a70a18f0fed208ed594f92e","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        if not backups:"},{"line_number":118,"context_line":"            err_msg \u003d \u0027No matching backup name \"{0}\" found\u0027.format("},{"line_number":119,"context_line":"                hostname_backup_name)"},{"line_number":120,"context_line":"            raise IndexError(err_msg)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        for backup in backups:"},{"line_number":123,"context_line":"            backup.remove()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_b0fb7dc0","line":120,"updated":"2016-12-05 10:00:10.000000000","message":"From my point of view, it\u0027s not an error. We should just inform that no matching backup found and nothing was deleted. AFAIK, raising this exception will interrupt performing admin job and this is not right. You took this approach from line 96, in that case raising IndexError is excepted on line 162. But in your case it\u0027s not excepted when remove_older_than() called.","commit_id":"843022de06b6d81e53789350f1002c832f6ccf6d"}]}
