)]}'
{"freezer/engine/engine.py":[{"author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"change_message_id":"e87ca0352def8af5a7a70a1dc27831fcaf25bbdb","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        for level in range(0, max_level + 1):"},{"line_number":247,"context_line":"            backup \u003d backups[level]"},{"line_number":248,"context_line":"            LOG.info(\"Restoring backup {0}\".format("},{"line_number":249,"context_line":"                backup.hostname_backup_name))"},{"line_number":250,"context_line":"            read_pipe, write_pipe \u003d multiprocessing.Pipe()"},{"line_number":251,"context_line":"            process_stream \u003d multiprocessing.Process("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_a981db91","line":248,"updated":"2016-12-01 13:17:23.000000000","message":"If we have a lot of backup levels, this output may be too intrusive. For example, 12 backup levels will produce 12 messages with the same content:\n\u0027Restoring backup blabla\u0027. I recommend two options:\n1. Move this log to line 245, then this message will be printed only once.\nOR\n2. Add to this output info about current backup level, it will be more verbose.\n\nAnd you can use \u0027hostname_backup_name\u0027 function parameter to print it, not to get it from backup object:\nLOG.info(\u0027Restoring backup {0}\u0027.format(hostname_backup_name))\ninstead of\nLOG.info(\u0027Restoring backup {0}\u0027.format(backups[max_level].hostname_backup_name))","commit_id":"f322eb7995c24392df5b9d88c2576716d3a1a1d4"},{"author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"change_message_id":"89d268870f2c385247694fe8879622308da10fd5","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        for level in range(0, max_level + 1):"},{"line_number":247,"context_line":"            backup \u003d backups[level]"},{"line_number":248,"context_line":"            LOG.info(\"Restoring backup {0}\".format("},{"line_number":249,"context_line":"                backup.hostname_backup_name))"},{"line_number":250,"context_line":"            read_pipe, write_pipe \u003d multiprocessing.Pipe()"},{"line_number":251,"context_line":"            process_stream \u003d multiprocessing.Process("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_4f1127ac","line":248,"in_reply_to":"3a71b18c_0cbf3dd1","updated":"2016-12-02 00:56:56.000000000","message":"Thanks a lot. I think it\u0027s better to use LOG.info.\nIn fact, the action of restore data will be not frequently.","commit_id":"f322eb7995c24392df5b9d88c2576716d3a1a1d4"},{"author":{"_account_id":6508,"name":"Dmitry Stepanenko","email":"dstepanenko@mirantis.com","username":"dstepanenko"},"change_message_id":"ff6f0add6a2484731debca9a7795c4338bbf594a","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        for level in range(0, max_level + 1):"},{"line_number":247,"context_line":"            backup \u003d backups[level]"},{"line_number":248,"context_line":"            LOG.info(\"Restoring backup {0}\".format("},{"line_number":249,"context_line":"                backup.hostname_backup_name))"},{"line_number":250,"context_line":"            read_pipe, write_pipe \u003d multiprocessing.Pipe()"},{"line_number":251,"context_line":"            process_stream \u003d multiprocessing.Process("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_0cbf3dd1","line":248,"in_reply_to":"3a71b18c_a981db91","updated":"2016-12-01 13:34:01.000000000","message":"+1 to Ruslan\u0027s comment. I would prefer option #1, but 2nd is also not so bad.\nAlso you can move this message from info to debug level of logs. I mean using LOG.debug(...)","commit_id":"f322eb7995c24392df5b9d88c2576716d3a1a1d4"},{"author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"change_message_id":"89d268870f2c385247694fe8879622308da10fd5","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        for level in range(0, max_level + 1):"},{"line_number":247,"context_line":"            backup \u003d backups[level]"},{"line_number":248,"context_line":"            LOG.info(\"Restoring backup {0}\".format("},{"line_number":249,"context_line":"                backup.hostname_backup_name))"},{"line_number":250,"context_line":"            read_pipe, write_pipe \u003d multiprocessing.Pipe()"},{"line_number":251,"context_line":"            process_stream \u003d multiprocessing.Process("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_afc47b40","line":248,"in_reply_to":"3a71b18c_a981db91","updated":"2016-12-02 00:56:56.000000000","message":"Thanks a lot. Done.","commit_id":"f322eb7995c24392df5b9d88c2576716d3a1a1d4"}]}