)]}'
{"freezer/job.py":[{"author":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"change_message_id":"4a11261202b99c695be1bbff88686534c243902d","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            if not self.conf.no_incremental:"},{"line_number":118,"context_line":"                raise ValueError(\"Incremental nova backup is not supported.\")"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if self.conf.mode \u003d\u003d \u0027cinder\u0027 and self.conf.backup_media \u003d\u003d \u0027fs\u0027:"},{"line_number":121,"context_line":"            if not self.conf.path_to_backup:"},{"line_number":122,"context_line":"                raise ValueError(\u0027path-to-backup argument must be provided\u0027)"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bff0334d_16cde15c","line":120,"updated":"2017-04-05 17:11:28.000000000","message":"This looks weird to me as we can\u0027t have mode\u003dcinder and backup_media\u003dfs as far as I know!","commit_id":"5583b2a2856b76318cb7192d63f93d906c399eec"},{"author":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"change_message_id":"cda71f8c91fbc9a5f3d1660dc584ce273fdbbfcb","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            if not self.conf.no_incremental:"},{"line_number":118,"context_line":"                raise ValueError(\"Incremental nova backup is not supported\")"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"            if not self.conf.nova_inst_id:"},{"line_number":121,"context_line":"                raise ValueError(\"nova-inst-id argument must be provided\")"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if self.conf.mode \u003d\u003d \u0027cinder\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_a079fdfc","line":120,"updated":"2017-04-07 10:07:44.000000000","message":"nova mode works with either nova_inst_id or project_id for tenant backups. You need either to handle both or drop this check!","commit_id":"4d4b9710364dc57f4db198bf9d4b0a54132bc552"},{"author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"change_message_id":"2db7276d5daa69eb1d4736e0ca1bcd273a77e1cb","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            if not self.conf.no_incremental:"},{"line_number":118,"context_line":"                raise ValueError(\"Incremental nova backup is not supported\")"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"            if not self.conf.nova_inst_id:"},{"line_number":121,"context_line":"                raise ValueError(\"nova-inst-id argument must be provided\")"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if self.conf.mode \u003d\u003d \u0027cinder\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_bd6fdf90","line":120,"in_reply_to":"bff0334d_a079fdfc","updated":"2017-04-07 12:23:23.000000000","message":"Done","commit_id":"4d4b9710364dc57f4db198bf9d4b0a54132bc552"}]}
