)]}'
{"freezer/common/config.py":[{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"daad1ca1619800834bd70cd3f323a923f2d57540","unresolved":false,"context_lines":[{"line_number":480,"context_line":"    cfg.IntOpt(\u0027ssh-port\u0027,"},{"line_number":481,"context_line":"               dest\u003d\u0027ssh_port\u0027,"},{"line_number":482,"context_line":"               default\u003dDEFAULT_PARAMS[\u0027ssh_port\u0027],"},{"line_number":483,"context_line":"               help\u003d\"Remote port for ssh(sftp) storage\""},{"line_number":484,"context_line":"                    \" only (default 22)\""},{"line_number":485,"context_line":"               ),"},{"line_number":486,"context_line":"    cfg.StrOpt(\u0027config\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_2de92ce3","line":483,"range":{"start_line":483,"start_character":40,"end_line":483,"end_character":46},"updated":"2018-11-21 03:46:29.000000000","message":"This is confusing. Better be something like \"ssh and sftp\"","commit_id":"b876cbc11bedb37547955e4cb28c1011c7ac9a41"}],"freezer/main.py":[{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"7f2caae7b90d6520260e7e8df64ce451ee80984b","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    elif storage_name \u003d\u003d \"ssh\":"},{"line_number":216,"context_line":"        storage \u003d ssh.SshStorage("},{"line_number":217,"context_line":"            container,"},{"line_number":218,"context_line":"            backup_args[\u0027ssh_key\u0027], backup_args[\u0027ssh_username\u0027],"},{"line_number":219,"context_line":"            backup_args[\u0027ssh_host\u0027],"},{"line_number":220,"context_line":"            int(backup_args[\u0027ssh_port\u0027]),"},{"line_number":221,"context_line":"            max_segment_size\u003dmax_segment_size,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_2af84416","line":218,"range":{"start_line":218,"start_character":6,"end_line":218,"end_character":34},"updated":"2018-11-20 08:58:43.000000000","message":"If the password is provided, this becomes redundant.","commit_id":"59ed1c205b62b3bce71132a9d8aabe5f7c91269f"},{"author":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"change_message_id":"ddb1f3a8efeaf198bd3288f01585bd01263e57c4","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    elif storage_name \u003d\u003d \"ssh\":"},{"line_number":216,"context_line":"        storage \u003d ssh.SshStorage("},{"line_number":217,"context_line":"            container,"},{"line_number":218,"context_line":"            backup_args[\u0027ssh_key\u0027], backup_args[\u0027ssh_username\u0027],"},{"line_number":219,"context_line":"            backup_args[\u0027ssh_host\u0027],"},{"line_number":220,"context_line":"            int(backup_args[\u0027ssh_port\u0027]),"},{"line_number":221,"context_line":"            max_segment_size\u003dmax_segment_size,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_0d2a302d","line":218,"range":{"start_line":218,"start_character":6,"end_line":218,"end_character":34},"in_reply_to":"3f79a3b5_2af84416","updated":"2018-11-21 03:39:06.000000000","message":"done","commit_id":"59ed1c205b62b3bce71132a9d8aabe5f7c91269f"}],"freezer/storage/ssh.py":[{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"7f2caae7b90d6520260e7e8df64ce451ee80984b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":"    _type \u003d \u0027ssh\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, storage_path, ssh_key_path,"},{"line_number":35,"context_line":"                 remote_username, remote_ip, port, max_segment_size,"},{"line_number":36,"context_line":"                 remote_pwd\u003dNone):"},{"line_number":37,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c701890a","line":34,"range":{"start_line":34,"start_character":37,"end_line":34,"end_character":49},"updated":"2018-11-20 08:58:43.000000000","message":"If the user decides to use password as ssh authentication, she still has to provide the ssh_key_path when initialize the SshStorage object. So I think ssh_key_path should also be used as an option.","commit_id":"59ed1c205b62b3bce71132a9d8aabe5f7c91269f"},{"author":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"change_message_id":"ddb1f3a8efeaf198bd3288f01585bd01263e57c4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":"    _type \u003d \u0027ssh\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, storage_path, ssh_key_path,"},{"line_number":35,"context_line":"                 remote_username, remote_ip, port, max_segment_size,"},{"line_number":36,"context_line":"                 remote_pwd\u003dNone):"},{"line_number":37,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ad077cc8","line":34,"range":{"start_line":34,"start_character":37,"end_line":34,"end_character":49},"in_reply_to":"3f79a3b5_326667be","updated":"2018-11-21 03:39:06.000000000","message":"Ok.","commit_id":"59ed1c205b62b3bce71132a9d8aabe5f7c91269f"},{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"487af418fcadf1c6ca48c74b13c03c5bcfde209b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":"    _type \u003d \u0027ssh\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, storage_path, ssh_key_path,"},{"line_number":35,"context_line":"                 remote_username, remote_ip, port, max_segment_size,"},{"line_number":36,"context_line":"                 remote_pwd\u003dNone):"},{"line_number":37,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_326667be","line":34,"range":{"start_line":34,"start_character":37,"end_line":34,"end_character":49},"in_reply_to":"3f79a3b5_6f4e3cc4","updated":"2018-11-21 01:39:16.000000000","message":"No, what I meant is with the current code, the user still needs to provide the ssh_key_path parameter when initializing SshStorage when she uses ssh_password:\n\nnewSshStorage \u003d SshStorage(storagepath, ssh_key_path, usename, ip, port, segmentsize, password)\n\nIt\u0027s better to make it optional, something like:\n\nnewSshStorage \u003d SshStorage(storagepath, usename, ip, port, segmentsize, password)\n\n\nIf you worry about the config.py, so change it.","commit_id":"59ed1c205b62b3bce71132a9d8aabe5f7c91269f"},{"author":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"change_message_id":"6b4fb74e08eb86341ff1c4647a9d4bb7864e1bf7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":"    _type \u003d \u0027ssh\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, storage_path, ssh_key_path,"},{"line_number":35,"context_line":"                 remote_username, remote_ip, port, max_segment_size,"},{"line_number":36,"context_line":"                 remote_pwd\u003dNone):"},{"line_number":37,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6f4e3cc4","line":34,"range":{"start_line":34,"start_character":37,"end_line":34,"end_character":49},"in_reply_to":"3f79a3b5_c701890a","updated":"2018-11-21 00:51:23.000000000","message":"In config.py, The code is as follos:\n\u0027ssh_key\u0027: os.path.join(home, \u0027.ssh/id_rsa\u0027).\nIf users don\u0027t provide ssh_key param, ssh_key exists default value, but ssh_key will not work without the default file .ssh/id_rsa.\n\nIn order to use the ssh_password, we prefer ssh_password to ssh_key. \n1. If the user providers ssh_password, ssh_password will be used, regardless of ssh_key. \n2. If the user does not use ssh_password, it can also be compatible with the usage of ssh_key.\nPlease look at the function def _validate(self):\n        elif self.remote_pwd:\n            return True\n        elif not self.ssh_key_path:\n            raise ValueError(\u0027Please provide path to ssh key using \u0027\n                             \u0027--ssh-key argument\u0027)\n        elif not os.path.exists(self.ssh_key_path):","commit_id":"59ed1c205b62b3bce71132a9d8aabe5f7c91269f"},{"author":{"_account_id":19098,"name":"lumeihong","email":"lu.meihong@zte.com.cn","username":"lu-meihong"},"change_message_id":"768e9bccd4e38eae4476b60863e8bca77dce3579","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                             \u0027it exists and ensure backup node can \u0027"},{"line_number":72,"context_line":"                             \u0027login to {1} as user {2} \u0027"},{"line_number":73,"context_line":"                             \u0027without password.\\n\u0027"},{"line_number":74,"context_line":"                             \u0027 or \\n\u0027"},{"line_number":75,"context_line":"                             \u00272. --ssh-password argument is required and\u0027"},{"line_number":76,"context_line":"                             \u0027ensure backup node can login to {1} \u0027"},{"line_number":77,"context_line":"                             \u0027as user {2} with password.\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_72dfff38","line":74,"updated":"2018-11-21 01:54:34.000000000","message":"\u0027or\u0027 may be deleted","commit_id":"59ed1c205b62b3bce71132a9d8aabe5f7c91269f"},{"author":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"change_message_id":"ddb1f3a8efeaf198bd3288f01585bd01263e57c4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                             \u0027it exists and ensure backup node can \u0027"},{"line_number":72,"context_line":"                             \u0027login to {1} as user {2} \u0027"},{"line_number":73,"context_line":"                             \u0027without password.\\n\u0027"},{"line_number":74,"context_line":"                             \u0027 or \\n\u0027"},{"line_number":75,"context_line":"                             \u00272. --ssh-password argument is required and\u0027"},{"line_number":76,"context_line":"                             \u0027ensure backup node can login to {1} \u0027"},{"line_number":77,"context_line":"                             \u0027as user {2} with password.\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_cd1d1862","line":74,"in_reply_to":"3f79a3b5_72dfff38","updated":"2018-11-21 03:39:06.000000000","message":"delete","commit_id":"59ed1c205b62b3bce71132a9d8aabe5f7c91269f"}]}
