)]}'
{"id":"openstack%2Ffreezer~736460","triplet_id":"openstack%2Ffreezer~master~Ib992a69e5b5f79cc28fb1ed629d9cea7b13a0025","project":"openstack/freezer","branch":"master","hashtags":[],"change_id":"Ib992a69e5b5f79cc28fb1ed629d9cea7b13a0025","subject":"Update \"if...if...\" to \"if...elif...else...\" in BackupJob._validata()","status":"MERGED","created":"2020-06-18 06:34:32.000000000","updated":"2020-06-19 06:23:58.000000000","submitted":"2020-06-19 06:20:20.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"736460-1592547621008-93a3f69b","meta_rev_id":"a8b158064314bdf37d68df0fcf54d198f1cd0951","_number":736460,"virtual_id_number":736460,"owner":{"_account_id":21069,"name":"Carl caihui","email":"caihui_nj@163.com","username":"caihui"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},{"value":0,"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-06-19 06:20:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},{"value":0,"_account_id":21069,"name":"Carl caihui","email":"caihui_nj@163.com","username":"caihui"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"all":[{"value":0,"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},{"value":2,"date":"2020-06-18 09:30:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-06-18 11:28:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},{"value":2,"date":"2020-06-19 05:36:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":21069,"name":"Carl caihui","email":"caihui_nj@163.com","username":"caihui"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21069,"name":"Carl caihui","email":"caihui_nj@163.com","username":"caihui"},"all":[{"value":0,"date":"2020-06-18 09:17:45.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},{"value":0,"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},{"value":1,"date":"2020-06-19 05:36:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":21069,"name":"Carl caihui","email":"caihui_nj@163.com","username":"caihui"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":21069,"name":"Carl caihui","email":"caihui_nj@163.com","username":"caihui"},{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-18 09:17:45.000000000","updated_by":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"reviewer":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"state":"REVIEWER"},{"updated":"2020-06-18 09:30:11.000000000","updated_by":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"reviewer":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"state":"REVIEWER"},{"updated":"2020-06-18 11:28:47.000000000","updated_by":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"reviewer":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"state":"REVIEWER"},{"updated":"2020-06-19 06:20:20.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b7108101d3ae7aa808795735dbc56df297fbf013","author":{"_account_id":21069,"name":"Carl caihui","email":"caihui_nj@163.com","username":"caihui"},"date":"2020-06-18 06:34:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fcc3719d4e4e48f46cd6cf240ab4049b333037b0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-18 07:39:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f17a15702d264846a6c94d78adeedc5c : SUCCESS in 9m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c60e2abb3e104664919fd1303585ca24 : SUCCESS in 7m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/78e385f10d2a4dbaa2ed89d1351571fa : SUCCESS in 7m 51s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b04f7e426b5d45b9a2e135f1c9bf79c9 : SUCCESS in 9m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8cac91cef2fe488ba0ac67324c0a04a3 : SUCCESS in 10m 09s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/1edd0d3dbfbc42f798fda0d116c584f2 : SUCCESS in 10m 10s\n- freezer-agent-tempest https://zuul.opendev.org/t/openstack/build/6a60760c729240bdbc7a11cdc74196e6 : SUCCESS in 42m 33s\n- freezer-scheduler-tempest https://zuul.opendev.org/t/openstack/build/23018f272a594934ad496964cd051f24 : SUCCESS in 39m 21s","accounts_in_message":[],"_revision_number":1},{"id":"da3b2017f88b28d4019f40ac5741fe7e52603154","author":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"date":"2020-06-18 09:30:11.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM ,thanks","accounts_in_message":[],"_revision_number":1},{"id":"0ca4ebae27c0f0f869b180898125c35e233591ef","author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"date":"2020-06-18 11:28:47.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6a8033268c8c118ed1d486cdf7b3689e4a6e0f00","author":{"_account_id":21069,"name":"Carl caihui","email":"caihui_nj@163.com","username":"caihui"},"date":"2020-06-19 05:36:29.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"72dda7a72d1c9a543e866daeafd0ecd35e331dcc","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-19 05:36:40.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"8bb62cf79837f9b867480fe0e593a7c24e05b7b3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-19 06:20:20.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5b859d4a23694924b84d6bea0c21f357 : SUCCESS in 4m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a74e06db2edd4f78b768ea810b447b26 : SUCCESS in 4m 19s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e061c604f8f040ee8a9c4cd7f7ab9101 : SUCCESS in 4m 47s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/7ceef9947e2f49689454c06be5bf379b : SUCCESS in 5m 00s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c5bbe5cb79684aa7b5dacb4b9d6f667d : SUCCESS in 4m 48s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/aef31ab1313c43179c98deda04f2e937 : SUCCESS in 5m 32s\n- freezer-agent-tempest https://zuul.opendev.org/t/openstack/build/402e8bb603d147ea9291ccfed2801e68 : SUCCESS in 38m 40s\n- freezer-scheduler-tempest https://zuul.opendev.org/t/openstack/build/260c3d17c49742b4a14f86e5f569abec : SUCCESS in 38m 27s","accounts_in_message":[],"_revision_number":1},{"id":"449f7f6c3906dfead40b61902b72acd805839a89","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-19 06:20:21.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"a8b158064314bdf37d68df0fcf54d198f1cd0951","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-19 06:23:58.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/068cc6d9204b43f0b284b14791cad566 : SUCCESS in 3m 08s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"85111f528bd73e44ed7d22985ceadf96e9100c45","revisions":{"85111f528bd73e44ed7d22985ceadf96e9100c45":{"kind":"REWORK","_number":1,"created":"2020-06-18 06:34:32.000000000","uploader":{"_account_id":21069,"name":"Carl caihui","email":"caihui_nj@163.com","username":"caihui"},"ref":"refs/changes/60/736460/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/freezer","ref":"refs/changes/60/736460/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/freezer refs/changes/60/736460/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/freezer refs/changes/60/736460/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/freezer refs/changes/60/736460/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/freezer refs/changes/60/736460/1"}}},"commit":{"parents":[{"commit":"ecaf5e0ea05dfcb6f48750996195e2bf78ed6adc","subject":"Fix a bug","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/freezer/commit/ecaf5e0ea05dfcb6f48750996195e2bf78ed6adc"}]}],"author":{"name":"Caihui","email":"cai.hui@zte.com.cn","date":"2020-06-18 06:01:43.000000000","tz":-420},"committer":{"name":"Caihui","email":"cai.hui@zte.com.cn","date":"2020-06-18 06:34:02.000000000","tz":-420},"subject":"Update \"if...if...\" to \"if...elif...else...\" in BackupJob._validata()","message":"Update \"if...if...\" to \"if...elif...else...\" in BackupJob._validata()\n\nUpdate \"if...if...\" to \"if...elif...else...\"\"\" in BackupJob._validata(),\nrunning efficiency is improved and  code structure is more clear.\n\nChange-Id: Ib992a69e5b5f79cc28fb1ed629d9cea7b13a0025\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/freezer/commit/85111f528bd73e44ed7d22985ceadf96e9100c45"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/freezer/commit/85111f528bd73e44ed7d22985ceadf96e9100c45"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}