)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10391,"name":"Ihor Kalnytskyi","email":"ihor@kalnytskyi.com","username":"ikalnitsky"},"change_message_id":"1e2665f74a374163eecdbb66da7544cb3a8007ad","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Extended Ubuntu cloud-init config template to create a non-root"},{"line_number":11,"context_line":"account. Root account is still accessible via SSH for compatibility."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"partially implements blueprint fuel-nonroot-openstack-nodes"},{"line_number":14,"context_line":"Depends-On: 258185"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I69831fe0327ef9ac55bed99301d2c3732b87ed88"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a68dd71_9d3afc97","line":13,"updated":"2016-01-25 13:06:25.000000000","message":"minor: Think it\u0027d be more beauty to write just:\n\n  Blueprint: fuel-nonroot-openstack-nodes","commit_id":"7d8effbf7e77355eb150d9142f20d82237afeaea"},{"author":{"_account_id":10391,"name":"Ihor Kalnytskyi","email":"ihor@kalnytskyi.com","username":"ikalnitsky"},"change_message_id":"1e2665f74a374163eecdbb66da7544cb3a8007ad","unresolved":false,"context_lines":[{"line_number":11,"context_line":"account. Root account is still accessible via SSH for compatibility."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"partially implements blueprint fuel-nonroot-openstack-nodes"},{"line_number":14,"context_line":"Depends-On: 258185"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I69831fe0327ef9ac55bed99301d2c3732b87ed88"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a68dd71_9dd3dc5f","line":14,"updated":"2016-01-25 13:06:25.000000000","message":"Incorrect reference. Please use change id from the patch (probably 258185) to make a proper reference.","commit_id":"7d8effbf7e77355eb150d9142f20d82237afeaea"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"3c54d92965a7de39801e13480fcbde6944c55df0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"sshd_config values. This means, that PermitRootLogin should be"},{"line_number":16,"context_line":"managed by library as well."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Blueprint: fuel-nonroot-openstack-nodes"},{"line_number":19,"context_line":"Depends-On: Ia18305e07d07377886783c3b3e44abe93cef2da5"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I69831fe0327ef9ac55bed99301d2c3732b87ed88"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9aed3d3a_6e037f10","line":18,"updated":"2016-02-25 18:16:02.000000000","message":"https://wiki.openstack.org/wiki/GitCommitMessages\nit should be \"Implements: blueprint fuel-nonroot-openstack-nodes\"","commit_id":"86f101ebc271a92d0d689e65a8e6475e1bac427b"}],"cloud-init-templates/boothook_ubuntu.jinja2":[{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"6c6c91e0851cc76d00221dd7765af44b72cb1be8","unresolved":false,"context_lines":[{"line_number":87,"context_line":"add_str_to_file_if_not_exists /etc/ssh/sshd_config \u0027UseDNS\u0027 \u0027UseDNS no\u0027"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"cloud-init-per instance gssapi_disable sed -i -e \"/^\\s*GSSAPICleanupCredentials yes/d\" -e \"/^\\s*GSSAPIAuthentication yes/d\" /etc/ssh/sshd_config"},{"line_number":90,"context_line":"cloud-init-per instance root_ssh_disable sed -i -e \"/^\\s*PermitRootLogin/d\" -e \"\\$ a PermitRootLogin no \" /etc/ssh/sshd_config"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"cloud-init-per instance nailgun_agent_0 /bin/sh -c \u0027echo \"rm -f /etc/nailgun-agent/nodiscover\" | tee /etc/rc.local\u0027"},{"line_number":93,"context_line":"cloud-init-per instance nailgun_agent_1 /bin/sh -c \u0027echo \"flock -w 0 -o /var/lock/agent.lock -c \\\"/usr/bin/nailgun-agent \u003e\u003e /var/log/nailgun-agent.log 2\u003e\u00261\\\"\" | tee -a /etc/rc.local\u0027"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"dae33548_68bda001","line":90,"updated":"2016-02-17 12:07:00.000000000","message":"is it safe?\n\ncould a node end up with locking itself out?","commit_id":"a11d0140edcf3ded9201a71f4f8a44a9ea2bdc38"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"46469be0efa17c7a7ca972c4608b925f429b1589","unresolved":false,"context_lines":[{"line_number":87,"context_line":"add_str_to_file_if_not_exists /etc/ssh/sshd_config \u0027UseDNS\u0027 \u0027UseDNS no\u0027"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"cloud-init-per instance gssapi_disable sed -i -e \"/^\\s*GSSAPICleanupCredentials yes/d\" -e \"/^\\s*GSSAPIAuthentication yes/d\" /etc/ssh/sshd_config"},{"line_number":90,"context_line":"cloud-init-per instance root_ssh_disable sed -i -e \"/^\\s*PermitRootLogin/d\" -e \"\\$ a PermitRootLogin no \" /etc/ssh/sshd_config"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"cloud-init-per instance nailgun_agent_0 /bin/sh -c \u0027echo \"rm -f /etc/nailgun-agent/nodiscover\" | tee /etc/rc.local\u0027"},{"line_number":93,"context_line":"cloud-init-per instance nailgun_agent_1 /bin/sh -c \u0027echo \"flock -w 0 -o /var/lock/agent.lock -c \\\"/usr/bin/nailgun-agent \u003e\u003e /var/log/nailgun-agent.log 2\u003e\u00261\\\"\" | tee -a /etc/rc.local\u0027"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"dae33548_8b8f3e29","line":90,"in_reply_to":"dae33548_2828b899","updated":"2016-02-17 12:21:40.000000000","message":"so, there\u0027ll be no chance to login under root credentials. Only os and svc user accounts will be allowed.\n\nok, that\u0027s fine.\n\nbtw, does your CR interfere with https://review.openstack.org/#/c/277353/ somehow? could you check it?","commit_id":"a11d0140edcf3ded9201a71f4f8a44a9ea2bdc38"},{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"25984d3f8d64b92efa71d7087bb79709d272ef41","unresolved":false,"context_lines":[{"line_number":87,"context_line":"add_str_to_file_if_not_exists /etc/ssh/sshd_config \u0027UseDNS\u0027 \u0027UseDNS no\u0027"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"cloud-init-per instance gssapi_disable sed -i -e \"/^\\s*GSSAPICleanupCredentials yes/d\" -e \"/^\\s*GSSAPIAuthentication yes/d\" /etc/ssh/sshd_config"},{"line_number":90,"context_line":"cloud-init-per instance root_ssh_disable sed -i -e \"/^\\s*PermitRootLogin/d\" -e \"\\$ a PermitRootLogin no \" /etc/ssh/sshd_config"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"cloud-init-per instance nailgun_agent_0 /bin/sh -c \u0027echo \"rm -f /etc/nailgun-agent/nodiscover\" | tee /etc/rc.local\u0027"},{"line_number":93,"context_line":"cloud-init-per instance nailgun_agent_1 /bin/sh -c \u0027echo \"flock -w 0 -o /var/lock/agent.lock -c \\\"/usr/bin/nailgun-agent \u003e\u003e /var/log/nailgun-agent.log 2\u003e\u00261\\\"\" | tee -a /etc/rc.local\u0027"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"dae33548_2828b899","line":90,"in_reply_to":"dae33548_68bda001","updated":"2016-02-17 12:11:36.000000000","message":"No, it won\u0027t as Fuel doesn\u0027t use SSH for orchestration. Once the node is provisioned, it\u0027ll start mcollective and nailgun-agent. Further communication happens via mcollective RPC.","commit_id":"a11d0140edcf3ded9201a71f4f8a44a9ea2bdc38"},{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"4cda72f02541f7889492b8ed57914b19f6afd564","unresolved":false,"context_lines":[{"line_number":87,"context_line":"add_str_to_file_if_not_exists /etc/ssh/sshd_config \u0027UseDNS\u0027 \u0027UseDNS no\u0027"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"cloud-init-per instance gssapi_disable sed -i -e \"/^\\s*GSSAPICleanupCredentials yes/d\" -e \"/^\\s*GSSAPIAuthentication yes/d\" /etc/ssh/sshd_config"},{"line_number":90,"context_line":"cloud-init-per instance root_ssh_disable sed -i -e \"/^\\s*PermitRootLogin/d\" -e \"\\$ a PermitRootLogin no \" /etc/ssh/sshd_config"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"cloud-init-per instance nailgun_agent_0 /bin/sh -c \u0027echo \"rm -f /etc/nailgun-agent/nodiscover\" | tee /etc/rc.local\u0027"},{"line_number":93,"context_line":"cloud-init-per instance nailgun_agent_1 /bin/sh -c \u0027echo \"flock -w 0 -o /var/lock/agent.lock -c \\\"/usr/bin/nailgun-agent \u003e\u003e /var/log/nailgun-agent.log 2\u003e\u00261\\\"\" | tee -a /etc/rc.local\u0027"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"dae33548_be29a239","line":90,"in_reply_to":"dae33548_8b8f3e29","updated":"2016-02-17 12:40:50.000000000","message":"my patch doesn\u0027t interfere with 277353, since my patch alters behavior of Nailgun data driver along with ConfigDriveScheme contents. And 277353 alters the way bootstrap image is built. As long as bootstrap build doesn\u0027t use cloud-init, we\u0027re safe. And it doesn\u0027t seem to use cloud-init.","commit_id":"a11d0140edcf3ded9201a71f4f8a44a9ea2bdc38"}],"cloud-init-templates/cloud_config_ubuntu.jinja2":[{"author":{"_account_id":10391,"name":"Ihor Kalnytskyi","email":"ihor@kalnytskyi.com","username":"ikalnitsky"},"change_message_id":"1e2665f74a374163eecdbb66da7544cb3a8007ad","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  mode: false"},{"line_number":5,"context_line":"disable_ec2_metadata: true"},{"line_number":6,"context_line":"disable_root: true"},{"line_number":7,"context_line":"users:"},{"line_number":8,"context_line":"  - name: {{ common.svc_user_name }}"},{"line_number":9,"context_line":"    password: {{ common.svc_user_password }}"},{"line_number":10,"context_line":"    ssh_authorized_keys:"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9a68dd71_dd1f14b5","line":7,"updated":"2016-01-25 13:06:25.000000000","message":"Hm.. How that change will affect earlier releases? Will they work? Do we have versioned clout init configs?","commit_id":"7d8effbf7e77355eb150d9142f20d82237afeaea"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"bc89ed7c8f23fb574d2ed7eac5d8977499c84c00","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  mode: false"},{"line_number":5,"context_line":"disable_ec2_metadata: true"},{"line_number":6,"context_line":"disable_root: true"},{"line_number":7,"context_line":"users:"},{"line_number":8,"context_line":"  - name: {{ common.svc_user_name }}"},{"line_number":9,"context_line":"    password: {{ common.svc_user_password }}"},{"line_number":10,"context_line":"    ssh_authorized_keys:"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9a68dd71_0eced462","line":7,"in_reply_to":"9a68dd71_dd1f14b5","updated":"2016-01-25 14:17:38.000000000","message":"\u003e How that change will affect earlier releases? \n\nthanks for raising this question!\n\n\u003e Do we have versioned clout init configs?\n\nYep, we have. https://github.com/openstack/fuel-agent/tree/master/cloud-init-templates\n\nIt looks like we need to perform more accurate versioning of cloud-init configs. And it should be done prior that patch.\n\nAs right now, only boothooks have been versioned.\n\nIt sounds like a valid bug.","commit_id":"7d8effbf7e77355eb150d9142f20d82237afeaea"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"fb022e0ca2e8694efb66f6194d204b98ebe7ccce","unresolved":false,"context_lines":[{"line_number":5,"context_line":"disable_ec2_metadata: true"},{"line_number":6,"context_line":"disable_root: false"},{"line_number":7,"context_line":"users:"},{"line_number":8,"context_line":"  - name: {{ user_accounts.service_user.name }}"},{"line_number":9,"context_line":"    password: {{ user_accounts.service_user.password }}"},{"line_number":10,"context_line":"    ssh_authorized_keys:"},{"line_number":11,"context_line":"    {% for key in common.ssh_auth_keys %}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"9aed3d3a_d6403459","line":8,"updated":"2016-02-26 11:36:33.000000000","message":"{% for user in user_accounts %}\n  - name: {{ user.name }}\n    password: {{ user.password }}\n    ssh_authorized_keys:\n    {% for key in user.keys %}\n      - {{ key }}\n    {% endfor %}\n    shell: {{ user.shell }}\n  {% endfor %}\n\nPlease do not try to merge something, try to merge something that is supposed to be maintainable.","commit_id":"a2168ae08e0b1e62f16c880cdcc20a947c2e9507"},{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"d813f25a61de2bfdb5dbc6fb2cb865e4f357173d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"disable_ec2_metadata: true"},{"line_number":6,"context_line":"disable_root: false"},{"line_number":7,"context_line":"users:"},{"line_number":8,"context_line":"  - name: {{ user_accounts.service_user.name }}"},{"line_number":9,"context_line":"    password: {{ user_accounts.service_user.password }}"},{"line_number":10,"context_line":"    ssh_authorized_keys:"},{"line_number":11,"context_line":"    {% for key in common.ssh_auth_keys %}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"9aed3d3a_e7fe646a","line":8,"in_reply_to":"9aed3d3a_d6403459","updated":"2016-02-26 12:23:27.000000000","message":"Done","commit_id":"a2168ae08e0b1e62f16c880cdcc20a947c2e9507"}],"fuel_agent/drivers/nailgun.py":[{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"6c6c91e0851cc76d00221dd7765af44b72cb1be8","unresolved":false,"context_lines":[{"line_number":549,"context_line":"            svc_user \u003d data[\u0027ks_meta\u0027][\u0027svc_user\u0027]"},{"line_number":550,"context_line":"            os_user \u003d data[\u0027ks_meta\u0027][\u0027os_user\u0027]"},{"line_number":551,"context_line":"            root_password \u003d data[\u0027ks_meta\u0027][\u0027root_password\u0027]"},{"line_number":552,"context_line":"        except KeyError:"},{"line_number":553,"context_line":"            os_user \u003d {\"name\": \"fueladmin\","},{"line_number":554,"context_line":"                       \"password\": \"fueladmin\","},{"line_number":555,"context_line":"                       \"homedir\": \"/home/fueladmin\","}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_880bc48d","line":552,"updated":"2016-02-17 12:07:00.000000000","message":"Perhaps, we should show a clear log message with warning.\n\neg:\n\n\"ConfigDrive: non-root user accounts won\u0027t be created. Looks like current environment doesn\u0027t support this feature.\"\n\ndo you mind to add it here?","commit_id":"a11d0140edcf3ded9201a71f4f8a44a9ea2bdc38"},{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"25984d3f8d64b92efa71d7087bb79709d272ef41","unresolved":false,"context_lines":[{"line_number":549,"context_line":"            svc_user \u003d data[\u0027ks_meta\u0027][\u0027svc_user\u0027]"},{"line_number":550,"context_line":"            os_user \u003d data[\u0027ks_meta\u0027][\u0027os_user\u0027]"},{"line_number":551,"context_line":"            root_password \u003d data[\u0027ks_meta\u0027][\u0027root_password\u0027]"},{"line_number":552,"context_line":"        except KeyError:"},{"line_number":553,"context_line":"            os_user \u003d {\"name\": \"fueladmin\","},{"line_number":554,"context_line":"                       \"password\": \"fueladmin\","},{"line_number":555,"context_line":"                       \"homedir\": \"/home/fueladmin\","}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_c815cc49","line":552,"in_reply_to":"dae33548_880bc48d","updated":"2016-02-17 12:11:36.000000000","message":"I\u0027ll do it","commit_id":"a11d0140edcf3ded9201a71f4f8a44a9ea2bdc38"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"36456a5078fe687cdd70d22ef42544c32db021b6","unresolved":false,"context_lines":[{"line_number":553,"context_line":"            LOG.warn((\u0027This environment does not support non-root accounts \u0027"},{"line_number":554,"context_line":"                      \u0027on the target nodes. Non-root user accounts will not \u0027"},{"line_number":555,"context_line":"                      \u0027be created\u0027))"},{"line_number":556,"context_line":"            operator_user \u003d {\"name\": \"fueladmin\","},{"line_number":557,"context_line":"                             \"password\": \"fueladmin\","},{"line_number":558,"context_line":"                             \"homedir\": \"/home/fueladmin\","},{"line_number":559,"context_line":"                             \"sudo\": [],"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_11f77dd3","line":556,"updated":"2016-02-24 16:53:30.000000000","message":"is it really what you mean? probably fueladmin is a service user and fuel is an operator.","commit_id":"ebf24947ca4d5252ceda3a94a6b5bda393f60c1d"},{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"859379c10d5ae66f1a111e7d95d21aa478d97e99","unresolved":false,"context_lines":[{"line_number":553,"context_line":"            LOG.warn((\u0027This environment does not support non-root accounts \u0027"},{"line_number":554,"context_line":"                      \u0027on the target nodes. Non-root user accounts will not \u0027"},{"line_number":555,"context_line":"                      \u0027be created\u0027))"},{"line_number":556,"context_line":"            operator_user \u003d {\"name\": \"fueladmin\","},{"line_number":557,"context_line":"                             \"password\": \"fueladmin\","},{"line_number":558,"context_line":"                             \"homedir\": \"/home/fueladmin\","},{"line_number":559,"context_line":"                             \"sudo\": [],"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_104630bf","line":556,"in_reply_to":"bae84128_11f77dd3","updated":"2016-02-25 08:15:03.000000000","message":"Yes, \"fuel\" is the service user, following the same scheme as with all the other OpenStack services (nova/Nova etc).","commit_id":"ebf24947ca4d5252ceda3a94a6b5bda393f60c1d"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"bc13deb51e7f70dac0d0c3c8b17e50dabd79b947","unresolved":false,"context_lines":[{"line_number":622,"context_line":"            name\u003d\"root\","},{"line_number":623,"context_line":"            username\u003d\"root\","},{"line_number":624,"context_line":"            password\u003droot_password,"},{"line_number":625,"context_line":"            homedir\u003d\"/root/\","},{"line_number":626,"context_line":"        )"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"        LOG.debug(\u0027Setting configdrive profile %s\u0027 % data[\u0027profile\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aed3d3a_2ed5ce42","line":625,"updated":"2016-02-26 10:14:40.000000000","message":"trailing slash. is it really essential?","commit_id":"12a0b59b5c9a7734892b235087783367558a7a83"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"fb022e0ca2e8694efb66f6194d204b98ebe7ccce","unresolved":false,"context_lines":[{"line_number":601,"context_line":"        )"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"        LOG.debug(\u0027Adding user accounts parameters\u0027)"},{"line_number":604,"context_line":"        configdrive_scheme.add_user_account("},{"line_number":605,"context_line":"            name\u003d\"operator_user\","},{"line_number":606,"context_line":"            username\u003doperator_user[\u0027name\u0027],"},{"line_number":607,"context_line":"            password\u003doperator_user[\u0027password\u0027],"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aed3d3a_a1372caf","line":604,"updated":"2016-02-26 11:36:33.000000000","message":"this should also be a loop over collection. what if the number of users is 1000? will you manually instantiate 1000 objects?","commit_id":"a2168ae08e0b1e62f16c880cdcc20a947c2e9507"},{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"d813f25a61de2bfdb5dbc6fb2cb865e4f357173d","unresolved":false,"context_lines":[{"line_number":601,"context_line":"        )"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"        LOG.debug(\u0027Adding user accounts parameters\u0027)"},{"line_number":604,"context_line":"        configdrive_scheme.add_user_account("},{"line_number":605,"context_line":"            name\u003d\"operator_user\","},{"line_number":606,"context_line":"            username\u003doperator_user[\u0027name\u0027],"},{"line_number":607,"context_line":"            password\u003doperator_user[\u0027password\u0027],"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aed3d3a_27f96c81","line":604,"in_reply_to":"9aed3d3a_a1372caf","updated":"2016-02-26 12:23:27.000000000","message":"Done","commit_id":"a2168ae08e0b1e62f16c880cdcc20a947c2e9507"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"27d9ac6b0d97b97cae49442d8490002201eb50eb","unresolved":false,"context_lines":[{"line_number":571,"context_line":"        # Add common SSH keys to user-specified keys"},{"line_number":572,"context_line":"        operator_user[\u0027ssh_keys\u0027] +\u003d ssh_auth_keys"},{"line_number":573,"context_line":"        service_user[\u0027ssh_keys\u0027] \u003d ssh_auth_keys"},{"line_number":574,"context_line":"        # FIXME: once Fuel doesn\u0027t rely on root SSH, remove this"},{"line_number":575,"context_line":"        root_user[\u0027ssh_keys\u0027] \u003d ssh_auth_keys"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        user_accounts.append(operator_user)"}],"source_content_type":"text/x-python","patch_set":25,"id":"9aed3d3a_1939b2d7","line":574,"range":{"start_line":574,"start_character":10,"end_line":574,"end_character":15},"updated":"2016-02-29 18:23:36.000000000","message":"change to FIXME(dnikishov)","commit_id":"6b8ae659166ad3afce5ffbcea916659645add11a"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"05790da64c9607eab911d17675d765ba471f1981","unresolved":false,"context_lines":[{"line_number":285,"context_line":"    def parse_operating_system(self):"},{"line_number":286,"context_line":"        LOG.debug(\u0027--- Preparing operating system data ---\u0027)"},{"line_number":287,"context_line":"        os_release \u003d self._image_meta.get(\u0027os\u0027, None)"},{"line_number":288,"context_line":"        return self.get_os_by_image_meta(os_release) or \\"},{"line_number":289,"context_line":"            self.get_os_by_profile(self.data[\u0027profile\u0027].lower())"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    def parse_partition_scheme(self):"},{"line_number":292,"context_line":"        LOG.debug(\u0027--- Preparing partition scheme ---\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"7af24918_53caa650","line":289,"range":{"start_line":288,"start_character":8,"end_line":289,"end_character":64},"updated":"2016-03-01 12:37:43.000000000","message":"os \u003d self.get_os_by_image_meta(os_release) or \\\n      self.get_os_by_profile(self.data[\u0027profile\u0027].lower())\n\n  # piece of code from 543-555L\n\n  for account in user_accounts:\n      os.add_user_account(**account)","commit_id":"e126a54ecc6471081782e3fab49b3ff997f8c420"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"05790da64c9607eab911d17675d765ba471f1981","unresolved":false,"context_lines":[{"line_number":520,"context_line":"    def parse_configdrive_scheme(self):"},{"line_number":521,"context_line":"        LOG.debug(\u0027--- Preparing configdrive scheme ---\u0027)"},{"line_number":522,"context_line":"        data \u003d self.data"},{"line_number":523,"context_line":"        configdrive_scheme \u003d objects.ConfigDriveScheme()"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        LOG.debug(\u0027Adding common parameters\u0027)"},{"line_number":526,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"7af24918_737402fd","line":523,"updated":"2016-03-01 12:37:43.000000000","message":"objects.ConfigDriveScheme(user_accounts\u003dself._operating_system.user_accounts)","commit_id":"e126a54ecc6471081782e3fab49b3ff997f8c420"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"05790da64c9607eab911d17675d765ba471f1981","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        if data[\u0027ks_meta\u0027][\u0027auth_key\u0027]:"},{"line_number":541,"context_line":"            ssh_auth_keys.append(data[\u0027ks_meta\u0027][\u0027auth_key\u0027])"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        # FIXME(dnikishov): until fuel-agent-versioning BP"},{"line_number":544,"context_line":"        # will have been implemented, we need to deal with the case when"},{"line_number":545,"context_line":"        # 9.0 fuel-agent will be managing 6.1 to 8.0 environments, whose"},{"line_number":546,"context_line":"        # provisioning serializers on Nailgun side will not have"},{"line_number":547,"context_line":"        # user_accounts in the ks_meta dict"},{"line_number":548,"context_line":"        try:"},{"line_number":549,"context_line":"            user_accounts \u003d data[\u0027ks_meta\u0027][\u0027user_accounts\u0027]"},{"line_number":550,"context_line":"        except KeyError:"},{"line_number":551,"context_line":"            LOG.warn((\u0027This environment does not support non-root accounts \u0027"},{"line_number":552,"context_line":"                      \u0027on the target nodes. Non-root user accounts will not \u0027"},{"line_number":553,"context_line":"                      \u0027be created\u0027))"},{"line_number":554,"context_line":"            user_accounts \u003d []"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        configdrive_scheme.set_common("},{"line_number":557,"context_line":"            ssh_auth_keys\u003dssh_auth_keys,"},{"line_number":558,"context_line":"            hostname\u003ddata[\u0027hostname\u0027],"}],"source_content_type":"text/x-python","patch_set":27,"id":"7af24918_b3620aac","line":555,"range":{"start_line":543,"start_character":0,"end_line":555,"end_character":0},"updated":"2016-03-01 12:37:43.000000000","message":"this piece of code should be moved to parse_operating_system()","commit_id":"e126a54ecc6471081782e3fab49b3ff997f8c420"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"f87d2a36f0317fd8a7a74f9b88f0f1fc1fb65d38","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        LOG.debug(\u0027--- Preparing configdrive scheme ---\u0027)"},{"line_number":522,"context_line":"        data \u003d self.data"},{"line_number":523,"context_line":"        configdrive_scheme \u003d objects.ConfigDriveScheme("},{"line_number":524,"context_line":"            user_accounts\u003dself._operating_system.user_accounts"},{"line_number":525,"context_line":"        )"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"        LOG.debug(\u0027Adding common parameters\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7af24918_a8ad748a","line":524,"updated":"2016-03-01 13:03:52.000000000","message":"underscore is not needed. Nailgun has a property \u0027operating_system\u0027","commit_id":"c6f353c131c7eb6538b6076665fbe7b1621a5a09"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"f87d2a36f0317fd8a7a74f9b88f0f1fc1fb65d38","unresolved":false,"context_lines":[{"line_number":775,"context_line":""},{"line_number":776,"context_line":"        os \u003d objects.Ubuntu(repos\u003drepos, packages\u003dpackages, major\u003d14, minor\u003d4,"},{"line_number":777,"context_line":"                            proxies\u003dproxies)"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"        # FIXME(dnikishov): until fuel-agent-versioning BP"},{"line_number":780,"context_line":"        # will have been implemented, we need to deal with the case when"},{"line_number":781,"context_line":"        # 9.0 fuel-agent will be managing 6.1 to 8.0 environments, whose"}],"source_content_type":"text/x-python","patch_set":28,"id":"7af24918_e89adcc4","line":778,"updated":"2016-03-01 13:03:52.000000000","message":"aghhh :-(\n\nwrong driver class to deal with. Should have been Nailgun, not NailgunBuildImage","commit_id":"c6f353c131c7eb6538b6076665fbe7b1621a5a09"}],"fuel_agent/objects/configdrive.py":[{"author":{"_account_id":10391,"name":"Ihor Kalnytskyi","email":"ihor@kalnytskyi.com","username":"ikalnitsky"},"change_message_id":"c67b06ccb4362b7642b0f066533ebfd2015bee42","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    def __init__(self, ssh_auth_keys, hostname, fqdn, name_servers,"},{"line_number":20,"context_line":"                 search_domain, master_ip, master_url, udevrules, admin_mac,"},{"line_number":21,"context_line":"                 admin_ip, admin_mask, admin_iface_name, timezone, ks_repos,"},{"line_number":22,"context_line":"                 gw, os_user_name, os_user_password, os_user_homedir,"},{"line_number":23,"context_line":"                 os_user_sudo):"},{"line_number":24,"context_line":"        self.ssh_auth_keys \u003d ssh_auth_keys"},{"line_number":25,"context_line":"        self.hostname \u003d hostname"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_b6d4f7bc","line":22,"updated":"2015-12-28 13:11:49.000000000","message":"What the reason to pass it there, if you don\u0027t use it?","commit_id":"abc2b43d1ea6b5d76592e057a9d0fe17e1112c76"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"4db82eb7a69894449ab267ffdd849077c5638650","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    def __init__(self, ssh_auth_keys, hostname, fqdn, name_servers,"},{"line_number":20,"context_line":"                 search_domain, master_ip, master_url, udevrules, admin_mac,"},{"line_number":21,"context_line":"                 admin_ip, admin_mask, admin_iface_name, timezone, ks_repos,"},{"line_number":22,"context_line":"                 gw, os_user_name, os_user_password, os_user_homedir,"},{"line_number":23,"context_line":"                 os_user_sudo):"},{"line_number":24,"context_line":"        self.ssh_auth_keys \u003d ssh_auth_keys"},{"line_number":25,"context_line":"        self.hostname \u003d hostname"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_5f44bfb5","line":22,"in_reply_to":"1a7b0d38_b6d4f7bc","updated":"2015-12-28 17:33:55.000000000","message":"+1\n\nthose vars should be stored as ConfigDriveCommon class attrs.","commit_id":"abc2b43d1ea6b5d76592e057a9d0fe17e1112c76"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"65d4e122dd746a665d94ca1948b1238a2866fe5f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                 admin_ip, admin_mask, admin_iface_name, timezone, ks_repos,"},{"line_number":22,"context_line":"                 gw, os_user_name, os_user_password, os_user_homedir,"},{"line_number":23,"context_line":"                 os_user_sudo, os_user_authkeys, svc_user_name, svc_user_sudo,"},{"line_number":24,"context_line":"                 svc_user_homedir, svc_user_password):"},{"line_number":25,"context_line":"        self.ssh_auth_keys \u003d ssh_auth_keys"},{"line_number":26,"context_line":"        self.hostname \u003d hostname"},{"line_number":27,"context_line":"        self.fqdn \u003d fqdn"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_e54b0658","line":24,"updated":"2016-01-19 13:43:43.000000000","message":"nit: Parameters order\n\nsvc_user_homedir should precede svc_user_sudo.\n\nPlease consider swapping them.\n\nat least, unit test relies on params order.\n\nhttps://review.openstack.org/#/c/258200/4/fuel_agent/tests/test_configdrive.py","commit_id":"37994a86c2663226bee54e92a00be7577f38f0e3"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"36456a5078fe687cdd70d22ef42544c32db021b6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.service_user_password \u003d service_user_password"},{"line_number":49,"context_line":"        self.service_user_homedir \u003d service_user_homedir"},{"line_number":50,"context_line":"        self.service_user_sudo \u003d service_user_sudo"},{"line_number":51,"context_line":"        self.root_password \u003d root_password"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class ConfigDrivePuppet(object):"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_51990578","line":51,"updated":"2016-02-24 16:53:30.000000000","message":"That became ugly. Please use separate object like User for managing accounts.","commit_id":"ebf24947ca4d5252ceda3a94a6b5bda393f60c1d"},{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"859379c10d5ae66f1a111e7d95d21aa478d97e99","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.service_user_password \u003d service_user_password"},{"line_number":49,"context_line":"        self.service_user_homedir \u003d service_user_homedir"},{"line_number":50,"context_line":"        self.service_user_sudo \u003d service_user_sudo"},{"line_number":51,"context_line":"        self.root_password \u003d root_password"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class ConfigDrivePuppet(object):"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_d0220801","line":51,"in_reply_to":"bae84128_51990578","updated":"2016-02-25 08:15:03.000000000","message":"Fixed","commit_id":"ebf24947ca4d5252ceda3a94a6b5bda393f60c1d"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"bf0f5e7d8aba8826dc46540445d7444bd595040d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.identity \u003d identity"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class ConfigDriveUserAccounts(object):"},{"line_number":60,"context_line":"    def __init__(self, operator_user_name, operator_user_password,"},{"line_number":61,"context_line":"                 operator_user_homedir, operator_user_sudo,"},{"line_number":62,"context_line":"                 operator_user_authkeys, service_user_name,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_68eed7ed","line":59,"updated":"2016-02-25 17:43:49.000000000","message":"What if you need yet another account in the future. Are you going to extend this object? Please use standard OOP approach.\n  class Account:\n    name\n    password\n    sudo\n    etc.\n\nand then instantiate as many accounts as you need. It should be a collection.","commit_id":"86f101ebc271a92d0d689e65a8e6475e1bac427b"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"bc13deb51e7f70dac0d0c3c8b17e50dabd79b947","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.mcollective \u003d mcollective"},{"line_number":75,"context_line":"        self._profile \u003d profile or \u0027ubuntu\u0027"},{"line_number":76,"context_line":"        self.templates \u003d templates or {}"},{"line_number":77,"context_line":"        self.user_accounts \u003d user_accounts"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # TODO(kozhukalov) make it possible to validate scheme according to"},{"line_number":80,"context_line":"    # chosen profile which means chosen set of cloud-init templates."}],"source_content_type":"text/x-python","patch_set":17,"id":"9aed3d3a_6e2b5631","line":77,"updated":"2016-02-26 10:14:40.000000000","message":"self.user_accounts \u003d user_accounts or {}","commit_id":"12a0b59b5c9a7734892b235087783367558a7a83"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"bc13deb51e7f70dac0d0c3c8b17e50dabd79b947","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.mcollective \u003d ConfigDriveMcollective(**kwargs)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def add_user_account(self, name, **kwargs):"},{"line_number":93,"context_line":"        if self.user_accounts is None:"},{"line_number":94,"context_line":"            self.user_accounts \u003d {}"},{"line_number":95,"context_line":"        self.user_accounts[name] \u003d ConfigDriveUserAccount(**kwargs)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def template_data(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aed3d3a_0ec56a3b","line":94,"range":{"start_line":93,"start_character":0,"end_line":94,"end_character":35},"updated":"2016-02-26 10:14:40.000000000","message":"my suggestion is to move this condition to __init__(), ie:\n\n  self.user_accounts \u003d user_accounts or {}","commit_id":"12a0b59b5c9a7734892b235087783367558a7a83"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"fb022e0ca2e8694efb66f6194d204b98ebe7ccce","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.mcollective \u003d mcollective"},{"line_number":75,"context_line":"        self._profile \u003d profile or \u0027ubuntu\u0027"},{"line_number":76,"context_line":"        self.templates \u003d templates or {}"},{"line_number":77,"context_line":"        self.user_accounts \u003d user_accounts or {}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # TODO(kozhukalov) make it possible to validate scheme according to"},{"line_number":80,"context_line":"    # chosen profile which means chosen set of cloud-init templates."}],"source_content_type":"text/x-python","patch_set":18,"id":"9aed3d3a_b6b650da","line":77,"updated":"2016-02-26 11:36:33.000000000","message":"user_accounts or []\nwhy do you use dict instead of list or set?","commit_id":"a2168ae08e0b1e62f16c880cdcc20a947c2e9507"},{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"d813f25a61de2bfdb5dbc6fb2cb865e4f357173d","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.mcollective \u003d mcollective"},{"line_number":75,"context_line":"        self._profile \u003d profile or \u0027ubuntu\u0027"},{"line_number":76,"context_line":"        self.templates \u003d templates or {}"},{"line_number":77,"context_line":"        self.user_accounts \u003d user_accounts or {}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # TODO(kozhukalov) make it possible to validate scheme according to"},{"line_number":80,"context_line":"    # chosen profile which means chosen set of cloud-init templates."}],"source_content_type":"text/x-python","patch_set":18,"id":"9aed3d3a_a72bbcea","line":77,"in_reply_to":"9aed3d3a_b6b650da","updated":"2016-02-26 12:23:27.000000000","message":"Done","commit_id":"a2168ae08e0b1e62f16c880cdcc20a947c2e9507"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"fb022e0ca2e8694efb66f6194d204b98ebe7ccce","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.mcollective \u003d ConfigDriveMcollective(**kwargs)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def add_user_account(self, name, **kwargs):"},{"line_number":93,"context_line":"        self.user_accounts[name] \u003d ConfigDriveUserAccount(**kwargs)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def template_data(self):"},{"line_number":96,"context_line":"        if self.common is None:"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aed3d3a_b62bf0ea","line":93,"updated":"2016-02-26 11:36:33.000000000","message":"self.user_accounts.append(ConfigDriveUserAccount(**kwargs))","commit_id":"a2168ae08e0b1e62f16c880cdcc20a947c2e9507"},{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"d813f25a61de2bfdb5dbc6fb2cb865e4f357173d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.mcollective \u003d ConfigDriveMcollective(**kwargs)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def add_user_account(self, name, **kwargs):"},{"line_number":93,"context_line":"        self.user_accounts[name] \u003d ConfigDriveUserAccount(**kwargs)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def template_data(self):"},{"line_number":96,"context_line":"        if self.common is None:"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aed3d3a_c73a4036","line":93,"in_reply_to":"9aed3d3a_b62bf0ea","updated":"2016-02-26 12:23:27.000000000","message":"Done","commit_id":"a2168ae08e0b1e62f16c880cdcc20a947c2e9507"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"dc28f3ece26ef673ea7d36fa513da2967e497497","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            template_data.update(puppet\u003dself.puppet)"},{"line_number":104,"context_line":"        if self.mcollective is not None:"},{"line_number":105,"context_line":"            template_data.update(mcollective\u003dself.mcollective)"},{"line_number":106,"context_line":"        if self.user_accounts is not None:"},{"line_number":107,"context_line":"            template_data.update(user_accounts\u003dself.user_accounts)"},{"line_number":108,"context_line":"        return template_data"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"9aed3d3a_b9259cac","line":106,"updated":"2016-02-26 12:50:32.000000000","message":"self.user_accounts is always not None, but [].\n\n  if self.user_accounts:\n\nwould be highly enough.","commit_id":"065fd2a0ee052e9c15fe39ed4e2cd65e2de9bec3"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"96b21db90c1d3e28fec32b782e2f89537d56b956","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.identity \u003d identity"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class ConfigDriveUserAccount(object):"},{"line_number":60,"context_line":"    def __init__(self, name, password, homedir, sudo\u003dNone, ssh_keys\u003dNone,"},{"line_number":61,"context_line":"                 shell\u003d\"/bin/bash\"):"},{"line_number":62,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":23,"id":"9aed3d3a_54d02e1f","line":59,"updated":"2016-02-29 15:51:43.000000000","message":"could you separate this object into single module like user.py\n\nalso, please consider removing ConfigDrive from the class name.\n\n(we\u0027re planning to re-use this object outside of configdrive)","commit_id":"c22d0994bf3af25168c68e95812caee11f6a8d8d"},{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"22e0cf41e75c8ab7b1c29f32554f2ea46b078e5a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.identity \u003d identity"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class ConfigDriveUserAccount(object):"},{"line_number":60,"context_line":"    def __init__(self, name, password, homedir, sudo\u003dNone, ssh_keys\u003dNone,"},{"line_number":61,"context_line":"                 shell\u003d\"/bin/bash\"):"},{"line_number":62,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":23,"id":"9aed3d3a_00a2e04a","line":59,"in_reply_to":"9aed3d3a_54d02e1f","updated":"2016-02-29 16:34:50.000000000","message":"https://review.openstack.org/286125","commit_id":"c22d0994bf3af25168c68e95812caee11f6a8d8d"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"05790da64c9607eab911d17675d765ba471f1981","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    def set_mcollective(self, **kwargs):"},{"line_number":82,"context_line":"        self.mcollective \u003d ConfigDriveMcollective(**kwargs)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def add_user_account(self, **kwargs):"},{"line_number":85,"context_line":"        self.user_accounts.append(User(**kwargs))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def template_data(self):"}],"source_content_type":"text/x-python","patch_set":27,"id":"7af24918_f3393243","line":84,"updated":"2016-03-01 12:37:43.000000000","message":"this method will be moved to operating system object.","commit_id":"e126a54ecc6471081782e3fab49b3ff997f8c420"}],"fuel_agent/objects/operating_system.py":[{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"f87d2a36f0317fd8a7a74f9b88f0f1fc1fb65d38","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from fuel_agent.objects.users import User"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class OperatingSystem(object):"}],"source_content_type":"text/x-python","patch_set":28,"id":"7af24918_888d187e","line":15,"updated":"2016-03-01 13:03:52.000000000","message":"from fuel_agent.objects import users","commit_id":"c6f353c131c7eb6538b6076665fbe7b1621a5a09"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"f87d2a36f0317fd8a7a74f9b88f0f1fc1fb65d38","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        self.user_accounts \u003d user_accounts or []"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def add_user_account(self, **kwargs):"},{"line_number":29,"context_line":"        self.user_accounts.append(User(**kwargs))"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def to_dict(self):"},{"line_number":32,"context_line":"        return {\u0027major\u0027: self.major,"}],"source_content_type":"text/x-python","patch_set":28,"id":"7af24918_28dde442","line":29,"updated":"2016-03-01 13:03:52.000000000","message":"self.user_accounts.append(users.User(**kwargs))","commit_id":"c6f353c131c7eb6538b6076665fbe7b1621a5a09"}],"fuel_agent/tests/fixtures/simple_nailgun_driver.json":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"fb022e0ca2e8694efb66f6194d204b98ebe7ccce","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            ]"},{"line_number":90,"context_line":"        },"},{"line_number":91,"context_line":"        \"timezone\": \"America/Los_Angeles\","},{"line_number":92,"context_line":"        \"operator_user\": {"},{"line_number":93,"context_line":"            \"name\": \"fueladmin\","},{"line_number":94,"context_line":"            \"password\": \"fueladmin\","},{"line_number":95,"context_line":"            \"homedir\": \"/home/fueladmin\","}],"source_content_type":"application/json","patch_set":18,"id":"9aed3d3a_410100ae","line":92,"updated":"2016-02-26 11:36:33.000000000","message":"Why can not this be a collection (not a set of independent branches)?","commit_id":"a2168ae08e0b1e62f16c880cdcc20a947c2e9507"},{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"d813f25a61de2bfdb5dbc6fb2cb865e4f357173d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            ]"},{"line_number":90,"context_line":"        },"},{"line_number":91,"context_line":"        \"timezone\": \"America/Los_Angeles\","},{"line_number":92,"context_line":"        \"operator_user\": {"},{"line_number":93,"context_line":"            \"name\": \"fueladmin\","},{"line_number":94,"context_line":"            \"password\": \"fueladmin\","},{"line_number":95,"context_line":"            \"homedir\": \"/home/fueladmin\","}],"source_content_type":"application/json","patch_set":18,"id":"9aed3d3a_c7ec00ca","line":92,"in_reply_to":"9aed3d3a_410100ae","updated":"2016-02-26 12:23:27.000000000","message":"Nailgun wouldn\u0027t really need a large number of OS accounts on target nodes created.","commit_id":"a2168ae08e0b1e62f16c880cdcc20a947c2e9507"}],"fuel_agent/tests/fixtures/simple_nailgun_driver_old.json":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"36456a5078fe687cdd70d22ef42544c32db021b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"bae84128_b1be9162","side":"PARENT","updated":"2016-02-24 16:53:30.000000000","message":"Please avoid using new and old terms when naming files. It reminds me Windows UX with pleanty of New Folder, New Folder (2), etc. Introduce mature versioning mechanism instead.","commit_id":"11e535e6e396afed03627f48ac5e1229a7cf6cf9"},{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"859379c10d5ae66f1a111e7d95d21aa478d97e99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"bae84128_70785cf9","side":"PARENT","in_reply_to":"bae84128_b1be9162","updated":"2016-02-25 08:15:03.000000000","message":"Fixed","commit_id":"11e535e6e396afed03627f48ac5e1229a7cf6cf9"}],"fuel_agent/tests/test_simple_nailgun_driver.py":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"36456a5078fe687cdd70d22ef42544c32db021b6","unresolved":false,"context_lines":[{"line_number":212,"context_line":"class TestFullDataRead(unittest2.TestCase):"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    PROVISION_DATA \u003d base.load_fixture(\u0027simple_nailgun_driver.json\u0027)"},{"line_number":215,"context_line":"    PROVISION_DATA_OLD \u003d base.load_fixture(\u0027simple_nailgun_driver_old.json\u0027)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def test_read_with_no_error(self, mock_requests):"},{"line_number":218,"context_line":"        mock_requests.get(\u0027http://fake.host.org:123/imgs/fake_image.img.gz\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_5100e501","line":215,"updated":"2016-02-24 16:53:30.000000000","message":"Avoid using _OLD. Introduce versions that better fit software engineering culture.","commit_id":"ebf24947ca4d5252ceda3a94a6b5bda393f60c1d"},{"author":{"_account_id":10392,"name":"Dmitry Nikishov","email":"dnikishov@mirantis.com","username":"dnikishov"},"change_message_id":"859379c10d5ae66f1a111e7d95d21aa478d97e99","unresolved":false,"context_lines":[{"line_number":212,"context_line":"class TestFullDataRead(unittest2.TestCase):"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    PROVISION_DATA \u003d base.load_fixture(\u0027simple_nailgun_driver.json\u0027)"},{"line_number":215,"context_line":"    PROVISION_DATA_OLD \u003d base.load_fixture(\u0027simple_nailgun_driver_old.json\u0027)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def test_read_with_no_error(self, mock_requests):"},{"line_number":218,"context_line":"        mock_requests.get(\u0027http://fake.host.org:123/imgs/fake_image.img.gz\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_9087e0d6","line":215,"in_reply_to":"bae84128_5100e501","updated":"2016-02-25 08:15:03.000000000","message":"Fixed","commit_id":"ebf24947ca4d5252ceda3a94a6b5bda393f60c1d"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"bf0f5e7d8aba8826dc46540445d7444bd595040d","unresolved":false,"context_lines":[{"line_number":212,"context_line":"class TestFullDataRead(unittest2.TestCase):"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    PROVISION_DATA \u003d base.load_fixture(\u0027simple_nailgun_driver.json\u0027)"},{"line_number":215,"context_line":"    PROVISION_DATA_61_70_80 \u003d base.load_fixture("},{"line_number":216,"context_line":"        \u0027simple_nailgun_driver_61_70_80.json\u0027"},{"line_number":217,"context_line":"    )"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_a893bf4e","line":215,"updated":"2016-02-25 17:43:49.000000000","message":"How does it differ from the old/new approach? Could you please have one data sample and then patch it depending on version?","commit_id":"86f101ebc271a92d0d689e65a8e6475e1bac427b"}]}
