)]}'
{"deployment/puppet/openstack/manifests/cinder.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2acef6772cf449eaa4569c32f8082fe176a85f48","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  $sql_connection,"},{"line_number":7,"context_line":"  $cinder_user_password,"},{"line_number":8,"context_line":"  $glance_api_servers,"},{"line_number":9,"context_line":"  $queue_provider         \u003d \u0027rabbitmq\u0027,"},{"line_number":10,"context_line":"  $amqp_hosts             \u003d \u0027127.0.0.1\u0027,"},{"line_number":11,"context_line":"  $amqp_user              \u003d \u0027nova\u0027,"},{"line_number":12,"context_line":"  $amqp_password          \u003d \u0027rabbit_pw\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_0ac5118d","line":9,"updated":"2014-06-20 10:43:10.000000000","message":"I believe the defaults should be [\u0027127.0.0.1:5672\u0027]","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"fd5e7282c7baf6238206141ef4f102c5e2c93fb8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  $sql_connection,"},{"line_number":7,"context_line":"  $cinder_user_password,"},{"line_number":8,"context_line":"  $glance_api_servers,"},{"line_number":9,"context_line":"  $queue_provider         \u003d \u0027rabbitmq\u0027,"},{"line_number":10,"context_line":"  $amqp_hosts             \u003d \u0027127.0.0.1\u0027,"},{"line_number":11,"context_line":"  $amqp_user              \u003d \u0027nova\u0027,"},{"line_number":12,"context_line":"  $amqp_password          \u003d \u0027rabbit_pw\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_5eac3a35","line":9,"in_reply_to":"1ae5cdf2_0ac5118d","updated":"2014-06-20 12:39:07.000000000","message":"Please elaborate","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"a0749cb970370146bb4ff8a01fe97e07b52e09da","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  $sql_connection,"},{"line_number":7,"context_line":"  $cinder_user_password,"},{"line_number":8,"context_line":"  $glance_api_servers,"},{"line_number":9,"context_line":"  $queue_provider         \u003d \u0027rabbitmq\u0027,"},{"line_number":10,"context_line":"  $amqp_hosts             \u003d \u0027127.0.0.1\u0027,"},{"line_number":11,"context_line":"  $amqp_user              \u003d \u0027nova\u0027,"},{"line_number":12,"context_line":"  $amqp_password          \u003d \u0027rabbit_pw\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_03e9777e","line":9,"in_reply_to":"1ae5cdf2_32cb1f54","updated":"2014-06-20 14:37:46.000000000","message":"Well, this parameter never gets default value since we always pass it. But I see no problems to change it to \u0027127.0.0.1:5672\u0027","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4b897d3aa135bd0f284a2fbdf619f6e3aa292624","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  $sql_connection,"},{"line_number":7,"context_line":"  $cinder_user_password,"},{"line_number":8,"context_line":"  $glance_api_servers,"},{"line_number":9,"context_line":"  $queue_provider         \u003d \u0027rabbitmq\u0027,"},{"line_number":10,"context_line":"  $amqp_hosts             \u003d \u0027127.0.0.1\u0027,"},{"line_number":11,"context_line":"  $amqp_user              \u003d \u0027nova\u0027,"},{"line_number":12,"context_line":"  $amqp_password          \u003d \u0027rabbit_pw\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_32cb1f54","line":9,"in_reply_to":"1ae5cdf2_5eac3a35","updated":"2014-06-20 13:17:44.000000000","message":"from cluster_ha: $amqp_hosts \u003d inline_template(\"\u003c%\u003d @amqp_nodes.map {|x| x + \u0027:\u0027 + @amqp_port}.join \u0027,\u0027 %\u003e\")\n\nSo, the expected default value should provide both host and port as well.","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2acef6772cf449eaa4569c32f8082fe176a85f48","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  $cinder_rate_limits     \u003d undef,"},{"line_number":25,"context_line":"  $verbose                \u003d false,"},{"line_number":26,"context_line":"  $debug                  \u003d false,"},{"line_number":27,"context_line":"  $idle_timeout           \u003d \u00273600\u0027,"},{"line_number":28,"context_line":"  $max_pool_size          \u003d \u002710\u0027,"},{"line_number":29,"context_line":"  $max_overflow           \u003d \u002730\u0027,"},{"line_number":30,"context_line":"  $max_retries            \u003d \u0027-1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_6a5a151f","line":27,"updated":"2014-06-20 10:43:10.000000000","message":"missing declaration as a config value from cinder::base","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"a0749cb970370146bb4ff8a01fe97e07b52e09da","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  $cinder_rate_limits     \u003d undef,"},{"line_number":25,"context_line":"  $verbose                \u003d false,"},{"line_number":26,"context_line":"  $debug                  \u003d false,"},{"line_number":27,"context_line":"  $idle_timeout           \u003d \u00273600\u0027,"},{"line_number":28,"context_line":"  $max_pool_size          \u003d \u002710\u0027,"},{"line_number":29,"context_line":"  $max_overflow           \u003d \u002730\u0027,"},{"line_number":30,"context_line":"  $max_retries            \u003d \u0027-1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_23275313","line":27,"in_reply_to":"1ae5cdf2_324cff41","updated":"2014-06-20 14:37:46.000000000","message":"It\u0027s defined already in the bottom of this file","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"fd5e7282c7baf6238206141ef4f102c5e2c93fb8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  $cinder_rate_limits     \u003d undef,"},{"line_number":25,"context_line":"  $verbose                \u003d false,"},{"line_number":26,"context_line":"  $debug                  \u003d false,"},{"line_number":27,"context_line":"  $idle_timeout           \u003d \u00273600\u0027,"},{"line_number":28,"context_line":"  $max_pool_size          \u003d \u002710\u0027,"},{"line_number":29,"context_line":"  $max_overflow           \u003d \u002730\u0027,"},{"line_number":30,"context_line":"  $max_retries            \u003d \u0027-1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_f75449ff","line":27,"in_reply_to":"1ae5cdf2_6a5a151f","updated":"2014-06-20 12:39:07.000000000","message":"Please elaborate","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4b897d3aa135bd0f284a2fbdf619f6e3aa292624","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  $cinder_rate_limits     \u003d undef,"},{"line_number":25,"context_line":"  $verbose                \u003d false,"},{"line_number":26,"context_line":"  $debug                  \u003d false,"},{"line_number":27,"context_line":"  $idle_timeout           \u003d \u00273600\u0027,"},{"line_number":28,"context_line":"  $max_pool_size          \u003d \u002710\u0027,"},{"line_number":29,"context_line":"  $max_overflow           \u003d \u002730\u0027,"},{"line_number":30,"context_line":"  $max_retries            \u003d \u0027-1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_324cff41","line":27,"in_reply_to":"1ae5cdf2_f75449ff","updated":"2014-06-20 13:17:44.000000000","message":"I mean we have to define\n\ncinder_config {\n    \u0027DATABASE/max_pool_size\u0027: value \u003d\u003e $max_pool_size;\n    \u0027DATABASE/max_retries\u0027:   value \u003d\u003e $max_retries;\n    \u0027DATABASE/max_overflow\u0027:  value \u003d\u003e $max_overflow;\n}","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2acef6772cf449eaa4569c32f8082fe176a85f48","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  $verbose                \u003d false,"},{"line_number":26,"context_line":"  $debug                  \u003d false,"},{"line_number":27,"context_line":"  $idle_timeout           \u003d \u00273600\u0027,"},{"line_number":28,"context_line":"  $max_pool_size          \u003d \u002710\u0027,"},{"line_number":29,"context_line":"  $max_overflow           \u003d \u002730\u0027,"},{"line_number":30,"context_line":"  $max_retries            \u003d \u0027-1\u0027,"},{"line_number":31,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_aa9fbdb2","line":28,"updated":"2014-06-20 10:43:10.000000000","message":"missing declaration as a config value from cinder::base","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"fd5e7282c7baf6238206141ef4f102c5e2c93fb8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  $verbose                \u003d false,"},{"line_number":26,"context_line":"  $debug                  \u003d false,"},{"line_number":27,"context_line":"  $idle_timeout           \u003d \u00273600\u0027,"},{"line_number":28,"context_line":"  $max_pool_size          \u003d \u002710\u0027,"},{"line_number":29,"context_line":"  $max_overflow           \u003d \u002730\u0027,"},{"line_number":30,"context_line":"  $max_retries            \u003d \u0027-1\u0027,"},{"line_number":31,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_1758d52f","line":28,"in_reply_to":"1ae5cdf2_aa9fbdb2","updated":"2014-06-20 12:39:07.000000000","message":"Please elaborate","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2acef6772cf449eaa4569c32f8082fe176a85f48","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  $debug                  \u003d false,"},{"line_number":27,"context_line":"  $idle_timeout           \u003d \u00273600\u0027,"},{"line_number":28,"context_line":"  $max_pool_size          \u003d \u002710\u0027,"},{"line_number":29,"context_line":"  $max_overflow           \u003d \u002730\u0027,"},{"line_number":30,"context_line":"  $max_retries            \u003d \u0027-1\u0027,"},{"line_number":31,"context_line":") {"},{"line_number":32,"context_line":"  include cinder::params"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_eaa54503","line":29,"updated":"2014-06-20 10:43:10.000000000","message":"missing declaration as a config value from cinder::base","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"fd5e7282c7baf6238206141ef4f102c5e2c93fb8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  $debug                  \u003d false,"},{"line_number":27,"context_line":"  $idle_timeout           \u003d \u00273600\u0027,"},{"line_number":28,"context_line":"  $max_pool_size          \u003d \u002710\u0027,"},{"line_number":29,"context_line":"  $max_overflow           \u003d \u002730\u0027,"},{"line_number":30,"context_line":"  $max_retries            \u003d \u0027-1\u0027,"},{"line_number":31,"context_line":") {"},{"line_number":32,"context_line":"  include cinder::params"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_3742313e","line":29,"in_reply_to":"1ae5cdf2_eaa54503","updated":"2014-06-20 12:39:07.000000000","message":"Please elaborate","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2acef6772cf449eaa4569c32f8082fe176a85f48","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        # makes \"rabbit_host:rabbit_port\" from it. So we need to split"},{"line_number":62,"context_line":"        # our aqmp_hosts or provide defaults"},{"line_number":63,"context_line":"        $rabbit_host_array[0] \u003d \u0027127.0.0.1\u0027"},{"line_number":64,"context_line":"        $rabbit_host_array[1] \u003d \u00275672\u0027"},{"line_number":65,"context_line":"      }"},{"line_number":66,"context_line":"      else {"},{"line_number":67,"context_line":"        $rabbit_hosts_real \u003d false"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_4a73994d","line":64,"updated":"2014-06-20 10:43:10.000000000","message":"you should define either rabbit_host \u0026 rabbit_port OR rabbit_hosts. We use rabbit_hosts for all services supporting Oslo.messeging, and Cinder does it. Please use rabbit_hosts only.","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"fd5e7282c7baf6238206141ef4f102c5e2c93fb8","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        # makes \"rabbit_host:rabbit_port\" from it. So we need to split"},{"line_number":62,"context_line":"        # our aqmp_hosts or provide defaults"},{"line_number":63,"context_line":"        $rabbit_host_array[0] \u003d \u0027127.0.0.1\u0027"},{"line_number":64,"context_line":"        $rabbit_host_array[1] \u003d \u00275672\u0027"},{"line_number":65,"context_line":"      }"},{"line_number":66,"context_line":"      else {"},{"line_number":67,"context_line":"        $rabbit_hosts_real \u003d false"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_3edccee3","line":64,"in_reply_to":"1ae5cdf2_4a73994d","updated":"2014-06-20 12:39:07.000000000","message":"Please see how cinder module handles this here:\n\nhttps://github.com/stackforge/puppet-cinder/blob/4.0.0/manifests/init.pp#L137-L146","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2acef6772cf449eaa4569c32f8082fe176a85f48","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      }"},{"line_number":73,"context_line":"      class { \u0027::cinder\u0027:"},{"line_number":74,"context_line":"        package_ensure        \u003d\u003e $::openstack_version[\u0027cinder\u0027],"},{"line_number":75,"context_line":"        rpc_backend           \u003d\u003e \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"},{"line_number":76,"context_line":"        rabbit_host           \u003d\u003e $rabbit_host_array[0],"},{"line_number":77,"context_line":"        rabbit_port           \u003d\u003e $rabbit_host_array[1],"},{"line_number":78,"context_line":"        rabbit_hosts          \u003d\u003e $rabbit_hosts_real,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_4a52b9de","line":75,"updated":"2014-06-20 10:43:10.000000000","message":"Please use a class param \n$rpc_backend                 \u003d \u0027heat.openstack.common.rpc.impl_kombu\u0027,","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4b897d3aa135bd0f284a2fbdf619f6e3aa292624","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      }"},{"line_number":73,"context_line":"      class { \u0027::cinder\u0027:"},{"line_number":74,"context_line":"        package_ensure        \u003d\u003e $::openstack_version[\u0027cinder\u0027],"},{"line_number":75,"context_line":"        rpc_backend           \u003d\u003e \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"},{"line_number":76,"context_line":"        rabbit_host           \u003d\u003e $rabbit_host_array[0],"},{"line_number":77,"context_line":"        rabbit_port           \u003d\u003e $rabbit_host_array[1],"},{"line_number":78,"context_line":"        rabbit_hosts          \u003d\u003e $rabbit_hosts_real,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_12ff0367","line":75,"in_reply_to":"1ae5cdf2_1eb71286","updated":"2014-06-20 13:17:44.000000000","message":"Well I can live with that unless we decide to start supporting qpid backend in Fuel.","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"fd5e7282c7baf6238206141ef4f102c5e2c93fb8","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      }"},{"line_number":73,"context_line":"      class { \u0027::cinder\u0027:"},{"line_number":74,"context_line":"        package_ensure        \u003d\u003e $::openstack_version[\u0027cinder\u0027],"},{"line_number":75,"context_line":"        rpc_backend           \u003d\u003e \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"},{"line_number":76,"context_line":"        rabbit_host           \u003d\u003e $rabbit_host_array[0],"},{"line_number":77,"context_line":"        rabbit_port           \u003d\u003e $rabbit_host_array[1],"},{"line_number":78,"context_line":"        rabbit_hosts          \u003d\u003e $rabbit_hosts_real,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_1eb71286","line":75,"in_reply_to":"1ae5cdf2_4a52b9de","updated":"2014-06-20 12:39:07.000000000","message":"Why? We use \u0027cinder.openstack.common.rpc.impl_kombu\u0027 in our current cinder module.","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2acef6772cf449eaa4569c32f8082fe176a85f48","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      class { \u0027::cinder\u0027:"},{"line_number":74,"context_line":"        package_ensure        \u003d\u003e $::openstack_version[\u0027cinder\u0027],"},{"line_number":75,"context_line":"        rpc_backend           \u003d\u003e \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"},{"line_number":76,"context_line":"        rabbit_host           \u003d\u003e $rabbit_host_array[0],"},{"line_number":77,"context_line":"        rabbit_port           \u003d\u003e $rabbit_host_array[1],"},{"line_number":78,"context_line":"        rabbit_hosts          \u003d\u003e $rabbit_hosts_real,"},{"line_number":79,"context_line":"        rabbit_userid         \u003d\u003e $amqp_user,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_ca0c09ef","line":76,"updated":"2014-06-20 10:43:10.000000000","message":"you should pass either rabbit_host \u0026 rabbit_port OR rabbit_hosts. We use rabbit_hosts for all services supporting Oslo.messeging, and Cinder does it. Please use  rabbit_hosts only.","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4b897d3aa135bd0f284a2fbdf619f6e3aa292624","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      class { \u0027::cinder\u0027:"},{"line_number":74,"context_line":"        package_ensure        \u003d\u003e $::openstack_version[\u0027cinder\u0027],"},{"line_number":75,"context_line":"        rpc_backend           \u003d\u003e \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"},{"line_number":76,"context_line":"        rabbit_host           \u003d\u003e $rabbit_host_array[0],"},{"line_number":77,"context_line":"        rabbit_port           \u003d\u003e $rabbit_host_array[1],"},{"line_number":78,"context_line":"        rabbit_hosts          \u003d\u003e $rabbit_hosts_real,"},{"line_number":79,"context_line":"        rabbit_userid         \u003d\u003e $amqp_user,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_b2ef2f86","line":76,"in_reply_to":"1ae5cdf2_9edde2df","updated":"2014-06-20 13:17:44.000000000","message":"aggree","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"fd5e7282c7baf6238206141ef4f102c5e2c93fb8","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      class { \u0027::cinder\u0027:"},{"line_number":74,"context_line":"        package_ensure        \u003d\u003e $::openstack_version[\u0027cinder\u0027],"},{"line_number":75,"context_line":"        rpc_backend           \u003d\u003e \u0027cinder.openstack.common.rpc.impl_kombu\u0027,"},{"line_number":76,"context_line":"        rabbit_host           \u003d\u003e $rabbit_host_array[0],"},{"line_number":77,"context_line":"        rabbit_port           \u003d\u003e $rabbit_host_array[1],"},{"line_number":78,"context_line":"        rabbit_hosts          \u003d\u003e $rabbit_hosts_real,"},{"line_number":79,"context_line":"        rabbit_userid         \u003d\u003e $amqp_user,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_9edde2df","line":76,"in_reply_to":"1ae5cdf2_ca0c09ef","updated":"2014-06-20 12:39:07.000000000","message":"Please see how cinder module handles this here:\n\nhttps://github.com/stackforge/puppet-cinder/blob/4.0.0/manifests/init.pp#L137-L146","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2acef6772cf449eaa4569c32f8082fe176a85f48","unresolved":false,"context_lines":[{"line_number":99,"context_line":"      }"},{"line_number":100,"context_line":"    }"},{"line_number":101,"context_line":"  }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  if ($bind_host) {"},{"line_number":104,"context_line":"    class { \u0027cinder::api\u0027:"},{"line_number":105,"context_line":"      keystone_enabled   \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_aa8c1d36","line":102,"updated":"2014-06-20 10:43:10.000000000","message":"missed package {\"$::cinder::params::qemuimg_package_name\":}\nfrom cinder::base\n\nmissed package { \u0027python-cinder\u0027:\nfrom cinder::base","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"fd5e7282c7baf6238206141ef4f102c5e2c93fb8","unresolved":false,"context_lines":[{"line_number":99,"context_line":"      }"},{"line_number":100,"context_line":"    }"},{"line_number":101,"context_line":"  }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  if ($bind_host) {"},{"line_number":104,"context_line":"    class { \u0027cinder::api\u0027:"},{"line_number":105,"context_line":"      keystone_enabled   \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_41cfff7e","line":102,"in_reply_to":"1ae5cdf2_aa8c1d36","updated":"2014-06-20 12:39:07.000000000","message":"\u0027python-cinder\u0027 and \u0027qemu-img\u0027 are being installed as a dependency for \u0027openstack-cinder\u0027 package. At least in CentOS. Will check in ubuntu.","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2acef6772cf449eaa4569c32f8082fe176a85f48","unresolved":false,"context_lines":[{"line_number":109,"context_line":"      bind_host          \u003d\u003e $bind_host,"},{"line_number":110,"context_line":"      ratelimits         \u003d\u003e $cinder_rate_limits"},{"line_number":111,"context_line":"    }"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    class { \u0027cinder::scheduler\u0027:"},{"line_number":114,"context_line":"      package_ensure \u003d\u003e $::openstack_version[\u0027cinder\u0027],"},{"line_number":115,"context_line":"      enabled        \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_0a21914c","line":112,"updated":"2014-06-20 10:43:10.000000000","message":"missed  if $keystone_enabled { ... keystone_authtoken/* ....} config stanza from cinder::api","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"fd5e7282c7baf6238206141ef4f102c5e2c93fb8","unresolved":false,"context_lines":[{"line_number":109,"context_line":"      bind_host          \u003d\u003e $bind_host,"},{"line_number":110,"context_line":"      ratelimits         \u003d\u003e $cinder_rate_limits"},{"line_number":111,"context_line":"    }"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    class { \u0027cinder::scheduler\u0027:"},{"line_number":114,"context_line":"      package_ensure \u003d\u003e $::openstack_version[\u0027cinder\u0027],"},{"line_number":115,"context_line":"      enabled        \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_a197e343","line":112,"in_reply_to":"1ae5cdf2_0a21914c","updated":"2014-06-20 12:39:07.000000000","message":"Will add shortly.","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"456697f1af83f6f06b8093c2f7f0ba8ff85d5645","unresolved":false,"context_lines":[{"line_number":143,"context_line":"      }"},{"line_number":144,"context_line":"    }"},{"line_number":145,"context_line":"  }"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"  if $use_syslog {"},{"line_number":148,"context_line":"    cinder_config {"},{"line_number":149,"context_line":"      \u0027DEFAULT/use_syslog_rfc_format\u0027: value \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_6a4135a5","line":146,"updated":"2014-06-20 10:47:14.000000000","message":"missed cinder::ceilometer class call for ensuring ceilometer notifications","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"fd5e7282c7baf6238206141ef4f102c5e2c93fb8","unresolved":false,"context_lines":[{"line_number":143,"context_line":"      }"},{"line_number":144,"context_line":"    }"},{"line_number":145,"context_line":"  }"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"  if $use_syslog {"},{"line_number":148,"context_line":"    cinder_config {"},{"line_number":149,"context_line":"      \u0027DEFAULT/use_syslog_rfc_format\u0027: value \u003d\u003e true;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1ae5cdf2_d703cd0a","line":146,"in_reply_to":"1ae5cdf2_6a4135a5","updated":"2014-06-20 12:39:07.000000000","message":"Will add shortly.","commit_id":"57bcadcb3786ca411e0e13276eadcc65bd293de5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1f4071f5d72c6f2042192d90e0137385dd85ccea","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    cinder_config {"},{"line_number":162,"context_line":"      \u0027database/max_pool_size\u0027:               value \u003d\u003e $max_pool_size;"},{"line_number":163,"context_line":"      \u0027database/max_retries\u0027:                 value \u003d\u003e $max_retries;"},{"line_number":164,"context_line":"      \u0027database/max_overflow\u0027:                value \u003d\u003e $max_overflow;"},{"line_number":165,"context_line":"      \u0027keystone_authtoken/auth_protocol\u0027:     value \u003d\u003e $keystone_auth_protocol;"},{"line_number":166,"context_line":"      \u0027keystone_authtoken/auth_host\u0027:         value \u003d\u003e $auth_host;"},{"line_number":167,"context_line":"      \u0027keystone_authtoken/auth_port\u0027:         value \u003d\u003e $keystone_auth_port;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1ae5cdf2_0455d71d","line":164,"updated":"2014-06-23 09:58:36.000000000","message":"sqlalchemy backend related sections should be moved out from if $keystone_enabled scope","commit_id":"7b200730a76bb1342213d1511d70835b078d2dab"}],"deployment/puppet/osnailyfacter/manifests/cluster_ha.pp":[{"author":{"_account_id":8787,"name":"Dmitry Borodaenko","email":"angdraug@gmail.com","username":"angdraug"},"change_message_id":"1c16bd4324d4966f1c9e203bedebfd7dc464179c","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        max_pool_size        \u003d\u003e $max_pool_size,"},{"line_number":679,"context_line":"        max_overflow         \u003d\u003e $max_overflow,"},{"line_number":680,"context_line":"        idle_timeout         \u003d\u003e $idle_timeout,"},{"line_number":681,"context_line":"        ceilometer           \u003d\u003e $ceilometer_hash[enabled],"},{"line_number":682,"context_line":"      }"},{"line_number":683,"context_line":"    } # CINDER ENDS"},{"line_number":684,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1ae5cdf2_d09f7c00","line":681,"updated":"2014-06-27 05:42:25.000000000","message":"enabled without quotes will through a puppet-lint warning, please use $ceilometer_hash[\u0027enabled\u0027]","commit_id":"a9869f63ca4cbd2134be0bb07a047dcea5653a48"}],"deployment/puppet/osnailyfacter/manifests/cluster_simple.pp":[{"author":{"_account_id":8787,"name":"Dmitry Borodaenko","email":"angdraug@gmail.com","username":"angdraug"},"change_message_id":"1c16bd4324d4966f1c9e203bedebfd7dc464179c","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        max_pool_size        \u003d\u003e $max_pool_size,"},{"line_number":501,"context_line":"        max_overflow         \u003d\u003e $max_overflow,"},{"line_number":502,"context_line":"        idle_timeout         \u003d\u003e $idle_timeout,"},{"line_number":503,"context_line":"        ceilometer           \u003d\u003e $ceilometer_hash[enabled]"},{"line_number":504,"context_line":"      }"},{"line_number":505,"context_line":"    } #CINDER ENDS"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1ae5cdf2_f08718b4","line":503,"updated":"2014-06-27 05:42:25.000000000","message":"same problem with missing quotes.","commit_id":"a9869f63ca4cbd2134be0bb07a047dcea5653a48"}]}
