)]}'
{"deployment/puppet/mellanox_openstack/Modulefile":[{"author":{"_account_id":8935,"name":"Andrey Danin","email":"gcon.monolake@gmail.com","username":"adanin"},"change_message_id":"1e668c64fbb3d6079aa988275ba80e718c802fc9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"license \u0027Apache License, Version 2.0\u0027"},{"line_number":6,"context_line":"summary \u0027UNKNOWN\u0027"},{"line_number":7,"context_line":"description \u0027UNKNOWN\u0027"},{"line_number":8,"context_line":"project_page \u0027UNKNOWN\u0027"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"## Add dependencies, if any:"},{"line_number":11,"context_line":"# dependency \u0027username/name\u0027, \u0027\u003e\u003d 1.2.0\u0027"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_1a5f7c42","line":8,"updated":"2014-07-03 10:27:28.000000000","message":"Can you provide all the information in nearest future? Including License and copyright. It\u0027s not blocker now, but it should be done before we merge the code.","commit_id":"c485ba98b2b49d64779e03698ec6083eff2a877d"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"8c7b1746260b32def62039c3609cf8248b1f8546","unresolved":false,"context_lines":[{"line_number":5,"context_line":"license \u0027Apache License, Version 2.0\u0027"},{"line_number":6,"context_line":"summary \u0027UNKNOWN\u0027"},{"line_number":7,"context_line":"description \u0027UNKNOWN\u0027"},{"line_number":8,"context_line":"project_page \u0027UNKNOWN\u0027"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"## Add dependencies, if any:"},{"line_number":11,"context_line":"# dependency \u0027username/name\u0027, \u0027\u003e\u003d 1.2.0\u0027"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_88a347b1","line":8,"in_reply_to":"baada198_1a5f7c42","updated":"2014-07-03 10:35:56.000000000","message":"Sure, it will be pushed with the roles manifests. I added here just the skeleton.","commit_id":"c485ba98b2b49d64779e03698ec6083eff2a877d"},{"author":{"_account_id":8935,"name":"Andrey Danin","email":"gcon.monolake@gmail.com","username":"adanin"},"change_message_id":"b004a461dd8e1402c7da41518e22cd9ce03ace0f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"license \u0027Apache License, Version 2.0\u0027"},{"line_number":6,"context_line":"summary \u0027UNKNOWN\u0027"},{"line_number":7,"context_line":"description \u0027UNKNOWN\u0027"},{"line_number":8,"context_line":"project_page \u0027UNKNOWN\u0027"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"## Add dependencies, if any:"},{"line_number":11,"context_line":"# dependency \u0027username/name\u0027, \u0027\u003e\u003d 1.2.0\u0027"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_e8d4c3be","line":8,"in_reply_to":"baada198_88a347b1","updated":"2014-07-03 10:40:24.000000000","message":"Done","commit_id":"c485ba98b2b49d64779e03698ec6083eff2a877d"}],"deployment/puppet/mellanox_openstack/manifests/init.pp":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"cb7900cbf43037b94a355a98c76ea48921f95ed4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# Document parameters here."},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# [*sample_parameter*]"},{"line_number":10,"context_line":"#   Explanation of what this parameter affects and what it defaults to."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_db2203a2","line":7,"updated":"2014-07-07 17:09:54.000000000","message":"put some real parameters in here or just remove this commented code","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"383726e24f960559dbbcfb39c117a625db9e61b7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# Document parameters here."},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# [*sample_parameter*]"},{"line_number":10,"context_line":"#   Explanation of what this parameter affects and what it defaults to."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_c3380040","line":7,"in_reply_to":"baada198_db2203a2","updated":"2014-07-09 20:44:34.000000000","message":"Done","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"}],"deployment/puppet/mellanox_openstack/manifests/iser_rename.pp":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"cb7900cbf43037b94a355a98c76ea48921f95ed4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  $iser_rename_script \u003d \"$iser_script_dir/iser_rename.sh\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  file { $iser_script_dir:"},{"line_number":8,"context_line":"    ensure \u003d\u003e \"directory\","},{"line_number":9,"context_line":"  }"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  file { $iser_rename_script:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_9b532b16","line":8,"updated":"2014-07-07 17:09:54.000000000","message":"no quotes around keyword directory","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"383726e24f960559dbbcfb39c117a625db9e61b7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  $iser_rename_script \u003d \"$iser_script_dir/iser_rename.sh\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  file { $iser_script_dir:"},{"line_number":8,"context_line":"    ensure \u003d\u003e \"directory\","},{"line_number":9,"context_line":"  }"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  file { $iser_rename_script:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_2349bcd0","line":8,"in_reply_to":"baada198_9b532b16","updated":"2014-07-09 20:44:34.000000000","message":"Done","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"cb7900cbf43037b94a355a98c76ea48921f95ed4","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  file { $iser_rename_script:"},{"line_number":12,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":13,"context_line":"    owner   \u003d\u003e root,"},{"line_number":14,"context_line":"    group   \u003d\u003e root,"},{"line_number":15,"context_line":"    mode    \u003d\u003e 500,"},{"line_number":16,"context_line":"    content \u003d\u003e template(\"mellanox_openstack/iser_rename.erb\"),"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_db592336","line":13,"updated":"2014-07-07 17:09:54.000000000","message":"quotes around root","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"383726e24f960559dbbcfb39c117a625db9e61b7","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  file { $iser_rename_script:"},{"line_number":12,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":13,"context_line":"    owner   \u003d\u003e root,"},{"line_number":14,"context_line":"    group   \u003d\u003e root,"},{"line_number":15,"context_line":"    mode    \u003d\u003e 500,"},{"line_number":16,"context_line":"    content \u003d\u003e template(\"mellanox_openstack/iser_rename.erb\"),"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_4344f0b6","line":13,"in_reply_to":"baada198_db592336","updated":"2014-07-09 20:44:34.000000000","message":"Done","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"cb7900cbf43037b94a355a98c76ea48921f95ed4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  file { $iser_rename_script:"},{"line_number":12,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":13,"context_line":"    owner   \u003d\u003e root,"},{"line_number":14,"context_line":"    group   \u003d\u003e root,"},{"line_number":15,"context_line":"    mode    \u003d\u003e 500,"},{"line_number":16,"context_line":"    content \u003d\u003e template(\"mellanox_openstack/iser_rename.erb\"),"},{"line_number":17,"context_line":"    require \u003d\u003e File[$iser_script_dir],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_fb43473f","line":14,"updated":"2014-07-07 17:09:54.000000000","message":"quotes around root","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"383726e24f960559dbbcfb39c117a625db9e61b7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  file { $iser_rename_script:"},{"line_number":12,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":13,"context_line":"    owner   \u003d\u003e root,"},{"line_number":14,"context_line":"    group   \u003d\u003e root,"},{"line_number":15,"context_line":"    mode    \u003d\u003e 500,"},{"line_number":16,"context_line":"    content \u003d\u003e template(\"mellanox_openstack/iser_rename.erb\"),"},{"line_number":17,"context_line":"    require \u003d\u003e File[$iser_script_dir],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_6312d4b5","line":14,"in_reply_to":"baada198_fb43473f","updated":"2014-07-09 20:44:34.000000000","message":"Done","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"cb7900cbf43037b94a355a98c76ea48921f95ed4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":13,"context_line":"    owner   \u003d\u003e root,"},{"line_number":14,"context_line":"    group   \u003d\u003e root,"},{"line_number":15,"context_line":"    mode    \u003d\u003e 500,"},{"line_number":16,"context_line":"    content \u003d\u003e template(\"mellanox_openstack/iser_rename.erb\"),"},{"line_number":17,"context_line":"    require \u003d\u003e File[$iser_script_dir],"},{"line_number":18,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_3b4a1f55","line":15,"updated":"2014-07-07 17:09:54.000000000","message":"quotes around mode","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"383726e24f960559dbbcfb39c117a625db9e61b7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":13,"context_line":"    owner   \u003d\u003e root,"},{"line_number":14,"context_line":"    group   \u003d\u003e root,"},{"line_number":15,"context_line":"    mode    \u003d\u003e 500,"},{"line_number":16,"context_line":"    content \u003d\u003e template(\"mellanox_openstack/iser_rename.erb\"),"},{"line_number":17,"context_line":"    require \u003d\u003e File[$iser_script_dir],"},{"line_number":18,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_c30f2087","line":15,"in_reply_to":"baada198_3b4a1f55","updated":"2014-07-09 20:44:34.000000000","message":"Done","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"a556aa58c20fa8fc2cac7fcdf6ffb68797ead112","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    owner   \u003d\u003e root,"},{"line_number":14,"context_line":"    group   \u003d\u003e root,"},{"line_number":15,"context_line":"    mode    \u003d\u003e 500,"},{"line_number":16,"context_line":"    content \u003d\u003e template(\"mellanox_openstack/iser_rename.erb\"),"},{"line_number":17,"context_line":"    require \u003d\u003e File[$iser_script_dir],"},{"line_number":18,"context_line":"  }"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_73d91b56","line":16,"updated":"2014-07-07 18:32:20.000000000","message":"single quote strings with out variable interpolation","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"383726e24f960559dbbcfb39c117a625db9e61b7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    owner   \u003d\u003e root,"},{"line_number":14,"context_line":"    group   \u003d\u003e root,"},{"line_number":15,"context_line":"    mode    \u003d\u003e 500,"},{"line_number":16,"context_line":"    content \u003d\u003e template(\"mellanox_openstack/iser_rename.erb\"),"},{"line_number":17,"context_line":"    require \u003d\u003e File[$iser_script_dir],"},{"line_number":18,"context_line":"  }"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_a30cec95","line":16,"in_reply_to":"baada198_73d91b56","updated":"2014-07-09 20:44:34.000000000","message":"Done","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"cb7900cbf43037b94a355a98c76ea48921f95ed4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    group   \u003d\u003e root,"},{"line_number":15,"context_line":"    mode    \u003d\u003e 500,"},{"line_number":16,"context_line":"    content \u003d\u003e template(\"mellanox_openstack/iser_rename.erb\"),"},{"line_number":17,"context_line":"    require \u003d\u003e File[$iser_script_dir],"},{"line_number":18,"context_line":"  }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  exec { \u0027iser_rename\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_bb6d4fce","line":17,"updated":"2014-07-07 17:09:54.000000000","message":"puppet can already sort all file resources. you don\u0027t need this require","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"383726e24f960559dbbcfb39c117a625db9e61b7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    group   \u003d\u003e root,"},{"line_number":15,"context_line":"    mode    \u003d\u003e 500,"},{"line_number":16,"context_line":"    content \u003d\u003e template(\"mellanox_openstack/iser_rename.erb\"),"},{"line_number":17,"context_line":"    require \u003d\u003e File[$iser_script_dir],"},{"line_number":18,"context_line":"  }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  exec { \u0027iser_rename\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_e325040b","line":17,"in_reply_to":"baada198_bb6d4fce","updated":"2014-07-09 20:44:34.000000000","message":"Done","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"cb7900cbf43037b94a355a98c76ea48921f95ed4","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    require \u003d\u003e File[$iser_script_dir],"},{"line_number":18,"context_line":"  }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  exec { \u0027iser_rename\u0027:"},{"line_number":21,"context_line":"    command  \u003d\u003e \"bash $iser_rename_script\","},{"line_number":22,"context_line":"    user     \u003d\u003e root,"},{"line_number":23,"context_line":"    onlyif   \u003d\u003e \"test ! -f $interfaces_path/$iser_interface_name\","}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_7bec972a","line":20,"updated":"2014-07-07 17:09:54.000000000","message":"Consider adding add logoutput \u003d\u003e true","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"383726e24f960559dbbcfb39c117a625db9e61b7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    require \u003d\u003e File[$iser_script_dir],"},{"line_number":18,"context_line":"  }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  exec { \u0027iser_rename\u0027:"},{"line_number":21,"context_line":"    command  \u003d\u003e \"bash $iser_rename_script\","},{"line_number":22,"context_line":"    user     \u003d\u003e root,"},{"line_number":23,"context_line":"    onlyif   \u003d\u003e \"test ! -f $interfaces_path/$iser_interface_name\","}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_032118fc","line":20,"in_reply_to":"baada198_7bec972a","updated":"2014-07-09 20:44:34.000000000","message":"Done","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"cb7900cbf43037b94a355a98c76ea48921f95ed4","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  exec { \u0027iser_rename\u0027:"},{"line_number":21,"context_line":"    command  \u003d\u003e \"bash $iser_rename_script\","},{"line_number":22,"context_line":"    user     \u003d\u003e root,"},{"line_number":23,"context_line":"    onlyif   \u003d\u003e \"test ! -f $interfaces_path/$iser_interface_name\","},{"line_number":24,"context_line":"    path     \u003d\u003e [\u0027/usr/bin\u0027,\u0027/usr/sbin\u0027,\u0027/bin\u0027,\u0027/sbin\u0027,\u0027/usr/local/bin\u0027],"},{"line_number":25,"context_line":"    require  \u003d\u003e File[$iser_rename_script]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_dba76309","line":22,"updated":"2014-07-07 17:09:54.000000000","message":"default runas is root. not needed","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"383726e24f960559dbbcfb39c117a625db9e61b7","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  exec { \u0027iser_rename\u0027:"},{"line_number":21,"context_line":"    command  \u003d\u003e \"bash $iser_rename_script\","},{"line_number":22,"context_line":"    user     \u003d\u003e root,"},{"line_number":23,"context_line":"    onlyif   \u003d\u003e \"test ! -f $interfaces_path/$iser_interface_name\","},{"line_number":24,"context_line":"    path     \u003d\u003e [\u0027/usr/bin\u0027,\u0027/usr/sbin\u0027,\u0027/bin\u0027,\u0027/sbin\u0027,\u0027/usr/local/bin\u0027],"},{"line_number":25,"context_line":"    require  \u003d\u003e File[$iser_rename_script]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_431b10ca","line":22,"in_reply_to":"baada198_dba76309","updated":"2014-07-09 20:44:34.000000000","message":"Done","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"cb7900cbf43037b94a355a98c76ea48921f95ed4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  exec { \u0027iser_rename\u0027:"},{"line_number":21,"context_line":"    command  \u003d\u003e \"bash $iser_rename_script\","},{"line_number":22,"context_line":"    user     \u003d\u003e root,"},{"line_number":23,"context_line":"    onlyif   \u003d\u003e \"test ! -f $interfaces_path/$iser_interface_name\","},{"line_number":24,"context_line":"    path     \u003d\u003e [\u0027/usr/bin\u0027,\u0027/usr/sbin\u0027,\u0027/bin\u0027,\u0027/sbin\u0027,\u0027/usr/local/bin\u0027],"},{"line_number":25,"context_line":"    require  \u003d\u003e File[$iser_rename_script]"},{"line_number":26,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_7bd3b75f","line":23,"updated":"2014-07-07 17:09:54.000000000","message":"change onlyif to unless \u003d\u003e \"test -f ${interfaces_path}/${iser_interface_name}\"\nInterpolation is recommended when using variables inside quotes","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"383726e24f960559dbbcfb39c117a625db9e61b7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  exec { \u0027iser_rename\u0027:"},{"line_number":21,"context_line":"    command  \u003d\u003e \"bash $iser_rename_script\","},{"line_number":22,"context_line":"    user     \u003d\u003e root,"},{"line_number":23,"context_line":"    onlyif   \u003d\u003e \"test ! -f $interfaces_path/$iser_interface_name\","},{"line_number":24,"context_line":"    path     \u003d\u003e [\u0027/usr/bin\u0027,\u0027/usr/sbin\u0027,\u0027/bin\u0027,\u0027/sbin\u0027,\u0027/usr/local/bin\u0027],"},{"line_number":25,"context_line":"    require  \u003d\u003e File[$iser_rename_script]"},{"line_number":26,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_6379f4fb","line":23,"in_reply_to":"baada198_7bd3b75f","updated":"2014-07-09 20:44:34.000000000","message":"Done","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"}],"deployment/puppet/mellanox_openstack/templates/iser_rename.erb":[{"author":{"_account_id":8935,"name":"Andrey Danin","email":"gcon.monolake@gmail.com","username":"adanin"},"change_message_id":"1e668c64fbb3d6079aa988275ba80e718c802fc9","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  logger_print info \"Changed probed port name from $PROBED_PORT_NAME to $ISER_NAME.\""},{"line_number":78,"context_line":"else"},{"line_number":79,"context_line":"  logger_print info \"Probed port name is configured properly to $ISER_NAME.\""},{"line_number":80,"context_line":"fi"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"exit $SUCCESS"}],"source_content_type":"application/x-erb","patch_set":2,"id":"baada198_e8f683f8","line":79,"updated":"2014-07-03 10:27:28.000000000","message":"Just to clarify, maybe add \"already\"? Like:\n\"is already configured properly\"","commit_id":"c485ba98b2b49d64779e03698ec6083eff2a877d"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"8c7b1746260b32def62039c3609cf8248b1f8546","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  logger_print info \"Changed probed port name from $PROBED_PORT_NAME to $ISER_NAME.\""},{"line_number":78,"context_line":"else"},{"line_number":79,"context_line":"  logger_print info \"Probed port name is configured properly to $ISER_NAME.\""},{"line_number":80,"context_line":"fi"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"exit $SUCCESS"}],"source_content_type":"application/x-erb","patch_set":2,"id":"baada198_287b1b29","line":79,"in_reply_to":"baada198_e8f683f8","updated":"2014-07-03 10:35:56.000000000","message":"OK","commit_id":"c485ba98b2b49d64779e03698ec6083eff2a877d"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"cb7900cbf43037b94a355a98c76ea48921f95ed4","unresolved":false,"context_lines":[{"line_number":26,"context_line":"fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Find first probe card BUS ID, and its ports"},{"line_number":29,"context_line":"SON_BUS\u003d`ls -l $FATHER_FIRST_VF | awk \u0027{print $11}\u0027 | sed s/\\.\\.[\\/]// | sed s/[\\/]//`"},{"line_number":30,"context_line":"CANDIDATES\u003d`ls -l /sys/class/net/*/device | grep -i $SON_BUS|awk \u0027{print $9}\u0027`"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Find the probe VF port that fits the storage ports number"}],"source_content_type":"application/x-erb","patch_set":3,"id":"baada198_9b640bba","line":29,"updated":"2014-07-07 17:09:54.000000000","message":"parsing ls output is bad. What do you want here?","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"63773ace30f113ef90764cee942a3600c1087ca5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Find first probe card BUS ID, and its ports"},{"line_number":29,"context_line":"SON_BUS\u003d`ls -l $FATHER_FIRST_VF | awk \u0027{print $11}\u0027 | sed s/\\.\\.[\\/]// | sed s/[\\/]//`"},{"line_number":30,"context_line":"CANDIDATES\u003d`ls -l /sys/class/net/*/device | grep -i $SON_BUS|awk \u0027{print $9}\u0027`"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Find the probe VF port that fits the storage ports number"}],"source_content_type":"application/x-erb","patch_set":3,"id":"baada198_46bd3a01","line":29,"in_reply_to":"baada198_9b640bba","updated":"2014-07-07 18:44:30.000000000","message":"/sys/class/net/$STORAGE_PORT/device/virtfn0 is a directory that is linked to the bus ID of the first virtual card under this ports card.\n\nFor example, if eth3 is the storage parent: \n[root@node-1 ~]# ls -l /sys/class/net/eth3/device/virtfn0\n\nlrwxrwxrwx 1 root root 0 Jul  7 17:25 /sys/class/net/eth3/device/virtfn0 -\u003e ../0000:02:00.1\n\nWe need to get exactly the bus for the udev stage.","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"383726e24f960559dbbcfb39c117a625db9e61b7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Find first probe card BUS ID, and its ports"},{"line_number":29,"context_line":"SON_BUS\u003d`ls -l $FATHER_FIRST_VF | awk \u0027{print $11}\u0027 | sed s/\\.\\.[\\/]// | sed s/[\\/]//`"},{"line_number":30,"context_line":"CANDIDATES\u003d`ls -l /sys/class/net/*/device | grep -i $SON_BUS|awk \u0027{print $9}\u0027`"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Find the probe VF port that fits the storage ports number"}],"source_content_type":"application/x-erb","patch_set":3,"id":"baada198_a3830ccb","line":29,"in_reply_to":"baada198_9b640bba","updated":"2014-07-09 20:44:34.000000000","message":"Done","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"cb7900cbf43037b94a355a98c76ea48921f95ed4","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Find first probe card BUS ID, and its ports"},{"line_number":29,"context_line":"SON_BUS\u003d`ls -l $FATHER_FIRST_VF | awk \u0027{print $11}\u0027 | sed s/\\.\\.[\\/]// | sed s/[\\/]//`"},{"line_number":30,"context_line":"CANDIDATES\u003d`ls -l /sys/class/net/*/device | grep -i $SON_BUS|awk \u0027{print $9}\u0027`"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Find the probe VF port that fits the storage ports number"},{"line_number":33,"context_line":"STORAGE_PORT_NUMBER\u003d`cat /sys/class/net/$STORAGE_PORT/dev_id`"}],"source_content_type":"application/x-erb","patch_set":3,"id":"baada198_1b70fb70","line":30,"updated":"2014-07-07 17:09:54.000000000","message":"again ls is bad here. grep -i $SON_BUS /sys/class/net/*/device","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"383726e24f960559dbbcfb39c117a625db9e61b7","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Find first probe card BUS ID, and its ports"},{"line_number":29,"context_line":"SON_BUS\u003d`ls -l $FATHER_FIRST_VF | awk \u0027{print $11}\u0027 | sed s/\\.\\.[\\/]// | sed s/[\\/]//`"},{"line_number":30,"context_line":"CANDIDATES\u003d`ls -l /sys/class/net/*/device | grep -i $SON_BUS|awk \u0027{print $9}\u0027`"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Find the probe VF port that fits the storage ports number"},{"line_number":33,"context_line":"STORAGE_PORT_NUMBER\u003d`cat /sys/class/net/$STORAGE_PORT/dev_id`"}],"source_content_type":"application/x-erb","patch_set":3,"id":"baada198_c38640db","line":30,"in_reply_to":"baada198_1b70fb70","updated":"2014-07-09 20:44:34.000000000","message":"Done","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"63773ace30f113ef90764cee942a3600c1087ca5","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Find first probe card BUS ID, and its ports"},{"line_number":29,"context_line":"SON_BUS\u003d`ls -l $FATHER_FIRST_VF | awk \u0027{print $11}\u0027 | sed s/\\.\\.[\\/]// | sed s/[\\/]//`"},{"line_number":30,"context_line":"CANDIDATES\u003d`ls -l /sys/class/net/*/device | grep -i $SON_BUS|awk \u0027{print $9}\u0027`"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Find the probe VF port that fits the storage ports number"},{"line_number":33,"context_line":"STORAGE_PORT_NUMBER\u003d`cat /sys/class/net/$STORAGE_PORT/dev_id`"}],"source_content_type":"application/x-erb","patch_set":3,"id":"baada198_86bf5260","line":30,"in_reply_to":"baada198_1b70fb70","updated":"2014-07-07 18:44:30.000000000","message":"We use /sys/class/net/*/device as an expression to search over linked ports directories, and get candidates for the virtual storage port (all of the ports of the same card will have the same bus, we need the one with the same dev_id):\n\n[root@node-1 ~]# ls -l /sys/class/net/*/device\n\nlrwxrwxrwx 1 root root 0 Jul  7 17:25 /sys/class/net/eth0/device -\u003e ../../../0000:06:00.0\n\nlrwxrwxrwx 1 root root 0 Jul  7 17:25 /sys/class/net/eth1/device -\u003e ../../../0000:06:00.1\n\nlrwxrwxrwx 1 root root 0 Jul  7 17:25 /sys/class/net/eth2/device -\u003e ../../../0000:02:00.0\n\nlrwxrwxrwx 1 root root 0 Jul  7 17:25 /sys/class/net/eth3/device -\u003e ../../../0000:02:00.0\n\nlrwxrwxrwx 1 root root 0 Jul  7 17:25 /sys/class/net/eth4/device -\u003e ../../../0000:02:00.1\n\nlrwxrwxrwx 1 root root 0 Jul  7 17:25 /sys/class/net/eth5/device -\u003e ../../../0000:02:00.1\n\nSo grep -i $SON_BUS /sys/class/net/*/device will not work here..\ndo you have a better suggestion?\n\nCan you please elaborate here?","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"}],"deployment/puppet/osnailyfacter/examples/site.pp":[{"author":{"_account_id":8935,"name":"Andrey Danin","email":"gcon.monolake@gmail.com","username":"adanin"},"change_message_id":"1e668c64fbb3d6079aa988275ba80e718c802fc9","unresolved":false,"context_lines":[{"line_number":147,"context_line":"class os_common {"},{"line_number":148,"context_line":"  if $::fuel_settings[\u0027storage\u0027][\u0027iser\u0027]{"},{"line_number":149,"context_line":"      class {\"mellanox_openstack::iser_rename\":"},{"line_number":150,"context_line":"                   stage \u003d\u003e \u0027zero\u0027,"},{"line_number":151,"context_line":"                   storage_parent \u003d\u003e $::fuel_settings[\u0027neutron_mellanox\u0027][\u0027storage_parent\u0027],"},{"line_number":152,"context_line":"                   iser_interface_name \u003d\u003e $::fuel_settings[\u0027neutron_mellanox\u0027][\u0027iser_interface_name\u0027],"},{"line_number":153,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_c8c8dfaa","line":150,"updated":"2014-07-03 10:27:28.000000000","message":"What is \u0027stage\u0027?","commit_id":"c485ba98b2b49d64779e03698ec6083eff2a877d"},{"author":{"_account_id":8935,"name":"Andrey Danin","email":"gcon.monolake@gmail.com","username":"adanin"},"change_message_id":"b004a461dd8e1402c7da41518e22cd9ce03ace0f","unresolved":false,"context_lines":[{"line_number":147,"context_line":"class os_common {"},{"line_number":148,"context_line":"  if $::fuel_settings[\u0027storage\u0027][\u0027iser\u0027]{"},{"line_number":149,"context_line":"      class {\"mellanox_openstack::iser_rename\":"},{"line_number":150,"context_line":"                   stage \u003d\u003e \u0027zero\u0027,"},{"line_number":151,"context_line":"                   storage_parent \u003d\u003e $::fuel_settings[\u0027neutron_mellanox\u0027][\u0027storage_parent\u0027],"},{"line_number":152,"context_line":"                   iser_interface_name \u003d\u003e $::fuel_settings[\u0027neutron_mellanox\u0027][\u0027iser_interface_name\u0027],"},{"line_number":153,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_a8ce4b2c","line":150,"in_reply_to":"baada198_8806e784","updated":"2014-07-03 10:40:24.000000000","message":"Done","commit_id":"c485ba98b2b49d64779e03698ec6083eff2a877d"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"8c7b1746260b32def62039c3609cf8248b1f8546","unresolved":false,"context_lines":[{"line_number":147,"context_line":"class os_common {"},{"line_number":148,"context_line":"  if $::fuel_settings[\u0027storage\u0027][\u0027iser\u0027]{"},{"line_number":149,"context_line":"      class {\"mellanox_openstack::iser_rename\":"},{"line_number":150,"context_line":"                   stage \u003d\u003e \u0027zero\u0027,"},{"line_number":151,"context_line":"                   storage_parent \u003d\u003e $::fuel_settings[\u0027neutron_mellanox\u0027][\u0027storage_parent\u0027],"},{"line_number":152,"context_line":"                   iser_interface_name \u003d\u003e $::fuel_settings[\u0027neutron_mellanox\u0027][\u0027iser_interface_name\u0027],"},{"line_number":153,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_8806e784","line":150,"in_reply_to":"baada198_c8c8dfaa","updated":"2014-07-03 10:35:56.000000000","message":"Once stages have been declared, a class may be assigned to a custom stage with the stagemetaparameter. more here: http://docs.puppetlabs.com/puppet/latest/reference/lang_run_stages.html#assigning-classes-to-stages","commit_id":"c485ba98b2b49d64779e03698ec6083eff2a877d"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"cb7900cbf43037b94a355a98c76ea48921f95ed4","unresolved":false,"context_lines":[{"line_number":145,"context_line":"}"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"class os_common {"},{"line_number":148,"context_line":"  if $::fuel_settings[\u0027storage\u0027][\u0027iser\u0027]{"},{"line_number":149,"context_line":"      class {\"mellanox_openstack::iser_rename\":"},{"line_number":150,"context_line":"                   stage \u003d\u003e \u0027zero\u0027,"},{"line_number":151,"context_line":"                   storage_parent \u003d\u003e $::fuel_settings[\u0027neutron_mellanox\u0027][\u0027storage_parent\u0027],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_9b324ba5","line":148,"updated":"2014-07-07 17:09:54.000000000","message":"add space between ]{","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"383726e24f960559dbbcfb39c117a625db9e61b7","unresolved":false,"context_lines":[{"line_number":145,"context_line":"}"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"class os_common {"},{"line_number":148,"context_line":"  if $::fuel_settings[\u0027storage\u0027][\u0027iser\u0027]{"},{"line_number":149,"context_line":"      class {\"mellanox_openstack::iser_rename\":"},{"line_number":150,"context_line":"                   stage \u003d\u003e \u0027zero\u0027,"},{"line_number":151,"context_line":"                   storage_parent \u003d\u003e $::fuel_settings[\u0027neutron_mellanox\u0027][\u0027storage_parent\u0027],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_e36c2439","line":148,"in_reply_to":"baada198_9b324ba5","updated":"2014-07-09 20:44:34.000000000","message":"Done","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"cb7900cbf43037b94a355a98c76ea48921f95ed4","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"class os_common {"},{"line_number":148,"context_line":"  if $::fuel_settings[\u0027storage\u0027][\u0027iser\u0027]{"},{"line_number":149,"context_line":"      class {\"mellanox_openstack::iser_rename\":"},{"line_number":150,"context_line":"                   stage \u003d\u003e \u0027zero\u0027,"},{"line_number":151,"context_line":"                   storage_parent \u003d\u003e $::fuel_settings[\u0027neutron_mellanox\u0027][\u0027storage_parent\u0027],"},{"line_number":152,"context_line":"                   iser_interface_name \u003d\u003e $::fuel_settings[\u0027neutron_mellanox\u0027][\u0027iser_interface_name\u0027],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_3b021fb4","line":149,"updated":"2014-07-07 17:09:54.000000000","message":"add space { \"mellanox...\"","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"383726e24f960559dbbcfb39c117a625db9e61b7","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"class os_common {"},{"line_number":148,"context_line":"  if $::fuel_settings[\u0027storage\u0027][\u0027iser\u0027]{"},{"line_number":149,"context_line":"      class {\"mellanox_openstack::iser_rename\":"},{"line_number":150,"context_line":"                   stage \u003d\u003e \u0027zero\u0027,"},{"line_number":151,"context_line":"                   storage_parent \u003d\u003e $::fuel_settings[\u0027neutron_mellanox\u0027][\u0027storage_parent\u0027],"},{"line_number":152,"context_line":"                   iser_interface_name \u003d\u003e $::fuel_settings[\u0027neutron_mellanox\u0027][\u0027iser_interface_name\u0027],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_2377fc03","line":149,"in_reply_to":"baada198_3370833f","updated":"2014-07-09 20:44:34.000000000","message":"Done","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"383726e24f960559dbbcfb39c117a625db9e61b7","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"class os_common {"},{"line_number":148,"context_line":"  if $::fuel_settings[\u0027storage\u0027][\u0027iser\u0027]{"},{"line_number":149,"context_line":"      class {\"mellanox_openstack::iser_rename\":"},{"line_number":150,"context_line":"                   stage \u003d\u003e \u0027zero\u0027,"},{"line_number":151,"context_line":"                   storage_parent \u003d\u003e $::fuel_settings[\u0027neutron_mellanox\u0027][\u0027storage_parent\u0027],"},{"line_number":152,"context_line":"                   iser_interface_name \u003d\u003e $::fuel_settings[\u0027neutron_mellanox\u0027][\u0027iser_interface_name\u0027],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_03683820","line":149,"in_reply_to":"baada198_3b021fb4","updated":"2014-07-09 20:44:34.000000000","message":"Done","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"a556aa58c20fa8fc2cac7fcdf6ffb68797ead112","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"class os_common {"},{"line_number":148,"context_line":"  if $::fuel_settings[\u0027storage\u0027][\u0027iser\u0027]{"},{"line_number":149,"context_line":"      class {\"mellanox_openstack::iser_rename\":"},{"line_number":150,"context_line":"                   stage \u003d\u003e \u0027zero\u0027,"},{"line_number":151,"context_line":"                   storage_parent \u003d\u003e $::fuel_settings[\u0027neutron_mellanox\u0027][\u0027storage_parent\u0027],"},{"line_number":152,"context_line":"                   iser_interface_name \u003d\u003e $::fuel_settings[\u0027neutron_mellanox\u0027][\u0027iser_interface_name\u0027],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_3370833f","line":149,"in_reply_to":"baada198_3b021fb4","updated":"2014-07-07 18:32:20.000000000","message":"use single quotes","commit_id":"4d1b8fb164c873b04a60b6d96a9c180179aaca78"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"a7a0d0b308ad712f5815d4fb08c41cf62fea74e2","unresolved":false,"context_lines":[{"line_number":145,"context_line":"}"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"class os_common {"},{"line_number":148,"context_line":"  if $::fuel_settings[\u0027storage\u0027][\u0027iser\u0027] {"},{"line_number":149,"context_line":"      class { \u0027mellanox_openstack::iser_rename\u0027:"},{"line_number":150,"context_line":"                   stage \u003d\u003e \u0027zero\u0027,"},{"line_number":151,"context_line":"                   storage_parent \u003d\u003e $::fuel_settings[\u0027neutron_mellanox\u0027][\u0027storage_parent\u0027],"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"baada198_50a01043","line":148,"updated":"2014-07-10 16:10:30.000000000","message":"Please, add \"if ($::fuel_settings[\u0027neutron_mellanox\u0027]) and\" here. Even if you expect $::fuel_settings[\u0027neutron_mellanox\u0027] be always present. Deployment will break with error if this section is absent. Add our CI will -1 you unless it will generate this section, and it will not i guess.","commit_id":"95c93a27a881c579611c3d25573a18b276d706cd"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"c4dec52251c748017b23eb1c34d177f6d600c728","unresolved":false,"context_lines":[{"line_number":145,"context_line":"}"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"class os_common {"},{"line_number":148,"context_line":"  if $::fuel_settings[\u0027storage\u0027][\u0027iser\u0027] {"},{"line_number":149,"context_line":"      class { \u0027mellanox_openstack::iser_rename\u0027:"},{"line_number":150,"context_line":"                   stage \u003d\u003e \u0027zero\u0027,"},{"line_number":151,"context_line":"                   storage_parent \u003d\u003e $::fuel_settings[\u0027neutron_mellanox\u0027][\u0027storage_parent\u0027],"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"baada198_ee077d7f","line":148,"in_reply_to":"baada198_50a01043","updated":"2014-07-10 21:09:23.000000000","message":"Done","commit_id":"95c93a27a881c579611c3d25573a18b276d706cd"}]}
