)]}'
{"deployment/puppet/cinder/manifests/backend/iscsi.pp":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"8f9a281fa59aa81ae0db25d0a8a8f6375febe38f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  $volume_backend_name \u003d $name,"},{"line_number":13,"context_line":"  $volume_group        \u003d \u0027cinder-volumes\u0027,"},{"line_number":14,"context_line":"  $iscsi_helper        \u003d $::cinder::params::iscsi_helper,"},{"line_number":15,"context_line":"  $iser                \u003d false,"},{"line_number":16,"context_line":") {"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  include cinder::params"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_13e61f44","line":15,"updated":"2014-07-07 18:28:23.000000000","message":"nit: please propose iser patch to upstream puppet-cinder or these will be lost when we finish pulling upstream.","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"5e65c0871d538665f99af4a583974c416dbd0ca0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  $volume_backend_name \u003d $name,"},{"line_number":13,"context_line":"  $volume_group        \u003d \u0027cinder-volumes\u0027,"},{"line_number":14,"context_line":"  $iscsi_helper        \u003d $::cinder::params::iscsi_helper,"},{"line_number":15,"context_line":"  $iser                \u003d false,"},{"line_number":16,"context_line":") {"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  include cinder::params"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_681f5a5b","line":15,"in_reply_to":"baada198_13e61f44","updated":"2014-07-08 12:07:01.000000000","message":"we have an open bug on this issue: https://bugs.launchpad.net/fuel/+bug/1337210\n\nWe need iser working in fuel v5.1, and since it\u0027s broken on icehouse upstream we provided a patch for your packaging team to apply on \"python-cinder\" package","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d5ca5499b3a9da4d02cac42e613ccc2e6257d803","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  $volume_backend_name \u003d $name,"},{"line_number":13,"context_line":"  $volume_group        \u003d \u0027cinder-volumes\u0027,"},{"line_number":14,"context_line":"  $iscsi_helper        \u003d $::cinder::params::iscsi_helper,"},{"line_number":15,"context_line":"  $iser                \u003d false,"},{"line_number":16,"context_line":") {"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  include cinder::params"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_5979f42d","line":15,"updated":"2014-07-18 14:20:37.000000000","message":"we should not modify upstream synced code, if possible. Please move it to openstack::cinder","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"fafbcec9e96aca537aeb0b635beb9a0f515b34c0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  $volume_backend_name \u003d $name,"},{"line_number":13,"context_line":"  $volume_group        \u003d \u0027cinder-volumes\u0027,"},{"line_number":14,"context_line":"  $iscsi_helper        \u003d $::cinder::params::iscsi_helper,"},{"line_number":15,"context_line":"  $iser                \u003d false,"},{"line_number":16,"context_line":") {"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  include cinder::params"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_967ed6e2","line":15,"in_reply_to":"baada198_5979f42d","updated":"2014-07-21 09:14:01.000000000","message":"Done","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d5ca5499b3a9da4d02cac42e613ccc2e6257d803","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    cinder_config {"},{"line_number":22,"context_line":"      \"${name}/volume_driver\":  value \u003d\u003e \u0027cinder.volume.drivers.lvm.LVMISERDriver\u0027"},{"line_number":23,"context_line":"    }"},{"line_number":24,"context_line":"  }"},{"line_number":25,"context_line":"  cinder_config {"},{"line_number":26,"context_line":"    \"${name}/volume_backend_name\":  value \u003d\u003e $volume_backend_name;"},{"line_number":27,"context_line":"    \"${name}/iscsi_ip_address\":     value \u003d\u003e $iscsi_ip_address;"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_7972384b","line":24,"updated":"2014-07-18 14:20:37.000000000","message":"ditto","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"fafbcec9e96aca537aeb0b635beb9a0f515b34c0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    cinder_config {"},{"line_number":22,"context_line":"      \"${name}/volume_driver\":  value \u003d\u003e \u0027cinder.volume.drivers.lvm.LVMISERDriver\u0027"},{"line_number":23,"context_line":"    }"},{"line_number":24,"context_line":"  }"},{"line_number":25,"context_line":"  cinder_config {"},{"line_number":26,"context_line":"    \"${name}/volume_backend_name\":  value \u003d\u003e $volume_backend_name;"},{"line_number":27,"context_line":"    \"${name}/iscsi_ip_address\":     value \u003d\u003e $iscsi_ip_address;"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_b67f5ade","line":24,"in_reply_to":"baada198_7972384b","updated":"2014-07-21 09:14:01.000000000","message":"Done","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"}],"deployment/puppet/cinder/manifests/volume/iscsi.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d5ca5499b3a9da4d02cac42e613ccc2e6257d803","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  $iscsi_ip_address,"},{"line_number":4,"context_line":"  $volume_group      \u003d \u0027cinder-volumes\u0027,"},{"line_number":5,"context_line":"  $iscsi_helper      \u003d $cinder::params::iscsi_helper,"},{"line_number":6,"context_line":"  $iser              \u003d false,"},{"line_number":7,"context_line":") {"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  cinder::backend::iscsi { \u0027DEFAULT\u0027:"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_79a9587b","line":6,"updated":"2014-07-18 14:20:37.000000000","message":"we should not modify upstream synced code, if possible. Please move it to openstack::cinder","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"fafbcec9e96aca537aeb0b635beb9a0f515b34c0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  $iscsi_ip_address,"},{"line_number":4,"context_line":"  $volume_group      \u003d \u0027cinder-volumes\u0027,"},{"line_number":5,"context_line":"  $iscsi_helper      \u003d $cinder::params::iscsi_helper,"},{"line_number":6,"context_line":"  $iser              \u003d false,"},{"line_number":7,"context_line":") {"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  cinder::backend::iscsi { \u0027DEFAULT\u0027:"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_76606235","line":6,"in_reply_to":"baada198_79a9587b","updated":"2014-07-21 09:14:01.000000000","message":"Done","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d5ca5499b3a9da4d02cac42e613ccc2e6257d803","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    iscsi_ip_address   \u003d\u003e $iscsi_ip_address,"},{"line_number":11,"context_line":"    volume_group       \u003d\u003e $volume_group,"},{"line_number":12,"context_line":"    iscsi_helper       \u003d\u003e $iscsi_helper,"},{"line_number":13,"context_line":"    iser               \u003d\u003e $iser,"},{"line_number":14,"context_line":"  }"},{"line_number":15,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_b9b690da","line":13,"updated":"2014-07-18 14:20:37.000000000","message":"ditto","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"fafbcec9e96aca537aeb0b635beb9a0f515b34c0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    iscsi_ip_address   \u003d\u003e $iscsi_ip_address,"},{"line_number":11,"context_line":"    volume_group       \u003d\u003e $volume_group,"},{"line_number":12,"context_line":"    iscsi_helper       \u003d\u003e $iscsi_helper,"},{"line_number":13,"context_line":"    iser               \u003d\u003e $iser,"},{"line_number":14,"context_line":"  }"},{"line_number":15,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_9665f646","line":13,"in_reply_to":"baada198_b9b690da","updated":"2014-07-21 09:14:01.000000000","message":"Done","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"}],"deployment/puppet/mellanox_openstack/manifests/agent.pp":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"620d621a0b0e8796148629376a2e6f5e27294de1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            group  \u003d\u003e \u0027root\u0027,"},{"line_number":17,"context_line":"        }"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"        file { \u0027filters_dir\u0027 :"},{"line_number":20,"context_line":"            ensure \u003d\u003e directory,"},{"line_number":21,"context_line":"            path   \u003d\u003e $filters_dir,"},{"line_number":22,"context_line":"            mode   \u003d\u003e \u00270755\u0027,"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"baada198_0d54ccc8","line":19,"updated":"2014-07-17 13:25:47.000000000","message":"file { $filters_dir:","commit_id":"cf29aefd36f4a7c56866164efd4a3e5ffbe7d1cf"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"620d621a0b0e8796148629376a2e6f5e27294de1","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"        file { \u0027filters_dir\u0027 :"},{"line_number":20,"context_line":"            ensure \u003d\u003e directory,"},{"line_number":21,"context_line":"            path   \u003d\u003e $filters_dir,"},{"line_number":22,"context_line":"            mode   \u003d\u003e \u00270755\u0027,"},{"line_number":23,"context_line":"        }"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":20,"id":"baada198_2d4fd035","line":21,"updated":"2014-07-17 13:25:47.000000000","message":"removefilters","commit_id":"cf29aefd36f4a7c56866164efd4a3e5ffbe7d1cf"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"620d621a0b0e8796148629376a2e6f5e27294de1","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        file { \u0027network.filters\u0027 :"},{"line_number":26,"context_line":"            ensure \u003d\u003e present,"},{"line_number":27,"context_line":"            path   \u003d\u003e $filters_file,"},{"line_number":28,"context_line":"            mode   \u003d\u003e \u00270644\u0027,"},{"line_number":29,"context_line":"            source \u003d\u003e \u0027puppet:///modules/mellanox_openstack/network.filters\u0027,"},{"line_number":30,"context_line":"        }"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"baada198_2db3504e","line":27,"updated":"2014-07-17 13:25:47.000000000","message":"name the resource $filters_file and remove path \u003d\u003e","commit_id":"cf29aefd36f4a7c56866164efd4a3e5ffbe7d1cf"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"6f1d4bf3df0b2efb427ff458f55c11463f1b7f3c","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        file { \u0027network.filters\u0027 :"},{"line_number":26,"context_line":"            ensure \u003d\u003e present,"},{"line_number":27,"context_line":"            path   \u003d\u003e $filters_file,"},{"line_number":28,"context_line":"            mode   \u003d\u003e \u00270644\u0027,"},{"line_number":29,"context_line":"            source \u003d\u003e \u0027puppet:///modules/mellanox_openstack/network.filters\u0027,"},{"line_number":30,"context_line":"        }"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"baada198_4d1164ae","line":27,"in_reply_to":"baada198_2db3504e","updated":"2014-07-17 13:30:28.000000000","message":"why don\u0027t you like this style? I do","commit_id":"cf29aefd36f4a7c56866164efd4a3e5ffbe7d1cf"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"620d621a0b0e8796148629376a2e6f5e27294de1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        }"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        File \u003c| title \u003d\u003d \u0027/etc/nova/nova.conf\u0027 |\u003e -\u003e"},{"line_number":33,"context_line":"        File[\u0027filters_dir\u0027] -\u003e"},{"line_number":34,"context_line":"        File[\u0027network.filters\u0027] ~\u003e"},{"line_number":35,"context_line":"        Service[$compute_service_name]"},{"line_number":36,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"baada198_ad43e011","line":33,"updated":"2014-07-17 13:25:47.000000000","message":"Directory hierarchy resolves without manual dependency, so this is redundant","commit_id":"cf29aefd36f4a7c56866164efd4a3e5ffbe7d1cf"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"6f1d4bf3df0b2efb427ff458f55c11463f1b7f3c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        }"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        File \u003c| title \u003d\u003d \u0027/etc/nova/nova.conf\u0027 |\u003e -\u003e"},{"line_number":33,"context_line":"        File[\u0027filters_dir\u0027] -\u003e"},{"line_number":34,"context_line":"        File[\u0027network.filters\u0027] ~\u003e"},{"line_number":35,"context_line":"        Service[$compute_service_name]"},{"line_number":36,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"baada198_8d829cc6","line":33,"in_reply_to":"baada198_ad43e011","updated":"2014-07-17 13:30:28.000000000","message":"Yes, but i had to make it to keep chain connected","commit_id":"cf29aefd36f4a7c56866164efd4a3e5ffbe7d1cf"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"620d621a0b0e8796148629376a2e6f5e27294de1","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        File \u003c| title \u003d\u003d \u0027/etc/nova/nova.conf\u0027 |\u003e -\u003e"},{"line_number":33,"context_line":"        File[\u0027filters_dir\u0027] -\u003e"},{"line_number":34,"context_line":"        File[\u0027network.filters\u0027] ~\u003e"},{"line_number":35,"context_line":"        Service[$compute_service_name]"},{"line_number":36,"context_line":"    }"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":20,"id":"baada198_4de88416","line":34,"updated":"2014-07-17 13:25:47.000000000","message":"File[$filters_file]","commit_id":"cf29aefd36f4a7c56866164efd4a3e5ffbe7d1cf"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"f0b018290a5b0efa990f14bf3675a1ba10d441d5","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    $agent                \u003d $::mellanox_openstack::params::agent_service"},{"line_number":9,"context_line":"    $filters_dir          \u003d $::mellanox_openstack::params::filters_dir"},{"line_number":10,"context_line":"    $filters_file         \u003d $::mellanox_openstack::params::filters_file"},{"line_number":11,"context_line":"    $compute_service_name \u003d $::mellanox_openstack::params::compute_service_name"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    if $::osfamily \u003d\u003d \u0027Debian\u0027 {"},{"line_number":14,"context_line":"        File {"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_6f5b4354","line":11,"updated":"2014-07-18 18:33:27.000000000","message":"Nit: not used","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"fafbcec9e96aca537aeb0b635beb9a0f515b34c0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    $agent                \u003d $::mellanox_openstack::params::agent_service"},{"line_number":9,"context_line":"    $filters_dir          \u003d $::mellanox_openstack::params::filters_dir"},{"line_number":10,"context_line":"    $filters_file         \u003d $::mellanox_openstack::params::filters_file"},{"line_number":11,"context_line":"    $compute_service_name \u003d $::mellanox_openstack::params::compute_service_name"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    if $::osfamily \u003d\u003d \u0027Debian\u0027 {"},{"line_number":14,"context_line":"        File {"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_b6567a5c","line":11,"in_reply_to":"baada198_6f5b4354","updated":"2014-07-21 09:14:01.000000000","message":"Is used below: Service[$compute_service_name]","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"f0b018290a5b0efa990f14bf3675a1ba10d441d5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    $filters_file         \u003d $::mellanox_openstack::params::filters_file"},{"line_number":11,"context_line":"    $compute_service_name \u003d $::mellanox_openstack::params::compute_service_name"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    if $::osfamily \u003d\u003d \u0027Debian\u0027 {"},{"line_number":14,"context_line":"        File {"},{"line_number":15,"context_line":"            owner  \u003d\u003e \u0027root\u0027,"},{"line_number":16,"context_line":"            group  \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_6fffc334","line":13,"updated":"2014-07-18 18:33:27.000000000","message":"Nit: add a comment that this is only needed for Debian because packaging is missing it.","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"fafbcec9e96aca537aeb0b635beb9a0f515b34c0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    $filters_file         \u003d $::mellanox_openstack::params::filters_file"},{"line_number":11,"context_line":"    $compute_service_name \u003d $::mellanox_openstack::params::compute_service_name"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    if $::osfamily \u003d\u003d \u0027Debian\u0027 {"},{"line_number":14,"context_line":"        File {"},{"line_number":15,"context_line":"            owner  \u003d\u003e \u0027root\u0027,"},{"line_number":16,"context_line":"            group  \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_d65bee83","line":13,"in_reply_to":"baada198_6fffc334","updated":"2014-07-21 09:14:01.000000000","message":"Done","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"f0b018290a5b0efa990f14bf3675a1ba10d441d5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        Service[$compute_service_name]"},{"line_number":34,"context_line":"    }"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    Mellanox_agent_config {"},{"line_number":37,"context_line":"        ensure  \u003d\u003e present,"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_cfee0f8b","line":36,"updated":"2014-07-18 18:33:27.000000000","message":"Nit: not needed, setting any value will implicitly result in it being ensured present.","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"fafbcec9e96aca537aeb0b635beb9a0f515b34c0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        Service[$compute_service_name]"},{"line_number":34,"context_line":"    }"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    Mellanox_agent_config {"},{"line_number":37,"context_line":"        ensure  \u003d\u003e present,"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_5c19bfcf","line":36,"in_reply_to":"baada198_cfee0f8b","updated":"2014-07-21 09:14:01.000000000","message":"Done","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"f0b018290a5b0efa990f14bf3675a1ba10d441d5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        ensure \u003d\u003e installed,"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    service { $agent :"},{"line_number":50,"context_line":"        ensure     \u003d\u003e running,"},{"line_number":51,"context_line":"        enable     \u003d\u003e true,"},{"line_number":52,"context_line":"        hasstatus  \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_6f7423cf","line":49,"updated":"2014-07-18 18:33:27.000000000","message":"Nit: it\u0027s better practice to use a non-variable name for service titles and use name \u003d\u003e $variable. This makes it easier for external manifests to define resource relationships","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"f0b018290a5b0efa990f14bf3675a1ba10d441d5","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    Package[$package] -\u003e"},{"line_number":57,"context_line":"    Mellanox_agent_config \u003c||\u003e ~\u003e"},{"line_number":58,"context_line":"    Service[$agent]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_4f0cbf42","line":58,"updated":"2014-07-18 18:33:27.000000000","message":"Does the agent need /etc/neutron/neutron.conf or /etc/neutron/plugins/ml2/ml2_conf.ini to be finished writing before starting?\n\nDoes eswitch service need to be running too?","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"96656b0e5ddb5ace703c4143f702638956ea36d6","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    Package[$package] -\u003e"},{"line_number":57,"context_line":"    Mellanox_agent_config \u003c||\u003e ~\u003e"},{"line_number":58,"context_line":"    Service[$agent]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_9f30a957","line":58,"in_reply_to":"baada198_4f0cbf42","updated":"2014-07-20 15:32:26.000000000","message":"Basically it needs /etc/neutron/neutron.conf and /etc/neutron/plugins/mlnx/mlnx_conf.ini\n\nYes. eswitch service should be running before agent is started.","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"fafbcec9e96aca537aeb0b635beb9a0f515b34c0","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    Package[$package] -\u003e"},{"line_number":57,"context_line":"    Mellanox_agent_config \u003c||\u003e ~\u003e"},{"line_number":58,"context_line":"    Service[$agent]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_3c4a4bad","line":58,"in_reply_to":"baada198_4f0cbf42","updated":"2014-07-21 09:14:01.000000000","message":"Re eswitch - I have this dependency on mellanox_openstack::compute :\n\n  Class[\u0027mellanox_openstack::mlnxvif\u0027] -\u003e\n  Class[\u0027mellanox_openstack::eswitchd\u0027] -\u003e\n  Class[\u0027mellanox_openstack::agent\u0027]","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"}],"deployment/puppet/mellanox_openstack/manifests/compute.pp":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"7d6fbdacd7a974e9f53fd6dab64ec8148f0bb19b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class mellanox_openstack::compute("},{"line_number":2,"context_line":"  $physnet \u003d \u0027physnet2\u0027,"},{"line_number":3,"context_line":"  $physifc,"},{"line_number":4,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_4c51bf0d","line":1,"updated":"2014-07-08 12:31:48.000000000","message":"This class should be nova::compute::mellanox","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"6b2031d7720e9777daa243e314a173bf79035a59","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class mellanox_openstack::compute("},{"line_number":2,"context_line":"  $physnet \u003d \u0027physnet2\u0027,"},{"line_number":3,"context_line":"  $physifc,"},{"line_number":4,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_44b50bcf","line":1,"in_reply_to":"baada198_4c51bf0d","updated":"2014-07-09 15:37:24.000000000","message":"Done","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"8f9a281fa59aa81ae0db25d0a8a8f6375febe38f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class mellanox_openstack::compute("},{"line_number":2,"context_line":"  $physnet \u003d \u0027physnet2\u0027,"},{"line_number":3,"context_line":"  $physifc,"},{"line_number":4,"context_line":") {"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  class { \u0027mellanox_openstack::compute_install_mlnx_plugin\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_263846d2","line":3,"updated":"2014-07-07 18:28:23.000000000","message":"nit: parameter without default should occur before those with defaults (when possible). Note that puppet 3.6 will not allow any parameters without defaults.","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"5e65c0871d538665f99af4a583974c416dbd0ca0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class mellanox_openstack::compute("},{"line_number":2,"context_line":"  $physnet \u003d \u0027physnet2\u0027,"},{"line_number":3,"context_line":"  $physifc,"},{"line_number":4,"context_line":") {"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  class { \u0027mellanox_openstack::compute_install_mlnx_plugin\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_5b0b3e7c","line":3,"in_reply_to":"baada198_263846d2","updated":"2014-07-08 12:07:01.000000000","message":"Done - changed the order.\n\nI checked your comment about puppet 3.6.1 and it allows parameters with no default value (of course you must always pass all the args to the class).\n\nI don\u0027t see what value to put as default since this is environment dependent. do you prefer to use \"undef\" there?","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"}],"deployment/puppet/mellanox_openstack/manifests/compute_install_mlnx_plugin.pp":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"8f9a281fa59aa81ae0db25d0a8a8f6375febe38f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class mellanox_openstack::compute_install_mlnx_plugin {"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  package { $::mellanox_openstack::params::mlnxvif_package:"},{"line_number":4,"context_line":"    ensure \u003d\u003e installed,"},{"line_number":5,"context_line":"  }"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_216670ed","line":3,"updated":"2014-07-07 18:28:23.000000000","message":"should be installed with whoever actually needs to consume this.","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"5e65c0871d538665f99af4a583974c416dbd0ca0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class mellanox_openstack::compute_install_mlnx_plugin {"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  package { $::mellanox_openstack::params::mlnxvif_package:"},{"line_number":4,"context_line":"    ensure \u003d\u003e installed,"},{"line_number":5,"context_line":"  }"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_ef428ca9","line":3,"in_reply_to":"baada198_216670ed","updated":"2014-07-08 12:07:01.000000000","message":"This package is related to the vif_driver parameter which is \ndefined in openstack/manifests/compute.pp .\n\nSince I want to control the package name value using our params.pp file on the package name, I will created a manifest in mellanox_openstack module that deals with mlnx vif driver (it only installs this package), and it is called from openstack/manifests/compute.pp","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"8f9a281fa59aa81ae0db25d0a8a8f6375febe38f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    ensure \u003d\u003e installed,"},{"line_number":5,"context_line":"  }"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  package { $::mellanox_openstack::params::eswitchd_package:"},{"line_number":8,"context_line":"    ensure \u003d\u003e installed,"},{"line_number":9,"context_line":"  }"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_413364f5","line":7,"updated":"2014-07-07 18:28:23.000000000","message":"should be installed as part of eswitch_config manifest","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"5e65c0871d538665f99af4a583974c416dbd0ca0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    ensure \u003d\u003e installed,"},{"line_number":5,"context_line":"  }"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  package { $::mellanox_openstack::params::eswitchd_package:"},{"line_number":8,"context_line":"    ensure \u003d\u003e installed,"},{"line_number":9,"context_line":"  }"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_0f08a0d8","line":7,"in_reply_to":"baada198_413364f5","updated":"2014-07-08 12:07:01.000000000","message":"Done","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"8f9a281fa59aa81ae0db25d0a8a8f6375febe38f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  }"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  # needs repackage by mirantis since this depends on openstack rpm, not mirantis"},{"line_number":12,"context_line":"  package { $::mellanox_openstack::params::neutron_mlnx_packages:"},{"line_number":13,"context_line":"    ensure \u003d\u003e installed,"},{"line_number":14,"context_line":"  }"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_81773c9f","line":12,"updated":"2014-07-07 18:28:23.000000000","message":"should be installed as part of mlnx_agent_config.","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"5e65c0871d538665f99af4a583974c416dbd0ca0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  }"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  # needs repackage by mirantis since this depends on openstack rpm, not mirantis"},{"line_number":12,"context_line":"  package { $::mellanox_openstack::params::neutron_mlnx_packages:"},{"line_number":13,"context_line":"    ensure \u003d\u003e installed,"},{"line_number":14,"context_line":"  }"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_2f0ba4d6","line":12,"in_reply_to":"baada198_81773c9f","updated":"2014-07-08 12:07:01.000000000","message":"Done","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"}],"deployment/puppet/mellanox_openstack/manifests/controller.pp":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"620d621a0b0e8796148629376a2e6f5e27294de1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class mellanox_openstack::controller ($ml2_eswitch) {"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  neutron_plugin_ml2 {"},{"line_number":4,"context_line":"    \u0027eswitch/vnic_type\u0027:            value \u003d\u003e $ml2_eswitch[\u0027vnic_type\u0027];"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"baada198_5262df16","line":1,"updated":"2014-07-17 13:25:47.000000000","message":"you should include defaults here so it is obvious what should be passed. Why not create this as 2 separate parameters instead of a hash?","commit_id":"cf29aefd36f4a7c56866164efd4a3e5ffbe7d1cf"}],"deployment/puppet/mellanox_openstack/manifests/eswitch_config.pp":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"8f9a281fa59aa81ae0db25d0a8a8f6375febe38f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class mellanox_openstack::eswitchd_config ($physnet, $physifc) {"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"    Ini_setting {"},{"line_number":4,"context_line":"        ensure \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_0116cc4b","line":1,"updated":"2014-07-07 18:28:23.000000000","message":"nit: same nit as mlnx_agent_config.pp\n\n-1: drop the word config and include the package management here","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"5e65c0871d538665f99af4a583974c416dbd0ca0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class mellanox_openstack::eswitchd_config ($physnet, $physifc) {"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"    Ini_setting {"},{"line_number":4,"context_line":"        ensure \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_4a6d26cb","line":1,"in_reply_to":"baada198_0116cc4b","updated":"2014-07-08 12:07:01.000000000","message":"Done","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"}],"deployment/puppet/mellanox_openstack/manifests/eswitchd.pp":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"f0b018290a5b0efa990f14bf3675a1ba10d441d5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    $package \u003d $::mellanox_openstack::params::eswitchd_package"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    Mellanox_eswitchd_config {"},{"line_number":10,"context_line":"        ensure  \u003d\u003e present,"},{"line_number":11,"context_line":"    }"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_014e1b6f","line":9,"updated":"2014-07-18 18:33:27.000000000","message":"nit: writing config lines and collecting them ensures this.","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"fafbcec9e96aca537aeb0b635beb9a0f515b34c0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    $package \u003d $::mellanox_openstack::params::eswitchd_package"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    Mellanox_eswitchd_config {"},{"line_number":10,"context_line":"        ensure  \u003d\u003e present,"},{"line_number":11,"context_line":"    }"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_1c8667b9","line":9,"in_reply_to":"baada198_014e1b6f","updated":"2014-07-21 09:14:01.000000000","message":"Done","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"}],"deployment/puppet/mellanox_openstack/manifests/mlnx_agent_config.pp":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"8f9a281fa59aa81ae0db25d0a8a8f6375febe38f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class mellanox_openstack::mlnx_agent_config ($physnet, $physifc) {"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"    Ini_setting {"},{"line_number":4,"context_line":"        ensure \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_06d18222","line":1,"updated":"2014-07-07 18:28:23.000000000","message":"nit: this should be moved into neutron (\u0026 upstream) at some point. until then, lets have this under mellanox_openstack::neutron::mlnx_agent_config namespace so it\u0027s easier to understand it\u0027s impact.\n\n-1: drop the word config, and add the package here","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"5e65c0871d538665f99af4a583974c416dbd0ca0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class mellanox_openstack::mlnx_agent_config ($physnet, $physifc) {"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"    Ini_setting {"},{"line_number":4,"context_line":"        ensure \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_0116b0f1","line":1,"in_reply_to":"baada198_06d18222","updated":"2014-07-08 12:07:01.000000000","message":"Done.\n\nRegarding pushing to upstream - we will start this activity asap..","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"7d6fbdacd7a974e9f53fd6dab64ec8148f0bb19b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class mellanox_openstack::mlnx_agent_config ($physnet, $physifc) {"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"    Ini_setting {"},{"line_number":4,"context_line":"        ensure \u003d\u003e present,"},{"line_number":5,"context_line":"        path \u003d\u003e \u0027/etc/neutron/plugins/mlnx/mlnx_conf.ini\u0027,"},{"line_number":6,"context_line":"        require \u003d\u003e Package[\u0027openstack-neutron-mellanox\u0027],"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_e12d3caa","line":3,"updated":"2014-07-08 12:31:48.000000000","message":"Any resource types you create are actually global. This should be mlnx_agent_setting instead of Ini_setting, which is now global.","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"6b2031d7720e9777daa243e314a173bf79035a59","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class mellanox_openstack::mlnx_agent_config ($physnet, $physifc) {"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"    Ini_setting {"},{"line_number":4,"context_line":"        ensure \u003d\u003e present,"},{"line_number":5,"context_line":"        path \u003d\u003e \u0027/etc/neutron/plugins/mlnx/mlnx_conf.ini\u0027,"},{"line_number":6,"context_line":"        require \u003d\u003e Package[\u0027openstack-neutron-mellanox\u0027],"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_2abd4103","line":3,"in_reply_to":"baada198_e12d3caa","updated":"2014-07-09 15:37:24.000000000","message":"Done","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"7d6fbdacd7a974e9f53fd6dab64ec8148f0bb19b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        \"physical_interface_mappings\" \u003d\u003e {"},{"line_number":17,"context_line":"            section \u003d\u003e \u0027eswitch\u0027,"},{"line_number":18,"context_line":"            setting \u003d\u003e \u0027physical_interface_mappings\u0027,"},{"line_number":19,"context_line":"            value \u003d\u003e \"$physnet:$physifc\""},{"line_number":20,"context_line":"        },"},{"line_number":21,"context_line":"    }"},{"line_number":22,"context_line":"    create_resources(Ini_setting, $mlnx_conf)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_ac117b55","line":19,"updated":"2014-07-08 12:31:48.000000000","message":"Use variable interpolation: \"${physnet}:${physifc}\"","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"6b2031d7720e9777daa243e314a173bf79035a59","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        \"physical_interface_mappings\" \u003d\u003e {"},{"line_number":17,"context_line":"            section \u003d\u003e \u0027eswitch\u0027,"},{"line_number":18,"context_line":"            setting \u003d\u003e \u0027physical_interface_mappings\u0027,"},{"line_number":19,"context_line":"            value \u003d\u003e \"$physnet:$physifc\""},{"line_number":20,"context_line":"        },"},{"line_number":21,"context_line":"    }"},{"line_number":22,"context_line":"    create_resources(Ini_setting, $mlnx_conf)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_ea0a6926","line":19,"in_reply_to":"baada198_ac117b55","updated":"2014-07-09 15:37:24.000000000","message":"Done","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"7d6fbdacd7a974e9f53fd6dab64ec8148f0bb19b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            value \u003d\u003e \"$physnet:$physifc\""},{"line_number":20,"context_line":"        },"},{"line_number":21,"context_line":"    }"},{"line_number":22,"context_line":"    create_resources(Ini_setting, $mlnx_conf)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    service { \u0027neutron-mlnx-agent\u0027:"},{"line_number":25,"context_line":"        ensure \u003d\u003e running,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_012b1095","line":22,"updated":"2014-07-08 12:31:48.000000000","message":"see my note on line 3","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"6b2031d7720e9777daa243e314a173bf79035a59","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            value \u003d\u003e \"$physnet:$physifc\""},{"line_number":20,"context_line":"        },"},{"line_number":21,"context_line":"    }"},{"line_number":22,"context_line":"    create_resources(Ini_setting, $mlnx_conf)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    service { \u0027neutron-mlnx-agent\u0027:"},{"line_number":25,"context_line":"        ensure \u003d\u003e running,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_2d6b9b86","line":22,"in_reply_to":"baada198_012b1095","updated":"2014-07-09 15:37:24.000000000","message":"Done","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"8f9a281fa59aa81ae0db25d0a8a8f6375febe38f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    }"},{"line_number":22,"context_line":"    create_resources(Ini_setting, $mlnx_conf)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    service { \u0027neutron-mlnx-agent\u0027:"},{"line_number":25,"context_line":"        ensure \u003d\u003e running,"},{"line_number":26,"context_line":"        enable \u003d\u003e true,"},{"line_number":27,"context_line":"        require \u003d\u003e Package[$::mellanox_openstack::params::neutron_mlnx_packages]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_064262ad","line":24,"updated":"2014-07-07 18:28:23.000000000","message":"didn\u0027t update the /etc/neutron/plugin.ini link. Is it not needed?","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"5e65c0871d538665f99af4a583974c416dbd0ca0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    }"},{"line_number":22,"context_line":"    create_resources(Ini_setting, $mlnx_conf)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    service { \u0027neutron-mlnx-agent\u0027:"},{"line_number":25,"context_line":"        ensure \u003d\u003e running,"},{"line_number":26,"context_line":"        enable \u003d\u003e true,"},{"line_number":27,"context_line":"        require \u003d\u003e Package[$::mellanox_openstack::params::neutron_mlnx_packages]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_be07e11c","line":24,"in_reply_to":"baada198_064262ad","updated":"2014-07-08 12:07:01.000000000","message":"No. /etc/neutron/plugin.ini points should point to /etc/neutron/plugins/ml2/ml2_conf.ini, this is a part of your ml2 feature, it exists here: \nhttps://review.openstack.org/#/c/103947/8/deployment/puppet/neutron/manifests/plugins/ml2.pp\n\nmellanox plugin is enabled by defining the value \"mlnx\" in \"mechanism_drivers\" in ml2 configuration, this will be done on the deployment serializer to be reflected in astute.yaml","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"}],"deployment/puppet/mellanox_openstack/manifests/mlnxvif.pp":[{"author":{"_account_id":8935,"name":"Andrey Danin","email":"gcon.monolake@gmail.com","username":"adanin"},"change_message_id":"0058867ced9e0a9b91a1a56a5c7b91aa8f34b7dd","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  }"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  Package[$package] -\u003e"},{"line_number":11,"context_line":"  Service \u003c| title \u003d\u003d \u0027nova-compute\u0027 |\u003e"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":23,"id":"baada198_6bee9bee","line":11,"updated":"2014-07-21 17:14:38.000000000","message":"You can use $::mellanox_openstack::params::compute_service_name here","commit_id":"93a12959c4e14f5cfd38437f3baabe8977b5d44b"}],"deployment/puppet/mellanox_openstack/manifests/params.pp":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"7d6fbdacd7a974e9f53fd6dab64ec8148f0bb19b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  $eswitchd_package                   \u003d \u0027eswitchd\u0027"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  # defined below for each osfamily"},{"line_number":6,"context_line":"  # $neutron_mlnx_packages              \u003d undef"},{"line_number":7,"context_line":"  # $mlnxvif_package                    \u003d undef"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  case $::osfamily {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_21bbb476","line":6,"updated":"2014-07-08 12:31:48.000000000","message":"remove this commented code. it shouldn\u0027t be in final production code","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"6b2031d7720e9777daa243e314a173bf79035a59","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  $eswitchd_package                   \u003d \u0027eswitchd\u0027"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  # defined below for each osfamily"},{"line_number":6,"context_line":"  # $neutron_mlnx_packages              \u003d undef"},{"line_number":7,"context_line":"  # $mlnxvif_package                    \u003d undef"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  case $::osfamily {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_4dc44f5f","line":6,"in_reply_to":"baada198_21bbb476","updated":"2014-07-09 15:37:24.000000000","message":"Done","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"}],"deployment/puppet/nova/manifests/compute/libvirt.pp":[{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"8f9a281fa59aa81ae0db25d0a8a8f6375febe38f","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    }"},{"line_number":198,"context_line":"  }"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"  if ($::fuel_settings[\u0027neutron_mellanox\u0027][\u0027plugin\u0027] \u003d\u003d \"ethernet\") {"},{"line_number":201,"context_line":"    nova_config {"},{"line_number":202,"context_line":"      \u0027DEFAULT/compute_driver\u0027:  value \u003d\u003e \u0027nova.virt.libvirt.driver.LibvirtDriver\u0027;"},{"line_number":203,"context_line":"      \u0027libvirt/vif_driver\u0027:      value \u003d\u003e \u0027mlnxvif.vif.MlxEthVIFDriver\u0027;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_2123d0bd","line":200,"updated":"2014-07-07 18:28:23.000000000","message":"-1: don\u0027t reference $::fuel_settings outside of osnailyfacter, or openstack modules, you need to pass them in or the module cant track upstream","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"5e65c0871d538665f99af4a583974c416dbd0ca0","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    }"},{"line_number":198,"context_line":"  }"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"  if ($::fuel_settings[\u0027neutron_mellanox\u0027][\u0027plugin\u0027] \u003d\u003d \"ethernet\") {"},{"line_number":201,"context_line":"    nova_config {"},{"line_number":202,"context_line":"      \u0027DEFAULT/compute_driver\u0027:  value \u003d\u003e \u0027nova.virt.libvirt.driver.LibvirtDriver\u0027;"},{"line_number":203,"context_line":"      \u0027libvirt/vif_driver\u0027:      value \u003d\u003e \u0027mlnxvif.vif.MlxEthVIFDriver\u0027;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_993cfec9","line":200,"in_reply_to":"baada198_2123d0bd","updated":"2014-07-08 12:07:01.000000000","message":"removed this whole \"if mellanox\" section in this module","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"8f9a281fa59aa81ae0db25d0a8a8f6375febe38f","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"  if ($::fuel_settings[\u0027neutron_mellanox\u0027][\u0027plugin\u0027] \u003d\u003d \"ethernet\") {"},{"line_number":201,"context_line":"    nova_config {"},{"line_number":202,"context_line":"      \u0027DEFAULT/compute_driver\u0027:  value \u003d\u003e \u0027nova.virt.libvirt.driver.LibvirtDriver\u0027;"},{"line_number":203,"context_line":"      \u0027libvirt/vif_driver\u0027:      value \u003d\u003e \u0027mlnxvif.vif.MlxEthVIFDriver\u0027;"},{"line_number":204,"context_line":"    }"},{"line_number":205,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_f337ebe0","line":202,"updated":"2014-07-07 18:28:23.000000000","message":"the defaults is \u0027libvirt.LibvirtDriver\u0027 how is this different? If this is necessary, it should be made a parameter of the class","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"5e65c0871d538665f99af4a583974c416dbd0ca0","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"  if ($::fuel_settings[\u0027neutron_mellanox\u0027][\u0027plugin\u0027] \u003d\u003d \"ethernet\") {"},{"line_number":201,"context_line":"    nova_config {"},{"line_number":202,"context_line":"      \u0027DEFAULT/compute_driver\u0027:  value \u003d\u003e \u0027nova.virt.libvirt.driver.LibvirtDriver\u0027;"},{"line_number":203,"context_line":"      \u0027libvirt/vif_driver\u0027:      value \u003d\u003e \u0027mlnxvif.vif.MlxEthVIFDriver\u0027;"},{"line_number":204,"context_line":"    }"},{"line_number":205,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_7e9b9065","line":202,"in_reply_to":"baada198_f337ebe0","updated":"2014-07-08 12:07:01.000000000","message":"fixed - set as a parameter. \n\nThe reason for the change is that the libvirt exists in this path:\n/usr/lib/python2.6/site-packages/nova/virt/libvirt/driver.py\nand LibvirtDriver is the class inside the module.\n\nthe decision about using mellanox parameters is done one level above on \"openstack::all\" and \"openstack::compute\"","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"8f9a281fa59aa81ae0db25d0a8a8f6375febe38f","unresolved":false,"context_lines":[{"line_number":200,"context_line":"  if ($::fuel_settings[\u0027neutron_mellanox\u0027][\u0027plugin\u0027] \u003d\u003d \"ethernet\") {"},{"line_number":201,"context_line":"    nova_config {"},{"line_number":202,"context_line":"      \u0027DEFAULT/compute_driver\u0027:  value \u003d\u003e \u0027nova.virt.libvirt.driver.LibvirtDriver\u0027;"},{"line_number":203,"context_line":"      \u0027libvirt/vif_driver\u0027:      value \u003d\u003e \u0027mlnxvif.vif.MlxEthVIFDriver\u0027;"},{"line_number":204,"context_line":"    }"},{"line_number":205,"context_line":"  }"},{"line_number":206,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_210af025","line":203,"updated":"2014-07-07 18:28:23.000000000","message":"-1: vif driver is set in nova/manifets/compute/neutron.pp (replace ours with upstream)","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"5e65c0871d538665f99af4a583974c416dbd0ca0","unresolved":false,"context_lines":[{"line_number":200,"context_line":"  if ($::fuel_settings[\u0027neutron_mellanox\u0027][\u0027plugin\u0027] \u003d\u003d \"ethernet\") {"},{"line_number":201,"context_line":"    nova_config {"},{"line_number":202,"context_line":"      \u0027DEFAULT/compute_driver\u0027:  value \u003d\u003e \u0027nova.virt.libvirt.driver.LibvirtDriver\u0027;"},{"line_number":203,"context_line":"      \u0027libvirt/vif_driver\u0027:      value \u003d\u003e \u0027mlnxvif.vif.MlxEthVIFDriver\u0027;"},{"line_number":204,"context_line":"    }"},{"line_number":205,"context_line":"  }"},{"line_number":206,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_54aa2b85","line":203,"in_reply_to":"baada198_210af025","updated":"2014-07-08 12:07:01.000000000","message":"openstack::compute calls nova::compute::neutron, therefore this is my fix in openstack/manifests/compute.pp:\n\n    $libvirt_vif_driver \u003d \u0027nova.virt.libvirt.vif.LibvirtGenericVIFDriver\u0027\n    if ($::fuel_settings[\u0027neutron_mellanox\u0027][\u0027plugin\u0027] \u003d\u003d \u0027ethernet\u0027) {\n      $libvirt_vif_driver \u003d \u0027mlnxvif.vif.MlxEthVIFDriver\u0027\n    }\n    class { \u0027nova::compute::neutron\u0027:\n      libvirt_vif_driver \u003d\u003e $libvirt_vif_driver,\n    }","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"620d621a0b0e8796148629376a2e6f5e27294de1","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  $remove_unused_original_minimum_age_seconds \u003d undef,"},{"line_number":75,"context_line":"  # DEPRECATED PARAMETER"},{"line_number":76,"context_line":"  $libvirt_type                               \u003d false,"},{"line_number":77,"context_line":"  $compute_driver                             \u003d \u0027libvirt.LibvirtDriver\u0027,"},{"line_number":78,"context_line":") {"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  include nova::params"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"baada198_cde5740b","line":77,"updated":"2014-07-17 13:25:47.000000000","message":"is this really deprecated? shouldn\u0027t it be above # DEPRECATED PARAMETER?","commit_id":"cf29aefd36f4a7c56866164efd4a3e5ffbe7d1cf"},{"author":{"_account_id":9037,"name":"Dmitry Ilyin","email":"idv1985@gmail.com","username":"dilyin"},"change_message_id":"6f1d4bf3df0b2efb427ff458f55c11463f1b7f3c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  $remove_unused_original_minimum_age_seconds \u003d undef,"},{"line_number":75,"context_line":"  # DEPRECATED PARAMETER"},{"line_number":76,"context_line":"  $libvirt_type                               \u003d false,"},{"line_number":77,"context_line":"  $compute_driver                             \u003d \u0027libvirt.LibvirtDriver\u0027,"},{"line_number":78,"context_line":") {"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  include nova::params"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"baada198_4ddc0419","line":77,"in_reply_to":"baada198_cde5740b","updated":"2014-07-17 13:30:28.000000000","message":"ok, i didn\u0027t notice the depricated comment","commit_id":"cf29aefd36f4a7c56866164efd4a3e5ffbe7d1cf"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d5ca5499b3a9da4d02cac42e613ccc2e6257d803","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  $libvirt_type                               \u003d false,"},{"line_number":78,"context_line":") {"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  include nova::params"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  Service[\u0027libvirt\u0027] -\u003e Service[\u0027nova-compute\u0027]"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_19adbc9b","line":80,"updated":"2014-07-18 14:20:37.000000000","message":"we should not modify upstream synced code, if possible. Please move it to openstack::compute","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"fafbcec9e96aca537aeb0b635beb9a0f515b34c0","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  $libvirt_type                               \u003d false,"},{"line_number":78,"context_line":") {"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  include nova::params"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"  Service[\u0027libvirt\u0027] -\u003e Service[\u0027nova-compute\u0027]"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_76d30238","line":80,"in_reply_to":"baada198_19adbc9b","updated":"2014-07-21 09:14:01.000000000","message":"Done","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d5ca5499b3a9da4d02cac42e613ccc2e6257d803","unresolved":false,"context_lines":[{"line_number":142,"context_line":"  }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  nova_config {"},{"line_number":145,"context_line":"    \u0027DEFAULT/compute_driver\u0027:   value \u003d\u003e $compute_driver;"},{"line_number":146,"context_line":"    \u0027DEFAULT/vncserver_listen\u0027: value \u003d\u003e $vncserver_listen;"},{"line_number":147,"context_line":"    \u0027libvirt/virt_type\u0027:        value \u003d\u003e $libvirt_virt_type_real;"},{"line_number":148,"context_line":"    \u0027libvirt/cpu_mode\u0027:         value \u003d\u003e $libvirt_cpu_mode_real;"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_5992d457","line":145,"updated":"2014-07-18 14:20:37.000000000","message":"ditto","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"fafbcec9e96aca537aeb0b635beb9a0f515b34c0","unresolved":false,"context_lines":[{"line_number":142,"context_line":"  }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  nova_config {"},{"line_number":145,"context_line":"    \u0027DEFAULT/compute_driver\u0027:   value \u003d\u003e $compute_driver;"},{"line_number":146,"context_line":"    \u0027DEFAULT/vncserver_listen\u0027: value \u003d\u003e $vncserver_listen;"},{"line_number":147,"context_line":"    \u0027libvirt/virt_type\u0027:        value \u003d\u003e $libvirt_virt_type_real;"},{"line_number":148,"context_line":"    \u0027libvirt/cpu_mode\u0027:         value \u003d\u003e $libvirt_cpu_mode_real;"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_56ea7ed8","line":145,"in_reply_to":"baada198_17a739be","updated":"2014-07-21 09:14:01.000000000","message":"Turns out we can use the default value, so I\u0027m removing all the compute_driver changes","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"fafbcec9e96aca537aeb0b635beb9a0f515b34c0","unresolved":false,"context_lines":[{"line_number":142,"context_line":"  }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  nova_config {"},{"line_number":145,"context_line":"    \u0027DEFAULT/compute_driver\u0027:   value \u003d\u003e $compute_driver;"},{"line_number":146,"context_line":"    \u0027DEFAULT/vncserver_listen\u0027: value \u003d\u003e $vncserver_listen;"},{"line_number":147,"context_line":"    \u0027libvirt/virt_type\u0027:        value \u003d\u003e $libvirt_virt_type_real;"},{"line_number":148,"context_line":"    \u0027libvirt/cpu_mode\u0027:         value \u003d\u003e $libvirt_cpu_mode_real;"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_96d89654","line":145,"in_reply_to":"baada198_5992d457","updated":"2014-07-21 09:14:01.000000000","message":"Done","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"f0b018290a5b0efa990f14bf3675a1ba10d441d5","unresolved":false,"context_lines":[{"line_number":142,"context_line":"  }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  nova_config {"},{"line_number":145,"context_line":"    \u0027DEFAULT/compute_driver\u0027:   value \u003d\u003e $compute_driver;"},{"line_number":146,"context_line":"    \u0027DEFAULT/vncserver_listen\u0027: value \u003d\u003e $vncserver_listen;"},{"line_number":147,"context_line":"    \u0027libvirt/virt_type\u0027:        value \u003d\u003e $libvirt_virt_type_real;"},{"line_number":148,"context_line":"    \u0027libvirt/cpu_mode\u0027:         value \u003d\u003e $libvirt_cpu_mode_real;"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_814b0b2a","line":145,"in_reply_to":"baada198_5992d457","updated":"2014-07-18 18:33:27.000000000","message":"Since we are changing an existing setting, I don\u0027t see a way around this.","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":8787,"name":"Dmitry Borodaenko","email":"angdraug@gmail.com","username":"angdraug"},"change_message_id":"379889ae19ac164bd52ed60f08ede374746eaee9","unresolved":false,"context_lines":[{"line_number":142,"context_line":"  }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  nova_config {"},{"line_number":145,"context_line":"    \u0027DEFAULT/compute_driver\u0027:   value \u003d\u003e $compute_driver;"},{"line_number":146,"context_line":"    \u0027DEFAULT/vncserver_listen\u0027: value \u003d\u003e $vncserver_listen;"},{"line_number":147,"context_line":"    \u0027libvirt/virt_type\u0027:        value \u003d\u003e $libvirt_virt_type_real;"},{"line_number":148,"context_line":"    \u0027libvirt/cpu_mode\u0027:         value \u003d\u003e $libvirt_cpu_mode_real;"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_17a739be","line":145,"in_reply_to":"baada198_814b0b2a","updated":"2014-07-18 19:43:09.000000000","message":"We shouldn\u0027t need to change the existing setting here, the argument presented for this line in patch set 2 doesn\u0027t hold water:\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/__init__.py#L17\n\nIf the default libvirt.LibvirtDriver doesn\u0027t work for you, you have a different problem and overriding the way nova expects compute_driver to be set is not the right solution.","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"}],"deployment/puppet/openstack/manifests/cinder.pp":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"7d6fbdacd7a974e9f53fd6dab64ec8148f0bb19b","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        }"},{"line_number":140,"context_line":"        if $iser {"},{"line_number":141,"context_line":"            Class[\u0027cinder::volume::iscsi\u0027] {"},{"line_number":142,"context_line":"                iser \u003d\u003e true"},{"line_number":143,"context_line":"            }"},{"line_number":144,"context_line":"        }"},{"line_number":145,"context_line":"        class { \u0027cinder::volume::iscsi\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_413508f6","line":142,"updated":"2014-07-08 12:31:48.000000000","message":"This is redundant code. $iser is true or false, so just call class \u0027cinder::volume::iscsi with iser \u003d\u003e $iser, instead of adding a new if statement.","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"6b2031d7720e9777daa243e314a173bf79035a59","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        }"},{"line_number":140,"context_line":"        if $iser {"},{"line_number":141,"context_line":"            Class[\u0027cinder::volume::iscsi\u0027] {"},{"line_number":142,"context_line":"                iser \u003d\u003e true"},{"line_number":143,"context_line":"            }"},{"line_number":144,"context_line":"        }"},{"line_number":145,"context_line":"        class { \u0027cinder::volume::iscsi\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_0df41786","line":142,"in_reply_to":"baada198_413508f6","updated":"2014-07-09 15:37:24.000000000","message":"Done","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"}],"deployment/puppet/osnailyfacter/examples/site.pp":[{"author":{"_account_id":8786,"name":"Vladimir Kuklin","email":"aglarendil@gmail.com","username":"aglarendil"},"change_message_id":"586f820f5c4c5cdaf7e1f9775632fbbebc824e39","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  }"},{"line_number":82,"context_line":"}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"if ($::fuel_settings[\u0027neutron_mellanox\u0027]) and ($::fuel_settings[\u0027neutron_mellanox\u0027][\u0027plugin\u0027] \u003d\u003d \u0027ethernet\u0027) {"},{"line_number":85,"context_line":"  $use_mellanox_plugin \u003d true"},{"line_number":86,"context_line":"} else {"},{"line_number":87,"context_line":"  $use_mellanox_plugin \u003d false"}],"source_content_type":"text/x-puppet","patch_set":20,"id":"baada198_1ea4f049","line":84,"updated":"2014-07-17 14:45:00.000000000","message":"if there is no \u0027neutron_mellanox\u0027 hash in astute.yaml this will lead to fail of addressing \u0027plugin\u0027 key and catalog compulation. I would use two ifs here:\nif neutron_mellanox\n  if neutron_mellanox[\u0027plugin\u0027]\n. Right now puppet is using common flow control for evaluation of boolean expressions, so this will not affect catalog compilation as the second expression will not be evaluated while the first one is empty. But anyway, it is safer and more explicit to use two if statements.","commit_id":"cf29aefd36f4a7c56866164efd4a3e5ffbe7d1cf"}],"deployment/puppet/osnailyfacter/manifests/cluster_ha.pp":[{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"9f1590ca0e3fb9fcf91951e742b9202c0f1927d7","unresolved":false,"context_lines":[{"line_number":631,"context_line":"        $compute_driver                 \u003d \u0027nova.virt.libvirt.driver.LibvirtDriver\u0027"},{"line_number":632,"context_line":"        $libvirt_vif_driver             \u003d \u0027mlnxvif.vif.MlxEthVIFDriver\u0027"},{"line_number":633,"context_line":"      } else {"},{"line_number":634,"context_line":"        $compute_driver                 \u003d \u0027libvirt.LibvirtDriver\u0027"},{"line_number":635,"context_line":"        $libvirt_vif_driver             \u003d \u0027nova.virt.libvirt.vif.LibvirtGenericVIFDriver\u0027"},{"line_number":636,"context_line":"      }"},{"line_number":637,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_d9916b53","line":634,"updated":"2014-07-19 11:08:07.000000000","message":"We need more deep explanation, why you pass \"nova.virt.libvirt.driver.LibvirtDriver\" instead \"libvirt.LibvirtDriver\" to the nova compute. Because this changes leads to non-obvious (may be unnecessary) changes in nova-compute upstream manifests.","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"},{"author":{"_account_id":12177,"name":"Gil Meir","email":"gmeir11@gmail.com","username":"gilmeir"},"change_message_id":"fafbcec9e96aca537aeb0b635beb9a0f515b34c0","unresolved":false,"context_lines":[{"line_number":631,"context_line":"        $compute_driver                 \u003d \u0027nova.virt.libvirt.driver.LibvirtDriver\u0027"},{"line_number":632,"context_line":"        $libvirt_vif_driver             \u003d \u0027mlnxvif.vif.MlxEthVIFDriver\u0027"},{"line_number":633,"context_line":"      } else {"},{"line_number":634,"context_line":"        $compute_driver                 \u003d \u0027libvirt.LibvirtDriver\u0027"},{"line_number":635,"context_line":"        $libvirt_vif_driver             \u003d \u0027nova.virt.libvirt.vif.LibvirtGenericVIFDriver\u0027"},{"line_number":636,"context_line":"      }"},{"line_number":637,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":22,"id":"baada198_9c36f701","line":634,"in_reply_to":"baada198_d9916b53","updated":"2014-07-21 09:14:01.000000000","message":"Was unnecessary. Removing all changes related to compute_driver","commit_id":"67eb075af3318130f9469482a8a0a65a6360ca0f"}],"deployment/puppet/osnailyfacter/manifests/cluster_simple.pp":[{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"7d6fbdacd7a974e9f53fd6dab64ec8148f0bb19b","unresolved":false,"context_lines":[{"line_number":446,"context_line":"        Class[\u0027openstack::compute\u0027] -\u003e Class[\u0027ceph\u0027]"},{"line_number":447,"context_line":"      }"},{"line_number":448,"context_line":"      if ($::fuel_settings[\u0027neutron_mellanox\u0027][\u0027plugin\u0027] \u003d\u003d \u0027ethernet\u0027) {"},{"line_number":449,"context_line":"        $net04_physnet \u003d $quantum_config[\u0027predefined_networks\u0027][\u0027net04\u0027][\u0027L2\u0027][\u0027physnet\u0027]"},{"line_number":450,"context_line":"        class { \u0027mellanox_openstack::compute\u0027:"},{"line_number":451,"context_line":"          physnet \u003d\u003e $net04_physnet,"},{"line_number":452,"context_line":"          physifc \u003d\u003e $::fuel_settings[\u0027neutron_mellanox\u0027][\u0027physical_port\u0027]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_616ccc09","line":449,"updated":"2014-07-08 12:31:48.000000000","message":"You aren\u0027t checking to see if we run nova or neutron here. Can mellanox deploy on nova network?","commit_id":"db267ba65b82a1c3af3f579888e0daa6337e70fd"}]}
