)]}'
{"deployment/puppet/keystone/manifests/endpoint.pp":[{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"2fea0c7ac106206629ea42628ab77522cbf77dc7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# * internal_address - internal address for keystone endpoint. Optional. Defaults to 127.0.0.1."},{"line_number":7,"context_line":"# * public_port      - Port for non-admin access to keystone endpoint. Optional. Defaults to 5000."},{"line_number":8,"context_line":"# * admin_port       - Port for admin access to keystone endpoint. Optional. Defaults to 35357."},{"line_number":9,"context_line":"# * public_use_ssl   - Use https instead of http for public url"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"class keystone::endpoint("},{"line_number":12,"context_line":"  $public_address   \u003d \u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1abeadc6_e4db48eb","line":9,"updated":"2014-08-19 08:32:45.000000000","message":"In my opinion, passing directly a \u0027public_protocol\u0027 parameter (http -default- or https) is easier to read/understand and also consistent with other manifests.","commit_id":"2ed9ffcd9c734c66e4521dcae849cbf4b937bff9"},{"author":{"_account_id":6904,"name":"Guillaume Thouvenin","email":"gthouvenin@mirantis.com","username":"guillaume-thouvenin"},"change_message_id":"d4b1e2943a4b9f70e66f6a4fbbe0f06639fb25b2","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# * internal_address - internal address for keystone endpoint. Optional. Defaults to 127.0.0.1."},{"line_number":7,"context_line":"# * public_port      - Port for non-admin access to keystone endpoint. Optional. Defaults to 5000."},{"line_number":8,"context_line":"# * admin_port       - Port for admin access to keystone endpoint. Optional. Defaults to 35357."},{"line_number":9,"context_line":"# * public_use_ssl   - Use https instead of http for public url"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"class keystone::endpoint("},{"line_number":12,"context_line":"  $public_address   \u003d \u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1abeadc6_cfa3c54d","line":9,"in_reply_to":"1abeadc6_e4db48eb","updated":"2014-08-19 08:42:49.000000000","message":"Done","commit_id":"2ed9ffcd9c734c66e4521dcae849cbf4b937bff9"}],"deployment/puppet/openstack/manifests/all.pp":[{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"9fe54b845598426f01865b34ec5d8852231430d7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"#  [syslog_log_facility] Facility for syslog, if used. Optional. Note: duplicating conf option"},{"line_number":43,"context_line":"#       wouldn\u0027t have been used, but more powerfull rsyslog features managed via conf template instead"},{"line_number":44,"context_line":"#  [syslog_log_level] logging level for non verbose and non debug mode. Optional."},{"line_number":45,"context_line":"#  [ssl_public_endpoint] Enable SSL for public endpoint"},{"line_number":46,"context_line":"#"},{"line_number":47,"context_line":"# \u003d\u003d\u003d Examples"},{"line_number":48,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9aa7fdbe_2ff04e90","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":23},"updated":"2014-10-25 20:06:29.000000000","message":"nit but \u0027ssl_for_public_endpoints\u0027 sounds better for me.","commit_id":"5894b3ad8161583c17831201f5897c57fd445399"},{"author":{"_account_id":6904,"name":"Guillaume Thouvenin","email":"gthouvenin@mirantis.com","username":"guillaume-thouvenin"},"change_message_id":"30f378c0d6b3eda8f512f9ee72d740082b9de9ec","unresolved":false,"context_lines":[{"line_number":42,"context_line":"#  [syslog_log_facility] Facility for syslog, if used. Optional. Note: duplicating conf option"},{"line_number":43,"context_line":"#       wouldn\u0027t have been used, but more powerfull rsyslog features managed via conf template instead"},{"line_number":44,"context_line":"#  [syslog_log_level] logging level for non verbose and non debug mode. Optional."},{"line_number":45,"context_line":"#  [ssl_public_endpoint] Enable SSL for public endpoint"},{"line_number":46,"context_line":"#"},{"line_number":47,"context_line":"# \u003d\u003d\u003d Examples"},{"line_number":48,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9aa7fdbe_40bf21aa","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":23},"in_reply_to":"9aa7fdbe_2ff04e90","updated":"2014-10-26 13:50:31.000000000","message":"I agree. I used ssl_for_public_endpoints the first time but I find it too long. But in fact ssl_public_endpoint is not so short and it is less understandable :).","commit_id":"5894b3ad8161583c17831201f5897c57fd445399"}],"deployment/puppet/openstack/manifests/ha/haproxy_service.pp":[{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"9fe54b845598426f01865b34ec5d8852231430d7","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    options   \u003d\u003e $haproxy_config_options,"},{"line_number":46,"context_line":"    if defined(\u0027ssl_certificate\u0027) {"},{"line_number":47,"context_line":"        bind \u003d\u003e [\"ssl\", \"crt\", $ssl_certificate]"},{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":"    mode     \u003d\u003e $mode,"},{"line_number":50,"context_line":"  }"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9aa7fdbe_eff9e680","line":48,"updated":"2014-10-25 20:06:29.000000000","message":"Are you sure that using \"if defined(..) {...}\" inside resource declaration is valid? If yes, don\u0027t you miss a comma after the closing curly bracket?\n\nAlso Puppet\u0027s style guide doesn\u0027t recommend it \u003d\u003e https://docs.puppetlabs.com/guides/style_guide.html#keep-resource-declarations-simple","commit_id":"5894b3ad8161583c17831201f5897c57fd445399"},{"author":{"_account_id":6904,"name":"Guillaume Thouvenin","email":"gthouvenin@mirantis.com","username":"guillaume-thouvenin"},"change_message_id":"30f378c0d6b3eda8f512f9ee72d740082b9de9ec","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    options   \u003d\u003e $haproxy_config_options,"},{"line_number":46,"context_line":"    if defined(\u0027ssl_certificate\u0027) {"},{"line_number":47,"context_line":"        bind \u003d\u003e [\"ssl\", \"crt\", $ssl_certificate]"},{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":"    mode     \u003d\u003e $mode,"},{"line_number":50,"context_line":"  }"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"9aa7fdbe_00c99958","line":48,"in_reply_to":"9aa7fdbe_eff9e680","updated":"2014-10-26 13:50:31.000000000","message":"No I\u0027m not sure. I will test it as soon as possible. I know that it is not a good practice to post code that is not tested but in this particular case it is because we are more than short in time so I pushed the code. So I really need to double check this.\n\nThanks for the links.","commit_id":"5894b3ad8161583c17831201f5897c57fd445399"},{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"e5520b59849cff84474d9c9cf1fcd2cb61d43f04","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    $virtual_ips \u003d [$public_virtual_ip]"},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  if $ssl_certificate {"},{"line_number":42,"context_line":"    haproxy::listen { $name:"},{"line_number":43,"context_line":"      order     \u003d\u003e $order,"},{"line_number":44,"context_line":"      ipaddress \u003d\u003e $virtual_ips,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9aa7fdbe_2626b068","line":41,"updated":"2014-10-27 08:37:54.000000000","message":"You\u0027ve got a typo: s/bind/bind_options/\n\nAlso it would be better to have only one resource declaration of haproxy::listen outside of the if statement. Also defined($foo) should evaluate to True if $foo is assigned the undef value.\n\n if $ssl_certificate {\n  $bind_options \u003d \"ssl crt ${ssl_certificate}\"\n } else {\n  $bind_options \u003d \u0027\u0027\n }\n \n haproxy::listen {$name:\n   ...,\n   bind_options \u003d\u003e $bind_options\n }","commit_id":"b5b39a43340426b55395a8e6365e8703570a6c09"},{"author":{"_account_id":6904,"name":"Guillaume Thouvenin","email":"gthouvenin@mirantis.com","username":"guillaume-thouvenin"},"change_message_id":"f65c3009a950fd2102d10845f9a82a6ef94ffb9c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    $virtual_ips \u003d [$public_virtual_ip]"},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  if $ssl_certificate {"},{"line_number":42,"context_line":"    haproxy::listen { $name:"},{"line_number":43,"context_line":"      order     \u003d\u003e $order,"},{"line_number":44,"context_line":"      ipaddress \u003d\u003e $virtual_ips,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9aa7fdbe_11d7244c","line":41,"in_reply_to":"9aa7fdbe_2626b068","updated":"2014-10-27 09:28:56.000000000","message":"In fact I looked at version 1.0.0 of puppetlabs-haproxy that says that bind-options will be deprecated in favor to bind. But as we are using haproxy-0.5.0 I will use bind_options and your way of doing it is more the puppet way :). So I will modify it.","commit_id":"b5b39a43340426b55395a8e6365e8703570a6c09"}],"deployment/puppet/openstack/manifests/keystone.pp":[{"author":{"_account_id":6904,"name":"Guillaume Thouvenin","email":"gthouvenin@mirantis.com","username":"guillaume-thouvenin"},"change_message_id":"f65c3009a950fd2102d10845f9a82a6ef94ffb9c","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        public_protocol  \u003d\u003e \u0027http\u0027,"},{"line_number":246,"context_line":"        admin_address    \u003d\u003e $admin_real,"},{"line_number":247,"context_line":"        internal_address \u003d\u003e $internal_real,"},{"line_number":248,"context_line":"      }"},{"line_number":249,"context_line":"    }"},{"line_number":250,"context_line":"    Exec \u003c| title \u003d\u003d \u0027keystone-manage db_sync\u0027 |\u003e -\u003e Class[\u0027keystone::endpoint\u0027]"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9aa7fdbe_b1f018ca","line":248,"updated":"2014-10-27 09:28:56.000000000","message":"I will replace by a more puppet style:\n\nif $ssl_for_public_endpoint {\n  $public_protocol \u003d\u003e \u0027https\u0027\n} else {\n  # this part is not needed but it makes things more\n  # understandable\n  $public_protocol \u003d\u003e \u0027http\u0027\n}\n\nclass { \u0027keystone::endpoint\u0027:\n  ...\n  public_protocol \u003d\u003e $public_protocol,\n  ...\n}","commit_id":"b5b39a43340426b55395a8e6365e8703570a6c09"},{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"c9dc5484755f6faef4fb74155cb03e8c98c44e82","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    # Setup the Keystone Identity Endpoint"},{"line_number":235,"context_line":"    if $ssl_for_public_endpoint {"},{"line_number":236,"context_line":"      public_protocol  \u003d\u003e \"https\","},{"line_number":237,"context_line":"    } else {"},{"line_number":238,"context_line":"      public_protocol  \u003d\u003e \"http\","},{"line_number":239,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7a8c0949_48f6fcd8","line":236,"updated":"2014-10-31 15:14:03.000000000","message":"syntax error\n\n  public_protocol \u003d \"https\"","commit_id":"408b4293183961a17f84b8c6f437b720a256eb2b"},{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"82f99ed84305189b070a153900ded68cce2ec50f","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    # Setup the Keystone Identity Endpoint"},{"line_number":235,"context_line":"    if $ssl_for_public_endpoint {"},{"line_number":236,"context_line":"      public_protocol  \u003d\u003e \"https\","},{"line_number":237,"context_line":"    } else {"},{"line_number":238,"context_line":"      public_protocol  \u003d\u003e \"http\","},{"line_number":239,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7a8c0949_e8dde843","line":236,"in_reply_to":"7a8c0949_48f6fcd8","updated":"2014-10-31 15:15:53.000000000","message":"$public_protocol \u003d \"https\"","commit_id":"408b4293183961a17f84b8c6f437b720a256eb2b"},{"author":{"_account_id":6904,"name":"Guillaume Thouvenin","email":"gthouvenin@mirantis.com","username":"guillaume-thouvenin"},"change_message_id":"27526cba7eddc3c6959498b4fdd5672dc8716286","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    # Setup the Keystone Identity Endpoint"},{"line_number":235,"context_line":"    if $ssl_for_public_endpoint {"},{"line_number":236,"context_line":"      public_protocol  \u003d\u003e \"https\","},{"line_number":237,"context_line":"    } else {"},{"line_number":238,"context_line":"      public_protocol  \u003d\u003e \"http\","},{"line_number":239,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7a8c0949_a8ee8089","line":236,"in_reply_to":"7a8c0949_e8dde843","updated":"2014-10-31 15:24:49.000000000","message":"Oops, copy/paste error. Thanks for the review\nDone","commit_id":"408b4293183961a17f84b8c6f437b720a256eb2b"},{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"c9dc5484755f6faef4fb74155cb03e8c98c44e82","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    if $ssl_for_public_endpoint {"},{"line_number":236,"context_line":"      public_protocol  \u003d\u003e \"https\","},{"line_number":237,"context_line":"    } else {"},{"line_number":238,"context_line":"      public_protocol  \u003d\u003e \"http\","},{"line_number":239,"context_line":"    }"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    class { \u0027keystone::endpoint\u0027:"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7a8c0949_2820d048","line":238,"updated":"2014-10-31 15:14:03.000000000","message":"syntax error\n\n public_protocol \u003d \"http\"","commit_id":"408b4293183961a17f84b8c6f437b720a256eb2b"},{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"82f99ed84305189b070a153900ded68cce2ec50f","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    if $ssl_for_public_endpoint {"},{"line_number":236,"context_line":"      public_protocol  \u003d\u003e \"https\","},{"line_number":237,"context_line":"    } else {"},{"line_number":238,"context_line":"      public_protocol  \u003d\u003e \"http\","},{"line_number":239,"context_line":"    }"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    class { \u0027keystone::endpoint\u0027:"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7a8c0949_28e7f013","line":238,"in_reply_to":"7a8c0949_2820d048","updated":"2014-10-31 15:15:53.000000000","message":"$public_protocol \u003d \"http\"","commit_id":"408b4293183961a17f84b8c6f437b720a256eb2b"}]}
