)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"10e59d73249eb166eb4ea45a1c884c0c6c4a42cd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     iberezovskiy \u003ciberezovskiy@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-09 18:05:50 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use default for inject_partition"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  Usage of default (-2) value prevents from"},{"line_number":10,"context_line":"  installation of libguestfs packages on compute node"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_4b910af0","line":7,"updated":"2015-07-09 15:16:44.000000000","message":"I\u0027m confused at this point: the bug says file injection is broken and you explicitly disable it by this change. This won\u0027t make the test pass for sure :)\n\nWhile I\u0027d love to disable file injection by default, the bug explicitly say it\u0027s currently broken. So if a customer enables it later, it won\u0027t work either.\n\nWe need to understand why both nbd and libguestfs backends didn\u0027t work when file injection was enabled.","commit_id":"8a0dc773ddca5357655fb4287a96e4295b8a1b02"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"10e59d73249eb166eb4ea45a1c884c0c6c4a42cd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use default for inject_partition"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  Usage of default (-2) value prevents from"},{"line_number":10,"context_line":"  installation of libguestfs packages on compute node"},{"line_number":11,"context_line":"  and running update-guestfs-appliance which requires"},{"line_number":12,"context_line":"  a lot of dependencies to be installed"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_0b62223e","line":10,"updated":"2015-07-09 15:16:44.000000000","message":"how is that? do we have a conditional somewhere else when installing packages?","commit_id":"8a0dc773ddca5357655fb4287a96e4295b8a1b02"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"10e59d73249eb166eb4ea45a1c884c0c6c4a42cd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  Usage of default (-2) value prevents from"},{"line_number":10,"context_line":"  installation of libguestfs packages on compute node"},{"line_number":11,"context_line":"  and running update-guestfs-appliance which requires"},{"line_number":12,"context_line":"  a lot of dependencies to be installed"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  Closes-bug: #1472520"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_6bf5ee4e","line":11,"updated":"2015-07-09 15:16:44.000000000","message":"it does that for a reason - to create a libguestfs appliance. But that\u0027s totally ok. What wouldn\u0027t we want to have libguestfs configured properly?","commit_id":"8a0dc773ddca5357655fb4287a96e4295b8a1b02"}],"deployment/puppet/openstack/manifests/compute.pp":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"362dc0d82f890a836144484661f2fe44d158291b","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    } else {"},{"line_number":319,"context_line":"      # Enable module by default on each compute node"},{"line_number":320,"context_line":"      k_mod {\u0027nbd\u0027:"},{"line_number":321,"context_line":"        ensure \u003d\u003e \u0027present\u0027"},{"line_number":322,"context_line":"      }"},{"line_number":323,"context_line":"      $libvirt_inject_partition \u003d \u00271\u0027"},{"line_number":324,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_1014859d","line":321,"updated":"2015-07-09 17:01:39.000000000","message":"is it like one-time modprobe nbd or putting nbd to /etc/modules, so that it\u0027s loaded automatically when OS boots?","commit_id":"b35e673889f176ecf69631861473d6045fe655c7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"b01102e53e8c855fde4e320ebb08b21712e3cbba","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    } else {"},{"line_number":319,"context_line":"      # Enable module by default on each compute node"},{"line_number":320,"context_line":"      k_mod {\u0027nbd\u0027:"},{"line_number":321,"context_line":"        ensure \u003d\u003e \u0027present\u0027"},{"line_number":322,"context_line":"      }"},{"line_number":323,"context_line":"      $libvirt_inject_partition \u003d \u00271\u0027"},{"line_number":324,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_565be621","line":321,"in_reply_to":"ba3cc151_1014859d","updated":"2015-07-09 17:11:41.000000000","message":"Good point, thank you. Will be fixed","commit_id":"b35e673889f176ecf69631861473d6045fe655c7"},{"author":{"_account_id":12841,"name":"Ivan Udovichenko","email":"iudovichenko@itkey.com","username":"ai"},"change_message_id":"04de4188769777ab7b9e1cac4b1e4733e37a6506","unresolved":false,"context_lines":[{"line_number":320,"context_line":"      k_mod {\u0027nbd\u0027:"},{"line_number":321,"context_line":"        ensure \u003d\u003e \u0027present\u0027"},{"line_number":322,"context_line":"      }"},{"line_number":323,"context_line":"      file_line {\u0027nbd_on_boot\u0027:"},{"line_number":324,"context_line":"        path \u003d\u003e \u0027/etc/modules\u0027,"},{"line_number":325,"context_line":"        line \u003d\u003e \u0027nbd\u0027,"},{"line_number":326,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba3cc151_16179ea3","line":323,"updated":"2015-07-09 17:22:00.000000000","message":"May be it is better to use something like this:\nhttp://projects.puppetlabs.com/projects/1/wiki/Kernel_Modules_Patterns","commit_id":"5013a663571684ab76840f666d797da3feb745da"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"ba7a95c2dc20cd5e50748da996e67b0bc0a55643","unresolved":false,"context_lines":[{"line_number":320,"context_line":"      k_mod {\u0027nbd\u0027:"},{"line_number":321,"context_line":"        ensure \u003d\u003e \u0027present\u0027"},{"line_number":322,"context_line":"      }"},{"line_number":323,"context_line":"      file_line {\u0027nbd_on_boot\u0027:"},{"line_number":324,"context_line":"        path \u003d\u003e \u0027/etc/modules\u0027,"},{"line_number":325,"context_line":"        line \u003d\u003e \u0027nbd\u0027,"},{"line_number":326,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba3cc151_5628c696","line":323,"in_reply_to":"ba3cc151_16179ea3","updated":"2015-07-09 17:28:12.000000000","message":"++ for doing is in cross-platform way","commit_id":"5013a663571684ab76840f666d797da3feb745da"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"4b53edcc41e275504f9ea462ca8d096d7698273d","unresolved":false,"context_lines":[{"line_number":320,"context_line":"      k_mod {\u0027nbd\u0027:"},{"line_number":321,"context_line":"        ensure \u003d\u003e \u0027present\u0027"},{"line_number":322,"context_line":"      }"},{"line_number":323,"context_line":"      file_line {\u0027nbd_on_boot\u0027:"},{"line_number":324,"context_line":"        path \u003d\u003e \u0027/etc/modules\u0027,"},{"line_number":325,"context_line":"        line \u003d\u003e \u0027nbd\u0027,"},{"line_number":326,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba3cc151_f99c6dc1","line":323,"in_reply_to":"ba3cc151_16179ea3","updated":"2015-07-09 17:29:18.000000000","message":"fuel-library modules doesn\u0027t contain this provider","commit_id":"5013a663571684ab76840f666d797da3feb745da"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"fa1c7d29386f54f9d850cc603ecfcfd75bc5f53f","unresolved":false,"context_lines":[{"line_number":320,"context_line":"      k_mod {\u0027nbd\u0027:"},{"line_number":321,"context_line":"        ensure \u003d\u003e \u0027present\u0027"},{"line_number":322,"context_line":"      }"},{"line_number":323,"context_line":"      file_line {\u0027nbd_on_boot\u0027:"},{"line_number":324,"context_line":"        path \u003d\u003e \u0027/etc/modules\u0027,"},{"line_number":325,"context_line":"        line \u003d\u003e \u0027nbd\u0027,"},{"line_number":326,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba3cc151_793cddc7","line":323,"in_reply_to":"ba3cc151_5628c696","updated":"2015-07-09 17:28:26.000000000","message":"*this","commit_id":"5013a663571684ab76840f666d797da3feb745da"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"05e31d674ee954f50fec2609d11aaf909750286b","unresolved":false,"context_lines":[{"line_number":320,"context_line":"      k_mod {\u0027nbd\u0027:"},{"line_number":321,"context_line":"        ensure \u003d\u003e \u0027present\u0027"},{"line_number":322,"context_line":"      }"},{"line_number":323,"context_line":"      file_line {\u0027nbd_on_boot\u0027:"},{"line_number":324,"context_line":"        path \u003d\u003e \u0027/etc/modules\u0027,"},{"line_number":325,"context_line":"        line \u003d\u003e \u0027nbd\u0027,"},{"line_number":326,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba3cc151_3cb7233b","line":323,"in_reply_to":"ba3cc151_b9fb457a","updated":"2015-07-09 17:53:44.000000000","message":"It\u0027s not hard to implement, but I\u0027m not sure that it makes sense.\n\nFuel-library folks, please confirm is it important to add separate custom resource or we can leave this patch as is?","commit_id":"5013a663571684ab76840f666d797da3feb745da"},{"author":{"_account_id":12841,"name":"Ivan Udovichenko","email":"iudovichenko@itkey.com","username":"ai"},"change_message_id":"fadb1f895604caee060456089e5fe0e992466892","unresolved":false,"context_lines":[{"line_number":320,"context_line":"      k_mod {\u0027nbd\u0027:"},{"line_number":321,"context_line":"        ensure \u003d\u003e \u0027present\u0027"},{"line_number":322,"context_line":"      }"},{"line_number":323,"context_line":"      file_line {\u0027nbd_on_boot\u0027:"},{"line_number":324,"context_line":"        path \u003d\u003e \u0027/etc/modules\u0027,"},{"line_number":325,"context_line":"        line \u003d\u003e \u0027nbd\u0027,"},{"line_number":326,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba3cc151_b9fb457a","line":323,"in_reply_to":"ba3cc151_f99c6dc1","updated":"2015-07-09 17:47:35.000000000","message":"You can try to define it in separate manifest.\nSimilar approach:\nhttps://review.openstack.org/#/c/138777/","commit_id":"5013a663571684ab76840f666d797da3feb745da"}]}
