)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"77b1e895fc184e5790d60eda5520437bc6265395","unresolved":false,"context_lines":[{"line_number":14,"context_line":"created."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Summary of changes:"},{"line_number":17,"context_line":"* Added auth_url_version function to openstacklib credentials.rb"},{"line_number":18,"context_line":"* Added call to auth_url_version in keystone base provider"},{"line_number":19,"context_line":"* Added OS_PROJECT_NAME to openrc (for openrc validation in keystone)"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a50d1a3_f365c0ae","line":17,"updated":"2015-08-03 10:13:05.000000000","message":"LGTM, but please provide upstream change id","commit_id":"f8bdf1b6f89d491f8218426f7a4420d76f997603"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"77b1e895fc184e5790d60eda5520437bc6265395","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Summary of changes:"},{"line_number":17,"context_line":"* Added auth_url_version function to openstacklib credentials.rb"},{"line_number":18,"context_line":"* Added call to auth_url_version in keystone base provider"},{"line_number":19,"context_line":"* Added OS_PROJECT_NAME to openrc (for openrc validation in keystone)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ifd0f378d189424e8fdf65f13a0f95fe8f50d4a45"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a50d1a3_530b54d5","line":18,"updated":"2015-08-03 10:13:05.000000000","message":"ditto","commit_id":"f8bdf1b6f89d491f8218426f7a4420d76f997603"}],"deployment/puppet/openstacklib/lib/puppet/provider/openstack/credentials.rb":[{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"cb0288d950d122d60914c17be8af2672e788b5d0","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  end"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  def auth_url_version"},{"line_number":62,"context_line":"    url \u003d @auth_url.split(\u0027/\u0027)[0..-2]"},{"line_number":63,"context_line":"    url \u003c\u003c \"v\" + version"},{"line_number":64,"context_line":"    url.join \u0027/\u0027"},{"line_number":65,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3a50d1a3_20e57bdb","line":62,"updated":"2015-07-30 17:21:13.000000000","message":"What if auth_url is \u0027http://host/\u0027 or \u0027http://host\u0027?","commit_id":"b283d0f3bb4a5fdecd5545a5b63a3c14f1faea58"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"9732b4e7a71263960e6fd8aaf261ff75e725163e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  end"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  def auth_url_version"},{"line_number":62,"context_line":"    url \u003d @auth_url.split(\u0027/\u0027)[0..-2]"},{"line_number":63,"context_line":"    url \u003c\u003c \"v\" + version"},{"line_number":64,"context_line":"    url.join \u0027/\u0027"},{"line_number":65,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3a50d1a3_a0918bf3","line":62,"in_reply_to":"3a50d1a3_20e57bdb","updated":"2015-07-30 17:29:25.000000000","message":"Good catch. I just tested in my local env and it works. I expected API version to always be there. I\u0027ll refactor to cover this case.","commit_id":"b283d0f3bb4a5fdecd5545a5b63a3c14f1faea58"}],"deployment/puppet/osnailyfacter/modular/keystone/keystone.pp":[{"author":{"_account_id":13948,"name":"Bartłomiej Piotrowski","email":"bpiotrowski@mirantis.com","username":"bpiotrowski"},"change_message_id":"80dfe8c7dd971e73db82eeac7b510a623f296f16","unresolved":false,"context_lines":[{"line_number":184,"context_line":"}"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"#Can\u0027t use openrc to create admin user"},{"line_number":187,"context_line":"exec { \u0027purge_openrc\u0027: "},{"line_number":188,"context_line":"  path        \u003d\u003e \u0027/bin:/usr/bin:/sbin:/usr/sbin\u0027,"},{"line_number":189,"context_line":"  command     \u003d\u003e \u0027rm -f /root/openrc\u0027,"},{"line_number":190,"context_line":"  refreshonly \u003d\u003e \u0027true\u0027,"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"1a4dcd0f_c8a51503","line":187,"updated":"2015-08-13 12:54:42.000000000","message":"Trailing whitespace.","commit_id":"13188b8c3705ff9d1dc24d581b9c1349e5279be6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"bf0a6868aa1fa7d9a63966c0316c666b2a744ea3","unresolved":false,"context_lines":[{"line_number":186,"context_line":"#Can\u0027t use openrc to create admin user"},{"line_number":187,"context_line":"exec { \u0027purge_openrc\u0027: "},{"line_number":188,"context_line":"  path        \u003d\u003e \u0027/bin:/usr/bin:/sbin:/usr/sbin\u0027,"},{"line_number":189,"context_line":"  command     \u003d\u003e \u0027rm -f /root/openrc\u0027,"},{"line_number":190,"context_line":"  refreshonly \u003d\u003e \u0027true\u0027,"},{"line_number":191,"context_line":"}"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"1a4dcd0f_13a6cec0","line":189,"updated":"2015-08-13 13:17:39.000000000","message":"let\u0027s use: onlyif \u003d\u003e \u0027test -f /root/openrc\u0027","commit_id":"13188b8c3705ff9d1dc24d581b9c1349e5279be6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"f17d9997e56f3899beba3ef2f7814f2883e79ea6","unresolved":false,"context_lines":[{"line_number":186,"context_line":"#Can\u0027t use openrc to create admin user"},{"line_number":187,"context_line":"exec { \u0027purge_openrc\u0027: "},{"line_number":188,"context_line":"  path        \u003d\u003e \u0027/bin:/usr/bin:/sbin:/usr/sbin\u0027,"},{"line_number":189,"context_line":"  command     \u003d\u003e \u0027rm -f /root/openrc\u0027,"},{"line_number":190,"context_line":"  refreshonly \u003d\u003e \u0027true\u0027,"},{"line_number":191,"context_line":"}"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"1a4dcd0f_ae0c51ec","line":189,"in_reply_to":"1a4dcd0f_1336ce02","updated":"2015-08-13 13:37:07.000000000","message":"Why we need run this command if file doesn\u0027t exists? I agree, that \u0027-f\u0027 flag doesnt return error, but i think will be better to use onlyif.\n\nAlso my -1 just nitpick in additional to trailing whitespace ;)","commit_id":"13188b8c3705ff9d1dc24d581b9c1349e5279be6"},{"author":{"_account_id":13948,"name":"Bartłomiej Piotrowski","email":"bpiotrowski@mirantis.com","username":"bpiotrowski"},"change_message_id":"c541d3fba9ed346131ce24582056cd2eafe41390","unresolved":false,"context_lines":[{"line_number":186,"context_line":"#Can\u0027t use openrc to create admin user"},{"line_number":187,"context_line":"exec { \u0027purge_openrc\u0027: "},{"line_number":188,"context_line":"  path        \u003d\u003e \u0027/bin:/usr/bin:/sbin:/usr/sbin\u0027,"},{"line_number":189,"context_line":"  command     \u003d\u003e \u0027rm -f /root/openrc\u0027,"},{"line_number":190,"context_line":"  refreshonly \u003d\u003e \u0027true\u0027,"},{"line_number":191,"context_line":"}"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"1a4dcd0f_1336ce02","line":189,"in_reply_to":"1a4dcd0f_13a6cec0","updated":"2015-08-13 13:28:04.000000000","message":"how does it change anything? This way or another one command is being run, and rm with force flag doesn\u0027t return error if file is not found.","commit_id":"13188b8c3705ff9d1dc24d581b9c1349e5279be6"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"37ceddfe8798d4e99d97174ee5a2b4e60c2c21b5","unresolved":false,"context_lines":[{"line_number":187,"context_line":"exec { \u0027purge_openrc\u0027: "},{"line_number":188,"context_line":"  path        \u003d\u003e \u0027/bin:/usr/bin:/sbin:/usr/sbin\u0027,"},{"line_number":189,"context_line":"  command     \u003d\u003e \u0027rm -f /root/openrc\u0027,"},{"line_number":190,"context_line":"  refreshonly \u003d\u003e \u0027true\u0027,"},{"line_number":191,"context_line":"}"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"Exec \u003c| title \u003d\u003d \u0027keystone-manage db_sync\u0027 |\u003e ~\u003e"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"1a4dcd0f_283279f2","line":190,"updated":"2015-08-13 12:53:11.000000000","message":"Can we use \u0027file { ensure \u003d\u003e absent }\u0027 instead of exec here?","commit_id":"13188b8c3705ff9d1dc24d581b9c1349e5279be6"},{"author":{"_account_id":13948,"name":"Bartłomiej Piotrowski","email":"bpiotrowski@mirantis.com","username":"bpiotrowski"},"change_message_id":"80dfe8c7dd971e73db82eeac7b510a623f296f16","unresolved":false,"context_lines":[{"line_number":187,"context_line":"exec { \u0027purge_openrc\u0027: "},{"line_number":188,"context_line":"  path        \u003d\u003e \u0027/bin:/usr/bin:/sbin:/usr/sbin\u0027,"},{"line_number":189,"context_line":"  command     \u003d\u003e \u0027rm -f /root/openrc\u0027,"},{"line_number":190,"context_line":"  refreshonly \u003d\u003e \u0027true\u0027,"},{"line_number":191,"context_line":"}"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"Exec \u003c| title \u003d\u003d \u0027keystone-manage db_sync\u0027 |\u003e ~\u003e"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"1a4dcd0f_08a0ddf2","line":190,"in_reply_to":"1a4dcd0f_283279f2","updated":"2015-08-13 12:54:42.000000000","message":"No, because File resources do not have refreshonly.","commit_id":"13188b8c3705ff9d1dc24d581b9c1349e5279be6"},{"author":{"_account_id":7195,"name":"Matthew Mosesohn","email":"raytrac3r@gmail.com","username":"mmosesohn"},"change_message_id":"60635689914e0002bc7d014285baacab29a2288e","unresolved":false,"context_lines":[{"line_number":187,"context_line":"exec { \u0027purge_openrc\u0027: "},{"line_number":188,"context_line":"  path        \u003d\u003e \u0027/bin:/usr/bin:/sbin:/usr/sbin\u0027,"},{"line_number":189,"context_line":"  command     \u003d\u003e \u0027rm -f /root/openrc\u0027,"},{"line_number":190,"context_line":"  refreshonly \u003d\u003e \u0027true\u0027,"},{"line_number":191,"context_line":"}"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"Exec \u003c| title \u003d\u003d \u0027keystone-manage db_sync\u0027 |\u003e ~\u003e"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"1a4dcd0f_88938da2","line":190,"in_reply_to":"1a4dcd0f_283279f2","updated":"2015-08-13 12:55:39.000000000","message":"No, because we\u0027re defining it later in openstack::auth_file.","commit_id":"13188b8c3705ff9d1dc24d581b9c1349e5279be6"}]}
