)]}'
{"Rakefile":[{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"5d7990a4626b5ed9f3516a877421a65d3cdbc371","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        system(\"#{library_dir}/.bundled_gems/bin/bundle install --without system_tests\")"},{"line_number":63,"context_line":"        result \u003d system(\"#{library_dir}/.bundled_gems/bin/bundle exec rake spec\")"},{"line_number":64,"context_line":"      elsif File.exists?(\u0027Rakefile\u0027)"},{"line_number":65,"context_line":"        result \u003d system(\"rake spec\")"},{"line_number":66,"context_line":"      else"},{"line_number":67,"context_line":"        puts \"!\"*80"},{"line_number":68,"context_line":"        puts \"No unit tests for #{module_path}\""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"3a29b11f_eed4e720","line":65,"updated":"2015-10-21 13:53:50.000000000","message":"Are we going to run rake spec without bundle? Then I\u0027m afraid that result may be unpredictable considering the possibility of different configurations on slaves.","commit_id":"c01da21ff18ca66f178376b2eea7290a2fd21308"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d7d72521edcfa950911b1f019c9376398afb155f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        system(\"#{library_dir}/.bundled_gems/bin/bundle install --without system_tests\")"},{"line_number":63,"context_line":"        result \u003d system(\"#{library_dir}/.bundled_gems/bin/bundle exec rake spec\")"},{"line_number":64,"context_line":"      elsif File.exists?(\u0027Rakefile\u0027)"},{"line_number":65,"context_line":"        result \u003d system(\"rake spec\")"},{"line_number":66,"context_line":"      else"},{"line_number":67,"context_line":"        puts \"!\"*80"},{"line_number":68,"context_line":"        puts \"No unit tests for #{module_path}\""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"3a29b11f_b155eec2","line":65,"in_reply_to":"3a29b11f_eed4e720","updated":"2015-10-21 13:59:38.000000000","message":"This should be fixed as we update all of the modules to include a Gemfile so that this does not get run and will be eventually removed. We are sharing the same puppet jobs which I believe have rake available but if not I\u0027ll fix it. The jobs just got merged so I\u0027m going to rebase this to see how it actually works on openstack-infra.","commit_id":"c01da21ff18ca66f178376b2eea7290a2fd21308"},{"author":{"_account_id":9387,"name":"Aleksandr Didenko","email":"adidenko@mirantis.com","username":"AD"},"change_message_id":"5d7990a4626b5ed9f3516a877421a65d3cdbc371","unresolved":false,"context_lines":[{"line_number":126,"context_line":"      #  result \u003d system(\"rake lint\")"},{"line_number":127,"context_line":"      else"},{"line_number":128,"context_line":"        Dir.glob(\"**/**.pp\") do |puppet_file|"},{"line_number":129,"context_line":"          result \u003d false unless system(\"puppet-lint #{skip_checks.join(\" \")} #{puppet_file}\")"},{"line_number":130,"context_line":"        end"},{"line_number":131,"context_line":"      end"},{"line_number":132,"context_line":"      if !result"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"3a29b11f_6e41b7a8","line":129,"updated":"2015-10-21 13:53:50.000000000","message":"In fuel_syntax_check.sh script we also check other files (like *files/ocf/*, *.erb, *.sh). Are we going to address it somewhere separately?","commit_id":"c01da21ff18ca66f178376b2eea7290a2fd21308"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d7d72521edcfa950911b1f019c9376398afb155f","unresolved":false,"context_lines":[{"line_number":126,"context_line":"      #  result \u003d system(\"rake lint\")"},{"line_number":127,"context_line":"      else"},{"line_number":128,"context_line":"        Dir.glob(\"**/**.pp\") do |puppet_file|"},{"line_number":129,"context_line":"          result \u003d false unless system(\"puppet-lint #{skip_checks.join(\" \")} #{puppet_file}\")"},{"line_number":130,"context_line":"        end"},{"line_number":131,"context_line":"      end"},{"line_number":132,"context_line":"      if !result"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"3a29b11f_91e6b213","line":129,"in_reply_to":"3a29b11f_6e41b7a8","updated":"2015-10-21 13:59:38.000000000","message":"I\u0027ll try and include that in here with the next update.","commit_id":"c01da21ff18ca66f178376b2eea7290a2fd21308"}]}
